@blumintinc/eslint-plugin-blumint 1.19.25 → 1.19.27

package/lib/index.js

@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.25',
+        version: '1.19.27',
     },
     parseOptions: {
         ecmaVersion: 2020,
@@ -267,7 +267,7 @@ module.exports = {
                 '@blumintinc/blumint/no-async-foreach': 'error',
                 '@blumintinc/blumint/no-console-error': [
                     'error',
-                    { allowWithUseAlertDialog: true },
+                    { allowWithUseAlertDialog: true, allowErrorInstanceArgument: true },
                 ],
                 '@blumintinc/blumint/no-conditional-literals-in-jsx': 'error',
                 '@blumintinc/blumint/no-filter-without-return': 'error',

package/lib/rules/no-console-error.d.ts

@@ -3,6 +3,7 @@ type Options = [
     {
         ignorePatterns?: string[];
         allowWithUseAlertDialog?: boolean;
+        allowErrorInstanceArgument?: boolean;
     }
 ];
 export declare const noConsoleError: TSESLint.RuleModule<"noConsoleError", Options, TSESLint.RuleListener>;

package/lib/rules/no-console-error.js

@@ -113,6 +113,18 @@ const getLocalNameFromPattern = (target) => {
     return null;
 };
 const findDeclaredVariableByName = (name, variables) => variables.find((variable) => variable.name === name);
+/**
+ * A `new <Something>Error(...)` argument is the structured-error handoff the
+ * rule exists to encourage: on the backend, `console.error(new HttpsError(...))`
+ * is the monitored pipeline (spyOnConsoleErrors reports the Error among the
+ * args), not a bypass of it. Detection stays purely syntactic — the rule is not
+ * type-aware and runs on files outside any `parserOptions.project` — so a bare
+ * identifier (`console.error(error)`) is deliberately excluded because syntax
+ * alone cannot prove it holds an Error.
+ */
+const isStructuredErrorArgument = (arg) => arg.type === utils_1.AST_NODE_TYPES.NewExpression &&
+    arg.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
+    /Error$/.test(arg.callee.name);
 /**
  * Tracks aliases of `console` and `console.error` to detect indirect calls.
  */
@@ -451,6 +463,7 @@ exports.noConsoleError = (0, createRule_1.createRule)({
                         items: { type: 'string' },
                     },
                     allowWithUseAlertDialog: { type: 'boolean' },
+                    allowErrorInstanceArgument: { type: 'boolean' },
                 },
                 additionalProperties: false,
             },
@@ -467,6 +480,7 @@ exports.noConsoleError = (0, createRule_1.createRule)({
         if (shouldIgnoreFile(filename))
             return {};
         const allowWithUseAlertDialog = options.allowWithUseAlertDialog === true;
+        const allowErrorInstanceArgument = options.allowErrorInstanceArgument === true;
         const aliasTracker = new AliasTracker(context);
         const dialogTracker = new UseAlertDialogTracker(context);
         const pendingTracker = new PendingCallTracker();
@@ -511,6 +525,14 @@ exports.noConsoleError = (0, createRule_1.createRule)({
                 const scope = getScopeForNode(context, node);
                 if (!aliasTracker.isConsoleErrorCall(node, scope))
                     return;
+                // A structured-error argument is the sanctioned, monitored path, so the
+                // carve-out applies to every matched call shape (direct, aliased,
+                // destructured, computed) — unlike the useAlertDialog queueing below,
+                // which is restricted to the direct-global shape.
+                if (allowErrorInstanceArgument &&
+                    node.arguments.some(isStructuredErrorArgument)) {
+                    return;
+                }
                 // Queueing is limited to direct global `console.error(...)` calls because deferral relies on
                 // linear control flow. Aliased or destructured references can escape the current scope
                 // (stored, passed, invoked later), so they are reported immediately to avoid missing non-local calls.

package/lib/rules/parallelize-async-operations.js

@@ -178,6 +178,19 @@ exports.parallelizeAsyncOperations = (0, createRule_1.createRule)({
          * name.
          */
         const GUARD_PATTERN = /^(assert|ensure|require|validate|verify|guard|check)/i;
+        /**
+         * Matches state re-read callees by their leading verb. A refetch/refresh
+         * that follows a preceding await exists to re-observe state a prior await
+         * may have mutated (e.g. `await unlinkProvider(...)` then `await
+         * refreshUser()`, where refreshUser re-reads the post-unlink server state).
+         * Running such a pair through Promise.all races the refetch ahead of / in
+         * parallel with the mutation, so a refresh that resolves first repopulates
+         * the just-mutated state -- a genuine correctness bug. Anchored at the
+         * start so it fires on the callee's own verb (refreshUser, reloadData,
+         * refetchProfile) rather than on an arbitrary substring elsewhere in the
+         * name (getRefreshToken must NOT match).
+         */
+        const REFETCH_PATTERN = /^(refresh|reload|refetch|revalidate|resync|sync)/i;
         /**
          * Extracts the callee's method name (the identifier bearing the leading
          * verb) from an await expression argument. Handles both direct
@@ -324,6 +337,33 @@ exports.parallelizeAsyncOperations = (0, createRule_1.createRule)({
                     return true;
                 }
             }
+            // 5. Refetch/refresh ordering barrier. A discarded-result await whose
+            // callee reads as a state re-read (refresh*, reload*, refetch*,
+            // revalidate*, resync*, sync*) exists to observe state that a PRECEDING
+            // await may have mutated. Promise.all invokes every operand eagerly and
+            // concurrently, so it would race the refetch ahead of the mutation -- a
+            // refresh that resolves first repopulates the just-mutated state, a
+            // genuine correctness bug. Treat a refetch that FOLLOWS another await as
+            // a sequencing dependency that blocks parallelizing the run. Only
+            // non-first positions qualify: the preceding await is what the refetch
+            // depends on. getCalleeMethodName handles both bare-identifier and
+            // member-expression callees. Only discarded-result awaits
+            // (ExpressionStatements) qualify here; a captured result carries a value
+            // and is handled by the data-dependency path above.
+            for (let i = 1; i < awaitNodes.length; i++) {
+                const node = awaitNodes[i];
+                if (node.type !== utils_1.AST_NODE_TYPES.ExpressionStatement) {
+                    continue;
+                }
+                const awaitExpr = getAwaitExpression(node);
+                if (!awaitExpr) {
+                    continue;
+                }
+                const methodName = getCalleeMethodName(awaitExpr);
+                if (methodName && REFETCH_PATTERN.test(methodName)) {
+                    return true;
+                }
+            }
             // If any node is a variable declaration with destructuring, consider it as having dependencies
             for (const node of awaitNodes) {
                 if (node.type === utils_1.AST_NODE_TYPES.VariableDeclaration) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.19.25",
+  "version": "1.19.27",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.19.27",
+    "date": "2026-07-23T04:26:05.419Z",
+    "rules": [
+      {
+        "name": "parallelize-async-operations",
+        "changeType": "fix",
+        "issues": [
+          1334
+        ],
+        "summary": "treat mutation→refetch bare-identifier awaits as ordered (closes #1334)"
+      }
+    ]
+  },
+  {
+    "version": "1.19.26",
+    "date": "2026-07-23T00:25:08.850Z",
+    "rules": [
+      {
+        "name": "no-console-error",
+        "changeType": "fix",
+        "issues": [
+          1333
+        ],
+        "summary": "allow structured Error argument via allowErrorInstanceArgument (closes #1333)"
+      }
+    ]
+  },
   {
     "version": "1.19.25",
     "date": "2026-07-22T21:39:17.787Z",