@blumintinc/eslint-plugin-blumint 1.19.25 → 1.19.26
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/lib/index.js
CHANGED
|
@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
|
|
|
222
222
|
module.exports = {
|
|
223
223
|
meta: {
|
|
224
224
|
name: '@blumintinc/eslint-plugin-blumint',
|
|
225
|
-
version: '1.19.
|
|
225
|
+
version: '1.19.26',
|
|
226
226
|
},
|
|
227
227
|
parseOptions: {
|
|
228
228
|
ecmaVersion: 2020,
|
|
@@ -267,7 +267,7 @@ module.exports = {
|
|
|
267
267
|
'@blumintinc/blumint/no-async-foreach': 'error',
|
|
268
268
|
'@blumintinc/blumint/no-console-error': [
|
|
269
269
|
'error',
|
|
270
|
-
{ allowWithUseAlertDialog: true },
|
|
270
|
+
{ allowWithUseAlertDialog: true, allowErrorInstanceArgument: true },
|
|
271
271
|
],
|
|
272
272
|
'@blumintinc/blumint/no-conditional-literals-in-jsx': 'error',
|
|
273
273
|
'@blumintinc/blumint/no-filter-without-return': 'error',
|
|
@@ -113,6 +113,18 @@ const getLocalNameFromPattern = (target) => {
|
|
|
113
113
|
return null;
|
|
114
114
|
};
|
|
115
115
|
const findDeclaredVariableByName = (name, variables) => variables.find((variable) => variable.name === name);
|
|
116
|
+
/**
|
|
117
|
+
* A `new <Something>Error(...)` argument is the structured-error handoff the
|
|
118
|
+
* rule exists to encourage: on the backend, `console.error(new HttpsError(...))`
|
|
119
|
+
* is the monitored pipeline (spyOnConsoleErrors reports the Error among the
|
|
120
|
+
* args), not a bypass of it. Detection stays purely syntactic — the rule is not
|
|
121
|
+
* type-aware and runs on files outside any `parserOptions.project` — so a bare
|
|
122
|
+
* identifier (`console.error(error)`) is deliberately excluded because syntax
|
|
123
|
+
* alone cannot prove it holds an Error.
|
|
124
|
+
*/
|
|
125
|
+
const isStructuredErrorArgument = (arg) => arg.type === utils_1.AST_NODE_TYPES.NewExpression &&
|
|
126
|
+
arg.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
|
|
127
|
+
/Error$/.test(arg.callee.name);
|
|
116
128
|
/**
|
|
117
129
|
* Tracks aliases of `console` and `console.error` to detect indirect calls.
|
|
118
130
|
*/
|
|
@@ -451,6 +463,7 @@ exports.noConsoleError = (0, createRule_1.createRule)({
|
|
|
451
463
|
items: { type: 'string' },
|
|
452
464
|
},
|
|
453
465
|
allowWithUseAlertDialog: { type: 'boolean' },
|
|
466
|
+
allowErrorInstanceArgument: { type: 'boolean' },
|
|
454
467
|
},
|
|
455
468
|
additionalProperties: false,
|
|
456
469
|
},
|
|
@@ -467,6 +480,7 @@ exports.noConsoleError = (0, createRule_1.createRule)({
|
|
|
467
480
|
if (shouldIgnoreFile(filename))
|
|
468
481
|
return {};
|
|
469
482
|
const allowWithUseAlertDialog = options.allowWithUseAlertDialog === true;
|
|
483
|
+
const allowErrorInstanceArgument = options.allowErrorInstanceArgument === true;
|
|
470
484
|
const aliasTracker = new AliasTracker(context);
|
|
471
485
|
const dialogTracker = new UseAlertDialogTracker(context);
|
|
472
486
|
const pendingTracker = new PendingCallTracker();
|
|
@@ -511,6 +525,14 @@ exports.noConsoleError = (0, createRule_1.createRule)({
|
|
|
511
525
|
const scope = getScopeForNode(context, node);
|
|
512
526
|
if (!aliasTracker.isConsoleErrorCall(node, scope))
|
|
513
527
|
return;
|
|
528
|
+
// A structured-error argument is the sanctioned, monitored path, so the
|
|
529
|
+
// carve-out applies to every matched call shape (direct, aliased,
|
|
530
|
+
// destructured, computed) — unlike the useAlertDialog queueing below,
|
|
531
|
+
// which is restricted to the direct-global shape.
|
|
532
|
+
if (allowErrorInstanceArgument &&
|
|
533
|
+
node.arguments.some(isStructuredErrorArgument)) {
|
|
534
|
+
return;
|
|
535
|
+
}
|
|
514
536
|
// Queueing is limited to direct global `console.error(...)` calls because deferral relies on
|
|
515
537
|
// linear control flow. Aliased or destructured references can escape the current scope
|
|
516
538
|
// (stored, passed, invoked later), so they are reported immediately to avoid missing non-local calls.
|
package/package.json
CHANGED
package/release-manifest.json
CHANGED
|
@@ -1,4 +1,18 @@
|
|
|
1
1
|
[
|
|
2
|
+
{
|
|
3
|
+
"version": "1.19.26",
|
|
4
|
+
"date": "2026-07-23T00:25:08.850Z",
|
|
5
|
+
"rules": [
|
|
6
|
+
{
|
|
7
|
+
"name": "no-console-error",
|
|
8
|
+
"changeType": "fix",
|
|
9
|
+
"issues": [
|
|
10
|
+
1333
|
|
11
|
+
],
|
|
12
|
+
"summary": "allow structured Error argument via allowErrorInstanceArgument (closes #1333)"
|
|
13
|
+
}
|
|
14
|
+
]
|
|
15
|
+
},
|
|
2
16
|
{
|
|
3
17
|
"version": "1.19.25",
|
|
4
18
|
"date": "2026-07-22T21:39:17.787Z",
|