@blumintinc/eslint-plugin-blumint 1.19.2 → 1.19.4

package/lib/index.js

@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.2',
+        version: '1.19.4',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/prefer-utility-function-own-file.js

@@ -367,6 +367,13 @@ exports.preferUtilityFunctionOwnFile = (0, createRule_1.createRule)({
             return {};
         const basename = fileBasename(filename);
         const topLevelFunctions = [];
+        // Top-level `VariableDeclarator` initializer expressions that are NOT
+        // themselves functions — e.g. a `Record` registry object literal or an
+        // array literal whose entries invoke a factory helper. These are the
+        // sibling consumers a reverse-closure walk over function bodies alone would
+        // miss, so we retain them to complete the "does the file need the
+        // candidate?" check.
+        const nonFunctionInitializers = [];
         let hasExportDefault = false;
         // Names of every top-level binding (functions, consts, lets, destructured
         // bindings). Used by the closure exemption: a function that references any
@@ -478,8 +485,14 @@ exports.preferUtilityFunctionOwnFile = (0, createRule_1.createRule)({
                         continue;
                     const name = declarator.id.name;
                     const fn = extractFunctionInit(declarator.init);
-                    if (!fn)
+                    if (!fn) {
+                        // A non-function initializer (object/array literal, call, etc.) may
+                        // still consume a sibling helper by name; retain it for the
+                        // reverse-closure exemption.
+                        if (declarator.init)
+                            nonFunctionInitializers.push(declarator.init);
                         continue;
+                    }
                     topLevelFunctions.push({
                         node: declarator,
                         name,
@@ -559,7 +572,7 @@ exports.preferUtilityFunctionOwnFile = (0, createRule_1.createRule)({
                         // primitive its sibling exports build on. A cohesive multi-export
                         // utility module is already a utility file; extracting its core
                         // would sever the file's internal cohesion.
-                        if (isReferencedBySibling(info, topLevelFunctions))
+                        if (isReferencedBySibling(info, topLevelFunctions, nonFunctionInitializers))
                             continue;
                     }
                     // --- Co-location gate: file must have a distinct primary export ---
@@ -618,17 +631,25 @@ function functionClosesOverModuleScope(fn, topLevelBindingNames) {
     return false;
 }
 /**
- * Returns true if any *other* top-level function in the file references the
- * candidate by name in its body. When sibling exports build on the candidate,
- * the candidate is the module's shared internal primitive — a cohesive
- * multi-export utility module is already a utility file, and extracting its core
- * would orphan the siblings from the primitive they depend on.
+ * Returns true if any *other* top-level sibling in the file references the
+ * candidate by name. When sibling exports build on the candidate, the candidate
+ * is the module's shared internal primitive — a cohesive multi-export utility
+ * module is already a utility file, and extracting its core would orphan the
+ * siblings from the primitive they depend on.
+ *
+ * Two kinds of sibling can consume the candidate:
+ * - Another top-level function that references it in its body.
+ * - A non-function top-level initializer expression that references it — e.g. a
+ *   `Record` registry object literal or array literal whose entries invoke the
+ *   candidate factory (`export const RENDERERS = { b: buildRenderer('b') }`).
+ *   The function-body walk cannot see these, so the initializer expressions are
+ *   inspected directly.
  *
  * This is the mirror of the closure exemption: `functionClosesOverModuleScope`
  * asks "does the candidate need the file?"; this asks "does the file need the
  * candidate?". Either direction of dependency means extraction severs cohesion.
  */
-function isReferencedBySibling(candidate, allFunctions) {
+function isReferencedBySibling(candidate, allFunctions, nonFunctionInitializers = []) {
     for (const other of allFunctions) {
         if (other.name === candidate.name)
             continue;
@@ -639,6 +660,11 @@ function isReferencedBySibling(candidate, allFunctions) {
         if (refs.has(candidate.name))
             return true;
     }
+    for (const init of nonFunctionInitializers) {
+        const refs = collectReferencedIdentifiers(init);
+        if (refs.has(candidate.name))
+            return true;
+    }
     return false;
 }
 /**

package/lib/rules/require-props-composition.js

@@ -46,6 +46,18 @@ const DEFAULT_EXCLUDED_COMPONENTS = new Set([
     'React.StrictMode',
 ]);
 const DEFAULT_TARGET_PATHS = ['src/components/**/*.tsx'];
+/**
+ * Icon components (e.g. CheckIcon, RefreshIcon from @mui/icons-material) are
+ * decorative leaf elements — the same category as the layout/decorative
+ * primitives in DEFAULT_EXCLUDED_COMPONENTS. They expose no composable
+ * customization surface a parent should re-expose, so rendering one is never a
+ * composition dependency. Matched by the conventional `*Icon` suffix, which
+ * excludes CheckIcon/LinkIcon/RefreshIcon without touching interactive
+ * components like IconButton (issue #1307).
+ */
+function isDecorativeIcon(name) {
+    return /Icon$/.test(name);
+}
 /**
  * Derives the expected Props type name for a JSX element name.
  * e.g. "LoadingButton" → "LoadingButtonProps"
@@ -432,7 +444,9 @@ exports.requirePropsComposition = (0, createRule_1.createRule)({
             const body = funcNode.body ?? funcNode;
             const allJsxNames = collectJsxElementNames(body);
             // Filter to non-excluded custom components
-            const depComponents = Array.from(allJsxNames).filter((name) => !excludeComponents.has(name) && name !== componentName);
+            const depComponents = Array.from(allJsxNames).filter((name) => !excludeComponents.has(name) &&
+                !isDecorativeIcon(name) &&
+                name !== componentName);
             if (depComponents.length < minDependencyCount) {
                 return;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.19.2",
+  "version": "1.19.4",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.19.4",
+    "date": "2026-07-14T18:24:36.895Z",
+    "rules": [
+      {
+        "name": "require-props-composition",
+        "changeType": "fix",
+        "issues": [
+          1307
+        ],
+        "summary": "exclude decorative *Icon leaf components (closes #1307)"
+      }
+    ]
+  },
+  {
+    "version": "1.19.3",
+    "date": "2026-07-14T11:28:07.708Z",
+    "rules": [
+      {
+        "name": "prefer-utility-function-own-file",
+        "changeType": "fix",
+        "issues": [
+          1305
+        ],
+        "summary": "exempt factory consumed only by sibling const initializer literal (closes #1305)"
+      }
+    ]
+  },
   {
     "version": "1.19.2",
     "date": "2026-07-14T07:32:08.575Z",