@blumintinc/eslint-plugin-blumint 1.19.19 → 1.19.21

package/lib/index.js

@@ -222,7 +222,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.19.19',
+        version: '1.19.21',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-object-literal-as-const.js

@@ -40,14 +40,20 @@ exports.enforceObjectLiteralAsConst = (0, createRule_1.createRule)({
             return false;
         }
         /**
-         * Checks if an array contains object literals that might be used as component props
+         * Checks if the (unwrapped) return argument is an array literal.
+         *
+         * Arrays returned from React hook callbacks represent memoized data/prop
+         * lists (component props, hit lists, tab labels, etc.). Freezing them into
+         * readonly tuples via `as const` fights the mutable/`readonly`-array types
+         * they flow into downstream, so any array returned from a hook is exempt —
+         * regardless of whether its elements are inline object literals (`[{...}]`),
+         * identifier/member references to objects (`[ANY_GAME_HIT]`,
+         * `[constants.HIT]`), or primitives. The rule has no type information, so it
+         * cannot narrow this further without reintroducing the false positives
+         * issues #511 and #1324 document.
          */
-        function isArrayWithObjectLiterals(node) {
-            if (node.type !== 'ArrayExpression') {
-                return false;
-            }
-            // Check if any element in the array is an object literal
-            return node.elements.some((elem) => elem !== null && elem.type === 'ObjectExpression');
+        function isArrayLiteral(node) {
+            return node.type === 'ArrayExpression';
         }
         return {
             ReturnStatement(node) {
@@ -96,9 +102,10 @@ exports.enforceObjectLiteralAsConst = (0, createRule_1.createRule)({
                         argument.elements.some((elem) => elem !== null && elem.type === 'SpreadElement'))) {
                     return;
                 }
-                // Skip arrays with object literals inside React hooks (likely component props)
+                // Skip arrays returned from React hooks (memoized data/prop lists that
+                // must not be frozen into readonly tuples — see #511 and #1324)
                 if (isInsideReactHook(ancestors) &&
-                    isArrayWithObjectLiterals(argument.type === 'TSAsExpression'
+                    isArrayLiteral(argument.type === 'TSAsExpression'
                         ? argument.expression
                         : argument)) {
                     return;

package/lib/rules/prefer-map-over-conditional-dispatch.js

@@ -177,7 +177,11 @@ exports.preferMapOverConditionalDispatch = (0, createRule_1.createRule)({
                 }
                 let text;
                 try {
-                    text = checker.typeToString(widened);
+                    // Pass the expression's TS node as the enclosing declaration so the
+                    // printer qualifies namespaced symbols to their scoped name (e.g.
+                    // `JSX.Element`, not the DOM global `Element`) at the fix site.
+                    const enclosing = esTreeNodeToTSNodeMap.get(expr);
+                    text = checker.typeToString(widened, enclosing);
                 }
                 catch {
                     return null;
@@ -192,9 +196,13 @@ exports.preferMapOverConditionalDispatch = (0, createRule_1.createRule)({
             }
             return parts.length > 0 ? parts.join(' | ') : null;
         }
-        function discriminantTypeText(type) {
+        function discriminantTypeText(type, discriminant) {
             try {
-                const text = checker.typeToString(type);
+                // Pass the discriminant's TS node as the enclosing declaration so the
+                // printer qualifies namespaced symbols to their scoped name at the fix
+                // site rather than printing an ambiguous short name.
+                const enclosing = esTreeNodeToTSNodeMap.get(discriminant);
+                const text = checker.typeToString(type, enclosing);
                 return text && text !== 'error' ? text : null;
             }
             catch {
@@ -542,7 +550,7 @@ exports.preferMapOverConditionalDispatch = (0, createRule_1.createRule)({
             if (literalKeys.length === 0 || hasOther) {
                 return null;
             }
-            const dText = discriminantTypeText(type);
+            const dText = discriminantTypeText(type, discriminant);
             if (!dText) {
                 return null;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.19.19",
+  "version": "1.19.21",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,32 @@
 [
+  {
+    "version": "1.19.21",
+    "date": "2026-07-21T21:24:23.464Z",
+    "rules": [
+      {
+        "name": "enforce-object-literal-as-const",
+        "changeType": "fix",
+        "issues": [
+          1324
+        ],
+        "summary": "exempt identifier/member array elements returned from hooks (closes #1324)"
+      }
+    ]
+  },
+  {
+    "version": "1.19.20",
+    "date": "2026-07-18T20:26:20.204Z",
+    "rules": [
+      {
+        "name": "prefer-map-over-conditional-dispatch",
+        "changeType": "fix",
+        "issues": [
+          1322
+        ],
+        "summary": "qualify JSX value/discriminant type via enclosingDeclaration (closes #1322)"
+      }
+    ]
+  },
   {
     "version": "1.19.19",
     "date": "2026-07-18T17:27:38.611Z",