@blumintinc/eslint-plugin-blumint 1.17.0 → 1.17.1

package/lib/index.js

@@ -217,7 +217,7 @@ function noFrontendImportsFromFunctionsPatterns(pattern) {
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.17.0',
+        version: '1.17.1',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/no-hungarian.js

@@ -353,36 +353,28 @@ exports.noHungarian = (0, createRule_1.createRule)({
                     return true;
                 }
                 // Abbreviation markers (str, num, int, bool, arr, obj, fn, func) are
-                // short enough that the raw-character boundary heuristic below can fire
-                // on them as substrings inside real English words (e.g. "int" inside
-                // "Mint", "str" inside "stream"). For these markers, require an exact
-                // match against a full camelCase token so that "Mint" → ["Mint"] never
-                // matches "int", while genuine Hungarian like intValue → ["int","Value"]
-                // still does.
+                // short enough that a raw-character boundary check can fire on them as
+                // substrings inside real English words (e.g. "int" inside "Mint", "str"
+                // inside "stream"). Require an exact match against a full camelCase
+                // token so that "Mint" → ["Mint"] never matches "int", while genuine
+                // Hungarian like intValue → ["int","Value"] still does.
                 if (ABBREVIATION_MARKER_SET.has(normalizedMarker)) {
                     const segments = splitCamelSegments(variableName);
                     return segments.some((s) => s.toLowerCase() === normalizedMarker);
                 }
-                // Check for word boundaries to avoid matching substrings
-                // For example, avoid matching "int" in "points" or "str" in "stream"
-                const markerIndex = normalizedVarName.indexOf(normalizedMarker);
-                if (markerIndex === -1) {
-                    return false;
-                }
-                const preMarkerPrefix = markerIndex > 0 ? variableName[markerIndex - 1] : '';
-                const suffix = variableName[markerIndex + normalizedMarker.length] ?? '';
-                // Ensure we have proper word boundaries
-                // A word boundary is defined by:
-                // 1. Start of string OR underscore OR capital letter before the marker
-                // 2. End of string OR underscore OR capital letter after the marker
-                const hasStartBoundary = markerIndex === 0 ||
-                    preMarkerPrefix === '_' ||
-                    /[A-Z]/.test(preMarkerPrefix) ||
-                    /[A-Z]/.test(variableName[markerIndex]);
-                const hasEndBoundary = markerIndex + normalizedMarker.length === normalizedVarName.length ||
-                    suffix === '_' ||
-                    /[A-Z]/.test(suffix);
-                return hasStartBoundary && hasEndBoundary;
+                // Full type-word markers (non-abbreviations: String, Number, Function,
+                // Array, Object, Boolean, …) are Hungarian only when they occupy the
+                // first or last camelCase segment — a genuine prefix or suffix that
+                // tags the entity's runtime type. The prefix/suffix character checks
+                // above already return `true` for those positions, so reaching this
+                // point means the marker sits in a middle segment of the identifier
+                // (e.g. cloud·Function·Registry, user·String·Name). A middle
+                // full-type-word qualifies a domain concept ("a registry of cloud
+                // functions") rather than redundantly encoding the entity's type.
+                // Accepting the resulting false negatives is the deliberate trade-off:
+                // middle-segment full-type-words are overwhelmingly domain vocabulary,
+                // not type tags.
+                return false;
             });
         }
         // Check if the identifier is a built-in method or imported from an external module

package/lib/rules/react-memoize-literals.js

@@ -485,6 +485,98 @@ function isStyleJSXAttributeValue(node) {
     }
     return false;
 }
+/**
+ * Returns true when the node is a JSX element or fragment. JSX nodes are
+ * always fresh references each render — wrapping a containing literal in
+ * useMemo provides no referential-stability benefit because the JSX member
+ * changes on every call regardless of the wrapper.
+ */
+function isJSXNode(node) {
+    return (node.type === utils_1.AST_NODE_TYPES.JSXElement ||
+        node.type === utils_1.AST_NODE_TYPES.JSXFragment);
+}
+/**
+ * Collects the names of variables declared in the owning function's top-level
+ * block body whose initializers resolve to JSX elements or fragments. Used to
+ * detect shorthand object properties like `{ Portal }` where
+ * `const Portal = <div />` precedes the return statement.
+ *
+ * Only top-level declarations are scanned; inner function scopes have their
+ * own render lifecycles and are not candidates for this exemption.
+ */
+function collectLocalJSXBindings(owner) {
+    const bindings = new Set();
+    const body = owner.body;
+    if (body.type !== utils_1.AST_NODE_TYPES.BlockStatement)
+        return bindings;
+    for (const stmt of body.body) {
+        if (stmt.type !== utils_1.AST_NODE_TYPES.VariableDeclaration)
+            continue;
+        for (const declarator of stmt.declarations) {
+            if (declarator.id.type !== utils_1.AST_NODE_TYPES.Identifier)
+                continue;
+            if (!declarator.init)
+                continue;
+            const unwrapped = unwrapNestedExpressions(declarator.init);
+            if (isJSXNode(unwrapped)) {
+                bindings.add(declarator.id.name);
+            }
+        }
+    }
+    return bindings;
+}
+/**
+ * Returns true when an ObjectExpression returned from a hook contains at
+ * least one property whose value is a JSX element or fragment — either
+ * directly inline (`{ Portal: <div /> }`) or via a shorthand identifier
+ * (`{ Portal }`) that resolves to a JSX initializer in the same function
+ * scope. Such objects cannot be stabilised by wrapping them in useMemo
+ * because the JSX member is a fresh reference on every render regardless of
+ * the wrapper. This is the same "no stability benefit" rationale applied to
+ * sx/style JSX attribute values.
+ */
+function objectLiteralContainsJSXValue(node, owner) {
+    // Resolve shorthand bindings lazily — only when at least one shorthand
+    // property is present, to avoid the body scan for the common inline case.
+    let localJSXBindings = null;
+    for (const prop of node.properties) {
+        if (prop.type === utils_1.AST_NODE_TYPES.SpreadElement)
+            continue;
+        const value = unwrapNestedExpressions(prop.value);
+        // Direct inline JSX: { Portal: <div /> } or { el: <></> }
+        if (isJSXNode(value)) {
+            return true;
+        }
+        // Shorthand identifier: { Portal } — resolve to a local JSX binding.
+        if (prop.shorthand && value.type === utils_1.AST_NODE_TYPES.Identifier) {
+            if (!localJSXBindings) {
+                localJSXBindings = collectLocalJSXBindings(owner);
+            }
+            if (localJSXBindings.has(value.name)) {
+                return true;
+            }
+        }
+    }
+    return false;
+}
+/**
+ * Returns true when an ArrayExpression returned from a hook contains at least
+ * one element that is a JSX element or fragment (after unwrapping expression
+ * wrappers). The same "no stability benefit" rationale applies: a JSX element
+ * is a fresh reference each render, so wrapping the array in useMemo would
+ * recompute on every call without improving referential stability.
+ */
+function arrayLiteralContainsJSXValue(node) {
+    for (const element of node.elements) {
+        if (!element)
+            continue;
+        const unwrapped = unwrapNestedExpressions(element);
+        if (isJSXNode(unwrapped)) {
+            return true;
+        }
+    }
+    return false;
+}
 /**
  * Formats a readable label for diagnostics based on the owning function.
  * @param fn Owning component or hook function.
@@ -511,7 +603,7 @@ exports.reactMemoizeLiterals = (0, createRule_1.createRule)({
         messages: {
             componentLiteral: 'New {{literalType}} inside {{context}} is created on every render → Breaks referential stability for hooks/props and can re-run effects or re-render children → Hoist it to a module-level constant or wrap it in {{memoHook}} with the right dependencies.',
             nestedHookLiteral: 'Nested {{literalType}} inside {{hookName}} arguments is recreated on every render → Dependency/reference comparisons change each time and defeat memoization/caching → Extract it into a memoized value (useMemo/useCallback) or hoist it to a module constant before passing it to {{hookName}}.',
-            hookReturnLiteral: '{{hookName}} returns a {{literalType}} literal on each render → Callers receive a fresh reference and may re-render or re-run effects → Memoize the returned value with useMemo/useCallback or return pre-memoized pieces so callers see stable references.',
+            hookReturnLiteral: '{{hookName}} returns an {{literalType}} on each render → Callers receive a fresh reference and may re-render or re-run effects → Memoize the returned value with useMemo/useCallback or return pre-memoized pieces so callers see stable references.',
             memoizeLiteralSuggestion: 'This {{literalType}} is created inline → It produces a new reference each render → Wrap it in {{memoHook}} and include every closed-over value in the dependency array.',
         },
     },
@@ -659,6 +751,19 @@ exports.reactMemoizeLiterals = (0, createRule_1.createRule)({
                 return;
             }
             if (isReturnValueFromHook(node, owner)) {
+                // A returned literal whose members include a JSX element or fragment
+                // cannot be stabilised by useMemo: JSX nodes are inherently fresh
+                // references each render, so the wrapper recomputes every call
+                // regardless. This mirrors the "no stability benefit" carve-out for
+                // sx/style JSX attribute values (see isStyleJSXAttributeValue).
+                if (node.type === utils_1.AST_NODE_TYPES.ObjectExpression &&
+                    objectLiteralContainsJSXValue(node, owner)) {
+                    return;
+                }
+                if (node.type === utils_1.AST_NODE_TYPES.ArrayExpression &&
+                    arrayLiteralContainsJSXValue(node)) {
+                    return;
+                }
                 const hookName = getFunctionName(owner) ?? 'this hook';
                 context.report({
                     node,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.17.0",
+  "version": "1.17.1",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",

package/release-manifest.json

@@ -1,4 +1,26 @@
 [
+  {
+    "version": "1.17.1",
+    "date": "2026-07-01T22:31:34.840Z",
+    "rules": [
+      {
+        "name": "no-hungarian",
+        "changeType": "fix",
+        "issues": [
+          1250
+        ],
+        "summary": "exempt middle-segment full-type-words from Hungarian detection (closes #1250)"
+      },
+      {
+        "name": "react-memoize-literals",
+        "changeType": "fix",
+        "issues": [
+          1251
+        ],
+        "summary": "exempt hook returns containing JSX-valued members (closes #1251)"
+      }
+    ]
+  },
   {
     "version": "1.17.0",
     "date": "2026-07-01T05:16:18.225Z",