@blumintinc/eslint-plugin-blumint 1.12.1 → 1.12.2

package/lib/index.js

@@ -106,7 +106,7 @@ const enforce_boolean_naming_prefixes_1 = require("./rules/enforce-boolean-namin
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '1.12.1',
+        version: '1.12.2',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/enforce-boolean-naming-prefixes.js

@@ -119,9 +119,48 @@ exports.enforceBooleanNamingPrefixes = (0, createRule_1.createRule)({
                     ['===', '!==', '==', '!=', '>', '<', '>=', '<='].includes(node.init.operator)) {
                     return true;
                 }
-                // Check for logical expressions (&&, ||)
+                // Check for logical expressions (&&)
                 if (node.init.type === utils_1.AST_NODE_TYPES.LogicalExpression &&
                     node.init.operator === '&&') {
+                    // Check if the right side is a method call that might return a non-boolean value
+                    const rightSide = node.init.right;
+                    if (rightSide.type === utils_1.AST_NODE_TYPES.CallExpression) {
+                        // If the method name doesn't suggest it returns a boolean, don't flag it
+                        if (rightSide.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+                            rightSide.callee.property.type === utils_1.AST_NODE_TYPES.Identifier) {
+                            const methodName = rightSide.callee.property.name;
+                            // Check if the method name suggests it returns a boolean
+                            const isBooleanMethod = approvedPrefixes.some((prefix) => methodName.toLowerCase().startsWith(prefix.toLowerCase()));
+                            // If the method name suggests it returns a boolean (starts with a boolean prefix or contains 'boolean' or 'enabled'),
+                            // then the variable should be treated as a boolean
+                            if (isBooleanMethod ||
+                                methodName.toLowerCase().includes('boolean') ||
+                                methodName.toLowerCase().includes('enabled') ||
+                                methodName.toLowerCase().includes('auth') ||
+                                methodName.toLowerCase().includes('valid') ||
+                                methodName.toLowerCase().includes('check')) {
+                                return true;
+                            }
+                            // For methods like getVolume(), getData(), etc., assume they return non-boolean values
+                            if (methodName.toLowerCase().startsWith('get') ||
+                                methodName.toLowerCase().startsWith('fetch') ||
+                                methodName.toLowerCase().startsWith('retrieve') ||
+                                methodName.toLowerCase().startsWith('load') ||
+                                methodName.toLowerCase().startsWith('read')) {
+                                return false;
+                            }
+                        }
+                    }
+                    // For property access like user.isAuthenticated, treat as boolean
+                    if (rightSide.type === utils_1.AST_NODE_TYPES.MemberExpression &&
+                        rightSide.property.type === utils_1.AST_NODE_TYPES.Identifier) {
+                        const propertyName = rightSide.property.name;
+                        const isBooleanProperty = approvedPrefixes.some((prefix) => propertyName.toLowerCase().startsWith(prefix.toLowerCase()));
+                        if (isBooleanProperty) {
+                            return true;
+                        }
+                    }
+                    // Default to true for other cases with && to avoid false negatives
                     return true;
                 }
                 // Special case for logical OR (||) - only consider it boolean if:

package/lib/rules/enforce-positive-naming.js

@@ -930,9 +930,12 @@ exports.enforcePositiveNaming = (0, createRule_1.createRule)({
             // Split the name into words
             const words = splitNameIntoWords(name);
             // Check if this follows the pattern IS_NOT_SOMETHING or HAS_NO_SOMETHING
-            const secondWord = words[1].toLowerCase();
-            if (EXCEPTION_WORDS.some((exception) => secondWord === exception.toLowerCase())) {
-                return { isNegative: false, alternatives: [] };
+            // Make sure words[1] exists before trying to access it
+            if (words.length > 1) {
+                const secondWord = words[1].toLowerCase();
+                if (EXCEPTION_WORDS.some((exception) => secondWord === exception.toLowerCase())) {
+                    return { isNegative: false, alternatives: [] };
+                }
             }
             const nameLowercase = name.toLowerCase();
             // Check for negative prefixes in boolean-like variables

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "1.12.1",
+  "version": "1.12.2",
   "description": "Custom eslint rules for use within BluMint",
   "author": {
     "name": "Brodie McGuire",