@blumintinc/eslint-plugin-blumint 0.1.19 → 0.1.21

package/lib/index.js

@@ -18,7 +18,7 @@ const require_memo_1 = require("./rules/require-memo");
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '0.1.19',
+        version: '0.1.21',
     },
     parseOptions: {
         ecmaVersion: 2020,

package/lib/rules/dynamic-https-errors.js

@@ -25,7 +25,7 @@ exports.dynamicHttpsErrors = (0, createRule_1.createRule)({
         },
         schema: [],
         messages: {
-            dynamicHttpsErrors: 'Found dynamic error details in the "message" field. Move any dynamic details third argument.',
+            dynamicHttpsErrors: 'Found dynamic error details in the second argument of the HttpsError constructor - the "message" field. This field is hashed to produce a unique id for error monitoring. Move any dynamic details to the third argument - the "details" field - to preserve the unique id and to monitor the error correctly.',
         },
     },
     defaultOptions: [],

package/lib/rules/require-memo.js

@@ -24,35 +24,41 @@ function isHigherOrderFunctionReturningJSX(node) {
     }
     return false;
 }
+const isUnmemoizedArrowFunction = (parentNode) => {
+    return (parentNode.type === 'VariableDeclarator' &&
+        parentNode.id.type === 'Identifier' &&
+        !isComponentExplicitlyUnmemoized(parentNode.id.name));
+};
+const isUnmemoizedFunctionComponent = (parentNode, node) => {
+    return (node.type === 'FunctionDeclaration' &&
+        parentNode.type === 'Program' &&
+        node.id &&
+        !isComponentExplicitlyUnmemoized(node.id.name));
+};
+const isUnmemoizedExportedFunctionComponent = (parentNode, node) => {
+    return (node.type === 'FunctionDeclaration' &&
+        parentNode.type === 'ExportNamedDeclaration' &&
+        node.id &&
+        !isComponentExplicitlyUnmemoized(node.id.name));
+};
 function checkFunction(context, node) {
     const fileName = context.getFilename();
     if (!fileName.endsWith('.tsx')) {
         return;
     }
     if (isHigherOrderFunctionReturningJSX(node)) {
-        console.log('Found HOF');
         return;
     }
-    const currentNode = node.parent;
+    const parentNode = node.parent;
     if (node.parent.type === 'CallExpression') {
         return;
     }
-    // while (currentNode.type === 'CallExpression') {
-    //   if (isMemoCallExpression(currentNode) || true) {
-    //     return;
-    //   }
-    //   currentNode = currentNode.parent;
-    // }
     if (ASTHelpers_1.ASTHelpers.returnsJSX(node.body) && ASTHelpers_1.ASTHelpers.hasParameters(node)) {
-        if (currentNode.type === 'VariableDeclarator' &&
-            currentNode.id.type === 'Identifier' &&
-            !isComponentExplicitlyUnmemoized(currentNode.id.name)) {
-            context.report({ node, messageId: 'requireMemo' });
-        }
-        else if (node.type === 'FunctionDeclaration' &&
-            currentNode.type === 'Program' &&
-            node.id &&
-            !isComponentExplicitlyUnmemoized(node.id.name)) {
+        if ([
+            isUnmemoizedArrowFunction,
+            isUnmemoizedFunctionComponent,
+            isUnmemoizedExportedFunctionComponent,
+        ].some((fn) => fn(parentNode, node))) {
             context.report({ node, messageId: 'requireMemo' });
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "0.1.19",
+  "version": "0.1.21",
   "description": "Custom eslint rules for use at BluMint",
   "keywords": [
     "eslint",