@blumintinc/eslint-plugin-blumint 0.1.13 → 0.1.14

package/lib/index.js

@@ -16,7 +16,7 @@ const prefer_type_over_interface_1 = require("./rules/prefer-type-over-interface
 module.exports = {
     meta: {
         name: '@blumintinc/eslint-plugin-blumint',
-        version: '0.1.13',
+        version: '0.1.14',
     },
     parseOptions: {
         ecmaVersion: 2020,
@@ -31,7 +31,7 @@ module.exports = {
                 '@blumintinc/blumint/generic-starts-with-t': 'warn',
                 '@blumintinc/blumint/no-async-array-filter': 'error',
                 '@blumintinc/blumint/no-async-foreach': 'error',
-                '@blumincinc/blumint/no-conditional-literals-in-jsx': 'error',
+                '@blumintinc/blumint/no-conditional-literals-in-jsx': 'error',
                 '@blumintinc/blumint/no-filter-without-return': 'error',
                 '@blumintinc/blumint/no-misused-switch-case': 'error',
                 '@blumintinc/blumint/no-unpinned-dependencies': 'error',

package/lib/rules/no-conditional-literals.js

@@ -0,0 +1,59 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.noConditionalLiterals = void 0;
+/* eslint-disable @blumintinc/blumint/extract-global-constants */
+// import { ASTHelpers } from '../utils/ASTHelpers';
+const utils_1 = require("@typescript-eslint/utils");
+exports.noConditionalLiterals = {
+    create(context) {
+        return {
+            // Imagine evaluating <div>text {conditional && 'string'}</div>
+            JSXExpressionContainer(node) {
+                // We start at the expression {conditional && 'string'}
+                if (node.expression.type !== 'LogicalExpression') {
+                    return;
+                }
+                const parentChildren = node.parent && 'children' in node.parent ? node.parent.children : [];
+                // "text" is one of the siblingTextNodes.
+                const siblingTextNodes = parentChildren.filter((n) => {
+                    if (n.type === utils_1.TSESTree.AST_NODE_TYPES.Literal ||
+                        n.type === utils_1.TSESTree.AST_NODE_TYPES.JSXText) {
+                        return !!('value' in n && !!n.value ? `${n.value}`.trim() : false);
+                    }
+                    return false;
+                });
+                // If we were evaluating
+                //   <div>{property} {conditional && 'string'}</div>
+                // Then {property} would be one of the siblingExpressionNodes
+                const siblingExpressionNodes = parentChildren.filter((n) => n.type === 'JSXExpressionContainer' &&
+                    'expression' in n &&
+                    (n.expression.type === 'Identifier' ||
+                        n.expression.type === 'MemberExpression'));
+                // Operands of {conditional && 'string'} -- the conditional and the
+                // literal. We want to make sure we have a text literal, otherwise we'd
+                // trigger this rule on the (safe) {conditional && <div>string</div>}.
+                const expressionOperandTypes = [
+                    node.expression.left.type,
+                    node.expression.right.type,
+                ];
+                if (siblingTextNodes.concat(siblingExpressionNodes).length > 0 &&
+                    expressionOperandTypes.includes(utils_1.TSESTree.AST_NODE_TYPES.Literal)) {
+                    context.report({ node, messageId: 'unexpected' });
+                }
+            },
+        };
+    },
+    meta: {
+        type: 'problem',
+        docs: {
+            description: 'Disallow use of conditional literals in JSX code',
+            recommended: 'error',
+        },
+        messages: {
+            unexpected: 'Conditional expression is a sibling of raw text and must be wrapped in <div> or <span>',
+        },
+        schema: [],
+    },
+    defaultOptions: [],
+};
+//# sourceMappingURL=no-conditional-literals.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blumintinc/eslint-plugin-blumint",
-  "version": "0.1.13",
+  "version": "0.1.14",
   "description": "Custom eslint rules for use at BluMint",
   "keywords": [
     "eslint",