@bloom-housing/ui-components 4.4.1-alpha.22 → 4.4.1-alpha.23

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.4.1-alpha.23](https://github.com/bloom-housing/bloom/compare/@bloom-housing/ui-components@4.4.1-alpha.22...@bloom-housing/ui-components@4.4.1-alpha.23) (2022-06-09)
+
+**Note:** Version bump only for package @bloom-housing/ui-components
+
+
+
+
+
 ## [4.4.1-alpha.22](https://github.com/bloom-housing/bloom/compare/@bloom-housing/ui-components@4.4.1-alpha.21...@bloom-housing/ui-components@4.4.1-alpha.22) (2022-06-09)
 
 **Note:** Version bump only for package @bloom-housing/ui-components

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bloom-housing/ui-components",
-  "version": "4.4.1-alpha.22",
+  "version": "4.4.1-alpha.23",
   "author": "Sean Albert <sean.albert@exygy.com>",
   "description": "Shared user interface components for Bloom affordable housing system",
   "homepage": "https://github.com/bloom-housing/bloom/tree/master/shared/ui-components",
@@ -108,5 +108,5 @@
     "ts-jest": "^26.4.1",
     "typesafe-actions": "^5.1.0"
   },
-  "gitHead": "75c4f85bceed686348d63acf6916ca827409e91b"
+  "gitHead": "1b2400d4c6ddd566fcd5b7bfa6756a6b9490cffd"
 }

package/src/page_components/sign-in/FormSignInMFACode.tsx

@@ -11,13 +11,17 @@ import {
   FormSignInErrorBox,
 } from "@bloom-housing/ui-components"
 import { NetworkStatus, FormSignInControl } from "./FormSignIn"
-import { EnumRequestMfaCodeMfaType } from "@bloom-housing/backend-core/types"
+
+export enum RequestType {
+  email = "email",
+  sms = "sms",
+}
 
 export type FormSignInMFACodeProps = {
   control: FormSignInControl
   onSubmit: (data: FormSignInMFACodeValues) => void
   networkError: NetworkStatus
-  mfaType: EnumRequestMfaCodeMfaType
+  mfaType: RequestType
   allowPhoneNumberEdit: boolean
   phoneNumber: string
   goBackToPhone: () => void
@@ -63,7 +67,7 @@ const FormSignInMFACode = ({
         <Icon size="2xl" symbol="profile" className="form-card__header-icon" />
         <h2 className="form-card__title is-borderless">{t("nav.signInMFA.verifyTitle")}</h2>
         <p className="form-card__sub-title">
-          {mfaType === EnumRequestMfaCodeMfaType.sms
+          {mfaType === RequestType.sms
             ? t("nav.signInMFA.haveSentCodeToPhone")
             : t("nav.signInMFA.haveSentCodeToEmail")}
         </p>

package/src/page_components/sign-in/FormSignInMFAType.tsx

@@ -12,12 +12,13 @@ import {
 } from "@bloom-housing/ui-components"
 import type { UseFormMethods } from "react-hook-form"
 import { NetworkStatus } from "./FormSignIn"
-import { EnumRequestMfaCodeMfaType } from "@bloom-housing/backend-core/types"
 
 export type FormSignInMFAProps = {
   control: FormSignInMFAControl
-  onSubmit: (data: FormSignInMFAValues) => void
+  onSubmit: (data: unknown) => void
   networkError: NetworkStatus
+  emailOnClick: () => void
+  smsOnClick: () => void
 }
 
 export type FormSignInMFAControl = {
@@ -27,14 +28,12 @@ export type FormSignInMFAControl = {
   setValue: UseFormMethods["setValue"]
 }
 
-export type FormSignInMFAValues = {
-  mfaType: EnumRequestMfaCodeMfaType
-}
-
 const FormSignInMFAType = ({
   onSubmit,
   networkError,
   control: { errors, register, handleSubmit, setValue },
+  emailOnClick,
+  smsOnClick,
 }: FormSignInMFAProps) => {
   const onError = () => {
     window.scrollTo(0, 0)
@@ -76,7 +75,7 @@ const FormSignInMFAType = ({
             <Button
               styleType={AppearanceStyleType.accentCool}
               data-test-id="verify-by-email"
-              onClick={() => setValue("mfaType", EnumRequestMfaCodeMfaType.email)}
+              onClick={smsOnClick}
             >
               {t("nav.signInMFA.verifyByEmail")}
             </Button>
@@ -85,7 +84,7 @@ const FormSignInMFAType = ({
             <Button
               styleType={AppearanceStyleType.accentCool}
               data-test-id="verify-by-phone"
-              onClick={() => setValue("mfaType", EnumRequestMfaCodeMfaType.sms)}
+              onClick={emailOnClick}
             >
               {t("nav.signInMFA.verifyByPhone")}
             </Button>