@bloom-housing/ui-components 3.0.0 → 3.0.1-alpha.0

package/CHANGELOG.md

@@ -3,6 +3,59 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.0.1-alpha.0](https://github.com/bloom-housing/bloom/compare/@bloom-housing/ui-components@3.0.0...@bloom-housing/ui-components@3.0.1-alpha.0) (2021-11-05)
+
+
+* 1837/preferences cleanup 3 (#2144) ([3ce6d5e](https://github.com/bloom-housing/bloom/commit/3ce6d5eb5aac49431ec5bf4912dbfcbe9077d84e)), closes [#2144](https://github.com/bloom-housing/bloom/issues/2144)
+
+
+### BREAKING CHANGES
+
+* Preferences are now M-N relation with a listing and have an intermediate table with ordinal number
+
+* refactor(backend): preferences deduplication
+
+So far each listing referenced it's own unique Preferences. This change introduces Many to Many
+relationship between Preference and Listing entity and forces sharing Preferences between listings.
+
+* feat(backend): extend preferences migration with moving existing relations to a new intermediate tab
+
+* feat(backend): add Preference - Jurisdiction ManyToMany relation
+
+* feat: adapt frontend to backend changes
+
+* fix(backend): typeORM preferences select statement
+
+* fix(backend): connect preferences with jurisdictions in seeds, fix pref filter validator
+
+* fix(backend): fix missing import in preferences-filter-params.ts
+
+* refactor: rebase issue
+
+* feat: uptake jurisdictional preferences
+
+* fix: fixup tests
+
+* fix: application preferences ignore page, always separate
+
+* Remove page from src/migration/1633359409242-add-listing-preferences-intermediate-relation.ts
+
+* fix: preference fetching and ordering/pages
+
+* Fix code style issues with Prettier
+
+* fix(backend): query User__leasingAgentInListings__jurisdiction_User__leasingAgentIn specified more
+
+* fix: perferences cypress tests
+
+Co-authored-by: Michal Plebanski <michalp@airnauts.com>
+Co-authored-by: Emily Jablonski <emily.jablonski@exygy.com>
+Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
+
+
+
+
+
 # [3.0.0](https://github.com/seanmalbert/bloom/compare/@bloom-housing/ui-components@2.0.1-alpha.8...@bloom-housing/ui-components@3.0.0) (2021-11-05)
 
 **Note:** Version bump only for package @bloom-housing/ui-components

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bloom-housing/ui-components",
-  "version": "3.0.0",
+  "version": "3.0.1-alpha.0",
   "author": "Sean Albert <sean.albert@exygy.com>",
   "description": "Shared user interface components for Bloom affordable housing system",
   "homepage": "https://github.com/bloom-housing/bloom/tree/master/shared/ui-components",
@@ -69,7 +69,7 @@
     "webpack": "^4.44.2"
   },
   "dependencies": {
-    "@bloom-housing/backend-core": "^3.0.0",
+    "@bloom-housing/backend-core": "^3.0.1-alpha.0",
     "@mapbox/mapbox-sdk": "^0.13.0",
     "@types/body-scroll-lock": "^2.6.1",
     "@types/jwt-decode": "^2.2.1",
@@ -100,5 +100,5 @@
     "tailwindcss": "2.2.10",
     "typesafe-actions": "^5.1.0"
   },
-  "gitHead": "05ed5c42d83134d0401081b2e67f739ad5bf69ac"
+  "gitHead": "a1bb74640840fb852b7819413e3c3d5b1ce0dd72"
 }

package/src/helpers/preferences.tsx

@@ -4,6 +4,7 @@ import {
   ApplicationPreference,
   FormMetadataOptions,
   Preference,
+  ListingPreference,
 } from "@bloom-housing/backend-core/types"
 import { UseFormMethods } from "react-hook-form"
 import {
@@ -373,20 +374,25 @@ export type ExclusiveKey = {
 /*
   Create an array of all exclusive keys from a preference set
 */
-export const getExclusiveKeys = (preferences: Preference[]) => {
+export const getExclusiveKeys = (preferences: ListingPreference[]) => {
   const exclusive: ExclusiveKey[] = []
-  preferences?.forEach((preference) => {
-    preference?.formMetadata?.options.forEach((option: FormMetadataOptions) => {
+  preferences?.forEach((listingPreference) => {
+    listingPreference.preference?.formMetadata?.options.forEach((option: FormMetadataOptions) => {
       if (option.exclusive)
         exclusive.push({
-          optionKey: getPreferenceOptionName(option.key, preference?.formMetadata?.key ?? ""),
-          preferenceKey: preference?.formMetadata?.key,
+          optionKey: getPreferenceOptionName(
+            option.key,
+            listingPreference.preference?.formMetadata?.key ?? ""
+          ),
+          preferenceKey: listingPreference.preference?.formMetadata?.key,
         })
     })
-    if (!preference?.formMetadata?.hideGenericDecline)
+    if (!listingPreference.preference?.formMetadata?.hideGenericDecline)
       exclusive.push({
-        optionKey: getExclusivePreferenceOptionName(preference?.formMetadata?.key),
-        preferenceKey: preference?.formMetadata?.key,
+        optionKey: getExclusivePreferenceOptionName(
+          listingPreference.preference?.formMetadata?.key
+        ),
+        preferenceKey: listingPreference.preference?.formMetadata?.key,
       })
   })
   return exclusive

package/src/lists/PreferencesList.tsx

@@ -1,10 +1,22 @@
 import * as React from "react"
-import { Preference, PreferenceLink } from "@bloom-housing/backend-core/types"
 import "./PreferencesList.scss"
 import { locale } from "../helpers/translator"
 
+export interface ListPreferenceLink {
+  title: string
+  url: string
+}
+
+export interface ListPreference {
+  ordinal?: number
+  links?: ListPreferenceLink[]
+  title?: string
+  subtitle?: string
+  description?: string
+}
+
 export interface PreferencesListProps {
-  preferences: Preference[]
+  listingPreferences: ListPreference[]
 }
 
 const getOrdinal = (n: number) => {
@@ -18,10 +30,7 @@ const getOrdinal = (n: number) => {
 }
 
 const PreferencesList = (props: PreferencesListProps) => {
-  const filteredPreferences = props.preferences.filter(
-    (pref) => !pref.formMetadata?.hideFromListing
-  )
-  const preferences = filteredPreferences.map((preference: Preference, index: number) => {
+  const preferences = props.listingPreferences?.map((preference: ListPreference, index: number) => {
     const itemClasses = ["preferences-list__item", "info-card"]
 
     if (!preference.subtitle && !preference.description && !preference.links) {
@@ -43,7 +52,7 @@ const PreferencesList = (props: PreferencesListProps) => {
         )}
         {preference.links && (
           <div className="preferences-list__links">
-            {preference.links.map((link: PreferenceLink, linkIndex: number) => (
+            {preference.links.map((link: ListPreferenceLink, linkIndex: number) => (
               <span key={linkIndex}>
                 <a href={link.url}>{link.title}</a>
               </span>

package/src/locales/general.json

@@ -891,6 +891,7 @@
     "isDigitalApplication": "Is there a digital application?",
     "isPaperApplication": "Is there a paper application?",
     "isReferralOpportunity": "Is there a referral opportunity?",
+    "selectJurisdiction": "You must first select a jurisdiction",
     "latitude": "Latitude",
     "leasingAgentAddress": "Leasing Agent Address",
     "listingPreviewOnly": "This is a listing preview only.",