@blogic-cz/agent-tools 0.15.7 → 0.15.10

package/README.md

@@ -263,7 +263,7 @@ Pod `exec` is limited to direct `redis-cli PING/INFO` and `ls` diagnostics. Gene
 
 ### gh-tool machine contracts
 
-`pr view` adds `headSha` and `baseSha`; failed-check evidence adds the same SHA pair. Review summaries, inline comments, and threads add `commitSha` plus `feedbackOrigin`: `current_head` only for an exact `commitSha === headSha`, `pre_existing` for a different known SHA (not an obsolescence verdict), and `unknown` when either SHA is absent. Issue comments always use `commitSha: null` and `feedbackOrigin: unknown`. `review-triage` preserves existing fields and adds `inlineComments` plus per-kind `feedbackOriginCounts`; batch triage returns the same object per PR.
+`pr view` adds `headSha` and `baseSha`; failed-check evidence adds the same SHA pair. Review summaries, inline comments, and threads add `commitSha` plus `feedbackOrigin`: `current_head` only for an exact `commitSha === headSha`, `pre_existing` for a different known SHA (not an obsolescence verdict), and `unknown` when either SHA is absent. Issue comments always use `commitSha: null` and `feedbackOrigin: unknown`. `review-triage` preserves existing fields and adds `inlineComments` plus per-kind `feedbackOriginCounts`; batch triage returns the same object per PR. `pr request-review --reviewers alice,bob` emits sorted `submittedReviewers` (normalized input) and `requestedReviewers` (GitHub-confirmed result).
 
 `pr watch --prs 12,34 --until terminal --format jsonl` accepts at most 50 unique, digits-only PR numbers and emits only JSONL state transitions. Identity uses `repo/pr/headSha/runId/attempt/jobId`; `runId`, `attempt`, and `jobId` are omitted from an event rather than emitted as `null`, and `checkId` is no longer emitted. State/bucket revisions emit even when identity stays stable; `supersedes` appears only when identity changes. Open PRs with no checks become terminal only after three stable empty snapshots, allowing bounded GitHub eventual consistency, and carry `checksObserved: false` — a terminal snapshot with no observed check is never green evidence. `pr checks`, batch checks, triage, and batch triage keep stderr silent with `--format json`; JSONL watch is also informationally silent. Failures still return structured nonzero errors on stderr.
 
@@ -275,6 +275,7 @@ bun gh-tool pr rerun-checks --pr 123 --failed-only --watch --timeout 600
 bun gh-tool pr trigger-checks --pr 123 --workflow dotnet-pull-request.yml # only when zero checks reported
 bun gh-tool pr watch --prs 123,124 --format jsonl --timeout 600
 bun gh-tool pr reply-and-resolve --comment-id 456 --body "Done" # infers PR and thread
+bun gh-tool pr request-review --repo be --pr 123 --reviewers alice,bob
 # Optional --pr/--thread-id retain legacy flow and are validated before either mutation.
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blogic-cz/agent-tools",
-  "version": "0.15.7",
+  "version": "0.15.10",
   "description": "CLI tools for AI coding agent workflows — GitHub, database, Kubernetes, Azure DevOps, logs, sessions, and audit",
   "keywords": [
     "agent",

package/src/gh-tool/index.ts

@@ -27,6 +27,7 @@ import {
   prEditCommand,
   prMergeCommand,
   prReadyCommand,
+  prRequestReviewCommand,
   prThreadsCommand,
   prCommentsCommand,
   prIssueCommentsCommand,
@@ -84,6 +85,7 @@ const prCommand = Command.make("pr", {}).pipe(
     prEditCommand,
     prMergeCommand,
     prReadyCommand,
+    prRequestReviewCommand,
     prWaitMergeableCommand,
     prThreadsCommand,
     prCommentsCommand,

package/src/gh-tool/pr/commands.ts

@@ -76,6 +76,85 @@ const withRepo = <A, E, R>(repo: Option.Option<string>, effect: Effect.Effect<A,
     return yield* gh.withRepoTarget(Option.getOrNull(repo), effect);
   });
 
+const reviewerInputError = (reviewers: string) =>
+  new GitHubCommandError({
+    message: `--reviewers must be comma-separated GitHub user logins without empty segments: ${JSON.stringify(reviewers)}`,
+    command: "gh-tool pr request-review",
+    exitCode: 1,
+    stderr: "",
+    hint: "Pass user logins such as --reviewers octocat,hubot.",
+  });
+
+const prNumberError = (pr: number) =>
+  new GitHubCommandError({
+    message: `--pr must be a positive integer: ${pr}`,
+    command: "gh-tool pr request-review",
+    exitCode: 1,
+    stderr: "",
+    hint: "Pass a positive PR number, e.g. --pr 123.",
+  });
+
+const GITHUB_LOGIN_RE = /^(?!.*--)[a-z\d](?:[a-z\d-]{0,37}[a-z\d])?$/;
+
+export const parseReviewers = (reviewers: string) => {
+  const parsed = reviewers.split(",").map((reviewer) => reviewer.trim().toLowerCase());
+  if (parsed.length === 0 || parsed.some((reviewer) => !GITHUB_LOGIN_RE.test(reviewer))) {
+    return Effect.fail(reviewerInputError(reviewers));
+  }
+  return Effect.succeed([...new Set(parsed)].toSorted());
+};
+
+type RequestedReviewersResponse = { requested_reviewers?: unknown };
+
+const confirmedReviewers = (response: RequestedReviewersResponse) => {
+  if (!Array.isArray(response.requested_reviewers)) {
+    return Effect.fail(
+      new GitHubCommandError({
+        message: "GitHub requested-reviewers response omitted requested_reviewers.",
+        command: "gh-tool pr request-review",
+        exitCode: 1,
+        stderr: JSON.stringify(response),
+      }),
+    );
+  }
+  const logins = response.requested_reviewers.map((reviewer) =>
+    typeof reviewer === "object" && reviewer !== null && "login" in reviewer
+      ? (reviewer as { login?: unknown }).login
+      : undefined,
+  );
+  if (logins.some((login) => typeof login !== "string")) {
+    return Effect.fail(
+      new GitHubCommandError({
+        message: "GitHub requested-reviewers response contained an invalid reviewer.",
+        command: "gh-tool pr request-review",
+        exitCode: 1,
+        stderr: JSON.stringify(response),
+      }),
+    );
+  }
+  return Effect.succeed([...new Set(logins as string[])].toSorted());
+};
+
+export const requestReview = (pr: number, reviewers: string) =>
+  Effect.gen(function* () {
+    if (!Number.isInteger(pr) || pr <= 0) return yield* prNumberError(pr);
+    const submittedReviewers = yield* parseReviewers(reviewers);
+    const gh = yield* GitHubService;
+    const repo = yield* gh.getRepoInfo();
+    const response = yield* gh.runGhJson<RequestedReviewersResponse>([
+      "api",
+      "--method",
+      "POST",
+      `repos/${repo.owner}/${repo.name}/pulls/${pr}/requested_reviewers`,
+      ...submittedReviewers.flatMap((reviewer) => ["-f", `reviewers[]=${reviewer}`]),
+    ]);
+    return {
+      pr,
+      submittedReviewers,
+      requestedReviewers: yield* confirmedReviewers(response),
+    };
+  });
+
 type ReviewTriageSummary = {
   readonly visibleOpenReviewThreadsCount: number;
   readonly unrepliedReviewThreadsCount: number;
@@ -1347,6 +1426,25 @@ export const prReviewTriageCommand = Command.make(
   ),
 );
 
+export const prRequestReviewCommand = Command.make(
+  "request-review",
+  {
+    format: formatOption,
+    pr: Flag.integer("pr").pipe(Flag.withDescription("Positive pull request number")),
+    repo: repoOption,
+    reviewers: Flag.string("reviewers").pipe(
+      Flag.withDescription("Comma-separated GitHub user logins"),
+    ),
+  },
+  ({ format, pr, repo, reviewers }) =>
+    withRepo(
+      repo,
+      Effect.gen(function* () {
+        yield* logFormatted(yield* requestReview(pr, reviewers), format);
+      }),
+    ),
+).pipe(Command.withDescription("Request review from comma-separated GitHub user logins"));
+
 export const prReviewTriageBatchCommand = Command.make(
   "review-triage-batch",
   {

package/src/gh-tool/pr/index.ts

@@ -14,6 +14,7 @@ export {
   prListCommand,
   prMergeCommand,
   prReadyCommand,
+  prRequestReviewCommand,
   prReplyCommand,
   prRerunChecksCommand,
   prReplyAndResolveCommand,

package/src/shared/prerequisites/runtime.ts

@@ -557,10 +557,23 @@ const acquireVpn = <E>(
         while (true) {
           const snapshot = store.snapshot();
           if (snapshot.lifecycle === "UNKNOWN") {
+            const contended = snapshot.activeLeases > 0;
+            if (!contended) {
+              const observed = yield* runStatusBefore(driver, connectDeadline, runCommand);
+              if (
+                observed !== undefined &&
+                (store.reconcileUnknown(snapshot, observed, Date.now()) ||
+                  store.snapshot().lifecycle !== "UNKNOWN")
+              ) {
+                continue;
+              }
+            }
             return yield* fail(
               new PrerequisiteRunError({
                 message: `VPN prerequisite "${key}" has unknown ownership: ${snapshot.evidence ?? "no evidence"}`,
-                hint: "Quiesce all agent-tools processes and remove its VPN runtime state before retrying.",
+                hint: contended
+                  ? "Another agent-tools process holds an active lease on this VPN. Retry once it has finished."
+                  : missingVpnToolHint(driver),
               }),
             );
           }

package/src/shared/prerequisites/store.ts

@@ -534,6 +534,28 @@ export class VpnStore {
     return false;
   }
 
+  /** Recovers terminal UNKNOWN from an observed status; fenced so it can never take ownership from a holder. */
+  reconcileUnknown(snapshot: VpnStateSnapshot, connected: boolean, now: number): boolean {
+    return this.immediate(
+      () =>
+        this.db
+          .query(
+            `UPDATE vpn_state SET lifecycle=?, managed_epoch_id=NULL, idle_deadline=NULL,
+               revision=revision+1, evidence=?, updated_at=?
+             WHERE singleton=1 AND lifecycle='UNKNOWN' AND operation_id IS NULL AND revision=?
+               AND NOT EXISTS (SELECT 1 FROM leases WHERE status='ACTIVE')`,
+          )
+          .run(
+            connected ? "EXTERNAL" : "DOWN",
+            connected
+              ? "Recovered from unknown ownership: VPN observed connected outside agent-tools."
+              : "Recovered from unknown ownership: VPN observed disconnected.",
+            now,
+            snapshot.revision,
+          ).changes === 1,
+    );
+  }
+
   private commitOperation(
     guard: OperationGuard,
     from: VpnLifecycle,