@blogic-cz/agent-tools 0.15.10 → 0.15.12

package/README.md

@@ -263,7 +263,7 @@ Pod `exec` is limited to direct `redis-cli PING/INFO` and `ls` diagnostics. Gene
 
 ### gh-tool machine contracts
 
-`pr view` adds `headSha` and `baseSha`; failed-check evidence adds the same SHA pair. Review summaries, inline comments, and threads add `commitSha` plus `feedbackOrigin`: `current_head` only for an exact `commitSha === headSha`, `pre_existing` for a different known SHA (not an obsolescence verdict), and `unknown` when either SHA is absent. Issue comments always use `commitSha: null` and `feedbackOrigin: unknown`. `review-triage` preserves existing fields and adds `inlineComments` plus per-kind `feedbackOriginCounts`; batch triage returns the same object per PR. `pr request-review --reviewers alice,bob` emits sorted `submittedReviewers` (normalized input) and `requestedReviewers` (GitHub-confirmed result).
+`pr view` adds `headSha` and `baseSha`; failed-check evidence adds the same SHA pair. Review summaries, inline comments, and threads add `commitSha` plus `feedbackOrigin`: `current_head` only for an exact `commitSha === headSha`, `pre_existing` for a different known SHA (not an obsolescence verdict), and `unknown` when either SHA is absent. Issue comments always use `commitSha: null` and `feedbackOrigin: unknown`. `review-triage` preserves existing fields and adds `inlineComments` plus per-kind `feedbackOriginCounts`; batch triage returns the same object per PR. `pr request-review --reviewers alice,bob` emits sorted `submittedReviewers` (normalized input), `newlyRequested` and `alreadyPending` (the submitted logins split by whether a pending request already existed, so a fresh re-request is distinguishable from a no-op), and `requestedReviewers` (GitHub-confirmed result). `pr last-human-reviewer` derives `currentRequestedReviewers` from live `reviewRequests` only; timeline events are not replayed because GitHub clears a pending request on review submit without emitting `ReviewRequestRemovedEvent`.
 
 `pr watch --prs 12,34 --until terminal --format jsonl` accepts at most 50 unique, digits-only PR numbers and emits only JSONL state transitions. Identity uses `repo/pr/headSha/runId/attempt/jobId`; `runId`, `attempt`, and `jobId` are omitted from an event rather than emitted as `null`, and `checkId` is no longer emitted. State/bucket revisions emit even when identity stays stable; `supersedes` appears only when identity changes. Open PRs with no checks become terminal only after three stable empty snapshots, allowing bounded GitHub eventual consistency, and carry `checksObserved: false` — a terminal snapshot with no observed check is never green evidence. `pr checks`, batch checks, triage, and batch triage keep stderr silent with `--format json`; JSONL watch is also informationally silent. Failures still return structured nonzero errors on stderr.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blogic-cz/agent-tools",
-  "version": "0.15.10",
+  "version": "0.15.12",
   "description": "CLI tools for AI coding agent workflows — GitHub, database, Kubernetes, Azure DevOps, logs, sessions, and audit",
   "keywords": [
     "agent",

package/src/gh-tool/pr/commands.ts

@@ -141,6 +141,15 @@ export const requestReview = (pr: number, reviewers: string) =>
     const submittedReviewers = yield* parseReviewers(reviewers);
     const gh = yield* GitHubService;
     const repo = yield* gh.getRepoInfo();
+    // ponytail: not atomic — a concurrent request between GET and POST misreports newlyRequested.
+    const pendingBefore = new Set(
+      (yield* confirmedReviewers(
+        yield* gh.runGhJson<RequestedReviewersResponse>([
+          "api",
+          `repos/${repo.owner}/${repo.name}/pulls/${pr}`,
+        ]),
+      )).map((login) => login.toLowerCase()),
+    );
     const response = yield* gh.runGhJson<RequestedReviewersResponse>([
       "api",
       "--method",
@@ -151,6 +160,8 @@ export const requestReview = (pr: number, reviewers: string) =>
     return {
       pr,
       submittedReviewers,
+      newlyRequested: submittedReviewers.filter((reviewer) => !pendingBefore.has(reviewer)),
+      alreadyPending: submittedReviewers.filter((reviewer) => pendingBefore.has(reviewer)),
       requestedReviewers: yield* confirmedReviewers(response),
     };
   });

package/src/gh-tool/pr/review.ts

@@ -126,27 +126,6 @@ const LAST_HUMAN_REVIEWER_QUERY = `
             submittedAt
           }
         }
-        timelineItems(first: 250, itemTypes: [REVIEW_REQUESTED_EVENT, REVIEW_REQUEST_REMOVED_EVENT]) {
-          nodes {
-            __typename
-            ... on ReviewRequestedEvent {
-              requestedReviewer {
-                __typename
-                ... on User { login }
-                ... on Team { name }
-                ... on Bot { login }
-              }
-            }
-            ... on ReviewRequestRemovedEvent {
-              requestedReviewer {
-                __typename
-                ... on User { login }
-                ... on Team { name }
-                ... on Bot { login }
-              }
-            }
-          }
-        }
       }
     }
   }
@@ -237,12 +216,6 @@ type LastHumanReviewerQueryResult = {
           submittedAt: string | null;
         }>;
       };
-      timelineItems: {
-        nodes: Array<{
-          __typename: string;
-          requestedReviewer: RequestedReviewerNode;
-        }>;
-      };
     };
   };
 };
@@ -1066,30 +1039,11 @@ export const fetchLastHumanReviewer = Effect.fn("pr.fetchLastHumanReviewer")(fun
 
   const prNode = response.repository.pullRequest;
 
-  const requestedFromTimeline: string[] = [];
-  for (const item of prNode.timelineItems.nodes) {
-    const login = requestedReviewerLogin(item.requestedReviewer);
-    if (login === null) {
-      continue;
-    }
-    if (item.__typename === "ReviewRequestedEvent") {
-      if (!requestedFromTimeline.includes(login)) {
-        requestedFromTimeline.push(login);
-      }
-    } else {
-      const index = requestedFromTimeline.indexOf(login);
-      if (index !== -1) {
-        requestedFromTimeline.splice(index, 1);
-      }
-    }
-  }
-
-  const currentRequestedReviewers =
-    requestedFromTimeline.length > 0
-      ? requestedFromTimeline
-      : prNode.reviewRequests.nodes
-          .map((node) => requestedReviewerLogin(node.requestedReviewer))
-          .filter((login): login is string => login !== null);
+  // GitHub clears a pending request on review submit without a ReviewRequestRemovedEvent, so
+  // only reviewRequests is authoritative; timeline replay would report stale reviewers forever.
+  const currentRequestedReviewers = prNode.reviewRequests.nodes
+    .map((node) => requestedReviewerLogin(node.requestedReviewer))
+    .filter((login): login is string => login !== null);
 
   const latestHumanReview = prNode.reviews.nodes.reduce<{ login: string; at: string } | null>(
     (latest, review) => {

package/src/session-tool/claude-code.ts

@@ -1,11 +1,12 @@
 import { Effect } from "effect";
 import { readdir } from "node:fs/promises";
+import { basename, join } from "node:path";
 
 import type { MessageSummary } from "./types";
 
 import { SessionReadError, SessionStorageNotFoundError, type SessionError } from "./errors";
 
-export const encodeProjectPath = (dir: string): string => dir.replaceAll("/", "-");
+export const encodeProjectPath = (dir: string): string => dir.replaceAll(/[/\\:]/g, "-");
 
 export type ContentBlock =
   | { type: "text"; text: string }
@@ -172,7 +173,7 @@ export const getClaudeCodeSessions = (
           continue;
         }
 
-        const projectPath = `${basePath}/${entry.name}`;
+        const projectPath = join(basePath, entry.name);
         let files: string[];
         try {
           // eslint-disable-next-line eslint/no-await-in-loop -- directory scan must finish before filtering file list
@@ -186,7 +187,7 @@ export const getClaudeCodeSessions = (
             continue;
           }
 
-          sessionFiles.push(`${projectPath}/${fileName}`);
+          sessionFiles.push(join(projectPath, fileName));
         }
       }
 
@@ -200,8 +201,8 @@ export const getClaudeCodeSessions = (
   });
 
 const getFileNameWithoutExtension = (filePath: string): string => {
-  const fileName = filePath.split("/").pop();
-  if (fileName === undefined) {
+  const fileName = basename(filePath);
+  if (fileName === "") {
     return "";
   }
 

package/src/session-tool/pi.ts

@@ -2,6 +2,7 @@ import { Effect } from "effect";
 // node:fs/promises, not Bun.file/Bun.Glob: vitest runs under Node, where the Bun globals do not
 // exist, and every function below is reached by the suite. See AGENTS.md.
 import { open, readFile, readdir, stat } from "node:fs/promises";
+import { join } from "node:path";
 
 import type { MessageSummary, SessionSummary } from "./types";
 
@@ -117,10 +118,10 @@ const walkSessionFiles = async (basePath: string): Promise<string[]> => {
     directories
       .filter((entry) => entry.isDirectory())
       .map(async (directory) => {
-        const directoryPath = `${basePath}/${directory.name}`;
+        const directoryPath = join(basePath, directory.name);
         return (await readdir(directoryPath, { withFileTypes: true }))
           .filter((entry) => entry.isFile() && entry.name.endsWith(".jsonl"))
-          .map((entry) => `${directoryPath}/${entry.name}`);
+          .map((entry) => join(directoryPath, entry.name));
       }),
   );
   return files.flat();

package/src/session-tool/service.ts

@@ -1,5 +1,6 @@
 import { Context, Effect, Layer } from "effect";
 import { readdir } from "node:fs/promises";
+import { basename } from "node:path";
 
 import type { MessageSummary, SessionInfo, SessionSource, SessionSummary } from "./types";
 
@@ -52,7 +53,7 @@ const UUID_SESSION_ID_REGEX =
   /^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$/u;
 
 const getSessionIdFromClaudeFile = (filePath: string): string => {
-  const fileName = filePath.split("/").pop() ?? "";
+  const fileName = basename(filePath);
   return fileName.endsWith(".jsonl") ? fileName.slice(0, -".jsonl".length) : fileName;
 };
 
@@ -333,7 +334,7 @@ export class SessionService extends Context.Service<
 
                     summaries.push({
                       sessionID: parsed.sessionID ?? sessionId,
-                      id: parsed.id ?? filePath.split("/").pop()?.replace(".json", "") ?? "",
+                      id: parsed.id ?? basename(filePath).replace(".json", ""),
                       title: parsed.summary.title,
                       body: parsed.summary.body ?? "",
                       created: parsed.time?.created ?? 0,