@blockcast/mmt-base 0.4.0-main.bbd83cb48eff → 0.4.0-main.bbdfdbf39ded

package/src/signalling.ts

@@ -23,6 +23,8 @@
 import {
   ALFEC_MESSAGE_ID,
   FEC_CODE_RAPTORQ,
+  FEC_CODE_REED_SOLOMON,
+  MMTP_SIGNALING_PACKET_ID,
   PACKET_TYPE_SIGNALING,
   parseMMTPHeader,
   type MMTPHeader,
@@ -453,100 +455,112 @@ export function parseAlFecMessage(mmtpPacket: Uint8Array): AlFecMessage | null {
 }
 
 /**
- * Decoder geometry of one FEC flow under the Blockcast one-stage RaptorQ
- * profile: private_field = RaptorQ FEC OTI (RFC 6330 3.3.2-3.3.3, 12 bytes)
- * followed by the interleave depth (1 byte).
+ * Decoder geometry of one FEC flow's AL-FEC message entry under
+ * draft-ramadan-moq-mmt-01 Section 8.3 ("iso-ssbg1-v1"): one Asset, coding
+ * byte 0x14, fec_code_id_for_repair_flow 3 (RaptorQ) or 1 (Reed-Solomon),
+ * and no OTI (draft-ramadan-moq-mmt-01 Section 7.2). K, T and P come from
+ * the entry's own fields; a private field, if present, is ignored.
  */
 export interface AlFecRaptorQFlowConfig {
+  /** The flow's one Asset packet_id (number_of_assets is 1). */
   sourcePacketIds: number[]
   repairFlowId: number
+  /** `FEC_CODE_RAPTORQ` (3) or `FEC_CODE_REED_SOLOMON` (1). */
+  fecCodeId: number
   /** Always `SSBG_MODE_1` (`iso-ssbg1-v1`). */
   ssbgMode: number
-  /** The coding byte's low bit as signalled (see AlFecFlow.fecPayloadIdMode). */
+  /** Always 0: the profile's coding byte is exactly 0x14. */
   fecPayloadIdMode: 0 | 1
+  /** T, from length_of_repair_symbol. */
   repairSymbolSize: number
+  /** K, from maximum_k_for_repair_flow. */
   maximumK: number
+  /** P, from maximum_p_for_repair_flow: the RSB_length total over every published layer. */
   maximumP: number
-  interleaveDepth: number
-  oti: Uint8Array
   protectionWindowTime: number
   protectionWindowSize: number
 }
 
-const RAPTORQ_PRIVATE_FIELD_LENGTH = 13
 const RAPTORQ_MAX_SOURCE_SYMBOLS = 56_403
 const REPAIR_SYMBOL_ID_MAX = 0x00ff_ffff
-
-function canonicalRaptorQOtiK(oti: Uint8Array, repairSymbolSize: number): number | null {
-  if (oti.length !== 12 || oti[5] !== 0) return null
-  const transferLength = (oti[0]! * 0x1_0000_0000) +
-    (((oti[1]! << 24) | (oti[2]! << 16) | (oti[3]! << 8) | oti[4]!) >>> 0)
-  const symbolSize = (oti[6]! << 8) | oti[7]!
-  const sourceBlocks = oti[8]!
-  const subBlocks = (oti[9]! << 8) | oti[10]!
-  const alignment = oti[11]!
-  if (!Number.isSafeInteger(transferLength) || transferLength <= 0 ||
-      symbolSize !== repairSymbolSize || symbolSize === 0 || symbolSize % 8 !== 0 ||
-      sourceBlocks !== 1 || subBlocks !== 1 || alignment !== 8 ||
-      transferLength % symbolSize !== 0) {
-    return null
-  }
-  const k = transferLength / symbolSize
-  return Number.isInteger(k) && k >= 1 && k <= RAPTORQ_MAX_SOURCE_SYMBOLS ? k : null
-}
+/** The 12-octet MMTP header plus the 2-octet length of the T - 2 construction (moq-fec-01 Section 7.3). */
+const MIN_REPAIR_SYMBOL_SIZE = 14
+const REED_SOLOMON_MAX_BLOCK = 255
 
 /**
- * Validate one parsed FEC flow against the Blockcast one-stage RaptorQ
- * profile and return its decoder geometry, or null when the flow is outside
- * the profile. Nothing is inferred: K comes from the OTI and must equal
- * maximum_k_for_repair_flow.
+ * Validate one parsed FEC flow against draft-ramadan-moq-mmt-01 Sections 8.3
+ * and 12.2 and return its decoder geometry, or null when the entry is
+ * outside them. Fail closed on everything else:
+ *
+ * - coding byte other than 0x14 (one-stage, ssbg_mode1, ffsrpts_flag 0,
+ *   fec_payload_id_mode 0). 0x15 is fec_payload_id_mode 1 under Amd 1:2025,
+ *   which "iso-ssbg1-v1" does not describe (moq-fec-01 Section 7.3);
+ * - number_of_assets other than 1;
+ * - fec_code_id_for_repair_flow other than 3 or 1, the retired Blockcast
+ *   code 2 included (ISO/IEC 23008-10 Table 1);
+ * - T < 14, K = 0, P = 0, K + P - 1 > 2^24 - 1;
+ * - RaptorQ: T not a multiple of 8, or K > 56403;
+ * - Reed-Solomon: K + P > 255;
+ * - repair_flow_id 0 (the signalling flow) or the flow's own packet_id.
  *
- * The profile is `iso-ssbg1-v1`, whose AL-FEC coding byte is 0x14
- * (draft-ramadan-moq-fec §7.3; ISO/IEC 23008-1 Table C.3 as replaced by
- * Amd 1:2025): one-stage, ssbg_mode1, ffsrpts_flag 0, fec_payload_id_mode 0.
- * 0x15 is accepted too: its low bit is fec_payload_id_mode 1 under Amd
- * 1:2025 but reserved "1" in the unamended 2023 Table C.3, so a 2023 sender
- * of the same profile emits it. No later field depends on the bit, and each
- * source packet's FEC_type says whether it carries a Source FEC Payload ID,
- * so the bit is reported, not interpreted (BLO-35597 N1). Any other coding
- * byte is refused here, though `parseAlFecMessageBody` still reports it:
- * ssbg_mode0 (0x10/0x11, the retired `k-padded-v1` wire) carries no length
- * field; ffsrpts_flag=1 changes the source/repair packet trailer layout.
+ * Checks that span entries (another entry's packet_id, a duplicate
+ * repair_flow_id or Asset) are `alFecMessageFlowConfigs`'.
  */
 export function alFecRaptorQFlowConfig(flow: AlFecFlow): AlFecRaptorQFlowConfig | null {
   if (flow.fecCodingStructure !== FEC_CODING_STRUCTURE_ONE_STAGE || flow.repairFlows.length !== 1) return null
-  if (flow.ssbgMode !== SSBG_MODE_1) return null
-  if (flow.ffsrptsFlag !== 0) return null
+  if (flow.ssbgMode !== SSBG_MODE_1 || flow.ffsrptsFlag !== 0 || flow.fecPayloadIdMode !== 0) return null
+  if (flow.packetIds.length !== 1) return null
   const repair = flow.repairFlows[0]!
-  if (repair.fecCodeId !== FEC_CODE_RAPTORQ) return null
-  const privateField = repair.privateField
-  if (!privateField || privateField.privateFlag !== 1 ||
-      privateField.data.length !== RAPTORQ_PRIVATE_FIELD_LENGTH) {
-    return null
-  }
-  const oti = privateField.data.slice(0, 12)
-  const interleaveDepth = privateField.data[12]!
-  const otiK = canonicalRaptorQOtiK(oti, flow.repairSymbolSize)
-  if (otiK === null || interleaveDepth === 0) return null
-  if (repair.maximumK !== otiK || repair.maximumP === 0 ||
-      repair.maximumK + repair.maximumP - 1 > REPAIR_SYMBOL_ID_MAX) {
+  const { fecCodeId, maximumK: k, maximumP: p } = repair
+  const t = flow.repairSymbolSize
+  if (t < MIN_REPAIR_SYMBOL_SIZE || k < 1 || p < 1 || k + p - 1 > REPAIR_SYMBOL_ID_MAX) return null
+  if (fecCodeId === FEC_CODE_RAPTORQ) {
+    if (t % 8 !== 0 || k > RAPTORQ_MAX_SOURCE_SYMBOLS) return null
+  } else if (fecCodeId === FEC_CODE_REED_SOLOMON) {
+    if (k + p > REED_SOLOMON_MAX_BLOCK) return null
+  } else {
     return null
   }
+  if (repair.repairFlowId === MMTP_SIGNALING_PACKET_ID || repair.repairFlowId === flow.packetIds[0]) return null
   return {
     sourcePacketIds: [...flow.packetIds],
     repairFlowId: repair.repairFlowId,
+    fecCodeId,
     ssbgMode: flow.ssbgMode,
     fecPayloadIdMode: flow.fecPayloadIdMode,
-    repairSymbolSize: flow.repairSymbolSize,
-    maximumK: repair.maximumK,
-    maximumP: repair.maximumP,
-    interleaveDepth,
-    oti,
+    repairSymbolSize: t,
+    maximumK: k,
+    maximumP: p,
     protectionWindowTime: repair.protectionWindowTime,
     protectionWindowSize: repair.protectionWindowSize,
   }
 }
 
+/**
+ * `alFecRaptorQFlowConfig` for every entry of a message, index for index,
+ * plus the draft-ramadan-moq-mmt-01 Section 12.2 checks that span entries: an
+ * entry whose repair_flow_id is another entry's Asset packet_id, and every
+ * entry of two that name one repair_flow_id or list one Asset, is null.
+ */
+export function alFecMessageFlowConfigs(message: AlFecMessageBody): (AlFecRaptorQFlowConfig | null)[] {
+  const assetCount = new Map<number, number>()
+  const repairCount = new Map<number, number>()
+  const bump = (map: Map<number, number>, key: number) => map.set(key, (map.get(key) ?? 0) + 1)
+  for (const flow of message.flows) {
+    for (const id of flow.packetIds) bump(assetCount, id)
+    for (const repair of flow.repairFlows) bump(repairCount, repair.repairFlowId)
+  }
+  return message.flows.map(flow => {
+    const config = alFecRaptorQFlowConfig(flow)
+    if (!config) return null
+    const [asset] = config.sourcePacketIds
+    if (assetCount.get(asset!) !== 1 || repairCount.get(config.repairFlowId) !== 1) return null
+    // Its own packet_id is already refused, so any count here is another entry's.
+    if (assetCount.has(config.repairFlowId)) return null
+    return config
+  })
+}
+
 // ---------------------------------------------------------------------------
 // 10.6 — location, asset_id and identifier mapping
 // ---------------------------------------------------------------------------