@blibliki/engine 0.1.19 → 0.1.20

package/package.json

@@ -1,6 +1,7 @@
 {
   "name": "@blibliki/engine",
-  "version": "0.1.19",
+  "version": "0.1.20",
+  "source": "src/index.ts",
   "main": "dist/main.cjs.js",
   "module": "dist/main.esm.js",
   "types": "dist/build/index.d.ts",
@@ -16,13 +17,6 @@
     "tone": "^14.7.77",
     "uuid": "^8.3.2"
   },
-  "scripts": {
-    "start": "tsc -w -p tsconfig.json",
-    "build": "rollup -c",
-    "lint": "eslint src",
-    "ts:check": "tsc --noEmit",
-    "test": "jest"
-  },
   "devDependencies": {
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-node-resolve": "^15.2.3",
@@ -38,9 +32,15 @@
     "jest": "^29.2.2",
     "prettier": "^2.7.1",
     "rollup": "^4.10.0",
-    "rollup-plugin-dts": "^6.1.0",
     "ts-jest": "^29.0.3",
     "typescript": "^5.2.2",
     "typescript-language-server": "^4.0.0"
+  },
+  "scripts": {
+    "start": "tsc -w -p tsconfig.json",
+    "build": "rollup -c",
+    "lint": "eslint src",
+    "ts:check": "tsc --noEmit",
+    "test": "jest"
   }
-}
+}

package/src/modules/Envelope/Base.ts

@@ -105,7 +105,10 @@ export default abstract class EnvelopeModule<EnvelopeLike extends Env>
   };
 
   triggerRelease = (note: Note, triggeredAt: number) => {
+    if (this.activeNote && this.activeNote !== note.fullName) return;
+
     this.internalModule.triggerRelease(triggeredAt);
+    this.activeNote = undefined;
   };
 
   private maxTime(stage: EnvelopeStages): number {

package/src/modules/MidiSelector.ts

@@ -59,10 +59,10 @@ export default class MidiSelector extends Module<
     if (!this.onMidiEvent || !midiId) return; // Ugly hack because of weird super bug
 
     const midiDevice = Engine.midiDeviceManager.find(midiId);
-    midiDevice?.addEventListener(this.onMidiEvent);
+    midiDevice?.addEventListener(this.forwardMidiEvent);
   }
 
-  private _onMidiEvent = (midiEvent: MidiEvent) => {
+  private forwardMidiEvent = (midiEvent: MidiEvent) => {
     this.midiOutput.onMidiEvent(midiEvent);
   };
 
@@ -70,6 +70,6 @@ export default class MidiSelector extends Module<
     if (!this.selectedId) return;
 
     const midiDevice = Engine.midiDeviceManager.find(this.selectedId);
-    midiDevice?.removeEventListener(this._onMidiEvent);
+    midiDevice?.removeEventListener(this.forwardMidiEvent);
   }
 }

package/src/modules/VirtualMidi.ts

@@ -48,16 +48,18 @@ export default class VirtualMidi extends Module<
     this.midiOutput.onMidiEvent(midiEvent);
   }
 
-  triggerAttack = (note: Note) => {
+  triggerAttack = (note: Note, triggerAttack: number) => {
     this.activeNotes = [...this.activeNotes, note.fullName];
     Engine._triggerPropsUpdate(this.id, this.props);
+    this.sendMidi(MidiEvent.fromNote(note, true, triggerAttack));
   };
 
-  triggerRelease = (note: Note) => {
+  triggerRelease = (note: Note, triggerAttack: number) => {
     this.activeNotes = this.activeNotes.filter(
       (name) => name !== note.fullName
     );
     Engine._triggerPropsUpdate(this.id, this.props);
+    this.sendMidi(MidiEvent.fromNote(note, false, triggerAttack));
   };
 
   serialize() {