@bli-cockpit/cli 0.2.58 → 0.2.60

package/dist/commands/local-args-tower-chat.js

@@ -31,6 +31,10 @@ export function parseJarvisArgs(args) {
             "--trace",
             "--limit",
             "--json",
+            // BLI-3755: opt a `--json` turn back into seeing the coding arm's
+            // approval code. Without it a `--json` turn is an agent surface and the
+            // code is withheld.
+            "--show-approval-code",
         ],
         valueFlags: [
             "--home",
@@ -123,6 +127,7 @@ export function parseJarvisArgs(args) {
         // callers that want the single-body shape on purpose, not a compat knob.
         stream: !values.booleans.has("--no-stream"),
         json: values.booleans.has("--json"),
+        showApprovalCode: values.booleans.has("--show-approval-code"),
     };
 }
 /**

package/dist/commands/local-args-tower-docs-msg.js

@@ -17,12 +17,15 @@ export function parseDocsArgs(args) {
             "--title",
             "--parent",
             "--clear-parent",
+            "--allow-empty",
             "--visibility",
             "--file",
             "--body-stdin",
+            "--query",
+            "--limit",
             "--json",
         ],
-        valueFlags: ["--home", "--dashboard-url", "--title", "--parent", "--visibility", "--file"],
+        valueFlags: ["--home", "--dashboard-url", "--title", "--parent", "--visibility", "--file", "--query", "--limit"],
     });
     const first = values.positionals[0];
     const action = (first === undefined ? "list" : first);
@@ -53,10 +56,30 @@ export function parseDocsArgs(args) {
     if (clearParent && action !== "update") {
         throw new Error("--clear-parent belongs to `cockpit docs update`.");
     }
+    // BLI-3759: the PATCH door refuses a body that empties a document holding
+    // text unless the caller sends `allow_empty: true` (`refused_empty_body`,
+    // 409, BLI-3757). `--allow-empty` is the terminal's way to say it, and it
+    // means nothing on the verbs that never send an existing document a new body.
+    const allowEmpty = values.booleans.has("--allow-empty");
+    if (allowEmpty && action !== "update") {
+        throw new Error("--allow-empty belongs to `cockpit docs update`.");
+    }
     const title = optionalNonEmpty(values.flags.get("--title"));
     if (action === "create" && !title) {
         throw new Error("docs create needs --title.");
     }
+    // BLI-3737: narrowing belongs to `list` only. `--parent` keeps its create/
+    // update meaning elsewhere (which parent to file the document under); on
+    // `list` the same word names which parent to list UNDER, plus the literal
+    // `root` for the top of the tree.
+    const query = optionalNonEmpty(values.flags.get("--query"));
+    if (query && action !== "list") {
+        throw new Error("--query belongs to `cockpit docs list`.");
+    }
+    const limit = optionalPositiveInteger(values.flags.get("--limit"), "--limit");
+    if (limit !== undefined && action !== "list") {
+        throw new Error("--limit belongs to `cockpit docs list`.");
+    }
     return {
         kind: "docs",
         action,
@@ -66,25 +89,96 @@ export function parseDocsArgs(args) {
         title,
         ...(parentId ? { parentId } : {}),
         clearParent,
+        ...(allowEmpty ? { allowEmpty } : {}),
         visibility: visibility,
         filePath: optionalNonEmpty(values.flags.get("--file")),
         bodyStdin: values.booleans.has("--body-stdin"),
+        ...(query ? { query } : {}),
+        ...(limit === undefined ? {} : { limit }),
         json: values.booleans.has("--json"),
     };
 }
-const MSG_ACTIONS = new Set(["channels", "read", "send", "thread"]);
+const MSG_ACTIONS = new Set(["channels", "read", "send", "thread", "create", "dm"]);
 const MSG_ACTIONS_NEEDING_A_CHANNEL = new Set(["read", "send"]);
+/**
+ * `--members a@x.test,b@y.test` — addresses only, split on commas, never
+ * fuzzy (BLI-3749). The door resolves each one exactly, so a typo comes back
+ * as `person_not_found` naming the address rather than as a stranger added
+ * to a private channel.
+ */
+function parseMemberEmails(raw) {
+    const value = optionalNonEmpty(raw);
+    if (!value)
+        return undefined;
+    const emails = value
+        .split(",")
+        .map((part) => part.trim())
+        .filter((part) => part !== "");
+    if (emails.length === 0)
+        throw new Error("msg create --members needs at least one email address.");
+    const notAnAddress = emails.find((email) => !email.includes("@"));
+    if (notAnAddress) {
+        throw new Error(`msg create --members takes email addresses; "${notAnAddress}" is not one.`);
+    }
+    return emails;
+}
 export function parseMsgArgs(args) {
     const values = parseNamedArgs(args, {
-        allowedFlags: ["--home", "--dashboard-url", "--channel", "--thread", "--limit", "--json"],
-        valueFlags: ["--home", "--dashboard-url", "--channel", "--thread", "--limit"],
+        allowedFlags: [
+            "--home",
+            "--dashboard-url",
+            "--channel",
+            "--thread",
+            "--limit",
+            "--private",
+            "--members",
+            "--description",
+            "--json",
+        ],
+        valueFlags: ["--home", "--dashboard-url", "--channel", "--thread", "--limit", "--members", "--description"],
     });
     const first = values.positionals[0];
     const action = (first === undefined ? "channels" : first);
     if (!MSG_ACTIONS.has(action)) {
-        throw new Error(`Unknown msg command: ${first}. Try channels, read, send, or thread.`);
+        throw new Error(`Unknown msg command: ${first}. Try channels, read, send, thread, create, or dm.`);
     }
     const rest = values.positionals.slice(first === undefined ? 0 : 1);
+    let channelName;
+    let dmEmail;
+    if (action === "create") {
+        channelName = optionalNonEmpty(rest[0]);
+        if (!channelName)
+            throw new Error("msg create needs a channel name, e.g. `cockpit msg create general`.");
+        if (rest.length > 1)
+            throw new Error(`msg create takes one channel name, not ${rest.length}.`);
+        // `#general` is how a person says it and how `read`/`send` accept it, so
+        // the leading # is dropped here rather than becoming part of the name.
+        if (channelName.startsWith("#"))
+            channelName = channelName.slice(1);
+        if (channelName === "")
+            throw new Error("msg create needs a channel name, e.g. `cockpit msg create general`.");
+    }
+    else if (action === "dm") {
+        dmEmail = optionalNonEmpty(rest[0]);
+        if (!dmEmail)
+            throw new Error("msg dm needs the person's email address, e.g. `cockpit msg dm ada@example.com`.");
+        if (rest.length > 1)
+            throw new Error(`msg dm takes one email address, not ${rest.length}.`);
+        if (!dmEmail.includes("@"))
+            throw new Error(`msg dm takes an email address; "${dmEmail}" is not one.`);
+    }
+    const isPrivate = values.booleans.has("--private");
+    if (isPrivate && action !== "create") {
+        throw new Error("--private belongs to `cockpit msg create`.");
+    }
+    const memberEmails = parseMemberEmails(values.flags.get("--members"));
+    if (memberEmails && action !== "create") {
+        throw new Error("--members belongs to `cockpit msg create`.");
+    }
+    const description = optionalNonEmpty(values.flags.get("--description"));
+    if (description && action !== "create") {
+        throw new Error("--description belongs to `cockpit msg create`.");
+    }
     let channelRef;
     if (MSG_ACTIONS_NEEDING_A_CHANNEL.has(action)) {
         channelRef = optionalNonEmpty(rest[0]);
@@ -99,7 +193,7 @@ export function parseMsgArgs(args) {
         if (rest.length > 1)
             throw new Error(`msg thread takes one thread id, not ${rest.length}.`);
     }
-    else if (rest.length > 0) {
+    else if (action !== "create" && action !== "dm" && rest.length > 0) {
         throw new Error(`msg ${action} does not take "${rest[0]}".`);
     }
     const threadFlag = optionalNonEmpty(values.flags.get("--thread"));
@@ -119,6 +213,11 @@ export function parseMsgArgs(args) {
         homeDir: optionalNonEmpty(values.flags.get("--home")),
         dashboardUrl: optionalUrl(values.flags.get("--dashboard-url")),
         ...(channelRef ? { channelRef } : {}),
+        ...(channelName ? { channelName } : {}),
+        ...(dmEmail ? { dmEmail } : {}),
+        ...(memberEmails ? { memberEmails } : {}),
+        ...(description ? { description } : {}),
+        isPrivate,
         ...(threadId ? { threadId } : {}),
         ...(limit === undefined ? {} : { limit }),
         json: values.booleans.has("--json"),

package/dist/commands/local-args-tower-search.js

@@ -0,0 +1,50 @@
+/**
+ * `cockpit search` argument parsing (BLI-3728).
+ *
+ * Its own sibling of `local-args-tower.ts` rather than folded into
+ * `local-args-tower-pages.ts` or `-docs-msg.ts`: search is not one surface's
+ * verb, it is the door OVER all of them — documents, messages, issues, meeting
+ * notes and memory — and putting it under any one family's doc comment would
+ * say something untrue about what it reads.
+ *
+ * The query is a POSITIONAL, not a flag, because that is how every search
+ * command a person has ever typed works (`grep`, `rg`, `gh search`). Several
+ * positionals are joined with a space so `cockpit search storage ceiling`
+ * behaves the way it looks, without demanding quotes.
+ */
+import { optionalNonEmpty, optionalPositiveInteger, optionalUrl, parseNamedArgs, } from "./local-arg-values.js";
+/** The five corpora. Kept here so an unknown kind is refused BEFORE a round trip. */
+export const SEARCH_KINDS = ["doc", "msg", "issue", "note", "memory"];
+export function parseSearchArgs(args) {
+    const values = parseNamedArgs(args, {
+        allowedFlags: ["--home", "--dashboard-url", "--kind", "--limit", "--json"],
+        valueFlags: ["--home", "--dashboard-url", "--kind", "--limit"],
+    });
+    const query = values.positionals.join(" ").trim();
+    if (query.length === 0) {
+        throw new Error('search needs something to search for, e.g. `cockpit search "storage ceiling"`.');
+    }
+    const kindFlag = optionalNonEmpty(values.flags.get("--kind"));
+    let kinds;
+    if (kindFlag) {
+        kinds = [];
+        for (const part of kindFlag.split(",").map((entry) => entry.trim()).filter(Boolean)) {
+            if (!SEARCH_KINDS.includes(part)) {
+                throw new Error(`search --kind must be one or more of ${SEARCH_KINDS.join(", ")} — not "${part}".`);
+            }
+            if (!kinds.includes(part))
+                kinds.push(part);
+        }
+        if (kinds.length === 0)
+            kinds = undefined;
+    }
+    return {
+        kind: "search",
+        query,
+        ...(kinds ? { kinds } : {}),
+        limit: optionalPositiveInteger(values.flags.get("--limit"), "--limit"),
+        homeDir: optionalNonEmpty(values.flags.get("--home")),
+        dashboardUrl: optionalUrl(values.flags.get("--dashboard-url")),
+        json: values.booleans.has("--json"),
+    };
+}

package/dist/commands/local-args-tower.js

@@ -20,6 +20,8 @@
  *                                                      channels/messages (BLI-3706)
  *   local-args-tower-work.ts    issue, project     — the issue tracker
  *                                                      (BLI-3716)
+ *   local-args-tower-search.ts   search            — one bar over all five
+ *                                                      corpora (BLI-3728)
  *
  * Every name this module has ever exported is still importable from here.
  */
@@ -27,4 +29,5 @@ export { parseJarvisArgs, parseCorrectArgs } from "./local-args-tower-chat.js";
 export { parseBriefArgs, WORKBOOK_MIN_WIDTH, parseWorkbookArgs, parseNotesArgs, } from "./local-args-tower-pages.js";
 export { SCOUT_MIN_PREFIX_LENGTH, parseScoutArgs, parseOpsArgs, SLACK_WORKSPACE_KEYS, parseSlackArgs, parseSettingsArgs, parseTeamArgs, parseModelArgs, } from "./local-args-tower-admin.js";
 export { parseDocsArgs, parseMsgArgs, } from "./local-args-tower-docs-msg.js";
-export { ISSUE_STATES, parseIssueArgs, parseProjectArgs, } from "./local-args-tower-work.js";
+export { ISSUE_STATES, parseIssueArgs, parseProjectArgs, } from "./local-args-tower-work.js";
+export { SEARCH_KINDS, parseSearchArgs } from "./local-args-tower-search.js";

package/dist/commands/local-args.js

@@ -1,23 +1,32 @@
+/**
+ * What a person may type, and what each subcommand means once typed.
+ *
+ * Two things live here and nothing else: `LocalCommand`, the shape every
+ * command runner is handed, and `parseLocalArgs`, the table that picks which
+ * decision table reads the rest of `argv`. The decision tables themselves are
+ * next door, one file per half of the product (BLI-3578):
+ *
+ *   local-arg-values.ts      argv into named flags, then one question per value
+ *   local-args-collector.ts  the commands that act on THIS machine
+ *   local-args-tower.ts      the commands that talk to Tower
+ *
+ * Split out of commands/local.ts originally so the command runners read as a
+ * table of contents and the parser (pure, independently testable) can change at
+ * its own rate. Behavior-preserving extraction throughout: functions moved
+ * verbatim, no logic change.
+ */
 import { parseAgentRulesArgs, parseAnalyzeArgs, parseAutostartArgs, parseBackfillArgs, parseCleanArgs, parseDoctorArgs, parseInstallArgs, parseLoginArgs, parseMemoryArgs, parseLogoutArgs, parseOnboardArgs, parseReleaseArgs, parseServeArgs, parseSessionsArgs, parseStartArgs, parseStatusArgs, parseSyncArgs, parseUpdateArgs, } from "./local-args-collector.js";
-import { parseBriefArgs, parseCorrectArgs, parseDocsArgs, parseIssueArgs, parseJarvisArgs, parseModelArgs, parseMsgArgs, parseNotesArgs, parseOpsArgs, parseProjectArgs, parseScoutArgs, parseSettingsArgs, parseSlackArgs, parseTeamArgs, parseWorkbookArgs, } from "./local-args-tower.js";
+import { parseBriefArgs, parseCorrectArgs, parseDocsArgs, parseIssueArgs, parseJarvisArgs, parseModelArgs, parseMsgArgs, parseNotesArgs, parseOpsArgs, parseProjectArgs, parseScoutArgs, parseSearchArgs, parseSettingsArgs, parseSlackArgs, parseTeamArgs, parseWorkbookArgs, } from "./local-args-tower.js";
 // `normalizeUrl` has always been part of this module's surface — `local.ts` and
 // `local-auth.ts` import it from here — so it stays exported from this address
 // even though it now lives next door. The same goes for the four names the
 // Tower parsers publish.
 export { normalizeUrl } from "./local-arg-values.js";
+// BLI-3728: the command SHAPES moved to a sibling when this file crossed the
+// 700-line ceiling. Re-exported here because ~40 modules and every sibling
+// parser import them from this path.
+export { DOCTOR_SETUP_ALIASES, } from "./local-command-shapes.js";
 export { SCOUT_MIN_PREFIX_LENGTH, SLACK_WORKSPACE_KEYS, WORKBOOK_MIN_WIDTH, ISSUE_STATES, } from "./local-args-tower.js";
-// The six human "set my machine up" doors. They are one thing wearing six
-// hats, so they all run the convergence command — but they keep accepting the
-// flags they always accepted, because DMs, runbooks and AGENTS.md rules across
-// the fleet still spell them out.
-export const DOCTOR_SETUP_ALIASES = [
-    "install",
-    "onboard",
-    "login",
-    "pair",
-    "update",
-    "upgrade",
-];
 export function parseLocalArgs(argv) {
     const command = argv[0];
     switch (command) {
@@ -32,6 +41,10 @@ export function parseLocalArgs(argv) {
         // Aliasing lands once the convergence run honours --ticket. See BLI-2494.
         case "do-everything":
         case "fix":
+        // BLI-3768: `doctor` is what the ops board's RED rows, the setup receipt
+        // and the heartbeat all tell a person to run. It routes here exactly like
+        // `fix` — the check table diagnoses, then converges.
+        case "doctor":
             return parseDoctorArgs(command, argv.slice(1));
         case "install":
             return parseInstallArgs(argv.slice(1));
@@ -92,6 +105,8 @@ export function parseLocalArgs(argv) {
             return parseIssueArgs(argv.slice(1));
         case "project":
             return parseProjectArgs(argv.slice(1));
+        case "search":
+            return parseSearchArgs(argv.slice(1));
         case "release":
             return parseReleaseArgs(argv.slice(1));
         default:

package/dist/commands/local-command-shapes.js

@@ -0,0 +1,12 @@
+// The six human "set my machine up" doors. They are one thing wearing six
+// hats, so they all run the convergence command — but they keep accepting the
+// flags they always accepted, because DMs, runbooks and AGENTS.md rules across
+// the fleet still spell them out.
+export const DOCTOR_SETUP_ALIASES = [
+    "install",
+    "onboard",
+    "login",
+    "pair",
+    "update",
+    "upgrade",
+];