@bli-cockpit/cli 0.2.39 → 0.2.40

package/dist/commands/cli-io.js

@@ -20,7 +20,39 @@ export function writeExecOutput(io, result, options) {
         writeRaw(io.stderr, result.stderr);
 }
 export function isInteractiveStdin(io) {
-    return Boolean(io.stdin.isTTY);
+    const isTTY = io.stdin.isTTY;
+    // Git Bash (mintty/MSYS) gives Node a pipe for an interactive terminal, so
+    // `isTTY` is undefined and the piped branch would wait forever on an EOF
+    // that never comes (BLI-3480). MSYSTEM is set only inside MSYS shells, so
+    // launchd / Task Scheduler / spawned runs keep the non-interactive branch.
+    if (isTTY === undefined && process.env["MSYSTEM"])
+        return true;
+    return Boolean(isTTY);
+}
+/**
+ * Drops one leading U+FEFF. PowerShell 5.1 redirection and Notepad both write
+ * byte-order marks; stored verbatim, a BOM makes the first line of an env blob
+ * unreachable and pollutes pasted notes (BLI-3480). One strip, never more —
+ * a BOM anywhere else is content.
+ */
+export function stripLeadingBom(text) {
+    return text.charCodeAt(0) === 0xfeff ? text.slice(1) : text;
+}
+/**
+ * Reads piped stdin whole as UTF-8, BOM-stripped. The one implementation
+ * behind every stdin-fed command (jarvis, correct, notes paste, settings env
+ * set) — each caller keeps its own size cap via `maxChars`.
+ */
+export async function readPipedText(stream, options) {
+    stream.setEncoding("utf8");
+    let text = "";
+    for await (const chunk of stream) {
+        text += chunk;
+        if (options?.maxChars !== undefined && text.length > options.maxChars) {
+            throw new Error(options.overflowMessage ?? `Piped input is limited to ${options.maxChars} characters.`);
+        }
+    }
+    return stripLeadingBom(text);
 }
 /**
  * Reads one line from stdin after writing a prompt. Shared by the onboard email

package/dist/commands/correct.js

@@ -23,7 +23,7 @@
  * is printed on stdout with an exit code of 0 — the correction WAS filed, with
  * its outcome recorded. Only a failure to file at all is a non-zero exit.
  */
-import { isInteractiveStdin, writeLine } from "./cli-io.js";
+import { isInteractiveStdin, readPipedText, writeLine } from "./cli-io.js";
 import { loadPairedSession, towerJsonRequest } from "../tower-client.js";
 const DIM = "\x1b[2m";
 const RESET = "\x1b[0m";
@@ -134,21 +134,10 @@ async function resolveText(command, io) {
         return command.text;
     if (isInteractiveStdin(io))
         return null;
-    const piped = await readAll(io.stdin);
+    const piped = await readPipedText(io.stdin, { maxChars: MAX_CORRECTION_LENGTH, overflowMessage: `A correction is limited to ${MAX_CORRECTION_LENGTH} characters.` });
     const trimmed = piped.trim();
     return trimmed.length > 0 ? trimmed : null;
 }
-async function readAll(stream) {
-    stream.setEncoding("utf8");
-    let text = "";
-    for await (const chunk of stream) {
-        text += chunk;
-        if (text.length > MAX_CORRECTION_LENGTH) {
-            throw new Error(`A correction is limited to ${MAX_CORRECTION_LENGTH} characters.`);
-        }
-    }
-    return text;
-}
 function writeFailure(command, io, reason, detail) {
     if (command.json) {
         writeLine(io.stdout, JSON.stringify({ ok: false, error: reason, detail }));

package/dist/commands/jarvis.js

@@ -5,7 +5,7 @@
  * existing paired device session, and every turn is executed by the dashboard
  * through the same JARVIS runtime used by web chat and Slack.
  */
-import { isInteractiveStdin, readLine, writeLine } from "./cli-io.js";
+import { isInteractiveStdin, readLine, readPipedText, writeLine } from "./cli-io.js";
 import { attachedFileRefusalSentence, readAttachedImage, } from "./jarvis-attachment.js";
 import { loadPairedSession, towerFailureDetail, towerJsonRequest, towerRequest, } from "../tower-client.js";
 import { readTowerTurn, streamFailureDetail, } from "../tower-stream.js";
@@ -136,7 +136,7 @@ async function resolveOneShotPrompt(command, io) {
         return validatePrompt(command.prompt);
     if (isInteractiveStdin(io))
         return null;
-    const piped = await readAll(io.stdin);
+    const piped = await readPipedText(io.stdin, { maxChars: 4000, overflowMessage: "JARVIS questions are limited to 4000 characters." });
     return validatePrompt(piped);
 }
 async function sendOneTurn(context, prompt, io) {
@@ -368,15 +368,4 @@ function validatePrompt(raw) {
         throw new Error("JARVIS questions are limited to 4000 characters.");
     }
     return prompt;
-}
-async function readAll(stream) {
-    stream.setEncoding("utf8");
-    let text = "";
-    for await (const chunk of stream) {
-        text += chunk;
-        if (text.length > 4000) {
-            throw new Error("JARVIS questions are limited to 4000 characters.");
-        }
-    }
-    return text;
 }

package/dist/commands/local-help.js

@@ -348,7 +348,7 @@ function localSubcommandHelp(command) {
                 "shelf [--limit <n>] — the notes YOU have put in, and what became of each.",
                 "shelves — the shelves in use, with how many notes are on each.",
                 "upload <paths...> [--exclude \"<sentence>\"] — put one or more local files in. Explicit paths only; your shell does any globbing, and a file that does not exist is named rather than skipped.",
-                "paste [--file <path>] [--name <n>] [--exclude \"<sentence>\"] — put text in with no file. Defaults to stdin: `pbpaste | cockpit notes paste` on macOS, `Get-Clipboard | cockpit notes paste` on Windows.",
+                "paste [--file <path>] [--name <n>] [--exclude \"<sentence>\"] — put text in. --file <path> is safest (any editor encoding is decoded). Stdin works too: `pbpaste | cockpit notes paste` on macOS; on Windows use PowerShell 7 (`Get-Clipboard | cockpit notes paste`) — PowerShell 5.1 turns non-ASCII into `?` on pipes.",
                 "--exclude carries your own sentence about what to leave out, exactly as the browser's box does.",
                 "share <id> [--yes] — let everyone signed in read the statements that are safe to share. Asks first in a terminal; --yes is required without one, and --json implies --yes.",
                 "unshare <id> — take it back. Never asks: it only ever narrows who can read.",

package/dist/commands/notes-file.js

@@ -99,4 +99,31 @@ export async function readNoteFile(filePath) {
         return { ok: false, refusal: "file_unreadable", detail: errorMessage(error) };
     }
     return { ok: true, bytes, fileName, extension: extension || "none" };
+}
+/**
+ * Decodes note/env bytes to text the way an editor would, not the way UTF-8
+ * hopes (BLI-3480). PowerShell 5.1 redirection writes UTF-16LE with a BOM and
+ * Notepad's "Unicode" save does the same; decoded blindly as UTF-8 that text
+ * becomes NUL-interleaved mojibake that passes an emptiness check and stores
+ * silently. The BOM decides the codec; a BOM-less file that still decodes to
+ * NULs is refused by name rather than stored as garbage.
+ */
+export function decodeTextBytes(bytes) {
+    let text;
+    if (bytes.length >= 2 && bytes[0] === 0xff && bytes[1] === 0xfe) {
+        text = bytes.subarray(2).toString("utf16le");
+    }
+    else if (bytes.length >= 2 && bytes[0] === 0xfe && bytes[1] === 0xff) {
+        text = new TextDecoder("utf-16be").decode(bytes.subarray(2));
+    }
+    else if (bytes.length >= 3 && bytes[0] === 0xef && bytes[1] === 0xbb && bytes[2] === 0xbf) {
+        text = bytes.subarray(3).toString("utf8");
+    }
+    else {
+        text = bytes.toString("utf8");
+    }
+    if (text.includes("\u0000")) {
+        return { ok: false, reason: "undecodable_text_encoding" };
+    }
+    return { ok: true, text };
 }

package/dist/commands/notes.js

@@ -23,8 +23,8 @@
  *    run has nobody to ask and asking it to guess is worse than the flag it
  *    already typed the command for.
  */
-import { isInteractiveStdin, readLine, writeLine, yesByDefault } from "./cli-io.js";
-import { NOTE_SLOW_UPLOAD_BYTES, noteFileRefusalSentence, readNoteFile, } from "./notes-file.js";
+import { isInteractiveStdin, readLine, readPipedText, writeLine, yesByDefault } from "./cli-io.js";
+import { NOTE_SLOW_UPLOAD_BYTES, decodeTextBytes, noteFileRefusalSentence, readNoteFile, } from "./notes-file.js";
 import { loadPairedSession, towerFailureDetail, towerRequest, } from "../tower-client.js";
 import { readResponseJson } from "../upload-http.js";
 /**
@@ -261,15 +261,24 @@ async function pasteNote(command, door) {
             writeLine(door.io.stderr, `${TAG} file refused ${JSON.stringify({ reason: read.refusal, detail: read.detail })}`);
             return fail(door, read.refusal, sentence);
         }
-        text = read.bytes.toString("utf8");
+        const decoded = decodeTextBytes(read.bytes);
+        if (!decoded.ok) {
+            writeLine(door.io.stderr, `${TAG} file refused ${JSON.stringify({ reason: decoded.reason })}`);
+            return fail(door, decoded.reason, "That file is not text this command can decode (it may be a binary or an unusual encoding). Nothing was sent.");
+        }
+        text = decoded.text;
     }
     else {
         if (isInteractiveStdin(door.io)) {
-            return fail(door, "nothing_piped", "Pipe the note in (`pbpaste | cockpit notes paste` on macOS, "
-                + "`Get-Clipboard | cockpit notes paste` on Windows) or pass --file <path>.");
+            return fail(door, "nothing_piped", "Pass --file <path> (safest on Windows), or pipe the note in "
+                + "(`pbpaste | cockpit notes paste` on macOS; on Windows use PowerShell 7 — "
+                + "Windows PowerShell 5.1 turns non-ASCII into `?` on pipes).");
         }
         try {
-            text = await readAll(door.io.stdin);
+            text = await readPipedText(door.io.stdin, {
+                maxChars: PASTE_MAX_CHARS,
+                overflowMessage: `A pasted note is limited to ${PASTE_MAX_CHARS} characters. Save it to a file and use --file instead.`,
+            });
         }
         catch (error) {
             return fail(door, "paste_too_long", errorText(error));
@@ -474,17 +483,6 @@ function sayScope(door, body) {
     writeLine(door.io.stderr, `${TAG} narrowed ${JSON.stringify({ scope: body.scope ?? null, reason: body.degradedBecause })}`);
     writeLine(door.io.stderr, body.degradedNote ?? "This answer is narrower than the browser's.");
 }
-async function readAll(stream) {
-    stream.setEncoding("utf8");
-    let text = "";
-    for await (const chunk of stream) {
-        text += chunk;
-        if (text.length > PASTE_MAX_CHARS) {
-            throw new Error(`A pasted note is limited to ${PASTE_MAX_CHARS} characters. Save it to a file and use --file instead.`);
-        }
-    }
-    return text;
-}
 function errorText(error) {
     return error instanceof Error ? error.message : String(error);
 }

package/dist/commands/public-root.js

@@ -15,7 +15,7 @@ export async function runCockpitCli(argv, io) {
   }
 
   if (command === "--version" || command === "-V" || command === "version") {
-    writeLine(io?.stdout ?? process.stdout, "0.2.39");
+    writeLine(io?.stdout ?? process.stdout, "0.2.40");
     return 0;
   }
 

package/dist/commands/settings.js

@@ -239,8 +239,9 @@ async function setEnvBlob(command, tower, io) {
         const failure = {
             reason: "content_not_piped",
             detail: "settings env set reads the file from stdin. Pipe it in: " +
-                "`cat <path> | cockpit settings env set --project <project> --file <name> --content-stdin` " +
-                "(PowerShell: `Get-Content <path> -Raw | cockpit settings env set …`).",
+                "`cat <path> | cockpit settings env set --project <project> --file <name> --content-stdin`. " +
+                "On Windows use PowerShell 7 (`pwsh`): `Get-Content <path> -Raw | cockpit settings env set …` — " +
+                "Windows PowerShell 5.1 turns non-ASCII into `?` on pipes.",
         };
         return writeCommandFailure(io, command.json, failure);
     }

package/dist/commands/tower-command.js

@@ -17,7 +17,7 @@
  * - **stdout belongs to `--json`.** Every operational line goes to stderr, which
  *   launchd captures; a `--json` run puts exactly one object on stdout.
  */
-import { writeLine } from "./cli-io.js";
+import { readPipedText, writeLine } from "./cli-io.js";
 import { loadPairedSession, towerFailureDetail, towerJsonRequest, } from "../tower-client.js";
 /** Client-side ceiling. These routes are small reads and writes, not turns. */
 const REQUEST_DEADLINE_MS = 30_000;
@@ -101,12 +101,11 @@ export function parseModelKey(key) {
     }
     return { provider: key.slice(0, separator), model: key.slice(separator + 1) };
 }
-/** Reads piped stdin whole. Used only for env content, which is never echoed. */
+/**
+ * Reads piped stdin whole, BOM-stripped (BLI-3480 — PowerShell redirection
+ * writes one, and stored verbatim it makes the first env line unreachable).
+ * Used only for env content, which is never echoed.
+ */
 export async function readAllStdin(stream) {
-    stream.setEncoding("utf8");
-    let text = "";
-    for await (const chunk of stream) {
-        text += chunk;
-    }
-    return text;
+    return readPipedText(stream);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bli-cockpit/cli",
-  "version": "0.2.39",
+  "version": "0.2.40",
   "private": false,
   "type": "module",
   "bin": {