@bli-cockpit/cli 0.2.241 → 0.2.243

package/dist/notifier.js

@@ -0,0 +1,83 @@
+/**
+ * The one place the collector paints an OS banner (BLI-21564, calendar slice 11).
+ *
+ * macOS goes through `osascript -e 'display notification ...'`, Windows through
+ * a PowerShell toast on PowerShell's own app id. Both are spawned through
+ * `process-runner.ts` with an ARRAY of arguments (never a shell line), and every
+ * string a person or a calendar can influence is escaped (AppleScript) or passed
+ * by environment variable (PowerShell), so a meeting title cannot become code.
+ *
+ * The result is always one of three named outcomes. A banner the OS refused is
+ * `permission_denied`; a helper that failed any other way is `notifier_failed`
+ * with its exit code; nothing here is silent. `osascript` exits 0 when the user
+ * switched notifications off for it, so a silent denial is not detectable: a
+ * desktop receipt, not this module, is the proof a banner appeared.
+ */
+import { createCapturedExecRunner } from "./process-runner.js";
+const NOTIFIER_TIMEOUT_MS = 15_000;
+const MAX_TEXT = 200;
+const DENIAL = /not allowed|not authorized|not permitted|access.*denied|notifications? (?:are |is )?(?:disabled|blocked|turned off)|\(-1743\)|\(-1744\)|blocked by/i;
+/** Controls become spaces and the length is bounded; the text is a banner, not a document. */
+function plain(value) {
+    // eslint-disable-next-line no-control-regex
+    return value.replace(/[\u0000-\u001f\u007f]+/g, " ").trim().slice(0, MAX_TEXT);
+}
+/** An AppleScript string literal body: backslash and double quote are the only escapes it needs. */
+export function appleScriptEscape(value) {
+    return plain(value).replace(/\\/g, "\\\\").replace(/"/g, '\\"');
+}
+export function macNotifyArgs(request) {
+    const sound = request.sound ? ' sound name "Glass"' : "";
+    return ["-e", `display notification "${appleScriptEscape(request.message)}" with title "${appleScriptEscape(request.title)}"${sound}`];
+}
+/** The toast script reads its text from the environment, so no title can reach the script body. */
+export const WINDOWS_TOAST_SCRIPT = [
+    "$ErrorActionPreference = 'Stop'",
+    "[Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime] | Out-Null",
+    "[Windows.Data.Xml.Dom.XmlDocument, Windows.Data.Xml.Dom.XmlDocument, ContentType = WindowsRuntime] | Out-Null",
+    "$title = [System.Security.SecurityElement]::Escape($env:TOWER_TOAST_TITLE)",
+    "$message = [System.Security.SecurityElement]::Escape($env:TOWER_TOAST_MESSAGE)",
+    "$audio = if ($env:TOWER_TOAST_SOUND -eq '1') { '' } else { '<audio silent=\"true\"/>' }",
+    "$xml = New-Object Windows.Data.Xml.Dom.XmlDocument",
+    "$xml.LoadXml('<toast><visual><binding template=\"ToastText02\"><text id=\"1\">' + $title + '</text><text id=\"2\">' + $message + '</text></binding></visual>' + $audio + '</toast>')",
+    "$toast = New-Object Windows.UI.Notifications.ToastNotification $xml",
+    "$appId = '{1AC14E77-02E7-4E5D-B744-2EB1AE5198B7}\\WindowsPowerShell\\v1.0\\powershell.exe'",
+    "[Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier($appId).Show($toast)",
+].join("\n");
+export function windowsNotifyArgs() {
+    const encoded = Buffer.from(WINDOWS_TOAST_SCRIPT, "utf16le").toString("base64");
+    return ["-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-EncodedCommand", encoded];
+}
+export async function showNotification(request, options = {}) {
+    const platform = options.platform ?? process.platform;
+    const exec = options.exec ?? createCapturedExecRunner({ platform });
+    let command;
+    let args;
+    let env;
+    if (platform === "darwin") {
+        command = "osascript";
+        args = macNotifyArgs(request);
+    }
+    else if (platform === "win32") {
+        command = "powershell.exe";
+        args = windowsNotifyArgs();
+        env = { ...(options.env ?? process.env), TOWER_TOAST_TITLE: plain(request.title), TOWER_TOAST_MESSAGE: plain(request.message), TOWER_TOAST_SOUND: request.sound ? "1" : "0" };
+    }
+    else {
+        const reason = `no_notifier_for_${platform}`;
+        console.error("[notifier] not shown", JSON.stringify({ outcome: "notifier_failed", reason }));
+        return { outcome: "notifier_failed", reason };
+    }
+    const result = await exec(command, args, { timeoutMs: NOTIFIER_TIMEOUT_MS, ...(env ? { env } : {}) });
+    if (result.code === 0) {
+        console.error("[notifier] shown", JSON.stringify({ outcome: "shown", platform }));
+        return { outcome: "shown", reason: null };
+    }
+    if (DENIAL.test(`${result.stderr}\n${result.stdout}`)) {
+        console.error("[notifier] not shown", JSON.stringify({ outcome: "permission_denied", platform, exit: result.code }));
+        return { outcome: "permission_denied", reason: `os_refused_exit_${result.code}` };
+    }
+    const reason = result.code === 124 ? "timed_out" : `exit_${result.code}`;
+    console.error("[notifier] not shown", JSON.stringify({ outcome: "notifier_failed", platform, exit: result.code }));
+    return { outcome: "notifier_failed", reason };
+}

package/dist/process-runner.js

@@ -35,6 +35,7 @@ export function createCapturedExecRunner(options = {}) {
             encoding: "utf8",
             env,
             windowsVerbatimArguments: invocation.windowsVerbatimArguments,
+            windowsHide: true,
             ...(runOptions?.timeoutMs ? { timeout: runOptions.timeoutMs } : {}),
         }, (error, stdout, stderr) => {
             const code = capturedExitCode(error, runOptions?.timeoutMs);
@@ -86,6 +87,9 @@ export function createInteractiveExecRunner(options = {}) {
             stdio,
             env,
             windowsVerbatimArguments: invocation.windowsVerbatimArguments,
+            // Ticket 21952: a scheduled sync has no console, so a child without this opens a visible window on Windows.
+            // With a console (a person typing `cockpit doctor`) the child shares it and the flag changes nothing.
+            windowsHide: true,
         });
         let settled = false;
         child.on("error", (error) => {

package/dist/repo-identity-git.js

@@ -14,6 +14,7 @@ export async function runGit(args, cwd) {
     const { stdout } = await execFileAsync("git", args, {
         cwd,
         timeout: 2_000,
+        windowsHide: true,
         maxBuffer: 1024 * 1024,
     });
     return stdout;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bli-cockpit/cli",
-  "version": "0.2.241",
+  "version": "0.2.243",
   "private": false,
   "type": "module",
   "bin": {
@@ -27,9 +27,9 @@
     "test": "node dist/cli.js --help && node ../../scripts/assert-public-cli-routing.mjs && node ../../scripts/assert-public-cli-verb-help.mjs && node ../../scripts/assert-public-cli-surface-doors.mjs && node ../../scripts/assert-public-cli-runtime-files.mjs && node ../../scripts/assert-public-cli-exit-contract.mjs && node ../../scripts/assert-public-cli-no-fleet-posts.mjs && node ../../scripts/assert-public-cli-doctor-json.mjs && node ../../scripts/assert-public-package-pack.mjs --workspace=@bli-cockpit/cli"
   },
   "dependencies": {
-    "@bli-cockpit/memory-mcp": "0.1.70",
-    "@bli-cockpit/mcp": "0.1.146",
-    "@bli-cockpit/telemetry-core": "0.1.77"
+    "@bli-cockpit/memory-mcp": "0.1.71",
+    "@bli-cockpit/mcp": "0.1.148",
+    "@bli-cockpit/telemetry-core": "0.1.78"
   },
   "repository": {
     "type": "git",