@bli-cockpit/cli 0.2.237 → 0.2.238

package/dist/commands/local-args-collector-setup.js

@@ -13,46 +13,45 @@
  */
 import { DEFAULT_DASHBOARD_URL } from "../local-state.js";
 import { assertNoPositionals, normalizeUrl, optionalEmail, optionalNonEmpty, optionalNonEmptyList, optionalPositiveInteger, optionalUrl, parseNamedArgs, workRootFlagValue, workRootFlagValues, } from "./local-arg-values.js";
+const ONBOARD_ALLOWED_FLAGS = [
+    "--home",
+    "--repo",
+    "--workspace",
+    "--dashboard-url",
+    "--email",
+    "--device-name",
+    "--ticket",
+    "--branch",
+    "--json",
+    "--no-auth",
+    "--poll-interval-ms",
+    "--timeout-ms",
+    "--max-depth",
+    "--max-repos",
+    "--allow-home-root",
+    // BLI-3731, the one-sign-in ceremony. Same three flags as `login`, so a
+    // person who learned them on one door does not relearn them on another.
+    "--pair",
+    "--no-browser",
+    "--legacy-pair",
+];
+const ONBOARD_VALUE_FLAGS = [
+    "--home",
+    "--repo",
+    "--workspace",
+    "--dashboard-url",
+    "--email",
+    "--device-name",
+    "--ticket",
+    "--branch",
+    "--poll-interval-ms",
+    "--timeout-ms",
+    "--max-depth",
+    "--max-repos",
+    "--pair",
+];
 function parseOnboardLikeArgs(args, command) {
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--repo",
-            "--workspace",
-            "--dashboard-url",
-            "--email",
-            "--device-name",
-            "--ticket",
-            "--branch",
-            "--json",
-            "--no-auth",
-            "--poll-interval-ms",
-            "--timeout-ms",
-            "--max-depth",
-            "--max-repos",
-            "--allow-home-root",
-            // BLI-3731, the one-sign-in ceremony. Same three flags as `login`, so a
-            // person who learned them on one door does not relearn them on another.
-            "--pair",
-            "--no-browser",
-            "--legacy-pair",
-        ],
-        valueFlags: [
-            "--home",
-            "--repo",
-            "--workspace",
-            "--dashboard-url",
-            "--email",
-            "--device-name",
-            "--ticket",
-            "--branch",
-            "--poll-interval-ms",
-            "--timeout-ms",
-            "--max-depth",
-            "--max-repos",
-            "--pair",
-        ],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: ONBOARD_ALLOWED_FLAGS, valueFlags: ONBOARD_VALUE_FLAGS });
     assertNoPositionals(values.positionals, command);
     return {
         homeDir: optionalNonEmpty(values.flags.get("--home")),
@@ -86,55 +85,54 @@ export function parseUpdateArgs(alias, args) {
         ...parseOnboardLikeArgs(args, alias),
     };
 }
+const DOCTOR_ALLOWED_FLAGS = [
+    "--home",
+    "--repo",
+    "--workspace",
+    "--dashboard-url",
+    "--update-tag",
+    "--dry-run",
+    "--check",
+    "--no-repair",
+    "--no-usage-telemetry",
+    "--lock-wait",
+    "--backfill-budget",
+    "--json",
+    "--allow-home-root",
+    "--max-depth",
+    "--max-repos",
+    // Accepted and ignored: the convergence run works these out itself.
+    // Rejecting them would break existing DMs and runbooks for no gain.
+    "--email",
+    "--device-name",
+    "--ticket",
+    "--branch",
+    "--no-auth",
+    "--poll-interval-ms",
+    "--timeout-ms",
+];
+const DOCTOR_VALUE_FLAGS = [
+    "--lock-wait",
+    "--backfill-budget",
+    "--home",
+    "--repo",
+    "--workspace",
+    "--dashboard-url",
+    "--update-tag",
+    "--max-depth",
+    "--max-repos",
+    "--email",
+    "--device-name",
+    "--ticket",
+    "--branch",
+    "--poll-interval-ms",
+    "--timeout-ms",
+];
 export function parseDoctorArgs(alias, args) {
     // The allowed set is the UNION of what the six setup doors used to accept.
     // An alias that silently rejected a flag its own docs told people to pass
     // would be a worse dead end than the one we are removing.
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--repo",
-            "--workspace",
-            "--dashboard-url",
-            "--update-tag",
-            "--dry-run",
-            "--check",
-            "--no-repair",
-            "--no-usage-telemetry",
-            "--lock-wait",
-            "--backfill-budget",
-            "--json",
-            "--allow-home-root",
-            "--max-depth",
-            "--max-repos",
-            // Accepted and ignored: the convergence run works these out itself.
-            // Rejecting them would break existing DMs and runbooks for no gain.
-            "--email",
-            "--device-name",
-            "--ticket",
-            "--branch",
-            "--no-auth",
-            "--poll-interval-ms",
-            "--timeout-ms",
-        ],
-        valueFlags: [
-            "--lock-wait",
-            "--backfill-budget",
-            "--home",
-            "--repo",
-            "--workspace",
-            "--dashboard-url",
-            "--update-tag",
-            "--max-depth",
-            "--max-repos",
-            "--email",
-            "--device-name",
-            "--ticket",
-            "--branch",
-            "--poll-interval-ms",
-            "--timeout-ms",
-        ],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: DOCTOR_ALLOWED_FLAGS, valueFlags: DOCTOR_VALUE_FLAGS });
     assertNoPositionals(values.positionals, alias);
     const updateTag = optionalNonEmpty(values.flags.get("--update-tag"));
     if (updateTag && !/^[a-z0-9][a-z0-9._-]*$/u.test(updateTag)) {

package/dist/commands/local-args-collector-work.js

@@ -9,45 +9,44 @@
  */
 import { IntentSourceSchema, WorkIntentSchema, WorkPhaseSchema, } from "@bli-cockpit/telemetry-core";
 import { assertNoPositionals, optionalConfidence, optionalNonEmpty, optionalNonNegativeInteger, optionalPositiveInteger, optionalSchemaValue, optionalUrl, parseNamedArgs, workRootFlagValue, } from "./local-arg-values.js";
+const START_ALLOWED_FLAGS = [
+    "--home",
+    "--repo",
+    "--workspace",
+    "--branch",
+    "--ticket",
+    "--clear-ticket",
+    "--topic",
+    "--topic-summary",
+    "--intent",
+    "--phase",
+    "--intent-source",
+    "--intent-confidence",
+    "--operator-id",
+    "--session-id",
+    "--json",
+    "--max-depth",
+    "--max-repos",
+];
+const START_VALUE_FLAGS = [
+    "--home",
+    "--repo",
+    "--workspace",
+    "--branch",
+    "--ticket",
+    "--topic",
+    "--topic-summary",
+    "--intent",
+    "--phase",
+    "--intent-source",
+    "--intent-confidence",
+    "--operator-id",
+    "--session-id",
+    "--max-depth",
+    "--max-repos",
+];
 export function parseStartArgs(args) {
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--repo",
-            "--workspace",
-            "--branch",
-            "--ticket",
-            "--clear-ticket",
-            "--topic",
-            "--topic-summary",
-            "--intent",
-            "--phase",
-            "--intent-source",
-            "--intent-confidence",
-            "--operator-id",
-            "--session-id",
-            "--json",
-            "--max-depth",
-            "--max-repos",
-        ],
-        valueFlags: [
-            "--home",
-            "--repo",
-            "--workspace",
-            "--branch",
-            "--ticket",
-            "--topic",
-            "--topic-summary",
-            "--intent",
-            "--phase",
-            "--intent-source",
-            "--intent-confidence",
-            "--operator-id",
-            "--session-id",
-            "--max-depth",
-            "--max-repos",
-        ],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: START_ALLOWED_FLAGS, valueFlags: START_VALUE_FLAGS });
     assertNoPositionals(values.positionals, "start");
     const activeTicketId = optionalNonEmpty(values.flags.get("--ticket"));
     const clearTicket = values.booleans.has("--clear-ticket");

package/dist/commands/local-args-tower-admin.js

@@ -65,6 +65,27 @@ export function parseScoutArgs(args) {
     }
     return { kind: "scout", action: rawAction, experimentRef, ...base };
 }
+const OPS_ALLOWED_FLAGS = [
+    "--home",
+    "--dashboard-url",
+    "--job",
+    "--skips",
+    "--memory",
+    "--memory-days",
+    // BLI-3798: the coverage half on its own, with the bucket table.
+    "--coverage",
+    // BLI-3912: one line per model — latency, tokens/s, today's spend, last
+    // probe verdict. A SECOND door like --memory, asked for only when named.
+    "--models",
+    "--turns",
+    "--tool-router",
+    // BLI-12507: the MCP's `people: true`. Per-device and per-person rows in --json.
+    "--people",
+    "--person",
+    "--dry-run",
+    "--json",
+];
+const OPS_VALUE_FLAGS = ["--home", "--dashboard-url", "--job", "--person", "--memory-days"];
 /**
  * `cockpit ops status [--job <id>] [--skips] [--memory [--memory-days N]]` and
  * `cockpit ops recompile --person <p> [--dry-run]` (BLI-3462).
@@ -76,29 +97,7 @@ export function parseScoutArgs(args) {
  * weekly or a monthly with the compile script, which does support it.
  */
 export function parseOpsArgs(args) {
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--dashboard-url",
-            "--job",
-            "--skips",
-            "--memory",
-            "--memory-days",
-            // BLI-3798: the coverage half on its own, with the bucket table.
-            "--coverage",
-            // BLI-3912: one line per model — latency, tokens/s, today's spend, last
-            // probe verdict. A SECOND door like --memory, asked for only when named.
-            "--models",
-            "--turns",
-            "--tool-router",
-            // BLI-12507: the MCP's `people: true`. Per-device and per-person rows in --json.
-            "--people",
-            "--person",
-            "--dry-run",
-            "--json",
-        ],
-        valueFlags: ["--home", "--dashboard-url", "--job", "--person", "--memory-days"],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: OPS_ALLOWED_FLAGS, valueFlags: OPS_VALUE_FLAGS });
     if (values.positionals.length > 1) {
         throw new Error("ops accepts one action: status or recompile.");
     }
@@ -111,36 +110,39 @@ export function parseOpsArgs(args) {
         dashboardUrl: optionalUrl(values.flags.get("--dashboard-url")),
         json: values.booleans.has("--json"),
     };
-    if (rawAction === "status") {
-        // BLI-3729: `--memory-days N` implies `--memory`, because asking for a
-        // window and getting nothing back is the silent breakage BLI-2490 forbids.
-        const memoryDays = optionalNonEmpty(values.flags.get("--memory-days"));
-        if (memoryDays !== undefined && !/^[0-9]{1,2}$/u.test(memoryDays)) {
-            throw new Error("ops --memory-days takes a whole number of days, 1 to 30.");
-        }
-        const coverageOnly = values.booleans.has("--coverage");
-        const job = optionalNonEmpty(values.flags.get("--job"));
-        if (coverageOnly && job !== undefined && job !== "collection-coverage") {
-            // Refused rather than silently preferring one: `--coverage --job
-            // daily-brief` is somebody asking two different questions in one
-            // command, and answering the wrong one is how a board loses trust.
-            throw new Error("ops --coverage IS --job collection-coverage. Pass one or the other, not a --job naming a different pipeline.");
-        }
-        return {
-            kind: "ops",
-            action: "status",
-            job: coverageOnly ? "collection-coverage" : job,
-            coverage: coverageOnly,
-            skips: values.booleans.has("--skips"),
-            memory: values.booleans.has("--memory") || memoryDays !== undefined,
-            models: values.booleans.has("--models"),
-            turns: values.booleans.has("--turns"),
-            toolRouter: values.booleans.has("--tool-router"),
-            people: values.booleans.has("--people"),
-            ...(memoryDays === undefined ? {} : { memoryDays: Number(memoryDays) }),
-            ...base,
-        };
+    return rawAction === "status" ? parseOpsStatus(values, base) : parseOpsRecompile(values, base);
+}
+function parseOpsStatus(values, base) {
+    // BLI-3729: `--memory-days N` implies `--memory`, because asking for a
+    // window and getting nothing back is the silent breakage BLI-2490 forbids.
+    const memoryDays = optionalNonEmpty(values.flags.get("--memory-days"));
+    if (memoryDays !== undefined && !/^[0-9]{1,2}$/u.test(memoryDays)) {
+        throw new Error("ops --memory-days takes a whole number of days, 1 to 30.");
+    }
+    const coverageOnly = values.booleans.has("--coverage");
+    const job = optionalNonEmpty(values.flags.get("--job"));
+    if (coverageOnly && job !== undefined && job !== "collection-coverage") {
+        // Refused rather than silently preferring one: `--coverage --job
+        // daily-brief` is somebody asking two different questions in one
+        // command, and answering the wrong one is how a board loses trust.
+        throw new Error("ops --coverage IS --job collection-coverage. Pass one or the other, not a --job naming a different pipeline.");
     }
+    return {
+        kind: "ops",
+        action: "status",
+        job: coverageOnly ? "collection-coverage" : job,
+        coverage: coverageOnly,
+        skips: values.booleans.has("--skips"),
+        memory: values.booleans.has("--memory") || memoryDays !== undefined,
+        models: values.booleans.has("--models"),
+        turns: values.booleans.has("--turns"),
+        toolRouter: values.booleans.has("--tool-router"),
+        people: values.booleans.has("--people"),
+        ...(memoryDays === undefined ? {} : { memoryDays: Number(memoryDays) }),
+        ...base,
+    };
+}
+function parseOpsRecompile(values, base) {
     const person = optionalNonEmpty(values.flags.get("--person"));
     if (!person) {
         throw new Error("ops recompile needs --person <email|name|id>. Nothing is recompiled by default, on purpose.");
@@ -161,37 +163,36 @@ export const SLACK_WORKSPACE_KEYS = ["bli", "blue_pearl"];
  * (BLI-3462).
  */
 const SLACK_READ_FORMATS = ["compact", "full"];
+const SLACK_ALLOWED_FLAGS = [
+    "--home",
+    "--dashboard-url",
+    "--workspace",
+    "--stale-only",
+    "--list",
+    "--person",
+    "--channel",
+    "--query",
+    "--word",
+    "--since",
+    "--until",
+    "--limit",
+    "--format",
+    "--json",
+];
+const SLACK_VALUE_FLAGS = [
+    "--home",
+    "--dashboard-url",
+    "--workspace",
+    "--person",
+    "--channel",
+    "--query",
+    "--since",
+    "--until",
+    "--limit",
+    "--format",
+];
 export function parseSlackArgs(args) {
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--dashboard-url",
-            "--workspace",
-            "--stale-only",
-            "--list",
-            "--person",
-            "--channel",
-            "--query",
-            "--word",
-            "--since",
-            "--until",
-            "--limit",
-            "--format",
-            "--json",
-        ],
-        valueFlags: [
-            "--home",
-            "--dashboard-url",
-            "--workspace",
-            "--person",
-            "--channel",
-            "--query",
-            "--since",
-            "--until",
-            "--limit",
-            "--format",
-        ],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: SLACK_ALLOWED_FLAGS, valueFlags: SLACK_VALUE_FLAGS });
     if (values.positionals.length > 1) {
         throw new Error("slack accepts one action: coverage, read, connect or disconnect.");
     }
@@ -210,32 +211,39 @@ export function parseSlackArgs(args) {
     if (values.booleans.has("--list") && rawAction !== "coverage") {
         throw new Error("--list belongs to `cockpit slack coverage`.");
     }
-    if (rawAction === "connect" || rawAction === "disconnect") {
-        const workspace = optionalNonEmpty(values.flags.get("--workspace"));
-        if (workspace && !SLACK_WORKSPACE_KEYS.includes(workspace))
-            throw new Error("Unknown Slack workspace.");
-        if (rawAction === "disconnect" && !workspace)
-            throw new Error("slack disconnect needs --workspace bli|blue_pearl.");
-        return { kind: "slack", action: rawAction, workspace, ...base };
-    }
-    if (rawAction === "coverage") {
-        // `--workspace` here is a Slack workspace key, NOT the collection-root
-        // `--workspace <path>` every setup command takes. Named at the point of use
-        // so the two cannot be confused silently.
-        const workspace = optionalNonEmpty(values.flags.get("--workspace"));
-        if (workspace && !SLACK_WORKSPACE_KEYS.includes(workspace)) {
-            throw new Error(`slack --workspace must be one of ${SLACK_WORKSPACE_KEYS.join(", ")}; got ${workspace}.`);
-        }
-        return {
-            kind: "slack",
-            action: "coverage",
-            workspace,
-            staleOnly: values.booleans.has("--stale-only"),
-            // BLI-10450: counts alone could not answer "is there a Kaiben channel?".
-            list: values.booleans.has("--list"),
-            ...base,
-        };
+    if (rawAction === "connect" || rawAction === "disconnect")
+        return parseSlackConnection(values, base, rawAction);
+    if (rawAction === "coverage")
+        return parseSlackCoverage(values, base);
+    return parseSlackRead(values, base);
+}
+function parseSlackConnection(values, base, action) {
+    const workspace = optionalNonEmpty(values.flags.get("--workspace"));
+    if (workspace && !SLACK_WORKSPACE_KEYS.includes(workspace))
+        throw new Error("Unknown Slack workspace.");
+    if (action === "disconnect" && !workspace)
+        throw new Error("slack disconnect needs --workspace bli|blue_pearl.");
+    return { kind: "slack", action, workspace, ...base };
+}
+function parseSlackCoverage(values, base) {
+    // `--workspace` here is a Slack workspace key, NOT the collection-root
+    // `--workspace <path>` every setup command takes. Named at the point of use
+    // so the two cannot be confused silently.
+    const workspace = optionalNonEmpty(values.flags.get("--workspace"));
+    if (workspace && !SLACK_WORKSPACE_KEYS.includes(workspace)) {
+        throw new Error(`slack --workspace must be one of ${SLACK_WORKSPACE_KEYS.join(", ")}; got ${workspace}.`);
     }
+    return {
+        kind: "slack",
+        action: "coverage",
+        workspace,
+        staleOnly: values.booleans.has("--stale-only"),
+        // BLI-10450: counts alone could not answer "is there a Kaiben channel?".
+        list: values.booleans.has("--list"),
+        ...base,
+    };
+}
+function parseSlackRead(values, base) {
     const person = optionalNonEmpty(values.flags.get("--person"));
     const channel = optionalNonEmpty(values.flags.get("--channel"));
     const query = optionalNonEmpty(values.flags.get("--query"));
@@ -271,20 +279,19 @@ export function parseSlackArgs(args) {
  * `cockpit team [members|invite <email>|role <userId>|device list|device
  * revoke <id|name>]` (BLI-3461; `device` added BLI-3559).
  */
+const TEAM_ALLOWED_FLAGS = [
+    "--home",
+    "--dashboard-url",
+    "--json",
+    "--role",
+    "--team-id",
+    "--yes",
+    "--reason",
+    "--note",
+];
+const TEAM_VALUE_FLAGS = ["--home", "--dashboard-url", "--role", "--team-id", "--reason", "--note"];
 export function parseTeamArgs(args) {
-    const values = parseNamedArgs(args, {
-        allowedFlags: [
-            "--home",
-            "--dashboard-url",
-            "--json",
-            "--role",
-            "--team-id",
-            "--yes",
-            "--reason",
-            "--note",
-        ],
-        valueFlags: ["--home", "--dashboard-url", "--role", "--team-id", "--reason", "--note"],
-    });
+    const values = parseNamedArgs(args, { allowedFlags: TEAM_ALLOWED_FLAGS, valueFlags: TEAM_VALUE_FLAGS });
     const common = {
         homeDir: optionalNonEmpty(values.flags.get("--home")),
         dashboardUrl: optionalUrl(values.flags.get("--dashboard-url")),
@@ -293,31 +300,15 @@ export function parseTeamArgs(args) {
         json: values.booleans.has("--json"),
     };
     const [verb, ...rest] = values.positionals;
-    if (verb === "github-login") {
-        const [operation, personRef, githubLogin, ...extra] = rest;
-        if (!["add", "remove", "list"].includes(operation ?? "") || !personRef || extra.length ||
-            (operation === "list" ? githubLogin !== undefined : !githubLogin)) {
-            throw new Error("team github-login takes add|remove <person> <login>, or list <person>.");
-        }
-        return { kind: "team", action: `github-login-${operation}`, personRef, githubLogin, ...common };
-    }
-    if (verb === "timezone") {
-        const [operation, personRef, zone, ...extra] = rest;
-        if (!["set", "list"].includes(operation ?? "") || extra.length ||
-            (operation === "list" ? personRef !== undefined : !personRef || !zone)) {
-            throw new Error("team timezone takes set <person> <iana-zone> (or the word unknown), or list.");
-        }
-        return { kind: "team", action: operation === "set" ? "timezone-set" : "timezone-list", ...(personRef ? { personRef } : {}), ...(zone ? { zone } : {}), ...common };
-    }
+    if (verb === "github-login")
+        return parseTeamGithubLoginArgs(rest, common);
+    if (verb === "timezone")
+        return parseTeamTimezoneArgs(rest, common);
     if (verb === "device") {
         return parseTeamDeviceArgs(rest, values.flags, common);
     }
-    if (verb === "grant" || verb === "revoke") {
-        const [person, section, level = "see", ...extra] = rest;
-        if (!person || section !== "careers" || !["see", "act"].includes(level) || extra.length)
-            throw new Error("team grant|revoke <person uuid> careers [see|act]");
-        return { kind: "team", action: verb, targetUserId: person, section: "careers", level: level, ...common };
-    }
+    if (verb === "grant" || verb === "revoke")
+        return parseTeamGrantArgs(verb, rest, common);
     const [subject, ...extra] = rest;
     if (extra.length > 0)
         throw new Error("team does not accept that many arguments.");
@@ -345,6 +336,28 @@ export function parseTeamArgs(args) {
     }
     throw new Error("team takes one verb: members, invite, role, grant, revoke, or device.");
 }
+function parseTeamGithubLoginArgs(rest, common) {
+    const [operation, personRef, githubLogin, ...extra] = rest;
+    if (!["add", "remove", "list"].includes(operation ?? "") || !personRef || extra.length ||
+        (operation === "list" ? githubLogin !== undefined : !githubLogin)) {
+        throw new Error("team github-login takes add|remove <person> <login>, or list <person>.");
+    }
+    return { kind: "team", action: `github-login-${operation}`, personRef, githubLogin, ...common };
+}
+function parseTeamTimezoneArgs(rest, common) {
+    const [operation, personRef, zone, ...extra] = rest;
+    if (!["set", "list"].includes(operation ?? "") || extra.length ||
+        (operation === "list" ? personRef !== undefined : !personRef || !zone)) {
+        throw new Error("team timezone takes set <person> <iana-zone> (or the word unknown), or list.");
+    }
+    return { kind: "team", action: operation === "set" ? "timezone-set" : "timezone-list", ...(personRef ? { personRef } : {}), ...(zone ? { zone } : {}), ...common };
+}
+function parseTeamGrantArgs(verb, rest, common) {
+    const [person, section, level = "see", ...extra] = rest;
+    if (!person || section !== "careers" || !["see", "act"].includes(level) || extra.length)
+        throw new Error("team grant|revoke <person uuid> careers [see|act]");
+    return { kind: "team", action: verb, targetUserId: person, section: "careers", level: level, ...common };
+}
 /**
  * `cockpit team device [list] [--json]` or
  * `cockpit team device revoke <id|name> --reason <label> [--note "<text>"]`