@bli-cockpit/cli 0.2.162 → 0.2.164

package/dist/commands/github.js

@@ -0,0 +1,92 @@
+/**
+ * `cockpit github` — a pull request's live state, and merge / retitle / re-run
+ * on the person's say-so (BLI-12385).
+ *
+ * The SAME door JARVIS's chat tools stand on (`POST /api/github/pull-request`,
+ * opted into the device token in `route-caller-census.test.ts`): GitHub's own
+ * answer, your own GitHub login's permission checked by GitHub, and the same
+ * two steps. Run a write without `--confirm` and it prints what would happen
+ * and an eight-character code; run it again with `--confirm <code>` and it does
+ * it. Nothing about the gate is decided on this side.
+ *
+ * A refusal keeps the door's own `reason` label and sentence verbatim
+ * (`github_login_unknown`, `github_permission_insufficient`, ...).
+ */
+import { askAgentDoor, emitAgentDoor, failAgentDoor, openAgentDoor } from "./agent-door.js";
+import { writeLine } from "./cli-io.js";
+const TAG = "[github cli]";
+const DEADLINE_MS = 60_000;
+export function buildGithubBody(command) {
+    const body = {
+        action: command.action === "pr" ? "read" : command.action,
+        repo: command.repo,
+    };
+    if (command.pullNumber !== undefined)
+        body["pullNumber"] = command.pullNumber;
+    if (command.runId !== undefined)
+        body["runId"] = command.runId;
+    if (command.title !== undefined)
+        body["title"] = command.title;
+    if (command.method !== undefined)
+        body["method"] = command.method;
+    if (command.claim !== undefined)
+        body["claim"] = command.claim;
+    if (command.confirm !== undefined)
+        body["confirm"] = command.confirm;
+    return body;
+}
+export async function runGithub(command, io) {
+    const door = await openAgentDoor("github", command, io);
+    const answer = await askAgentDoor(door, {
+        path: "/api/github/pull-request",
+        method: "POST",
+        label: `github-${command.action}`,
+        timeoutMs: DEADLINE_MS,
+        body: buildGithubBody(command),
+    });
+    if (!answer.ok)
+        return failAgentDoor(door, TAG, answer.reason, answer.detail);
+    const result = answer.body.result ?? {};
+    writeLine(io.stderr, `${TAG} ${command.action} ${JSON.stringify({
+        repo: command.repo,
+        pull_number: command.pullNumber ?? null,
+        status: result["status"] ?? null,
+        reason: result["reason"] ?? null,
+    })}`);
+    if (door.json)
+        return emitAgentDoor(door, answer.body);
+    return command.action === "pr" ? renderRead(door, result) : renderWrite(door, command, result);
+}
+function renderRead(door, result) {
+    const summary = typeof result["summary"] === "string" ? result["summary"] : "GitHub returned no summary.";
+    writeLine(door.io.stdout, summary);
+    if (typeof result["note"] === "string" && result["note"])
+        writeLine(door.io.stdout, result["note"]);
+    // A read GitHub could not answer is not a clean zero: say so in the exit code.
+    return result["status"] === "read_failed" || result["status"] === "unconfigured" ? 1 : 0;
+}
+function renderWrite(door, command, result) {
+    if (result["status"] === "needs_confirmation") {
+        const code = String(result["confirmationCode"] ?? "");
+        writeLine(door.io.stdout, `Would ${String(result["preview"] ?? "make this change")}`);
+        writeLine(door.io.stdout, `Nothing has been changed. To go ahead, run:`);
+        writeLine(door.io.stdout, `  ${rerunCommand(command, code)}`);
+        return 0;
+    }
+    writeLine(door.io.stdout, String(result["sayThis"] ?? "Done."));
+    return 0;
+}
+/** The exact second step, with the same arguments, so the code stays valid. */
+function rerunCommand(command, code) {
+    const parts = ["cockpit", "github", command.action, command.repo];
+    if (command.pullNumber !== undefined)
+        parts.push(String(command.pullNumber));
+    if (command.runId !== undefined)
+        parts.push("--run", String(command.runId));
+    if (command.title !== undefined)
+        parts.push("--title", JSON.stringify(command.title));
+    if (command.method !== undefined)
+        parts.push("--method", command.method);
+    parts.push("--confirm", code);
+    return parts.join(" ");
+}

package/dist/commands/local-args-tower-github.js

@@ -0,0 +1,81 @@
+/**
+ * `cockpit github` argument parsing (BLI-12385).
+ *
+ *   cockpit github pr <owner/repo> <n> [--claim merged|open|closed|ci_green|mergeable]
+ *   cockpit github merge <owner/repo> <n> [--method squash|merge|rebase] [--confirm <code>]
+ *   cockpit github retitle <owner/repo> <n> --title "<text>" [--confirm <code>]
+ *   cockpit github rerun <owner/repo> (<n> | --run <id>) [--confirm <code>]
+ *
+ * Without `--confirm` a write only previews and prints a code; with it, it
+ * executes. The server judges everything else (org, permission, code), so this
+ * file refuses only what could not be a request at all.
+ */
+import { optionalNonEmpty, optionalPositiveInteger, optionalUrl, parseNamedArgs, } from "./local-arg-values.js";
+export const GITHUB_ACTIONS = ["pr", "merge", "retitle", "rerun"];
+export const GITHUB_MERGE_METHODS = ["squash", "merge", "rebase"];
+export const GITHUB_CLAIMS = ["merged", "open", "closed", "ci_green", "mergeable"];
+const REPO_PATTERN = /^[A-Za-z0-9_.-]+(\/[A-Za-z0-9_.-]+)?$/;
+export function parseGithubArgs(args) {
+    const values = parseNamedArgs(args, {
+        allowedFlags: ["--home", "--dashboard-url", "--claim", "--method", "--title", "--run", "--confirm", "--json"],
+        valueFlags: ["--home", "--dashboard-url", "--claim", "--method", "--title", "--run", "--confirm"],
+    });
+    const action = values.positionals[0];
+    if (!action || !GITHUB_ACTIONS.includes(action)) {
+        throw new Error(`github action must be one of ${GITHUB_ACTIONS.join(", ")}.`);
+    }
+    const repo = values.positionals[1];
+    if (!repo || !REPO_PATTERN.test(repo)) {
+        throw new Error(`github ${action} needs a repo, e.g. BLI-INC/bli-cockpit.`);
+    }
+    const numberText = values.positionals[2];
+    if (values.positionals.length > 3)
+        throw new Error(`github ${action} takes a repo and a pull request number only.`);
+    const pullNumber = numberText === undefined ? undefined : optionalPositiveInteger(numberText, "pull request number");
+    const runId = optionalPositiveInteger(values.flags.get("--run"), "--run");
+    if (action === "rerun") {
+        if ((pullNumber === undefined) === (runId === undefined)) {
+            throw new Error("github rerun needs exactly one of a pull request number or --run <id>.");
+        }
+    }
+    else if (pullNumber === undefined) {
+        throw new Error(`github ${action} needs a pull request number.`);
+    }
+    const only = (flag, allowed) => {
+        if (values.flags.has(flag) && !allowed.includes(action)) {
+            throw new Error(`${flag} belongs to \`cockpit github ${allowed.join("|")}\`.`);
+        }
+    };
+    only("--claim", ["pr"]);
+    only("--method", ["merge"]);
+    only("--title", ["retitle"]);
+    only("--run", ["rerun"]);
+    if (values.flags.has("--confirm") && action === "pr") {
+        throw new Error("--confirm belongs to merge, retitle and rerun; pr only reads.");
+    }
+    const title = optionalNonEmpty(values.flags.get("--title"));
+    if (action === "retitle" && !title)
+        throw new Error("github retitle needs --title \"<new title>\".");
+    const method = optionalNonEmpty(values.flags.get("--method"));
+    if (method && !GITHUB_MERGE_METHODS.includes(method)) {
+        throw new Error(`--method must be one of ${GITHUB_MERGE_METHODS.join(", ")}; got ${method}.`);
+    }
+    const claim = optionalNonEmpty(values.flags.get("--claim"));
+    if (claim && !GITHUB_CLAIMS.includes(claim)) {
+        throw new Error(`--claim must be one of ${GITHUB_CLAIMS.join(", ")}; got ${claim}.`);
+    }
+    return {
+        kind: "github",
+        action,
+        repo,
+        ...(pullNumber === undefined ? {} : { pullNumber }),
+        ...(runId === undefined ? {} : { runId }),
+        ...(title ? { title } : {}),
+        ...(method ? { method: method } : {}),
+        ...(claim ? { claim } : {}),
+        ...(values.flags.get("--confirm") ? { confirm: values.flags.get("--confirm").trim() } : {}),
+        homeDir: optionalNonEmpty(values.flags.get("--home")),
+        dashboardUrl: optionalUrl(values.flags.get("--dashboard-url")),
+        json: values.booleans.has("--json"),
+    };
+}

package/dist/commands/local-args-tower.js

@@ -32,6 +32,7 @@ export { parseBriefArgs, WORKBOOK_MIN_WIDTH, parseWorkbookArgs, parseNotesArgs,
 export { SCOUT_MIN_PREFIX_LENGTH, parseScoutArgs, parseOpsArgs, SLACK_WORKSPACE_KEYS, parseSlackArgs, parseSettingsArgs, parseTeamArgs, parseModelArgs, } from "./local-args-tower-admin.js";
 export { parseDocsArgs, parseMsgArgs, } from "./local-args-tower-docs-msg.js";
 export { ISSUE_STATES, parseIssueArgs, parseProjectArgs, } from "./local-args-tower-work.js";
+export { parseGithubArgs } from "./local-args-tower-github.js";
 export { SEARCH_KINDS, parseSearchArgs } from "./local-args-tower-search.js";
 export { parseModelsArgs } from "./local-args-tower-models.js";
 export { parseMailArgs } from "./local-args-tower-mail.js";

package/dist/commands/local-args.js

@@ -18,7 +18,7 @@
 import { parseRootsArgs } from "./roots.js";
 import { SURFACE_ALIASES } from "./local-help.js";
 import { parseAgentRulesArgs, parseAnalyzeArgs, parseAutostartArgs, parseBackfillArgs, parseCleanArgs, parseDoctorArgs, parseInstallArgs, parseLoginArgs, parseMemoryArgs, parseLogoutArgs, parseOnboardArgs, parseReleaseArgs, parseServeArgs, parseSessionsArgs, parseSourcesArgs, parseStartArgs, parseStatusArgs, parseSyncArgs, parseUpdateArgs, } from "./local-args-collector.js";
-import { parseBriefArgs, parseCorrectArgs, parseDocsArgs, parseIssueArgs, parseJarvisArgs, parseMailArgs, parseCalArgs, parseModelArgs, parseMsgArgs, parseNotesArgs, parseOpsArgs, parseProjectArgs, parseModelsArgs, parseScoutArgs, parseSearchArgs, parseSettingsArgs, parseSlackArgs, parseTeamArgs, parseWorkbookArgs, parseUsageArgs, parseCareersArgs, parseRenameArgs, } from "./local-args-tower.js";
+import { parseBriefArgs, parseCorrectArgs, parseDocsArgs, parseIssueArgs, parseJarvisArgs, parseMailArgs, parseCalArgs, parseModelArgs, parseMsgArgs, parseNotesArgs, parseOpsArgs, parseProjectArgs, parseModelsArgs, parseScoutArgs, parseGithubArgs, parseSearchArgs, parseSettingsArgs, parseSlackArgs, parseTeamArgs, parseWorkbookArgs, parseUsageArgs, parseCareersArgs, parseRenameArgs, } from "./local-args-tower.js";
 // `normalizeUrl` has always been part of this module's surface — `local.ts` and
 // `local-auth.ts` import it from here — so it stays exported from this address
 // even though it now lives next door. The same goes for the four names the
@@ -123,6 +123,8 @@ export function parseLocalArgs(argv) {
             return parseProjectArgs(argv.slice(1));
         case "search":
             return parseSearchArgs(argv.slice(1));
+        case "github":
+            return parseGithubArgs(argv.slice(1));
         case "release":
             return parseReleaseArgs(argv.slice(1));
         case "careers":

package/dist/commands/local-command-shapes-github.js

@@ -0,0 +1,6 @@
+/**
+ * `cockpit github` command shape (BLI-12385), beside `local-command-shapes.ts`
+ * for the same reason `local-command-shapes-search.ts` is: that file sits at the
+ * readability ceiling.
+ */
+export {};

package/dist/commands/local-help-commands-tower-ops.js

@@ -10,6 +10,32 @@
  * something breaks, so it is a user-visible contract like any other.
  */
 export const TOWER_OPS_COMMAND_HELP = [
+    [
+        "github",
+        [
+            "Usage: cockpit github <pr|merge|retitle|rerun> <owner/repo> <n> [--claim <state>] [--method squash|merge|rebase] [--title \"<text>\"] [--run <id>] [--confirm <code>] [--json]",
+            "",
+            "  cockpit github pr <owner/repo> <n> [--claim merged|open|closed|ci_green|mergeable]",
+            "      GitHub's own record of one pull request: merged or not, by whom, mergeable,",
+            "      draft, title and CI. GitHub is the source of truth. --claim compares a state",
+            "      somebody told you against GitHub's answer and prints the correction.",
+            "  cockpit github merge|retitle|rerun <owner/repo> <n>",
+            "      The same three changes JARVIS can make, in TWO STEPS. Without --confirm it",
+            "      changes nothing: it prints what would happen and an eight-character code, plus",
+            "      the exact command to run next. Run that command (--confirm <code>) to do it.",
+            "      A code is signed to you, the repo, the pull request and the exact change, so a",
+            "      reworded --title or a new head commit needs a new code.",
+            "      merge takes --method squash (default), merge or rebase. retitle needs --title.",
+            "      rerun re-runs the FAILED jobs: pass a pull request number, or --run <id> for one run.",
+            "      Writes run only if YOUR OWN GitHub login (on the roster) has write, maintain or",
+            "      admin on the repo; otherwise the refusal github_login_unknown or",
+            "      github_permission_insufficient is printed as written. Only BLI-INC repos.",
+            "--json writes one object to stdout: { ok, result } where result is the read, the",
+            "preview { status: \"needs_confirmation\", confirmationCode, preview } or the outcome",
+            "{ status: \"done\", ... }; a refusal is { ok: false, error, detail } and exits 1.",
+            "The bli-tower MCP server has the twins: github_pr, github_merge, github_retitle, github_rerun.",
+        ],
+    ],
     [
         "jarvis",
         [

package/dist/commands/local-help.js

@@ -73,6 +73,7 @@ export const rootCommandNames = new Set([
     "cal",
     "project",
     "search",
+    "github",
     "release",
     "careers",
     "rename",
@@ -126,6 +127,7 @@ export function localCommandHelp(command) {
         "  cockpit mail [accounts|add-imap --address <a>|inbox|read <thread>|search \"<words>\"|send --account <id> --to <a> --subject <s>|attachment <id> --out <path>|sync <account>|detach <account>] [--account <id>] [--limit <n>] [--unread] [--label <l>] [--file <path>] [--dashboard-url <url>] [--json]",
         "  cockpit cal [today|week|next|find \"<words>\"|calendars|add-ical|create --calendar <id> --title <t> --at <iso> --until <iso>|share <id> --org-visible|--private|sync <id> [--full]|detach <id>] [--tz <zone>] [--offset <n>] [--hours <n>] [--from <d> --to <d>] [--calendar <id>] [--limit <n>] [--all] [--dashboard-url <url>] [--json]",
         "  cockpit project [list] [--archived] [--dashboard-url <url>] [--json]",
+        "  cockpit github <pr|merge|retitle|rerun> <owner/repo> <n> [--claim <state>] [--method squash|merge|rebase] [--title \"<text>\"] [--run <id>] [--confirm <code>] [--dashboard-url <url>] [--json]",
         `  cockpit search "<words>" [--kind ${SEARCH_KINDS.join(",")}] [--limit <n>] [--dashboard-url <url>] [--json]`,
         "  cockpit release [--dry-run] [--skip-checks] [--no-floor] [--tag <tag>] [--access <public|restricted>] [--otp <code>]",
         "  cockpit careers [list|show <id>|rescreen <id>|send-takehome <id>|decide <id> --decision <passed_on|archived|reopen>|followup <id> [--record-sent-at <iso>]|interview <id> <--at <iso>|--clear>|grade <id> [--now]|resume <id> [--out <path>]|takehome show <role>|takehome set <role> --body-file <path>|settings show|settings set --enabled <true|false> --followup-enabled <true|false> --followup-after-days <n> --takehome-window-hours <n>] [--role <slug>] [--min-score <n>] [--since <date>] [--stage <s>] [--force] [--json]",

package/dist/commands/local.js

@@ -44,6 +44,7 @@ import { runIssue } from "./issue.js";
 import { runCal } from "./cal.js";
 import { runMail } from "./mail.js";
 import { runProject } from "./project.js";
+import { runGithub } from "./github.js";
 import { runSearch } from "./search.js";
 import { runCareers } from "./careers.js";
 import { runRename } from "./rename-scope.js";
@@ -231,6 +232,8 @@ export async function runLocalCockpitCli(argv, io = defaultIo()) {
                 return await runProject(command, io);
             case "search":
                 return await runSearch(command, io);
+            case "github":
+                return await runGithub(command, io);
             case "release":
                 return await runRelease(command, io);
             case "careers":

package/dist/commands/public-root.js

@@ -21,7 +21,7 @@ export async function runCockpitCli(argv, io) {
   }
 
   if (command === "--version" || command === "-V" || command === "version") {
-    writeLine(io?.stdout ?? process.stdout, "0.2.162");
+    writeLine(io?.stdout ?? process.stdout, "0.2.164");
     return 0;
   }
 

package/dist/commands/slack.js

@@ -226,6 +226,13 @@ function writeReadReply(command, io, payload, read, messages) {
     const styled = colorEnabled(io);
     const summary = typeof read["summary"] === "string" ? read["summary"] : "";
     const header = summary.split("\n")[0] ?? "";
+    // BLI-12381: an unknown, uncovered or empty read leads with its reason
+    // label on stdout (not only the stderr receipt), so a zero never reads as
+    // "nobody said anything".
+    const status = typeof read["status"] === "string" ? read["status"] : null;
+    if (status && (status !== "ok" || messages.length === 0)) {
+        writeLine(io.stdout, `slack read: status=${status} reason=${String(read["reason"] ?? "?")}`);
+    }
     if (header)
         writeLine(io.stdout, header);
     if (command.format === "compact") {
@@ -243,7 +250,8 @@ function writeReadReply(command, io, payload, read, messages) {
             }
         }
     }
-    if (typeof read["note"] === "string" && read["note"]) {
+    // A refusal's summary IS its note (tools-slack.ts `boundary`); print it once.
+    if (typeof read["note"] === "string" && read["note"] && read["note"] !== header) {
         writeLine(io.stdout, "");
         writeLine(io.stdout, dim(read["note"], styled));
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bli-cockpit/cli",
-  "version": "0.2.162",
+  "version": "0.2.164",
   "private": false,
   "type": "module",
   "bin": {
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@bli-cockpit/memory-mcp": "0.1.45",
-    "@bli-cockpit/mcp": "0.1.80",
+    "@bli-cockpit/mcp": "0.1.82",
     "@bli-cockpit/telemetry-core": "0.1.57"
   },
   "repository": {