@bleedingdev/modern-js-create 3.5.0-ultramodern.0 → 3.5.0-ultramodern.10

package/template-workspace/pnpm-workspace.yaml.handlebars

@@ -8,6 +8,8 @@ minimumReleaseAgeStrict: true
 minimumReleaseAgeIgnoreMissingTime: false
 minimumReleaseAgeExclude:
   - '@bleedingdev/modern-js-*'
+  - 'effect@{{effectVersion}}'
+  - '@effect/opentelemetry@{{effectVersion}}'
   - '@tanstack/react-router'
   - '@tanstack/router-core'
   - 'typescript'
@@ -24,6 +26,9 @@ minimumReleaseAgeExclude:
   - 'ts-checker-rspack-plugin'
 trustPolicy: no-downgrade
 trustPolicyIgnoreAfter: 1440
+trustPolicyExclude:
+  - 'effect@{{effectVersion}}'
+  - '@effect/opentelemetry@{{effectVersion}}'
 blockExoticSubdeps: true
 engineStrict: true
 pmOnFail: error
@@ -37,11 +42,14 @@ peerDependencyRules:
     '@module-federation/enhanced>typescript': '{{typescriptVersion}}'
     '@module-federation/modern-js-v3>typescript': '{{typescriptVersion}}'
     '@module-federation/rspack>typescript': '{{typescriptVersion}}'
+    '@effect/vitest>effect': '{{effectVersion}}'
     'i18next>typescript': '{{typescriptVersion}}'
 
 overrides:
   '@tanstack/react-router': {{tanstackRouterVersion}}
   '@tanstack/router-core': {{tanstackRouterCoreVersion}}
+  '@effect/vitest': {{effectVitestVersion}}
+  effect: {{effectVersion}}
   node-fetch: '{{nodeFetchVersion}}'
 
 allowBuilds:

package/templates/workspace-scripts/check-ultramodern-api-boundaries.mts

@@ -97,7 +97,12 @@ function assertNotContains(relativePath, content, pattern, message) {
 }
 
 for (const forbiddenPath of [
-  'apps/shell-super-app/src/effect',
+  ...listDirectories('apps').flatMap(appPath => [
+    `${appPath}/api/effect`,
+    `${appPath}/api/lambda`,
+    `${appPath}/shared/effect`,
+    `${appPath}/src/effect`,
+  ]),
   ...listDirectories('verticals').flatMap(verticalPath => [
     `${verticalPath}/api/effect`,
     `${verticalPath}/api/lambda`,
@@ -148,6 +153,12 @@ for (const file of textFiles) {
       /\bcreateHandler\s*[:=]\s*(?!defineEffectBff\b)/u,
       'API modules must not define unbranded handler factories; use defineEffectBff(...).',
     );
+    assertNotContains(
+      file,
+      content,
+      /\bSchema\.(?:UnknownFromJsonString|Unknown|Any)\b/u,
+      'API modules must use concrete request, response and error schemas; Schema.UnknownFromJsonString, Schema.Unknown and Schema.Any are forbidden in UltraModern API code.',
+    );
   }
 
   assertNotContains(
@@ -170,17 +181,18 @@ for (const file of textFiles) {
   );
 }
 
+const verticalDirectories = listDirectories('verticals');
 const shellClient = 'apps/shell-super-app/src/api/vertical-clients.ts';
-if (exists('apps/shell-super-app')) {
+if (exists('apps/shell-super-app') && verticalDirectories.length > 0) {
   assert(exists(shellClient), `${shellClient} must aggregate vertical API clients.`);
 }
 
-for (const verticalPath of listDirectories('verticals')) {
-  const apiEntry = `${verticalPath}/api/index.ts`;
-  const sharedApi = `${verticalPath}/shared/api.ts`;
-  const srcApiDirectory = `${verticalPath}/src/api`;
-  const modernConfig = `${verticalPath}/modern.config.ts`;
-  const packageJsonPath = `${verticalPath}/package.json`;
+function assertApiSurface(appPath) {
+  const apiEntry = `${appPath}/api/index.ts`;
+  const sharedApi = `${appPath}/shared/api.ts`;
+  const srcApiDirectory = `${appPath}/src/api`;
+  const modernConfig = `${appPath}/modern.config.ts`;
+  const packageJsonPath = `${appPath}/package.json`;
 
   assert(exists(apiEntry), `${apiEntry} is required.`);
   assert(exists(sharedApi), `${sharedApi} is required.`);
@@ -288,6 +300,16 @@ for (const verticalPath of listDirectories('verticals')) {
   }
 }
 
+for (const appPath of listDirectories('apps')) {
+  if (exists(`${appPath}/api/index.ts`) || exists(`${appPath}/shared/api.ts`)) {
+    assertApiSurface(appPath);
+  }
+}
+
+for (const verticalPath of verticalDirectories) {
+  assertApiSurface(verticalPath);
+}
+
 if (exists('apps/shell-super-app/package.json')) {
   const shellPackageJson = JSON.parse(
     readText('apps/shell-super-app/package.json'),

package/templates/workspace-scripts/validate-ultramodern-workspace.mjs.handlebars

@@ -1349,6 +1349,22 @@ const extractAssetPrefixExpression = modernConfig => {
   assert(match?.groups?.expression, 'modern.config.ts must assign assetPrefix');
   return match.groups.expression;
 };
+const assertBuildCacheBase = (appId, modernConfig) => {
+  assert(
+    modernConfig.includes("const buildCacheTarget = cloudflareDeployEnabled ? 'cloudflare' : 'web';") &&
+      modernConfig.includes('const buildCacheDirectory = `node_modules/.cache/rspack-${appId}-${buildCacheTarget}`;') &&
+      modernConfig.includes('cacheDirectory: buildCacheDirectory,'),
+    `${appId} must provide a per-app/per-target Rspack cache base directory`,
+  );
+};
+const assertCloudflareBuildSkipsDeployRebuild = (appId, packageJson) => {
+  assert(
+    packageJson.scripts?.['cloudflare:build']?.includes(
+      'ULTRAMODERN_ZEPHYR=false MODERNJS_DEPLOY=cloudflare modern deploy --skip-build',
+    ),
+    `${appId} cloudflare:build must deploy with --skip-build after the explicit Cloudflare build`,
+  );
+};
 const stripYamlInlineComment = value => {
   let quote = undefined;
   for (let index = 0; index < value.length; index += 1) {
@@ -1701,6 +1717,7 @@ assert(
 assert(rootPackage.scripts?.['mf:types'] === 'node ./scripts/assert-mf-types.mts', 'Root must expose mf:types');
 assert(rootPackage.scripts?.['cloudflare:deploy'] === expectedCloudflareDeployScript, 'Root must expose cloudflare:deploy');
 assert(rootPackage.scripts?.['cloudflare:proof'] === 'node ./scripts/proof-cloudflare-version.mts --out .codex/reports/cloudflare-version-proof/public-url-proof.json', 'Root must expose cloudflare:proof');
+assert(rootPackage.scripts?.['migrate:strict-effect'] === 'node ./scripts/migrate-strict-effect.mts', 'Root must expose migrate:strict-effect');
 assert(rootPackage.scripts?.['skills:install'] === 'node ./scripts/bootstrap-agent-skills.mts', 'Root must expose skills:install');
 assert(rootPackage.scripts?.['skills:check'] === 'node ./scripts/bootstrap-agent-skills.mts --check', 'Root must expose skills:check');
 assert(rootPackage.scripts?.postinstall === "oxfmt . '!repos/**' && node ./scripts/bootstrap-agent-skills.mts --postinstall", 'Root postinstall must format, run the default-on Codex skills bootstrap, and leave reference repository installs explicit');
@@ -1709,6 +1726,7 @@ const agentSkillsBootstrap = readText('scripts/bootstrap-agent-skills.mts');
 assertToolWrapper('scripts/assert-mf-types.mts', 'mf-types');
 assertToolWrapper('scripts/generate-public-surface-assets.mts', 'public-surface');
 assertToolWrapper('scripts/proof-cloudflare-version.mts', 'cloudflare-proof');
+assertToolWrapper('scripts/migrate-strict-effect.mts', 'migrate-strict-effect');
 assertToolWrapper('scripts/bootstrap-agent-skills.mts', 'skills');
 assert(!agentSkillsBootstrap.includes("run('brew'") && !agentSkillsBootstrap.includes('runShell('), 'Agent skills bootstrap must never invoke system package managers');
 const agentReferenceRepoSetup = readText('scripts/setup-agent-reference-repos.mts');
@@ -1769,6 +1787,9 @@ assert(shellPackage.dependencies?.['@modern-js/plugin-bff'] === expectedModernPa
 assert(shellPackage.dependencies?.['@modern-js/plugin-i18n'] === expectedModernPackageSpecifier('@modern-js/plugin-i18n'), 'Shell plugin-i18n dependency must match package source metadata');
 assert(shellPackage.dependencies?.['@modern-js/plugin-tanstack'] === expectedModernPackageSpecifier('@modern-js/plugin-tanstack'), 'Shell plugin-tanstack dependency must match package source metadata');
 assert(shellPackage.dependencies?.['@modern-js/runtime'] === expectedModernPackageSpecifier('@modern-js/runtime'), 'Shell runtime dependency must match package source metadata');
+assert(shellPackage.scripts?.['cloudflare:deploy'] === 'ULTRAMODERN_CLOUDFLARE_REQUIRE_PUBLIC_URLS=true pnpm run cloudflare:build && wrangler deploy --config .output/wrangler.json', 'Shell must expose cloudflare:deploy');
+assertBuildCacheBase('shell-super-app', shellModernConfig);
+assertCloudflareBuildSkipsDeployRebuild('shell-super-app', shellPackage);
 const shellContract = generatedContract.apps?.find(app => app.id === 'shell-super-app');
 assert(shellContract?.deploy?.cloudflare?.workerName === expectedWorkerName('shell-super-app'), 'Shell Cloudflare workerName is incorrect');
 assert(shellContract?.deploy?.cloudflare?.publicUrlEnv === 'ULTRAMODERN_PUBLIC_URL_SHELL_SUPER_APP', 'Shell Cloudflare public URL env is incorrect');
@@ -1845,6 +1866,8 @@ for (const vertical of fullStackVerticals) {
   assert(routeMetadata.includes("authoring: 'colocated-route-meta'"), `${vertical.id} route metadata manifest must advertise colocated authoring`);
   assert(packageJson.name === vertical.packageName, `${vertical.id} package name is incorrect`);
   assert(packageJson.scripts?.['cloudflare:deploy'] === 'ULTRAMODERN_CLOUDFLARE_REQUIRE_PUBLIC_URLS=true pnpm run cloudflare:build && wrangler deploy --config .output/wrangler.json', `${vertical.id} must expose cloudflare:deploy`);
+  assertBuildCacheBase(vertical.id, modernConfig);
+  assertCloudflareBuildSkipsDeployRebuild(vertical.id, packageJson);
   assert(packageJson.scripts?.['cloudflare:proof']?.includes(`--app ${vertical.id}`), `${vertical.id} must expose cloudflare:proof`);
   assert(packageJson.devDependencies?.['@modern-js/app-tools'] === expectedModernPackageSpecifier('@modern-js/app-tools'), `${vertical.id} app-tools dependency must match package source metadata`);
   assert(packageJson.dependencies?.['@modern-js/plugin-bff'] === expectedModernPackageSpecifier('@modern-js/plugin-bff'), `${vertical.id} plugin-bff dependency must match package source metadata`);