@bldrs-ai/conway 1.580.1549 → 1.588.1550

package/compiled/examples/browser-bundled.cjs

@@ -30,7 +30,7 @@ var import_node_process = require("node:process");
 var readline = __toESM(require("node:readline"), 1);
 
 // compiled/src/version/version.js
-var versionString = "Conway v1.580.1549";
+var versionString = "Conway v1.588.1550";
 
 // compiled/dependencies/conway-geom/interface/conway_geometry.js
 var wasmType = "";

package/compiled/examples/cli-bundled.cjs

@@ -14985,7 +14985,7 @@ ${t5.join("\n")}` : "";
 var import_process = require("process");
 
 // compiled/src/version/version.js
-var versionString = "Conway v1.580.1549";
+var versionString = "Conway v1.588.1550";
 
 // compiled/dependencies/conway-geom/interface/conway_geometry.js
 function pThreadsAllowed() {

package/compiled/examples/cli-step-bundled.cjs

@@ -15963,7 +15963,7 @@ var ParsingBuffer = class {
 };
 
 // compiled/src/version/version.js
-var versionString = "Conway v1.580.1549";
+var versionString = "Conway v1.588.1550";
 
 // compiled/dependencies/conway-geom/interface/conway_geometry.js
 function pThreadsAllowed() {

package/compiled/examples/validator-bundled.cjs

@@ -944,7 +944,7 @@ var EntityTypesIfcCount = 909;
 var entity_types_ifc_gen_default = EntityTypesIfc;
 
 // compiled/src/version/version.js
-var versionString = "Conway v1.580.1549";
+var versionString = "Conway v1.588.1550";
 
 // compiled/dependencies/conway-geom/interface/conway_geometry.js
 var wasmType = "";

package/compiled/src/AP214E3_2010/ap214_product_structure_extraction.d.ts

@@ -28,7 +28,11 @@ export interface ProductStructureNode {
      * nodes, `'solid'` for ephemeral sub-product solid nodes.
      */
     type: string;
-    /** Display label: `product.name`, falling back to the NAUO name / reference designator. */
+    /**
+     * Display label: `product.name`, falling back to the NAUO name / reference
+     * designator, then to the part number (`product.id` / `product_definition.id`).
+     * `''` when the file names the node nowhere.
+     */
     name: string;
     /** Express id of the underlying `product_definition` (the part *type*). */
     productDefinitionExpressID: number;
@@ -204,13 +208,42 @@ export declare class AP214ProductStructureExtraction {
      * @param node The product/occurrence node to attach solid children to.
      */
     private appendSolidChildren;
+    /**
+     * Read one label candidate, treating anything unusable as absent.
+     *
+     * Every candidate below is a STEP string attribute, and the mandatory ones
+     * (`product.name`, `product.id`, `next_assembly_usage_occurrence.name`,
+     * `product_definition.id`) are extracted with `optional: false`, which
+     * throws `'Value in STEP was incorrectly typed'` when the slot actually
+     * holds `$` or a non-string — a shape exporters do emit. `formation` is an
+     * `extractElement` and can throw on a dangling reference the same way. A
+     * node label is cosmetic; a malformed one must never unwind
+     * {@link extractProductStructure} and cost the caller the entire tree, which
+     * is exactly what the derived-attribute read this replaced used to do.
+     *
+     * Whitespace-only counts as absent: the AP203 NIST files carry `' '` in
+     * `product_definition.description`, and a label of one space is not a label.
+     *
+     * @param read Thunk reading the candidate attribute.
+     * @return {string} The trimmed candidate, or `''` if it is absent, blank or
+     * unreadable.
+     */
+    private static labelCandidate;
     /**
      * Resolve a node label, preferring the product name, then the occurrence's
-     * own name / reference designator.
+     * own name / reference designator, then the part number (`product.id`).
+     *
+     * Deliberately never reads `product_definition.name`: that attribute is
+     * DERIVED in AP214, and its generated getter calls `get_name_value()` in
+     * `ap214_functions.ts`, an unimplemented stub that throws. It is not a real
+     * attribute of the entity at all — `product_definition` carries only `id`
+     * and `description` as strings — so that read could only ever throw, and did:
+     * it killed the whole NavTree for any file that got this far.
      *
      * @param productDef The product definition for the node.
      * @param occurrence The NAUO edge, when this is an occurrence node.
-     * @return {string} The best available human-readable label.
+     * @return {string} The best available human-readable label, or `''` when the
+     * file carries no usable identifier for the node.
      */
     private resolveLabel;
     /**

package/compiled/src/AP214E3_2010/ap214_product_structure_extraction.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ap214_product_structure_extraction.d.ts","sourceRoot":"","sources":["../../../src/AP214E3_2010/ap214_product_structure_extraction.ts"],"names":[],"mappings":"AAAA,OAAO,cAAc,MAAM,oBAAoB,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAA;AAkBhE;;;;;;;;;;;;;;;GAeG;AACH,MAAM,WAAW,oBAAoB;IAEnC;;;;OAIG;IACH,SAAS,EAAE,MAAM,CAAA;IAEjB;;;OAGG;IACH,IAAI,EAAE,MAAM,CAAA;IAEZ,2FAA2F;IAC3F,IAAI,EAAE,MAAM,CAAA;IAEZ,2EAA2E;IAC3E,0BAA0B,EAAE,MAAM,CAAA;IAElC,mEAAmE;IACnE,mBAAmB,CAAC,EAAE,MAAM,CAAA;IAE5B;;;;OAIG;IACH,cAAc,EAAE,MAAM,EAAE,CAAA;IAExB;;;;OAIG;IACH,sBAAsB,EAAE,MAAM,EAAE,CAAA;IAEhC,0EAA0E;IAC1E,QAAQ,EAAE,oBAAoB,EAAE,CAAA;IAEhC;;;;;OAKG;IACH,SAAS,CAAC,EAAE,OAAO,CAAA;IAEnB;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,CAAA;CACvB;AAED;;GAEG;AACH,MAAM,WAAW,uBAAuB;IAEtC;;;;;;;OAOG;IACH,aAAa,CAAC,EAAE,OAAO,CAAA;IAEvB;;;;OAIG;IACH,mBAAmB,CAAC,EAAE,MAAM,CAAA;IAE5B;;;;;;OAMG;IACH,0BAA0B,CAAC,EAAE,MAAM,CAAA;CACpC;AAED,yEAAyE;AACzE,eAAO,MAAM,8BAA8B,MAAM,CAAA;AAEjD,gFAAgF;AAChF,eAAO,MAAM,sCAAsC,KAAK,CAAA;AAmDxD;;;;;;;;;GASG;AACH,qBAAa,+BAA+B;IAqBtC,OAAO,CAAC,QAAQ,CAAC,KAAK;IACtB,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAC;IApBrC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAsD;IACrF,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAoB;IACxD,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAwC;IACxE,OAAO,CAAC,QAAQ,CAAC,sBAAsB,CAA8B;IACrE,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAoC;IACxE,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAiC;IACvE,OAAO,CAAC,cAAc,CAAQ;IAC9B,OAAO,CAAC,oBAAoB,CAAiC;IAC7D,OAAO,CAAC,2BAA2B,CAAyC;IAE5E;;;;;;;OAOG;gBAEkB,KAAK,EAAE,cAAc,EACrB,eAAe,CAAC,EAAE,oBAAoB,YAAA;IAG3D;;;;;;;;;OASG;IACI,uBAAuB,CAAE,OAAO,CAAC,EAAE,uBAAuB,GAAI,oBAAoB,EAAE;IAuC3F;;;OAGG;IACH,OAAO,CAAC,uBAAuB;IAa/B;;;;OAIG;IACH,OAAO,CAAC,mBAAmB;IA0B3B;;;;;OAKG;IACH,OAAO,CAAC,yBAAyB;IAiCjC;;;;;;;;;OASG;IACH,OAAO,CAAC,WAAW;IAuEnB;;;;;;;OAOG;IACH,OAAO,CAAC,QAAQ;IAoBhB;;;;;OAKG;IACH,OAAO,CAAC,sBAAsB;IAc9B;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,SAAS;IA2DjB;;;;;;;;OAQG;IACH,OAAO,CAAC,mBAAmB;IA2C3B;;;;;;;OAOG;IACH,OAAO,CAAC,YAAY;IA0BpB;;;;;;;;;OASG;IACH,MAAM,CAAC,0BAA0B,CAC7B,UAAU,EAAE;QAAE,SAAS,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,SAAS,GAAI,MAAM,GAAG,SAAS;CAgBzE"}
+{"version":3,"file":"ap214_product_structure_extraction.d.ts","sourceRoot":"","sources":["../../../src/AP214E3_2010/ap214_product_structure_extraction.ts"],"names":[],"mappings":"AAAA,OAAO,cAAc,MAAM,oBAAoB,CAAA;AAC/C,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAA;AAkBhE;;;;;;;;;;;;;;;GAeG;AACH,MAAM,WAAW,oBAAoB;IAEnC;;;;OAIG;IACH,SAAS,EAAE,MAAM,CAAA;IAEjB;;;OAGG;IACH,IAAI,EAAE,MAAM,CAAA;IAEZ;;;;OAIG;IACH,IAAI,EAAE,MAAM,CAAA;IAEZ,2EAA2E;IAC3E,0BAA0B,EAAE,MAAM,CAAA;IAElC,mEAAmE;IACnE,mBAAmB,CAAC,EAAE,MAAM,CAAA;IAE5B;;;;OAIG;IACH,cAAc,EAAE,MAAM,EAAE,CAAA;IAExB;;;;OAIG;IACH,sBAAsB,EAAE,MAAM,EAAE,CAAA;IAEhC,0EAA0E;IAC1E,QAAQ,EAAE,oBAAoB,EAAE,CAAA;IAEhC;;;;;OAKG;IACH,SAAS,CAAC,EAAE,OAAO,CAAA;IAEnB;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,CAAA;CACvB;AAED;;GAEG;AACH,MAAM,WAAW,uBAAuB;IAEtC;;;;;;;OAOG;IACH,aAAa,CAAC,EAAE,OAAO,CAAA;IAEvB;;;;OAIG;IACH,mBAAmB,CAAC,EAAE,MAAM,CAAA;IAE5B;;;;;;OAMG;IACH,0BAA0B,CAAC,EAAE,MAAM,CAAA;CACpC;AAED,yEAAyE;AACzE,eAAO,MAAM,8BAA8B,MAAM,CAAA;AAEjD,gFAAgF;AAChF,eAAO,MAAM,sCAAsC,KAAK,CAAA;AAmDxD;;;;;;;;;GASG;AACH,qBAAa,+BAA+B;IAqBtC,OAAO,CAAC,QAAQ,CAAC,KAAK;IACtB,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAC;IApBrC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAsD;IACrF,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAoB;IACxD,OAAO,CAAC,QAAQ,CAAC,eAAe,CAAwC;IACxE,OAAO,CAAC,QAAQ,CAAC,sBAAsB,CAA8B;IACrE,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAoC;IACxE,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAiC;IACvE,OAAO,CAAC,cAAc,CAAQ;IAC9B,OAAO,CAAC,oBAAoB,CAAiC;IAC7D,OAAO,CAAC,2BAA2B,CAAyC;IAE5E;;;;;;;OAOG;gBAEkB,KAAK,EAAE,cAAc,EACrB,eAAe,CAAC,EAAE,oBAAoB,YAAA;IAG3D;;;;;;;;;OASG;IACI,uBAAuB,CAAE,OAAO,CAAC,EAAE,uBAAuB,GAAI,oBAAoB,EAAE;IAuC3F;;;OAGG;IACH,OAAO,CAAC,uBAAuB;IAa/B;;;;OAIG;IACH,OAAO,CAAC,mBAAmB;IA0B3B;;;;;OAKG;IACH,OAAO,CAAC,yBAAyB;IAiCjC;;;;;;;;;OASG;IACH,OAAO,CAAC,WAAW;IAuEnB;;;;;;;OAOG;IACH,OAAO,CAAC,QAAQ;IAoBhB;;;;;OAKG;IACH,OAAO,CAAC,sBAAsB;IAc9B;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,SAAS;IA2DjB;;;;;;;;OAQG;IACH,OAAO,CAAC,mBAAmB;IA2C3B;;;;;;;;;;;;;;;;;;;OAmBG;IACH,OAAO,CAAC,MAAM,CAAC,cAAc;IAS7B;;;;;;;;;;;;;;;OAeG;IACH,OAAO,CAAC,YAAY;IAmDpB;;;;;;;;;OASG;IACH,MAAM,CAAC,0BAA0B,CAC7B,UAAU,EAAE;QAAE,SAAS,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,SAAS,GAAI,MAAM,GAAG,SAAS;CAgBzE"}

package/compiled/src/AP214E3_2010/ap214_product_structure_extraction.js

@@ -367,29 +367,81 @@ export class AP214ProductStructureExtraction {
             });
         }
     }
+    /**
+     * Read one label candidate, treating anything unusable as absent.
+     *
+     * Every candidate below is a STEP string attribute, and the mandatory ones
+     * (`product.name`, `product.id`, `next_assembly_usage_occurrence.name`,
+     * `product_definition.id`) are extracted with `optional: false`, which
+     * throws `'Value in STEP was incorrectly typed'` when the slot actually
+     * holds `$` or a non-string — a shape exporters do emit. `formation` is an
+     * `extractElement` and can throw on a dangling reference the same way. A
+     * node label is cosmetic; a malformed one must never unwind
+     * {@link extractProductStructure} and cost the caller the entire tree, which
+     * is exactly what the derived-attribute read this replaced used to do.
+     *
+     * Whitespace-only counts as absent: the AP203 NIST files carry `' '` in
+     * `product_definition.description`, and a label of one space is not a label.
+     *
+     * @param read Thunk reading the candidate attribute.
+     * @return {string} The trimmed candidate, or `''` if it is absent, blank or
+     * unreadable.
+     */
+    static labelCandidate(read) {
+        try {
+            return read()?.trim() ?? "";
+        }
+        catch {
+            return "";
+        }
+    }
     /**
      * Resolve a node label, preferring the product name, then the occurrence's
-     * own name / reference designator.
+     * own name / reference designator, then the part number (`product.id`).
+     *
+     * Deliberately never reads `product_definition.name`: that attribute is
+     * DERIVED in AP214, and its generated getter calls `get_name_value()` in
+     * `ap214_functions.ts`, an unimplemented stub that throws. It is not a real
+     * attribute of the entity at all — `product_definition` carries only `id`
+     * and `description` as strings — so that read could only ever throw, and did:
+     * it killed the whole NavTree for any file that got this far.
      *
      * @param productDef The product definition for the node.
      * @param occurrence The NAUO edge, when this is an occurrence node.
-     * @return {string} The best available human-readable label.
+     * @return {string} The best available human-readable label, or `''` when the
+     * file carries no usable identifier for the node.
      */
     resolveLabel(productDef, occurrence) {
-        const productName = productDef.formation?.of_product?.name;
-        if (productName !== void 0 && productName.length > 0) {
+        const productName = AP214ProductStructureExtraction.labelCandidate(() => productDef.formation?.of_product?.name);
+        if (productName.length > 0) {
             return productName;
         }
         if (occurrence !== void 0) {
-            if (occurrence.name.length > 0) {
-                return occurrence.name;
+            const occurrenceName = AP214ProductStructureExtraction.labelCandidate(() => occurrence.name);
+            if (occurrenceName.length > 0) {
+                return occurrenceName;
             }
-            const referenceDesignator = occurrence.reference_designator;
-            if (referenceDesignator !== null && referenceDesignator.length > 0) {
+            const referenceDesignator = AP214ProductStructureExtraction.labelCandidate(() => occurrence.reference_designator);
+            if (referenceDesignator.length > 0) {
                 return referenceDesignator;
             }
         }
-        return productDef.name ?? "";
+        // `product.id` is the part number, and it is where the NIST PMI files that
+        // leave `product.name` blank actually put the part identity
+        // ('NIST PMI CTC 04 ASME1'). It is tried ahead of `product_definition.id`
+        // because that one is the definition *discriminator*, not a part name —
+        // literally 'design' in nist_stc_06_asme1_ap242-e3 — and is empty in four
+        // of the six corpus models that reach this line.
+        const productId = AP214ProductStructureExtraction.labelCandidate(() => productDef.formation?.of_product?.id);
+        if (productId.length > 0) {
+            return productId;
+        }
+        // Neither entity's `description` is in the chain: it is prose, not an
+        // identifier. In the same corpus it is empty, whitespace, or the sentence
+        // 'NIST PMI test model downloaded from http://go.usa.gov/mGVm' — worse as a
+        // tree label than the empty string a consumer can substitute a type name
+        // for.
+        return AP214ProductStructureExtraction.labelCandidate(() => productDef.id);
     }
     /**
      * Resolve the owning `product_definition` express id from a

package/compiled/src/AP214E3_2010/ap214_product_structure_extraction.test.js

@@ -198,3 +198,31 @@ describe("AP214ProductStructureExtraction ephemeral solid layer", () => {
         expect(solids.map((solid) => solid.name)).toEqual(["Body1", "Body2"]);
     });
 });
+const UNNAMED_FIXTURE = "data/ap214-unnamed-product-labels.step";
+const UNNAMED_ROOT_COUNT = 3;
+describe("AP214ProductStructureExtraction labels for products with no name", () => {
+    // The regression itself. `product_definition.name` is a DERIVED attribute
+    // whose generated getter calls `get_name_value()`, an unimplemented stub that
+    // throws; resolveLabel used to end on it, so the first product that reached
+    // that line unwound extractProductStructure and Share got no NavTree at all
+    // for the model (red 'Error: Function not implemented.', tree collapsed to
+    // 'AuxScene > Object'). Every root in this fixture reaches that line.
+    test("yields a tree rather than throwing", () => {
+        expect(() => extractStructure(UNNAMED_FIXTURE)).not.toThrow();
+        expect(extractStructure(UNNAMED_FIXTURE).length).toBe(UNNAMED_ROOT_COUNT);
+    });
+    test("falls back to the part number on PRODUCT.id", () => {
+        const [root] = extractStructure(UNNAMED_FIXTURE);
+        expect(root.name).toBe("NIST PMI CTC 04 ASME1");
+    });
+    test("falls back to PRODUCT_DEFINITION.id when the product carries no id", () => {
+        const root = extractStructure(UNNAMED_FIXTURE)[1];
+        expect(root.name).toBe("BRACKET-REV-C");
+    });
+    test("is empty, not whitespace, when the file names the product nowhere", () => {
+        const root = extractStructure(UNNAMED_FIXTURE)[2];
+        // '' lets a consumer substitute a type label; '   ' would render as a blank
+        // NavTree row. nist_stc_09_asme1_ap242-e3 is this case for real.
+        expect(root.name).toBe("");
+    });
+});

package/compiled/src/version/version.js

@@ -5,5 +5,5 @@
 // only the first segment (major) is meaningful and is the one CI carries forward.
 // Must stay in `vN.N.N` shape: the CI stamp regex, scripts/updateVersion.mjs, and
 // statistics.ts all match `v\d+\.\d+\.\d+`.
-const versionString = 'Conway v1.580.1549';
+const versionString = 'Conway v1.588.1550';
 export { versionString };