@blamejs/pki 0.8.59 → 0.8.60

package/lib/cms-sign.js

@@ -15,6 +15,12 @@ var webcrypto = require("./webcrypto");
 var signScheme = require("./sign-scheme");
 var guard = require("./guard-all");
 var intrinsic = require("./guard-intrinsic");
+/** @internal `append`, not a captured `push`: appending with `push` STORES at the index, and a store
+ *  walks the prototype chain for a setter, so an accessor installed at an array index receives each
+ *  element as it is appended and can define something else in its place. The lists built here become
+ *  a message's signed attributes, its certificate set and its signer infos. `append` defines the
+ *  index on the array itself. */
+var _push = intrinsic.append;
 /** @internal `resolve` and `all` build their promise from the RECEIVER, so reading the global binding
  *  at the call hands the construction to whatever that binding holds. Each signer's digest and
  *  signature are awaited through one of these, and a replacement that settles without awaiting emits a
@@ -73,7 +79,11 @@ function _digest(digestName, content) {
 
 
 function _skiValue(cert) {
-  var ext = (cert.extensions || []).filter(function (e) { return e.oid === OID_SKI; })[0];
+  /** @internal The selection returns the first matching row or null, because `filter(...)[0]` indexes
+   *  a result that is EMPTY when the extension is absent, and index 0 of an empty array answers from
+   *  the array prototype: the refusal below would then not be reached for a certificate that carries
+   *  no SKI. */
+  var ext = guard.list.firstMatch(cert.extensions || [], function (e) { return e.oid === OID_SKI; });
   if (!ext) throw _err("cms/no-ski", "a subjectKeyIdentifier signer identifier requires the signer certificate to carry an SKI extension");
   try { return asn1.read.octetString(asn1.decode(ext.value)); }
   catch (e) { throw _err("cms/no-ski", "the signer certificate's subjectKeyIdentifier extension value is not an OCTET STRING", e); }
@@ -216,10 +226,10 @@ async function _finishSignerInfo(rc, md, content, eContentType, opts) {
       { type: O("contentType"), values: [b.oid(eContentType)] },
       { type: O("messageDigest"), values: [b.octetString(md)] },
     ];
-    if (opts.signingTime !== false) intrinsic.push(pairs, { type: O("signingTime"), values: [_timeValue(opts.signingTime)] });
+    if (opts.signingTime !== false) _push(pairs, { type: O("signingTime"), values: [_timeValue(opts.signingTime)] });
     var apOid = cms.algorithmProtectionOid(opts.algorithmProtection, _err);
     if (apOid) {
-      intrinsic.push(pairs, _algorithmProtectionPair(apOid,
+      _push(pairs, _algorithmProtectionPair(apOid,
         rc.scheme.digestAlgId, rc.scheme.sigAlgId, 1));
     }
     pairs = intrinsic.concat(pairs, _resolveAttrPairs(opts.additionalSignedAttributes, "a signed attribute value"));
@@ -230,10 +240,13 @@ async function _finishSignerInfo(rc, md, content, eContentType, opts) {
   var sig = await signScheme.signOverTbs(rc.scheme, rc.soKey, signedBytes, _signE);
   await _assertKeyMatchesSpki(rc.keyOnly, rc.soKey, rc.soSpki, rc.scheme, sig, signedBytes, rc.cert);
   var fields = [b.integer(BigInt(rc.version)), rc.sid, rc.scheme.digestAlgId];
-  if (toSign.wire) intrinsic.push(fields, toSign.wire);
-  intrinsic.push(fields, rc.scheme.sigAlgId, b.octetString(sig));
+  if (toSign.wire) _push(fields, toSign.wire);
+  /** @internal Two appends, because `append` takes one value where `push` took many: the algorithm
+   *  identifier and the signature it describes are adjacent fields of the same SignerInfo. */
+  _push(fields, rc.scheme.sigAlgId);
+  _push(fields, b.octetString(sig));
   var ua = _buildUnsignedAttrs(opts.unsignedAttributes);
-  if (ua) intrinsic.push(fields, ua);
+  if (ua) _push(fields, ua);
   return { si: b.sequence(fields), digestAlgId: rc.scheme.digestAlgId, version: rc.version, certDer: rc.certDer };
 }
 
@@ -367,7 +380,7 @@ async function _signStream(stream, signers, opts) {
   if (opts.signingTime != null && opts.signingTime !== false) guard.time.assertEncodable(opts.signingTime, _err, "cms/bad-input", "signingTime");
   var rcs = intrinsic.map(list, function (s) { return _resolveSignerContext(s, opts); });
   var digestNames = [], seenDigest = intrinsic.create(null);
-  intrinsic.forEach(rcs, function (r) { if (!seenDigest[r.scheme.digest]) { seenDigest[r.scheme.digest] = 1; intrinsic.push(digestNames, r.scheme.digest); } });
+  intrinsic.forEach(rcs, function (r) { if (!seenDigest[r.scheme.digest]) { seenDigest[r.scheme.digest] = 1; _push(digestNames, r.scheme.digest); } });
   var wcNames = intrinsic.map(digestNames, function (n) { return DIGEST_HASH[n]; });
   var digests;
   try {
@@ -379,7 +392,7 @@ async function _signStream(stream, signers, opts) {
   intrinsic.forEach(digestNames, function (n, i) { byName[n] = intrinsic.bufferFrom(digests[i]); });
   var built = [];
   for (var _ip = 0; _ip < rcs.length; _ip++) {
-    intrinsic.push(built, await _finishSignerInfo(rcs[_ip], byName[rcs[_ip].scheme.digest], null, eContentType, opts));
+    _push(built, await _finishSignerInfo(rcs[_ip], byName[rcs[_ip].scheme.digest], null, eContentType, opts));
   }
   return _assembleSignedData(built, eContentType, opts, null);
 }
@@ -420,19 +433,19 @@ function _sign(content, signers, opts) {
 
 function _assembleSignedData(built, eContentType, opts, contentBuf) {
   var seen = intrinsic.create(null), digestAlgs = [];
-  intrinsic.forEach(built, function (x) { var k = intrinsic.bufToString(x.digestAlgId, "hex"); if (!seen[k]) { seen[k] = 1; intrinsic.push(digestAlgs, x.digestAlgId); } });
+  intrinsic.forEach(built, function (x) { var k = intrinsic.bufToString(x.digestAlgId, "hex"); if (!seen[k]) { seen[k] = 1; _push(digestAlgs, x.digestAlgId); } });
   var v3 = intrinsic.some(built, function (x) { return x.version === 3; }) || eContentType !== OID_DATA;
   var version = v3 ? 3 : 1;
   var encapFields = [b.oid(eContentType)];
-  if (!opts.detached) intrinsic.push(encapFields, b.explicit(0, b.octetString(contentBuf)));
+  if (!opts.detached) _push(encapFields, b.explicit(0, b.octetString(contentBuf)));
   var encap = b.sequence(encapFields);
   var sdFields = [b.integer(BigInt(version)), b.set(digestAlgs), encap];
   if (opts.certificates !== false) {
     var certDers = intrinsic.sort(_dedupe(intrinsic.filter(intrinsic.map(built, function (x) { return x.certDer; }),
       function (d) { return d != null; })), intrinsic.compare);
-    if (certDers.length) intrinsic.push(sdFields, b.contextConstructed(0, intrinsic.bufferConcat(certDers)));
+    if (certDers.length) _push(sdFields, b.contextConstructed(0, intrinsic.bufferConcat(certDers)));
   }
-  intrinsic.push(sdFields, b.set(intrinsic.map(built, function (x) { return x.si; })));
+  _push(sdFields, b.set(intrinsic.map(built, function (x) { return x.si; })));
   var signedData = b.sequence(sdFields);
   var contentInfo = b.sequence([b.oid(OID_SIGNED_DATA), b.explicit(0, signedData)]);
   return opts.pem ? pkix.pemEncode(contentInfo, "CMS", frameworkError.PemError) : contentInfo;
@@ -450,7 +463,7 @@ function _digestAlgIdentifier(der) {
 
 function _dedupe(ders) {
   var seen = intrinsic.create(null), out = [];
-  intrinsic.forEach(ders, function (d) { var k = intrinsic.bufToString(d, "hex"); if (!seen[k]) { seen[k] = 1; intrinsic.push(out, d); } });
+  intrinsic.forEach(ders, function (d) { var k = intrinsic.bufToString(d, "hex"); if (!seen[k]) { seen[k] = 1; _push(out, d); } });
   return out;
 }
 
@@ -496,9 +509,9 @@ function certsOnly(certs, opts) {
   var crlDers = intrinsic.sort(_dedupe(intrinsic.map(crlList, function (c) { return _normEntityDer(c, "a CRL", "X509 CRL", _parseCrl); })), intrinsic.compare);
   var encap = b.sequence([b.oid(OID_DATA)]);
   var sdFields = [b.integer(1n), b.set([]), encap];
-  if (certDers.length) intrinsic.push(sdFields, b.contextConstructed(0, intrinsic.bufferConcat(certDers)));
-  if (crlDers.length) intrinsic.push(sdFields, b.contextConstructed(1, intrinsic.bufferConcat(crlDers)));
-  intrinsic.push(sdFields, b.set([]));
+  if (certDers.length) _push(sdFields, b.contextConstructed(0, intrinsic.bufferConcat(certDers)));
+  if (crlDers.length) _push(sdFields, b.contextConstructed(1, intrinsic.bufferConcat(crlDers)));
+  _push(sdFields, b.set([]));
   var signedData = b.sequence(sdFields);
   var contentInfo = b.sequence([b.oid(OID_SIGNED_DATA), b.explicit(0, signedData)]);
   return opts.pem ? pkix.pemEncode(contentInfo, "CMS", frameworkError.PemError) : contentInfo;
@@ -512,7 +525,7 @@ function _toBuf(v, what) {
 
 function _resolveSignerIndices(spec, n) {
   if (spec == null) { if (n < 1) throw _err("cms/bad-input", "the SignedData carries no SignerInfo to countersign"); return [0]; }
-  if (spec === "all") { var all = []; for (var i = 0; i < n; i++) all.push(i); return all; }
+  if (spec === "all") { var all = []; for (var i = 0; i < n; i++) _push(all, i); return all; }
   var arr = Array.isArray(spec) ? spec : [spec];
   if (!arr.length) throw _err("cms/bad-input", "signerIndex must select at least one signer");
   arr.forEach(function (i) { if (typeof i !== "number" || !Number.isInteger(i) || i < 0 || i >= n) throw _err("cms/bad-input", "signerIndex out of range: " + i); });
@@ -534,10 +547,10 @@ function _buildCountersignature(targetSigOctets, countersigner, opts) {
     if (opts.signedAttributes === false) return null;
     return intrinsic.chain(_digest(scheme.digest, targetSigOctets), function (md) {
       var pairs = [{ type: O("messageDigest"), values: [b.octetString(md)] }];
-      if (opts.signingTime !== false) pairs.push({ type: O("signingTime"), values: [_timeValue(opts.signingTime)] });
+      if (opts.signingTime !== false) _push(pairs, { type: O("signingTime"), values: [_timeValue(opts.signingTime)] });
       var csApOid = cms.algorithmProtectionOid(opts.algorithmProtection, _err);
       if (csApOid) {
-        intrinsic.push(pairs, _algorithmProtectionPair(csApOid, scheme.digestAlgId, scheme.sigAlgId, 1));
+        _push(pairs, _algorithmProtectionPair(csApOid, scheme.digestAlgId, scheme.sigAlgId, 1));
       }
       var extra = _resolveAttrPairs(opts.additionalSignedAttributes, "a countersignature signed attribute value");
       extra.forEach(function (p) { if (p.type === O("contentType")) throw _err("cms/bad-input", "a countersignature must not carry a content-type attribute (RFC 5652 sec. 11.4)"); });
@@ -556,8 +569,9 @@ function _buildCountersignature(targetSigOctets, countersigner, opts) {
       });
       return intrinsic.chain(selfChecked, function () {
         var fields = [b.integer(BigInt(sidv.version)), sidv.sid, scheme.digestAlgId];
-        if (attrs) fields.push(attrs.wire);
-        fields.push(scheme.sigAlgId, b.octetString(sig));
+        if (attrs) _push(fields, attrs.wire);
+        _push(fields, scheme.sigAlgId);
+        _push(fields, b.octetString(sig));
         return { value: b.sequence(fields), certDer: certDer, digestAlgId: scheme.digestAlgId };
       });
     });
@@ -568,13 +582,17 @@ function _mergeCountersig(uaNode, newCsValues) {
   var CS = O("countersignature");
   var others = [], csValues = [];
   if (uaNode) uaNode.children.forEach(function (attr) {
-    if (asn1.read.oid(attr.children[0]) === CS) attr.children[1].children.forEach(function (v) { csValues.push(v.bytes); });
-    else others.push(attr.bytes);
+    if (asn1.read.oid(attr.children[0]) === CS) intrinsic.forEach(attr.children[1].children, function (v) { _push(csValues, v.bytes); });
+    else _push(others, attr.bytes);
   });
-  newCsValues.forEach(function (v) { csValues.push(v); });
+  intrinsic.forEach(newCsValues, function (v) { _push(csValues, v); });
   var csAttr = b.sequence([b.oid(CS), b.set(csValues)]);
-  var setOf = b.set(others.concat([csAttr]));
-  var wire = Buffer.from(setOf); wire[0] = 0xA1;
+  /** @internal `concatList`, not `concat`: `Array.prototype.concat` builds its result through the
+   *  species constructor, so a species answering with a Proxy intercepted the countersignature
+   *  attribute as it was inserted and the merged value went out without it. `concatList` copies own
+   *  indexes into an array it made itself. */
+  var setOf = b.set(intrinsic.concatList(others, [csAttr]));
+  var wire = intrinsic.bufferFrom(setOf); wire[0] = 0xA1;
   return wire;
 }
 
@@ -583,7 +601,7 @@ function _appendCountersigs(siNode, newCsValues) {
   var last = kids[kids.length - 1];
   var hasUa = last.tagClass === "context" && last.tagNumber === 1;
   var base = (hasUa ? kids.slice(0, kids.length - 1) : kids).map(function (k) { return k.bytes; });
-  base.push(_mergeCountersig(hasUa ? last : null, newCsValues));
+  _push(base, _mergeCountersig(hasUa ? last : null, newCsValues));
   return b.sequence(base);
 }
 
@@ -603,7 +621,7 @@ function _spliceNested(siNode, j, newCsValues) {
   if (!found) throw _err("cms/bad-input", "the target signer carries no countersignature to countersign");
   var setOf = b.set(attrs); var wire = Buffer.from(setOf); wire[0] = 0xA1;
   var base = kids.slice(0, kids.length - 1).map(function (k) { return k.bytes; });
-  base.push(wire);
+  _push(base, wire);
   return b.sequence(base);
 }
 
@@ -619,7 +637,11 @@ function _targetPreimage(siNode, opts) {
   var last = siNode.children[siNode.children.length - 1];
   var CS = O("countersignature");
   if (!last || last.tagClass !== "context" || last.tagNumber !== 1) throw _err("cms/bad-input", "the target signer carries no countersignature to countersign");
-  var attr = last.children.filter(function (a) { return asn1.read.oid(a.children[0]) === CS; })[0];
+  /** @internal The selection returns the first matching attribute or null, because `filter(...)[0]`
+   *  indexes a result that is EMPTY when the signer carries no countersignature attribute, and index
+   *  0 of an empty array answers from the array prototype: the refusal below would then not be
+   *  reached and the signature bytes would be taken from whatever the accessor answered with. */
+  var attr = guard.list.firstMatch(last.children, function (a) { return asn1.read.oid(a.children[0]) === CS; });
   if (!attr) throw _err("cms/bad-input", "the target signer carries no countersignature to countersign");
   var values = attr.children[1].children;
   var j = opts.countersignatureOf;
@@ -653,15 +675,15 @@ function _countersign(cmsInput, signers, opts) {
   var jobs = [];
   targets.forEach(function (t) {
     var preimage = _targetPreimage(siSet.children[t], opts);
-    list.forEach(function (cs) { jobs.push({ t: t, p: _buildCountersignature(preimage, cs, opts) }); });
+    intrinsic.forEach(list, function (cs) { _push(jobs, { t: t, p: _buildCountersignature(preimage, cs, opts) }); });
   });
   return intrinsic.chain(intrinsic.allOf(intrinsic.mapList(jobs, function (j) { return j.p; })), function (built) {
     var byTarget = intrinsic.create(null), certDers = [], csDigestAlgs = [];
     intrinsic.forEach(built, function (res, i) {
       var slot = byTarget[jobs[i].t] || (byTarget[jobs[i].t] = []);
-      intrinsic.push(slot, res.value);
-      intrinsic.push(certDers, res.certDer);
-      intrinsic.push(csDigestAlgs, res.digestAlgId);
+      _push(slot, res.value);
+      _push(certDers, res.certDer);
+      _push(csDigestAlgs, res.digestAlgId);
     });
 
     var newSiSet = b.set(siSet.children.map(function (siNode, idx) {
@@ -675,8 +697,8 @@ function _countersign(cmsInput, signers, opts) {
       else if (sdKids[i].tagClass === "context" && sdKids[i].tagNumber === 1) crlsNode = sdKids[i];
     }
     var existing = [];
-    if (certsNode) certsNode.children.forEach(function (c) { existing.push(c.bytes); });
-    if (opts.certificates !== false) certDers.forEach(function (d) { existing.push(d); });
+    if (certsNode) intrinsic.forEach(certsNode.children, function (c) { _push(existing, c.bytes); });
+    if (opts.certificates !== false) intrinsic.forEach(certDers, function (d) { _push(existing, d); });
     /** @internal The DER SET ordering through the captured copy, sort AND comparator: read off its own
      * home, any of the three decides which certificate lands where in the set this message carries. */
     var allCerts = guard.list.sortedCopy(_dedupe(existing), intrinsic.compare);
@@ -693,20 +715,20 @@ function _countersign(cmsInput, signers, opts) {
      * comparison would list it a second time. */
     var listed = [];
     intrinsic.forEach(intrinsic.isArray(parsed.digestAlgorithms) ? parsed.digestAlgorithms : [],
-      function (a) { intrinsic.push(listed, a); });
+      function (a) { _push(listed, a); });
     var digestAlgs = intrinsic.map(sdKids[1].children, function (d) { return d.bytes; });
     intrinsic.forEach(csDigestAlgs, function (der) {
       var info = _digestAlgIdentifier(der);
       var already = false;
       intrinsic.forEach(listed, function (alg) { if (cms.sameDigestAlgorithm(alg, info)) already = true; });
       if (already) return;
-      intrinsic.push(listed, info);
-      intrinsic.push(digestAlgs, der);
+      _push(listed, info);
+      _push(digestAlgs, der);
     });
     var newSdFields = [sdKids[0].bytes, b.set(digestAlgs), sdKids[2].bytes];
-    if (allCerts.length) newSdFields.push(b.contextConstructed(0, Buffer.concat(allCerts)));
-    if (crlsNode) newSdFields.push(crlsNode.bytes);
-    newSdFields.push(newSiSet);
+    if (allCerts.length) _push(newSdFields, b.contextConstructed(0, intrinsic.bufferConcat(allCerts)));
+    if (crlsNode) _push(newSdFields, crlsNode.bytes);
+    _push(newSdFields, newSiSet);
     var newCi = b.sequence([root.children[0].bytes, b.explicit(0, b.sequence(newSdFields))]);
     return opts.pem ? pkix.pemEncode(newCi, "CMS", frameworkError.PemError) : newCi;
   });
@@ -732,7 +754,7 @@ function _appendUnsignedAttr(siNode, attrDer) {
   var existing = hasUa ? intrinsic.map(last.children, function (a) { return a.bytes; }) : [];
   var setOf = b.set(intrinsic.concat(existing, [attrDer]));
   var wire = intrinsic.bufferFrom(setOf); wire[0] = 0xA1;
-  intrinsic.push(base, wire);
+  _push(base, wire);
   return b.sequence(base);
 }
 
@@ -955,7 +977,7 @@ function _attachTimestamp(input, token, opts) {
   }));
   var sdKids = t.sd.children;
   var newSdFields = intrinsic.map(intrinsic.arraySlice(sdKids, 0, sdKids.length - 1), function (k) { return k.bytes; });
-  intrinsic.push(newSdFields, newSiSet);
+  _push(newSdFields, newSiSet);
   var out = b.sequence([t.root.children[0].bytes, b.explicit(0, b.sequence(newSdFields))]);
   return opts.pem ? pkix.pemEncode(out, "CMS", frameworkError.PemError) : out;
 }

package/lib/cms-verify.js

@@ -203,7 +203,11 @@ function _preferBoundCandidate(si, candidates) {
 }
 
 function _certSki(cert) {
-  var ext = (cert.extensions || []).filter(function (e) { return e.oid === oid.byName("subjectKeyIdentifier"); })[0];
+  /** @internal The selection returns the first matching row or null. `filter(...)[0]` indexes a
+   *  result that is EMPTY when the extension is absent, and index 0 of an empty array answers from
+   *  the array prototype, so a value installed there reads at the test below as an extension the
+   *  certificate does not carry. */
+  var ext = guard.list.firstMatch(cert.extensions || [], function (e) { return e.oid === oid.byName("subjectKeyIdentifier"); });
   if (!ext) return null;
   try {
     return asn1.read.octetString(asn1.decode(ext.value));
@@ -359,7 +363,7 @@ async function _computeCountersigBytes(si, csTarget) {
     attrs = _decodeSignedAttrs(reTagged);
   } catch (e) { if (e instanceof CmsError) throw e; throw _err("cms/bad-signed-attrs", "the countersignature signedAttrs is not a valid SET OF Attribute", e); }
   if (intrinsic.filter(attrs, function (a) { return a.type === OID_CONTENT_TYPE; }).length) throw _err("cms/misplaced-attr", "a countersignature must not carry a content-type attribute (RFC 5652 sec. 11.4)");
-  var mdAttr = intrinsic.filter(attrs, function (a) { return a.type === OID_MESSAGE_DIGEST; })[0];
+  var mdAttr = guard.list.firstMatch(attrs, function (a) { return a.type === OID_MESSAGE_DIGEST; });
   if (!mdAttr || mdAttr.values.length !== 1) throw _err("cms/bad-signed-attrs", "a countersignature's signedAttrs must carry exactly one message-digest attribute (RFC 5652 sec. 11.4)");
   var declared;
   try {
@@ -402,7 +406,7 @@ async function _computeSignedBytes(si, content, eContentType, digestByName) {
     ctOid = asn1.read.oid(ctAttr[0].values[0]);
   } catch (e) { throw _err("cms/bad-signed-attrs", "the content-type attribute value is not an OBJECT IDENTIFIER", e); }
   if (ctOid !== eContentType) return { mismatch: { code: "cms/content-type-mismatch", message: "the content-type signed attribute does not match the SignedData eContentType (RFC 5652 sec. 5.3)" } };
-  var mdAttr = intrinsic.filter(attrs, function (a) { return a.type === OID_MESSAGE_DIGEST; })[0];
+  var mdAttr = guard.list.firstMatch(attrs, function (a) { return a.type === OID_MESSAGE_DIGEST; });
   if (!mdAttr || mdAttr.values.length !== 1) throw _err("cms/bad-signed-attrs", "signedAttrs must carry exactly one message-digest attribute (RFC 5652 sec. 5.4)");
   var declared;
   try {
@@ -1172,7 +1176,7 @@ var _permitsSigning = pkix.keyUsagePermits(pkix.makeNS("cms", CmsError, oid),
   ["digitalSignature", "contentCommitment", "nonRepudiation"]);
 
 function _keyUsagePermitsSigning(parsedCerts, der) {
-  var entry = intrinsic.filter(parsedCerts, function (c) { return intrinsic.bufferEquals(c.der, der); })[0];
+  var entry = guard.list.firstMatch(parsedCerts, function (c) { return intrinsic.bufferEquals(c.der, der); });
   if (!entry) return true;
   return _permitsSigning(entry.cert);
 }

package/lib/crl-sign.js

@@ -24,6 +24,9 @@ var x509Schema = require("./schema-x509");
 var signScheme = require("./sign-scheme");
 var guard = require("./guard-all");
 var intrinsic = require("./guard-intrinsic");
+/** @internal The append every list here is built with: `push` stores at the index and a store
+ *  consults a setter inherited there, and these lists become the bytes that get signed. */
+var _push = intrinsic.append;
 var _hasOwn = intrinsic.hasOwn, _bufferEquals = intrinsic.bufferEquals;
 var _arrSlice = intrinsic.arraySlice, _promiseResolve = intrinsic.uncurry(intrinsic.promiseResolve);
 /** @internal The RECEIVER for the captured `Promise.resolve`, captured too. `resolve` builds through
@@ -184,11 +187,11 @@ function _idpValue(idp) {
   if (idp.fullName != null) {
     var entries = Array.isArray(idp.fullName) ? pkiBuild.reqDenseArray(idp.fullName, "issuingDistributionPoint.fullName", _err, "crl/bad-idp") : [idp.fullName];
     if (!entries.length) throw _err("crl/bad-idp", "issuingDistributionPoint fullName must carry at least one GeneralName");
-    children.push(b.contextConstructed(0, b.contextConstructed(0, Buffer.concat(entries.map(_encodeGeneralName)))));
+    _push(children,b.contextConstructed(0, b.contextConstructed(0, Buffer.concat(entries.map(_encodeGeneralName)))));
   }
   var scopeTrue = 0;
-  if (idp.onlyContainsUserCerts === true) { children.push(b.contextPrimitive(1, Buffer.from([0xff]))); scopeTrue++; }
-  if (idp.onlyContainsCACerts === true) { children.push(b.contextPrimitive(2, Buffer.from([0xff]))); scopeTrue++; }
+  if (idp.onlyContainsUserCerts === true) { _push(children,b.contextPrimitive(1, Buffer.from([0xff]))); scopeTrue++; }
+  if (idp.onlyContainsCACerts === true) { _push(children,b.contextPrimitive(2, Buffer.from([0xff]))); scopeTrue++; }
   if (idp.indirectCRL === true) throw _err("crl/bad-idp", _INDIRECT_IDP_DEFERRED);
   if (scopeTrue > 1) throw _err("crl/bad-idp", "at most one of onlyContainsUserCerts / onlyContainsCACerts may be TRUE (RFC 5280 sec. 5.2.5)");
   if (!children.length) throw _err("crl/bad-idp", "issuingDistributionPoint MUST NOT be empty (RFC 5280 sec. 5.2.5)");
@@ -232,7 +235,7 @@ function _buildCrlExtensions(spec, ctx) {
     var id = O(oidName);
     if (seen[id]) throw _err("crl/bad-input", "duplicate CRL extension " + oidName + " (RFC 5280 sec. 5.2 -- at most one instance)");
     seen[id] = true;
-    out.push(_ext(id, critical, valueDer));
+    _push(out,_ext(id, critical, valueDer));
   }
   var crlNumberVal = null;
   if (spec.crlNumber != null) { var cn = _boundedInteger(spec.crlNumber, "cRLNumber"); crlNumberVal = cn.value; push("cRLNumber", false, cn.tlv); }
@@ -264,7 +267,7 @@ function _buildCrlExtensions(spec, ctx) {
       }
       _assertExtensionValueDecodes(node, extnId, "extension");
       if (extnId === O("deltaCRLIndicator")) isDelta = true;
-      out.push(b.raw(der));
+      _push(out,b.raw(der));
     });
     if (isDelta) {
       if (seen[O("freshestCRL")]) throw _err("crl/bad-input", "freshestCRL MUST NOT appear in a delta CRL (RFC 5280 sec. 5.2.6)");
@@ -323,7 +326,7 @@ function _buildRevoked(entryList, isDelta) {
       var id = O(oidName);
       if (seen[id]) throw _err("crl/bad-input", "duplicate entry extension " + oidName + " in revoked entry [" + idx + "]");
       seen[id] = true;
-      entryExts.push(_ext(id, critical, valueDer));
+      _push(entryExts,_ext(id, critical, valueDer));
     }
     if (e.reason != null) {
       var codeNum = _resolveReason(e.reason, isDelta);
@@ -360,10 +363,10 @@ function _buildRevoked(entryList, isDelta) {
           }
         }
         _assertExtensionValueDecodes(xnode, extnId, "entry extension");
-        entryExts.push(b.raw(der));
+        _push(entryExts,b.raw(der));
       });
     }
-    if (entryExts.length) { anyExt = true; children.push(b.sequence(entryExts)); }
+    if (entryExts.length) { anyExt = true; _push(children,b.sequence(entryExts)); }
     return b.sequence(children);
   });
   return { entries: entries, anyExt: anyExt };
@@ -375,7 +378,11 @@ function _parseIssuerCert(cert) {
 }
 
 function _assertIssuerCanSignCrl(issuerCert) {
-  var kuExt = (issuerCert.extensions || []).filter(function (e) { return e.oid === O("keyUsage"); })[0];
+  /** @internal The selection returns the first matching row or null. `filter(...)[0]` indexes a
+   *  result that is EMPTY when the certificate carries no keyUsage, and index 0 of an empty array
+   *  answers from the array prototype, so a value installed there would be decoded as the issuer's
+   *  key usage and decide whether it may sign this CRL. */
+  var kuExt = guard.list.firstMatch(issuerCert.extensions || [], function (e) { return e.oid === O("keyUsage"); });
   if (!kuExt) return;
   var ku;
   try { ku = EXT_DECODERS[O("keyUsage")](kuExt.value); }
@@ -453,13 +460,13 @@ function _sign(spec, issuer, opts) {
    *  into the PreTBSCertList the alternative signature covers. */
   function tbsOver(extList, omitSignatureAlg) {
     var tbsChildren = [];
-    if (version === 2) tbsChildren.push(b.integer(1n));
-    if (omitSignatureAlg !== true) tbsChildren.push(scheme.sigAlgId);
-    tbsChildren.push(issuerDer);
-    tbsChildren.push(thisU);
-    if (nextU) tbsChildren.push(nextU);
-    if (revoked.entries.length) tbsChildren.push(b.sequence(revoked.entries));
-    if (extList.length) tbsChildren.push(b.explicit(0, b.sequence(extList)));
+    if (version === 2) _push(tbsChildren,b.integer(1n));
+    if (omitSignatureAlg !== true) _push(tbsChildren,scheme.sigAlgId);
+    _push(tbsChildren,issuerDer);
+    _push(tbsChildren,thisU);
+    if (nextU) _push(tbsChildren,nextU);
+    if (revoked.entries.length) _push(tbsChildren,b.sequence(revoked.entries));
+    if (extList.length) _push(tbsChildren,b.explicit(0, b.sequence(extList)));
     return b.sequence(tbsChildren);
   }
 
@@ -813,7 +820,7 @@ function isRevoked(crl, serialNumber, opts) {
 
 function _findExtOid(list, name) {
   var want = O(name);
-  return (list || []).filter(function (e) { return e.oid === want; })[0] || null;
+  return guard.list.firstMatch(list || [], function (e) { return e.oid === want; });
 }
 
 var _IDP_SCHEMA = pkix.issuingDistributionPoint("crl/scope-not-authoritative");

package/lib/csr-sign.js

@@ -26,6 +26,9 @@ var pkiBuild = require("./pki-build");
 var frameworkError = require("./framework-error");
 var guard = require("./guard-all");
 var intrinsic = require("./guard-intrinsic");
+/** @internal The append every list here is built with: `push` stores at the index and a store
+ *  consults a setter inherited there, and these lists become the bytes that get signed. */
+var _push = intrinsic.append;
 /** @internal The promise a self-check is awaited through, built from the constructor captured at load.
  *  `Promise.resolve` builds from its RECEIVER, so reading the global binding at the call hands the
  *  construction to whatever that binding holds, and a constructor settling without awaiting its
@@ -224,7 +227,7 @@ function _sign(spec, key, opts) {
   function addAttr(attrType, valueTlv) {
     if (seenAttr[attrType]) throw _err("csr/bad-input", "duplicate " + (oid.name(attrType) || attrType) + " attribute");
     seenAttr[attrType] = true;
-    attrs.push(b.sequence([b.oid(attrType), b.set([valueTlv])]));
+    _push(attrs,b.sequence([b.oid(attrType), b.set([valueTlv])]));
   }
   if (spec.extensionRequest != null) addAttr(O("extensionRequest"), _buildRequestedExtensions(spec.extensionRequest, subjectSpki));
   if (spec.challengePassword != null) addAttr(O("challengePassword"), _challengePassword(spec.challengePassword));
@@ -259,7 +262,7 @@ function _sign(spec, key, opts) {
       if (!n.children[1].children || n.children[1].children.length === 0) throw _err("csr/bad-input", "pre-encoded attribute [" + i + "] value SET must contain at least one value (RFC 2986 SET SIZE(1..MAX))");
       if (seenAttr[at]) throw _err("csr/bad-input", "duplicate " + (oid.name(at) || at) + " attribute");
       seenAttr[at] = true;
-      attrs.push(b.raw(der));
+      _push(attrs,b.raw(der));
     });
   }
 

package/lib/ct.js

@@ -64,6 +64,7 @@ var _bufferCompare = intrinsic.compare;
 var _subarray = intrinsic.subarray;
 var _toLowerCase = intrinsic.toLowerCase;
 var _ctTrim = intrinsic.uncurry(String.prototype.trim);
+var _writeBigUInt64BE = intrinsic.uncurry(Buffer.prototype.writeBigUInt64BE);
 var _bufCopy = intrinsic.uncurry(Buffer.prototype.copy);
 var _writeU64BE = intrinsic.uncurry(Buffer.prototype.writeBigUInt64BE);
 var _searchSet = intrinsic.uncurry(URLSearchParams.prototype.set);
@@ -293,8 +294,11 @@ function parseSctList(extValue) {
     }
     sctCount.tick();
     var one = _parseSct(outer.subReader(sctLen, "ct/list-trailing-bytes"), sctLen);
-    if (one.unknown) { var u = { version: one.version, rawSct: one.rawSct }; unknownScts.push(u); all.push(u); }
-    else { scts.push(one); all.push(one); }
+    /** @internal The parsed timestamps are appended by defining their indexes: the lists a caller
+     *  reads its verdict from, and the `all` list a policy counts, are what a numeric setter on the
+     *  array prototype would otherwise take an entry out of. */
+    if (one.unknown) { var u = { version: one.version, rawSct: one.rawSct }; intrinsic.append(unknownScts, u); intrinsic.append(all, u); }
+    else { intrinsic.append(scts, one); intrinsic.append(all, one); }
   }
   return guard.verdict.of({ scts: scts, unknownScts: unknownScts, all: all });
 }
@@ -366,29 +370,36 @@ function reconstructSignedData(entry, sct) {
     throw new CtError("ct/bad-input", "reconstructSignedData expects a decoded v1 SCT from parseSctList().scts[]");
   }
   var tsVal = guard.range.uint64(sct.timestamp, _ctErr, "ct/bad-input", "sct.timestamp (RFC 6962 3.2)");
+  /** @internal EVERY component of this preimage is appended by defining its index, and the
+   *  concatenation is the captured one. These bytes are what a log's signature is verified over, so a
+   *  numeric setter inherited from the array prototype replacing any one of them, the version, the
+   *  signature type, the timestamp, the entry type, the certificate or the extensions, puts the
+   *  verification on bytes the log never signed. Converting only the timestamp left the rest open,
+   *  which is the whole class: the rule belongs to the function, not to the line it was found on. */
   var parts = [];
-  parts.push(_bufferFrom([sct.version & 0xff]));
-  parts.push(_bufferFrom([0]));
-  var ts = _bufferAlloc(8); ts.writeBigUInt64BE(tsVal); parts.push(ts);
-  parts.push(_bufferFrom([(entryType >> 8) & 0xff, entryType & 0xff]));
+  intrinsic.append(parts, _bufferFrom([sct.version & 0xff]));
+  intrinsic.append(parts, _bufferFrom([0]));
+  var ts = _bufferAlloc(8); _writeBigUInt64BE(ts, tsVal); intrinsic.append(parts, ts);
+  intrinsic.append(parts, _bufferFrom([(entryType >> 8) & 0xff, entryType & 0xff]));
   if (entryType === 0) {
     var cert = _toBuffer(entry.leafCert, "leafCert", undefined, undefined, 0xffffff, "ct/bad-tbs-length");
-    parts.push(_u24Bytes(cert.length)); parts.push(cert);
+    intrinsic.append(parts, _u24Bytes(cert.length)); intrinsic.append(parts, cert);
   } else {
     var ikh = _toBuffer(entry.issuerKeyHash, "issuerKeyHash");
     if (ikh.length !== 32) {
       throw new CtError("ct/bad-issuer-key-hash", "issuer_key_hash must be exactly 32 bytes (SHA-256 of the issuer SPKI), got " + ikh.length + " (RFC 6962 sec. 3.2)");
     }
     var tbs = _toBuffer(entry.tbsCertificate, "tbsCertificate", undefined, undefined, 0xffffff, "ct/bad-tbs-length");
-    parts.push(ikh);
-    parts.push(_u24Bytes(tbs.length)); parts.push(tbs);
+    intrinsic.append(parts, ikh);
+    intrinsic.append(parts, _u24Bytes(tbs.length)); intrinsic.append(parts, tbs);
   }
   var ext = _toBuffer(sct.extensions, "sct.extensions", undefined, undefined, 0xffff, "ct/bad-extensions");
   if (ext.length > 0xffff) {
     throw new CtError("ct/bad-extensions", "CtExtensions must be 0..65535 bytes, got " + ext.length + " (RFC 6962 3.2)");
   }
-  parts.push(_bufferFrom([(ext.length >> 8) & 0xff, ext.length & 0xff])); parts.push(ext);
-  return Buffer.concat(parts);
+  intrinsic.append(parts, _bufferFrom([(ext.length >> 8) & 0xff, ext.length & 0xff]));
+  intrinsic.append(parts, ext);
+  return intrinsic.bufferConcat(parts);
 }
 
 var CT_HASH = intrinsic.assign(intrinsic.create(null), { sha256: "SHA-256" });
@@ -584,7 +595,7 @@ function encodeSctList(scts) {
     var el = ew.build();
     total += el.length;
     if (total > 0xffff) throw new CtError("ct/too-large", "the SCT list body exceeds the 65535-byte maximum (RFC 6962 sec. 3.3)");
-    elements.push(el);
+    intrinsic.append(elements, el);
   }
   var lw = new TlsWriter();
   lw.vector(2, 1, 0xffff, Buffer.concat(elements, total), "ct/too-large");
@@ -803,7 +814,7 @@ function parseLogList(json, opts) {
           continue;
         }
         byLogId[rec.logIdHex] = rec;
-        logs.push(rec);
+        intrinsic.append(logs, rec);
       }
     }
   }
@@ -1092,13 +1103,13 @@ function x509CertEntry(cert, issuer) {
   for (var j = 0; j < extsSeq.children.length; j++) {
     var ext = extsSeq.children[j];
     if (ext.children[0] && intrinsic.bufferEquals(ext.children[0].bytes, sctOid)) { removed++; continue; }
-    intrinsic.push(kept, ext.bytes);
+    intrinsic.append(kept, ext.bytes);
   }
   if (removed === 0) throw _ctErr("ct/no-sct-extension", "the certificate carries no signedCertificateTimestampList extension (RFC 6962 sec. 3.2)");
   var tbsChildren = [];
   for (var k = 0; k < tbs.children.length; k++) {
-    if (k !== wrapIdx) { intrinsic.push(tbsChildren, tbs.children[k].bytes); continue; }
-    if (kept.length > 0) intrinsic.push(tbsChildren, asn1.build.explicit(3, asn1.build.sequence(kept)));
+    if (k !== wrapIdx) { intrinsic.append(tbsChildren, tbs.children[k].bytes); continue; }
+    if (kept.length > 0) intrinsic.append(tbsChildren, asn1.build.explicit(3, asn1.build.sequence(kept)));
   }
   var issuerKeyHash = nodeCrypto.createHash("sha256").update(issSpki).digest();
   return { entryType: 1, tbsCertificate: asn1.build.sequence(tbsChildren), issuerKeyHash: issuerKeyHash };