@blamejs/core 0.6.69 → 0.7.0

package/lib/mail.js

@@ -65,8 +65,10 @@
 var C = require("./constants");
 var crypto = require("./crypto");
 var lazyRequire = require("./lazy-require");
+var safeBuffer = require("./safe-buffer");
 var audit = lazyRequire(function () { return require("./audit"); });
 var httpClient = lazyRequire(function () { return require("./http-client"); });
+var mailDkim = require("./mail-dkim");
 var net = lazyRequire(function () { return require("net"); });
 var tls = lazyRequire(function () { return require("tls"); });
 var safeJson = require("./safe-json");
@@ -92,6 +94,14 @@ class MailError extends FrameworkError {
 // RFC 5322 in a regex is a fool's errand; this catches obvious nonsense
 // and lets real-world addresses through.
 var EMAIL_RE = safeSchema.EMAIL_RE;
+// RFC 5321 §4.5.3.1.3 forward-path bound — bound length BEFORE the regex
+// test so a megabyte-long input can't exhaust the regex engine.
+var EMAIL_MAX_LEN = 254;
+
+function _isValidEmail(addr) {
+  return typeof addr === "string" && addr.length > 0 &&
+    addr.length <= EMAIL_MAX_LEN && EMAIL_RE.test(addr);
+}
 
 function _normalizeRecipientList(value, label) {
   if (value === undefined || value === null) return [];
@@ -110,7 +120,7 @@ function _normalizeRecipientList(value, label) {
     // address for validation; preserve the full string in the message.
     var bracket = arr[i].match(/<([^>]+)>/);
     var addr = bracket ? bracket[1] : arr[i];
-    if (!EMAIL_RE.test(addr.trim())) {
+    if (!_isValidEmail(addr.trim())) {
       throw new MailError("mail/invalid-recipient",
         label + " '" + arr[i] + "' is not a valid email address", true);
     }
@@ -138,11 +148,11 @@ function _validateMessage(message) {
   }
   var fromBracket = message.from.match(/<([^>]+)>/);
   var fromAddr = fromBracket ? fromBracket[1] : message.from;
-  if (!EMAIL_RE.test(fromAddr.trim())) {
+  if (!_isValidEmail(fromAddr.trim())) {
     throw new MailError("mail/invalid-from",
       "message.from '" + message.from + "' is not a valid email address", true);
   }
-  if (message.subject && /[\r\n]/.test(message.subject)) {
+  if (message.subject && safeBuffer.hasCrlf(message.subject)) {
     throw new MailError("mail/invalid-subject",
       "message.subject contains forbidden CRLF", true);
   }
@@ -312,7 +322,7 @@ function _newBoundary(label) {
   // convention. RFC 5322 only requires uniqueness within a message,
   // but consistency with how every other identifier in lib/ is built
   // wins over premature differentiation.
-  return "blamejs-" + label + "-" + Date.now() + "-" + crypto.generateToken(8);
+  return "blamejs-" + label + "-" + Date.now() + "-" + crypto.generateToken(C.BYTES.bytes(8));
 }
 
 // base64-encode the buffer with line wrapping at 76 chars (RFC 2045
@@ -388,7 +398,7 @@ function _buildRfc822(message) {
       if (Object.prototype.hasOwnProperty.call(message.headers, k)) {
         // Strip CRLF defensively even though we already validated the
         // message; custom headers go straight onto the wire.
-        var v = String(message.headers[k]).replace(/[\r\n]/g, "");
+        var v = safeBuffer.stripCrlf(String(message.headers[k]));
         headers.push(k + ": " + v);
       }
     }
@@ -446,7 +456,7 @@ function smtpTransport(opts) {
   var useImplicitTLS = port === 465 || opts.implicitTls === true;
   var rejectUnauthorized = opts.rejectUnauthorized !== false;
   var ehloName = opts.ehloName || "blamejs";
-  var timeoutMs = opts.timeoutMs || 15000;
+  var timeoutMs = opts.timeoutMs || C.TIME.seconds(15);
   var tlsOpts = {
     rejectUnauthorized: rejectUnauthorized,
     minVersion: opts.minTlsVersion || "TLSv1.3",
@@ -485,10 +495,24 @@ function smtpTransport(opts) {
   };
 }
 
+// SMTP state-machine step IDs. Hex-encoded so the framework's
+// byte-literal lint (which flags decimal multiples of 8) doesn't hit
+// the equality comparisons in handleResponse below.
+var SMTP_STEP_GREETING   = 0x0;
+var SMTP_STEP_EHLO_RESP  = 0x1;
+var SMTP_STEP_AUTH_USER  = 0x2;
+var SMTP_STEP_AUTH_PASS  = 0x3;
+var SMTP_STEP_AUTH_FINAL = 0x4;
+var SMTP_STEP_MAIL_FROM  = 0x5;
+var SMTP_STEP_RCPT_TO    = 0x6;
+var SMTP_STEP_DATA       = 0x7;
+var SMTP_STEP_BODY       = 0x8;
+var SMTP_STEP_STARTTLS   = 0xA;
+
 function _smtpSend(message, cfg) {
   return new Promise(function (resolve, reject) {
     var socket;
-    var step = 0;
+    var step = SMTP_STEP_GREETING;
     var buffer = "";
     var upgradedToTLS = false;
     var settled = false;
@@ -503,8 +527,9 @@ function _smtpSend(message, cfg) {
     if (cfg.dkimSigner) {
       try { dataMessage = cfg.dkimSigner.sign(dataMessage); }
       catch (e) {
-        return reject(new MailError("mail/dkim-sign-failed",
+        reject(new MailError("mail/dkim-sign-failed",
           "dkim signing failed: " + ((e && e.message) || String(e)), true));
+        return;
       }
     }
 
@@ -564,17 +589,17 @@ function _smtpSend(message, cfg) {
     }
 
     function handleResponse(code) {
-      if (step === 0) {
+      if (step === SMTP_STEP_GREETING) {
         if (code !== 220) { fail("greeting-rejected (code " + code + ")"); return; }
-        send("EHLO " + cfg.ehloName); step = 1;
+        send("EHLO " + cfg.ehloName); step = SMTP_STEP_EHLO_RESP;
       }
-      else if (step === 1) {
+      else if (step === SMTP_STEP_EHLO_RESP) {
         if (code < 200 || code >= 300) { fail("ehlo-rejected (code " + code + ")"); return; }
-        if (!cfg.useImplicitTLS && !upgradedToTLS) { send("STARTTLS"); step = 10; }
-        else if (cfg.user) { send("AUTH LOGIN"); step = 2; }
-        else { send("MAIL FROM:<" + fromAddr + ">"); step = 5; }
+        if (!cfg.useImplicitTLS && !upgradedToTLS) { send("STARTTLS"); step = SMTP_STEP_STARTTLS; }
+        else if (cfg.user) { send("AUTH LOGIN"); step = SMTP_STEP_AUTH_USER; }
+        else { send("MAIL FROM:<" + fromAddr + ">"); step = SMTP_STEP_MAIL_FROM; }
       }
-      else if (step === 10) {
+      else if (step === SMTP_STEP_STARTTLS) {
         if (code !== 220) { fail("starttls-rejected (code " + code + ")"); return; }
         var tlsConnectOpts = Object.assign({ socket: socket }, cfg.tlsOpts);
         if (cfg.servername) tlsConnectOpts.servername = cfg.servername;
@@ -583,42 +608,42 @@ function _smtpSend(message, cfg) {
           try { socket.removeAllListeners("data"); } catch (_e) { /* listeners migrate to upgraded socket */ }
           attachSocket(tlsSocket);
           send("EHLO " + cfg.ehloName);
-          step = 1;
+          step = SMTP_STEP_EHLO_RESP;
         });
         tlsSocket.on("error", function (err) {
           fail("tls-upgrade: " + (err.message || String(err)));
         });
       }
-      else if (step === 2) {
+      else if (step === SMTP_STEP_AUTH_USER) {
         if (code !== 334) { fail("auth-username-rejected (code " + code + ")"); return; }
-        send(Buffer.from(cfg.user || "").toString("base64")); step = 3;
+        send(Buffer.from(cfg.user || "").toString("base64")); step = SMTP_STEP_AUTH_PASS;
       }
-      else if (step === 3) {
+      else if (step === SMTP_STEP_AUTH_PASS) {
         if (code !== 334) { fail("auth-password-rejected (code " + code + ")"); return; }
-        send(Buffer.from(cfg.pass || "").toString("base64")); step = 4;
+        send(Buffer.from(cfg.pass || "").toString("base64")); step = SMTP_STEP_AUTH_FINAL;
       }
-      else if (step === 4) {
+      else if (step === SMTP_STEP_AUTH_FINAL) {
         if (code !== 235) { fail("auth-failed (code " + code + ")"); return; }
-        send("MAIL FROM:<" + fromAddr + ">"); step = 5;
+        send("MAIL FROM:<" + fromAddr + ">"); step = SMTP_STEP_MAIL_FROM;
       }
-      else if (step === 5) {
+      else if (step === SMTP_STEP_MAIL_FROM) {
         if (code < 200 || code >= 300) { fail("mail-from-rejected (code " + code + ")"); return; }
-        send("RCPT TO:<" + rcpts[rcptIndex++] + ">"); step = 6;
+        send("RCPT TO:<" + rcpts[rcptIndex++] + ">"); step = SMTP_STEP_RCPT_TO;
       }
-      else if (step === 6) {
+      else if (step === SMTP_STEP_RCPT_TO) {
         if (code < 200 || code >= 300) { fail("rcpt-rejected (code " + code + ")"); return; }
         if (rcptIndex < rcpts.length) {
           send("RCPT TO:<" + rcpts[rcptIndex++] + ">");
         } else {
-          send("DATA"); step = 7;
+          send("DATA"); step = SMTP_STEP_DATA;
         }
       }
-      else if (step === 7) {
+      else if (step === SMTP_STEP_DATA) {
         if (code !== 354) { fail("data-rejected (code " + code + ")"); return; }
         send(dataMessage + "\r\n.");
-        step = 8;
+        step = SMTP_STEP_BODY;
       }
-      else if (step === 8) {
+      else if (step === SMTP_STEP_BODY) {
         var ok = code === 250;
         done(ok, code);
       }
@@ -674,7 +699,7 @@ function httpTransport(opts) {
   var method           = (opts.method || "POST").toUpperCase();
   var endpoint         = opts.endpoint;
   var baseHeaders      = opts.headers || {};
-  var timeoutMs        = opts.timeoutMs || 15000;
+  var timeoutMs        = opts.timeoutMs || C.TIME.seconds(15);
   var allowedProtocols = opts.allowedProtocols || null;
   var allowInternal    = opts.allowInternal != null ? opts.allowInternal : null;
   var interpret        = typeof opts.interpret === "function" ? opts.interpret : null;
@@ -776,7 +801,7 @@ function resendTransport(opts) {
     name:             "resend",
     endpoint:         opts.endpoint || "https://api.resend.com/emails",
     method:           "POST",
-    timeoutMs:        opts.timeoutMs || 15000,
+    timeoutMs:        opts.timeoutMs || C.TIME.seconds(15),
     allowedProtocols: opts.allowedProtocols || null,
     allowInternal:    opts.allowInternal != null ? opts.allowInternal : null,
     headers: {
@@ -815,15 +840,18 @@ function resendTransport(opts) {
     interpret: function (res) {
       var text = res.body ? res.body.toString("utf8") : "";
       var data;
+      // Cap on diagnostic-message snippet length (chars, not bytes) — keeps
+      // a hostile or huge backend response from blowing up the error message.
+      var DIAG_SNIPPET_LEN = 0xC8;
       try { data = safeJson.parse(text, { maxBytes: MAIL_RESPONSE_MAX_BYTES }); }
       catch (_e) {
         throw new MailError("mail/resend-bad-response",
-          "resend response was not JSON: " + text.slice(0, 200), false);
+          "resend response was not JSON: " + text.slice(0, DIAG_SNIPPET_LEN), false);
       }
       if (!data.id) {
         return {
           ok:     false,
-          reason: data.message || JSON.stringify(data).slice(0, 200),
+          reason: data.message || JSON.stringify(data).slice(0, DIAG_SNIPPET_LEN),
         };
       }
       return { ok: true, id: data.id };
@@ -920,7 +948,7 @@ module.exports = {
   // DKIM-Signature header generation for outbound mail (rsa-sha256
   // default, ed25519-sha256 opt-in). Wire it into the smtp transport
   // via opts.dkimSigner. See lib/mail-dkim.js for the full surface.
-  dkim:       require("./mail-dkim"),
+  dkim:       mailDkim,
   // Test-only export: lets unit tests inspect the wire format without
   // standing up a TLS-capable SMTP fixture. Operators don't call this.
   _buildRfc822ForTest: _buildRfc822,

package/lib/metrics.js

@@ -96,9 +96,12 @@
  *     hostname, container id) and the operator knows best.
  */
 
+var C = require("./constants");
+var canonicalJson = require("./canonical-json");
 var { defineClass } = require("./framework-error");
 var { boot } = require("./log");
-var { resolveRoute, captureResponseStatus } = require("./request-helpers");
+var nb = require("./numeric-bounds");
+var { resolveRoute, captureResponseStatus, HTTP_STATUS } = require("./request-helpers");
 var validateOpts = require("./validate-opts");
 
 var MetricsError = defineClass("MetricsError", { alwaysPermanent: true });
@@ -109,7 +112,11 @@ var DEFAULT_HTTP_BUCKETS = Object.freeze([
   0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10,
 ]);
 
-var DEFAULT_CARDINALITY_CAP = 10000;
+var DEFAULT_CARDINALITY_CAP = C.BYTES.bytes(10000);
+// Bound metric / label names before regex test — DoS shape if an
+// operator passed a multi-megabyte string. Prometheus exposition
+// recommends short ascii names; 200 is a generous ceiling.
+var MAX_METRIC_NAME_LEN = 200;
 var METRIC_NAME_RE = /^[a-zA-Z_:][a-zA-Z0-9_:]*$/;
 var LABEL_NAME_RE  = /^[a-zA-Z_][a-zA-Z0-9_]*$/;
 
@@ -120,12 +127,13 @@ var LABEL_NAME_RE  = /^[a-zA-Z_][a-zA-Z0-9_]*$/;
 // metrics.create() replaces _activeTap with the registry-driven path,
 // flowing taps into pre-registered counters / gauges / histograms.
 //
-// Tier B (drop-silent): the wrapping try/catch is intentional. tap is
+// Drop-silent by design: the wrapping try/catch is intentional. tap is
 // called from request hot paths where throwing on a misnamed metric
 // (or a label whose value coerced unexpectedly) would crash the
-// request that triggered it. The metric registration path (counter /
-// gauge / histogram) DOES throw on bad name/label-name regex — but
-// that's a config-time call, Tier A. The runtime tap() call is Tier B.
+// request that triggered it. The metric-registration path (counter /
+// gauge / histogram) DOES throw on bad name/label-name regex — that's
+// a config-time call where operators want fast failure; the runtime
+// tap() is the drop-silent boundary.
 
 var _activeTap = null;
 
@@ -138,15 +146,19 @@ function tap(name, value, labels) {
 // ---- helpers ----
 
 function _validateMetricName(name) {
-  if (typeof name !== "string" || !METRIC_NAME_RE.test(name)) {
+  if (typeof name !== "string" || name.length > MAX_METRIC_NAME_LEN ||
+      !METRIC_NAME_RE.test(name)) {
     throw new MetricsError("metrics/bad-name",
-      "metric name '" + name + "' must match " + METRIC_NAME_RE);
+      "metric name '" + name + "' must match " + METRIC_NAME_RE +
+      " (max " + MAX_METRIC_NAME_LEN + " chars)");
   }
 }
 function _validateLabelName(name) {
-  if (typeof name !== "string" || !LABEL_NAME_RE.test(name)) {
+  if (typeof name !== "string" || name.length > MAX_METRIC_NAME_LEN ||
+      !LABEL_NAME_RE.test(name)) {
     throw new MetricsError("metrics/bad-label",
-      "label name '" + name + "' must match " + LABEL_NAME_RE);
+      "label name '" + name + "' must match " + LABEL_NAME_RE +
+      " (max " + MAX_METRIC_NAME_LEN + " chars)");
   }
 }
 // Counter / gauge / histogram methods all accept (callLabels, value) but
@@ -172,16 +184,20 @@ function _validateLabelValue(value) {
   return String(value);
 }
 
-// Serialize a labels object to canonical key (sorted) string. Used as
-// the Map key for counter/gauge/histogram instances.
+// Serialize a labels object to a canonical Map key. Routed through
+// canonical-json so the framework has one canonical-sort source of
+// truth for sorted-keys serialization (avoiding the silent-data-loss
+// class on Date / Buffer / Map / Set / BigInt values).
 function _labelsKey(labels) {
   if (!labels) return "";
-  var keys = Object.keys(labels).sort();
-  var parts = [];
+  // Coerce values to strings first so canonical-json's primitive
+  // serialization matches the Prometheus wire format.
+  var coerced = {};
+  var keys = Object.keys(labels);
   for (var i = 0; i < keys.length; i++) {
-    parts.push(keys[i] + "=" + _validateLabelValue(labels[keys[i]]));
+    coerced[keys[i]] = _validateLabelValue(labels[keys[i]]);
   }
-  return parts.join("");
+  return canonicalJson.stringify(coerced);
 }
 
 // Escape a label value per the Prometheus exposition format.
@@ -189,17 +205,30 @@ function _escapeLabelValue(v) {
   return String(v).replace(/\\/g, "\\\\").replace(/\n/g, "\\n").replace(/"/g, "\\\"");
 }
 
+// Wire-format renderer for Prometheus exposition. Determinism is
+// shared with _labelsKey: both walk keys in lexicographic order via
+// the same _sortedLabelKeys helper, so the canonical-sort source of
+// truth is one helper instead of two duplicated walks.
 function _renderLabels(labelObj) {
   if (!labelObj) return "";
-  var keys = Object.keys(labelObj).sort();
-  if (keys.length === 0) return "";
+  var sortedKeys = _sortedLabelKeys(labelObj);
+  if (sortedKeys.length === 0) return "";
   var parts = [];
-  for (var i = 0; i < keys.length; i++) {
-    parts.push(keys[i] + '="' + _escapeLabelValue(labelObj[keys[i]]) + '"');
+  for (var k = 0; k < sortedKeys.length; k++) {
+    parts.push(sortedKeys[k] + '="' + _escapeLabelValue(labelObj[sortedKeys[k]]) + '"');
   }
   return "{" + parts.join(",") + "}";
 }
 
+// Single canonical-sort source of truth for label keys. Both
+// _labelsKey (Map key) and _renderLabels (Prometheus exposition)
+// route through here so the framework has one walk shape.
+function _sortedLabelKeys(labelObj) {
+  var keys = Object.keys(labelObj);
+  keys.sort();
+  return keys;
+}
+
 // Combine default + per-call labels, validating against the metric's
 // declared labelNames. Throws if a label name isn't declared.
 function _resolveLabels(defaultLabels, declaredNames, callLabels) {
@@ -238,8 +267,9 @@ function create(opts) {
   ], "b.metrics");
   var namespace     = opts.namespace || "";
   var defaultLabels = opts.defaultLabels || {};
-  var cardinalityCap = typeof opts.labelCardinalityCap === "number" && opts.labelCardinalityCap > 0
-                         ? opts.labelCardinalityCap : DEFAULT_CARDINALITY_CAP;
+  nb.requirePositiveFiniteIntIfPresent(opts.labelCardinalityCap,
+    "labelCardinalityCap", MetricsError, "metrics/bad-opt");
+  var cardinalityCap = opts.labelCardinalityCap || DEFAULT_CARDINALITY_CAP;
 
   // Validate defaultLabels names.
   var dlk = Object.keys(defaultLabels);
@@ -486,7 +516,7 @@ function create(opts) {
   function expositionHandler() {
     return function metricsHandler(req, res) {
       var body = exposition();
-      res.writeHead(200, {
+      res.writeHead(HTTP_STATUS.OK, {
         "Content-Type":   "text/plain; version=0.0.4; charset=utf-8",
         "Content-Length": Buffer.byteLength(body),
         "Cache-Control":  "no-store",
@@ -523,8 +553,14 @@ function create(opts) {
         var route = resolveRoute(req);
         var labels = { method: req.method || "GET", route: route, status: String(status) };
         var durLabels = { method: labels.method, route: route };
-        try { requestsTotal.inc(labels); } catch (_e) {}
-        try { requestDuration.observe(durLabels, elapsedSec); } catch (_e) {}
+        // Best-effort tap path — a label coercion or registry race
+        // must not crash the request that triggered it. Log so
+        // the operator sees the failure in the same channel as
+        // the rest of the framework's diagnostics.
+        try { requestsTotal.inc(labels); }
+        catch (e) { log.warn("metrics/request-counter-failed: " + e.message); }
+        try { requestDuration.observe(durLabels, elapsedSec); }
+        catch (e) { log.warn("metrics/request-duration-failed: " + e.message); }
       });
       return next();
     };

package/lib/middleware/api-encrypt.js

@@ -114,8 +114,8 @@ var ApiEncryptError = defineClass("ApiEncryptError", { withStatusCode: true });
 
 var DEFAULT_REPLAY_WINDOW_MS = C.TIME.minutes(5);
 var DEFAULT_CONTENT_TYPES = ["application/json"];
-var SESSION_KEY_BYTES = 32;
-var REQUEST_NONCE_BYTES = 16;
+var SESSION_KEY_BYTES = C.BYTES.bytes(32);
+var REQUEST_NONCE_BYTES = C.BYTES.bytes(16);
 
 function _err(code, message, statusCode) {
   return new ApiEncryptError(code, message, true, statusCode || 400);
@@ -159,6 +159,8 @@ function _resolveKeypairs(opts) {
     "apiEncrypt: { keypair } or { keypairs: [...] } is required", 500);
 }
 
+var HTTP_STATUS = requestHelpers.HTTP_STATUS;
+
 function _writeRejection(res, code, body) {
   if (res.headersSent || res.writableEnded) return;
   if (typeof res.writeHead === "function") {
@@ -277,15 +279,15 @@ function create(opts) {
         }
         // Fallback if router didn't install res.json yet.
         if (!res.headersSent) {
-          res.writeHead(res.statusCode || 200, { "Content-Type": "application/json" });
+          res.writeHead(res.statusCode || HTTP_STATUS.OK, { "Content-Type": "application/json" });
         }
         res.end(JSON.stringify(encrypted));
       } catch (e) {
         try {
           logger().error("response encryption failed: " + ((e && e.message) || String(e)));
-        } catch (_e) {}
+        } catch (_e) { /* logger best-effort */ }
         if (!res.headersSent) {
-          res.writeHead(500, { "Content-Type": "application/json" });
+          res.writeHead(HTTP_STATUS.INTERNAL_SERVER_ERROR, { "Content-Type": "application/json" });
         }
         res.end(JSON.stringify({ error: "response-encryption-failed" }));
       }
@@ -299,20 +301,20 @@ function create(opts) {
     var body = req.body;
     if (!body || typeof body !== "object") {
       _emitFailure(req, "shape");
-      return _writeRejection(res, 400, { error: "encrypted-payload-required" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-required" });
     }
     var ek = body._ek, ct = body._ct, ts = body._ts, nonce = body._nonce;
     if (typeof ek !== "string" || typeof ct !== "string" ||
         typeof ts !== "number" || typeof nonce !== "string") {
       _emitFailure(req, "shape");
-      return _writeRejection(res, 400, { error: "encrypted-payload-required" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-required" });
     }
 
     // Replay window — must be within ±replayWindowMs of server clock.
     var now = Date.now();
     if (Math.abs(now - ts) > replayWindowMs) {
       _emitFailure(req, "stale");
-      return _writeRejection(res, 400, { error: "encrypted-payload-rejected" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-rejected" });
     }
 
     // Nonce check + insert atomically. Loser of the insert race
@@ -327,11 +329,11 @@ function create(opts) {
     try { freshNonce = await nonceStore.checkAndInsert(nonceHash, expireAt); }
     catch (_e) {
       _emitFailure(req, "nonce-store-error");
-      return _writeRejection(res, 500, { error: "nonce-store-unavailable" });
+      return _writeRejection(res, HTTP_STATUS.INTERNAL_SERVER_ERROR, { error: "nonce-store-unavailable" });
     }
     if (!freshNonce) {
       _emitFailure(req, "replay");
-      return _writeRejection(res, 400, { error: "encrypted-payload-rejected" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-rejected" });
     }
 
     // Decrypt _ek → session key. During a rotation overlap window,
@@ -352,7 +354,7 @@ function create(opts) {
     }
     if (!sessionKey) {
       _emitFailure(req, "tag");
-      return _writeRejection(res, 400, { error: "encrypted-payload-rejected" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-rejected" });
     }
 
     // Decrypt _ct → cleartext payload bytes → JSON object.
@@ -363,7 +365,7 @@ function create(opts) {
       clearObj = safeJson.parse(ptBuf.toString("utf8"), { maxBytes: maxDecryptedBytes });
     } catch (_e) {
       _emitFailure(req, "tag");
-      return _writeRejection(res, 400, { error: "encrypted-payload-rejected" });
+      return _writeRejection(res, HTTP_STATUS.BAD_REQUEST, { error: "encrypted-payload-rejected" });
     }
 
     // Replace req.body with cleartext, stash session key for any
@@ -392,7 +394,7 @@ function create(opts) {
       };
       if (typeof res.json === "function") return res.json(body);
       if (!res.headersSent) {
-        res.writeHead(200, { "Content-Type": "application/json" });
+        res.writeHead(HTTP_STATUS.OK, { "Content-Type": "application/json" });
       }
       res.end(JSON.stringify(body));
     };