@blamejs/core 0.15.57 → 0.15.58

package/CHANGELOG.md

@@ -8,6 +8,8 @@ upgrading across more than a few patches at a time.
 
 ## v0.15.x
 
+- v0.15.58 (2026-06-29) — **File-upload content-safety scanning now also runs the gate for a file's magic-byte-detected type, so a mislabeled file can't dodge the scanner for its real type by choosing the extension.** b.fileUpload selected the per-extension content-safety gate purely from the upload's filename extension, which the uploader controls. A file whose magic bytes identify one type but whose name carries another extension (e.g. a PDF named photo.png) was therefore scanned by the gate for the named extension — or, when no gate was registered for that extension, not scanned at all — so an uploader could dodge the scanner configured for the file's real type by renaming it. When a fileType detector is wired, finalize now also runs the content-safety gate for the type the magic bytes identify, in addition to the filename-extension gate, so the scanner for the real type runs even under a mismatched name. Magic-byte-less text formats (HTML, SVG, CSV) cannot be classified this way; that residual is covered by serving uploads with an explicit Content-Type plus X-Content-Type-Options: nosniff and by registering a content-safety gate for every accepted extension. **Security:** *Content-safety gate selection follows the sniffed type, not just the filename extension* — finalize chose the content-safety gate from nodePath.extname(filename), so a file's real type could be hidden behind a chosen extension: a PDF named photo.png ran the .png gate (or, with no .png gate, skipped scanning) and never reached the .pdf scanner. When opts.fileType is wired, finalize now detects the magic-byte type and, if it differs from the filename extension and a gate is registered for it, runs that gate too (alongside the filename-extension gate), refusing or sanitizing per the gate's decision. Existing behavior is unchanged when no fileType detector is wired or the detected type matches the extension. Formats without magic bytes (HTML/SVG/CSV/plain text) remain undetectable by content sniffing — defend those by serving stored files with a fixed Content-Type and X-Content-Type-Options: nosniff, and by registering a content-safety gate for each accepted extension.
+
 - v0.15.57 (2026-06-29) — **The RFC 9421 HTTP-message-signature verifier now enforces a required-coverage floor by default, refusing a signature whose covered set omits `@method` / `@target-uri` (and `content-digest` for bodied requests).** b.crypto.httpSig.verify built the signature base entirely from the covered-component list carried in the message's own Signature-Input header and never checked that the signature actually covered the security-relevant parts of the request (RFC 9421 §3.2). A signature covering only @authority therefore verified even after the method, target URI, or body were changed — so a captured signature could be replayed across a different method and path, or a request body swapped, under an otherwise-valid signature. verify now refuses a signature whose covered set omits a required component, returning { valid: false, reason: "missing-required-component", missing: [...] } before the cryptographic check. By default (security-on, not opt-in) it requires @method and @target-uri on every request, plus content-digest when the request carries a body; an operator can pass requiredComponents to assert an exact set, or requiredComponents: [] to waive the floor (the signature itself is still verified). **Security:** *httpSig.verify enforces a required-coverage floor (RFC 9421 §3.2)* — The verifier trusted the covered-component list from the message's Signature-Input header without requiring that any particular component be covered, so an under-covered signature (e.g. covering only @authority) verified while the method, target URI, and body were free to change — a captured signature replayed across method+path, or a swapped body, passed verification. verify now refuses a signature missing a required component with reason "missing-required-component" (and a missing[] list) before the crypto check. The default floor is @method + @target-uri on every request plus content-digest for bodied requests; requiredComponents overrides it explicitly, and requiredComponents: [] waives the floor for callers that intentionally sign a narrower set (the signature itself is still verified). **Migration:** *Signers must cover @method + @target-uri (and content-digest for bodied requests)* — If you verify HTTP message signatures with b.crypto.httpSig.verify, signatures whose covered set omits @method or @target-uri (or content-digest on a request with a body) now fail with reason "missing-required-component". Broaden the signer's covered set to include them (recommended), pass requiredComponents to assert the exact components your application requires, or pass requiredComponents: [] to keep the prior behavior of accepting whatever the signer covered. Verifying a fully-covered signature is unchanged.
 
 - v0.15.56 (2026-06-29) — **Break-glass and dual-control wildcard scope matching is now segment-aware, and the JMAP cross-tenant gate validates every account-id argument (including `fromAccountId`), closing two authorization gaps.** Two authorization gates under-checked their input. b.breakGlass and b.dualControl matched a wildcard scope/role by stripping a trailing "*" and doing a raw string-prefix comparison (requireScope.indexOf(prefix) === 0), which ignores ":" segment boundaries — so a partial-segment grant like "phi:a*" satisfied a required "phi:admin", letting a holder break-glass-unseal or approve a flow they were not scoped for. Both now match through the canonical, segment-aware b.permissions.match, so only an exact scope or a whole-segment wildcard ("phi:*") satisfies the requirement. Separately, the JMAP server's cross-tenant gate validated only a method call's destination accountId, not the fromAccountId that /copy methods (Email/copy, CalendarEvent/copy — RFC 8620 §5.4) read their SOURCE account from — so an actor could name a foreign fromAccountId and copy another tenant's data. The gate now validates every account-id argument the call names. **Security:** *Break-glass / dual-control wildcard scope matching is segment-aware* — b.breakGlass grant (requireScope) and b.dualControl approval (approverRoles) matched a wildcard-shaped actor scope/role by stripping its trailing "*" and testing requireScope.indexOf(prefix) === 0 — a raw string prefix that ignores the ":" segment structure. A partial-segment grant therefore over-matched: "phi:a*" satisfied "phi:admin" (and "p*" satisfied any "phi:..."), so an actor with a narrower grant could break-glass-unseal sealed data or approve a dual-control flow they were not authorized for. Both sites now match through b.permissions.match, where "*" must occupy a whole ":"-delimited segment — "phi:*" still satisfies "phi:admin", but "phi:a*" does not. Actor scopes/roles flow from operator-trusted assignment, so this tightens a defense-in-depth gate rather than a request-controlled bypass. · *JMAP cross-tenant gate validates every account-id argument, not only the destination* — The JMAP server rejects a method call that names an accountId outside the actor's enumerated set (RFC 8620 §3.6.1). It checked only accountId, but /copy methods (Email/copy, CalendarEvent/copy — RFC 8620 §5.4) also carry fromAccountId, the SOURCE account they read from. An actor enumerated for their own destination account could therefore name a foreign fromAccountId and have the operator's copy handler read another tenant's messages. The gate now validates every account-id argument (any *AccountId) against the actor's enumerated accounts before the handler runs, so a foreign source account is refused with accountNotFound. **Detectors:** *Scope/role wildcard matching must use b.permissions.match* — A codebase-patterns detector flags the hand-rolled wildcard idiom (a trailing-"*" check plus a slice(0,-1) strip plus a raw indexOf(prefix)===0 prefix match), so a new authorization gate cannot reintroduce a segment-unaware scope match instead of routing through b.permissions.match.

package/lib/file-upload.js

@@ -1164,11 +1164,36 @@ function create(opts) {
     }
     if (contentSafety) {
       var safetyExt = nodePath.extname(filename).toLowerCase();
-      var safetyGate = contentSafety[safetyExt];
-      if (safetyGate && typeof safetyGate.check === "function" && bodyBuffer) {
+      // Gates to run: the filename-extension gate, plus — when the magic bytes
+      // confidently identify a DIFFERENT type — that type's gate too, so a
+      // mislabeled magic-byte file (e.g. a PDF named .png) cannot dodge the
+      // scanner for its real type by choosing the extension. Text formats with
+      // no magic bytes (HTML/SVG/CSV) are not detectable here; that residual is
+      // covered by the serving layer's Content-Type + X-Content-Type-Options:
+      // nosniff and by registering a content gate for every accepted extension.
+      var gateExts = [safetyExt];
+      // Sniff from the reassembled body, or — for a streamed upload past
+      // maxStreamReassemblyBytes (bodyBuffer null) — the first chunk already
+      // read for the MIME-sniff gate. So a streamed mislabel still routes to its
+      // real type's gate; and when that gate cannot scan the un-reassembled
+      // body, the loop below surfaces it as a streamed-over-cap skip (not a
+      // no-gate skip), so operators can alert rather than miss the bypass.
+      var sniffBytes = bodyBuffer || firstChunk;
+      if (fileType && sniffBytes) {
+        var sniffed = fileType.detect(sniffBytes);
+        if (sniffed && sniffed.extension) {
+          var sniffedExt = "." + String(sniffed.extension).toLowerCase();
+          if (sniffedExt !== safetyExt && gateExts.indexOf(sniffedExt) === -1) {
+            gateExts.push(sniffedExt);
+          }
+        }
+      }
+      // Run one gate; throws on refuse / gate-error, mutates bodyBuffer on
+      // sanitize so a later gate sees the cleaned bytes.
+      var _runContentSafetyGate = async function (gate, gateExt) {
         var safetyDecision;
         try {
-          safetyDecision = await safetyGate.check({
+          safetyDecision = await gate.check({
             bytes:    bodyBuffer,
             filename: filename,
             actor:    actor,
@@ -1186,12 +1211,12 @@ function create(opts) {
             "fileUpload.finalize: contentSafety gate threw: " + (gateErr && gateErr.message));
         }
         if (!safetyDecision.ok || safetyDecision.action === "refuse") {
-          _emitObs("fileUpload.content_safety_refused", 1, { ext: safetyExt });
+          _emitObs("fileUpload.content_safety_refused", 1, { ext: gateExt });
           _emitAudit("fileUpload.finalize_failure", {
             actor:    requestHelpers.extractActorContext(actor),
             outcome:  "failure", reason: "content-safety-refused",
             metadata: {
-              uploadId: uploadId, ext: safetyExt,
+              uploadId: uploadId, ext: gateExt,
               issues: gateContract.summarizeIssues(safetyDecision.issues),
             },
           });
@@ -1200,26 +1225,37 @@ function create(opts) {
             (safetyDecision.issues || []).map(function (i) { return i.kind; }).join(", ") + ")");
         }
         if (safetyDecision.action === "sanitize" && safetyDecision.sanitized) {
-          // Replace the body buffer with the sanitized variant.
           bodyBuffer = safetyDecision.sanitized;
-          // Clear the streaming alias if present — sanitized fits in memory.
           bodyStream = null;
         }
-      } else if (safetyGate && typeof safetyGate.check === "function" && !bodyBuffer) {
-        // A content-safety gate is configured for this extension, but the
-        // upload streamed past maxStreamReassemblyBytes and was never
-        // reassembled into a buffer the byte-level gate can inspect. The
-        // MIME-sniff and filename gates still ran; the per-extension
-        // content gate did NOT. Audit the skip (with the streamed reason)
-        // so operators can alert, lower maxStreamReassemblyBytes, or cap
+      };
+      var ranAnyGate = false;
+      var hasGateButNoBody = false;
+      for (var ge = 0; ge < gateExts.length; ge += 1) {
+        var gateForExt = contentSafety[gateExts[ge]];
+        if (gateForExt && typeof gateForExt.check === "function") {
+          if (bodyBuffer) {
+            await _runContentSafetyGate(gateForExt, gateExts[ge]);
+            ranAnyGate = true;
+          } else {
+            hasGateButNoBody = true;
+          }
+        }
+      }
+      if (!ranAnyGate && hasGateButNoBody) {
+        // A content-safety gate is configured, but the upload streamed past
+        // maxStreamReassemblyBytes and was never reassembled into a buffer the
+        // byte-level gate can inspect. The MIME-sniff and filename gates still
+        // ran; the per-extension content gate did NOT. Audit the skip so
+        // operators can alert, lower maxStreamReassemblyBytes, or cap
         // maxFileBytes to force content-gating of this type.
         _emitContentSafetySkipped(uploadId, actor, "streamed-over-reassembly-cap",
                                   safetyExt, verified.totalBytes);
-      } else {
+      } else if (!ranAnyGate) {
         // contentSafety is wired but no gate is registered for this file's
-        // extension — the byte-level scan does not run. Audit the skip so
-        // a review can tell the upload bypassed content scanning (and
-        // register a gate for the extension if it should be scanned).
+        // extension or its sniffed type — the byte-level scan does not run.
+        // Audit the skip so a review can tell the upload bypassed content
+        // scanning (and register a gate for the extension if it should be).
         _emitContentSafetySkipped(uploadId, actor, "no-gate-for-extension",
                                   safetyExt, verified.totalBytes);
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/core",
-  "version": "0.15.57",
+  "version": "0.15.58",
   "description": "The Node framework that owns its stack.",
   "license": "Apache-2.0",
   "author": "blamejs contributors",

package/sbom.cdx.json

@@ -2,10 +2,10 @@
   "$schema": "http://cyclonedx.org/schema/bom-1.5.schema.json",
   "bomFormat": "CycloneDX",
   "specVersion": "1.5",
-  "serialNumber": "urn:uuid:2f36daef-8dad-4626-a48e-1ad3ed3e44ba",
+  "serialNumber": "urn:uuid:35ef4bd7-07c5-42a5-b080-7b6950504f68",
   "version": 1,
   "metadata": {
-    "timestamp": "2026-06-29T10:15:11.278Z",
+    "timestamp": "2026-06-29T12:31:38.470Z",
     "lifecycles": [
       {
         "phase": "build"
@@ -19,14 +19,14 @@
       }
     ],
     "component": {
-      "bom-ref": "@blamejs/core@0.15.57",
+      "bom-ref": "@blamejs/core@0.15.58",
       "type": "application",
       "name": "blamejs",
-      "version": "0.15.57",
+      "version": "0.15.58",
       "scope": "required",
       "author": "blamejs contributors",
       "description": "The Node framework that owns its stack.",
-      "purl": "pkg:npm/%40blamejs/core@0.15.57",
+      "purl": "pkg:npm/%40blamejs/core@0.15.58",
       "properties": [],
       "externalReferences": [
         {
@@ -54,7 +54,7 @@
   "components": [],
   "dependencies": [
     {
-      "ref": "@blamejs/core@0.15.57",
+      "ref": "@blamejs/core@0.15.58",
       "dependsOn": []
     }
   ]