@blamejs/blamejs-shop 0.4.77 → 0.4.79

package/CHANGELOG.md

@@ -8,6 +8,10 @@ upgrading across more than a few patches at a time.
 
 ## v0.4.x
 
+- v0.4.79 (2026-06-21) — **Reversing a receipt no longer mints phantom stock, and restock recommendations accept lowercase location codes.** Two inventory correctness fixes. Reversing an applied goods-receipt now rolls back exactly the quantity the reversal removed: when a SKU had already been decremented elsewhere to below the received quantity, the reversal's forward step removes only what's on hand, and a mid-reversal failure now compensates by that exact amount instead of adding back the full received quantity — which previously minted phantom stock. Separately, restock recommendations now accept lowercase and dotted location codes, matching the location-code format the rest of the inventory surface already accepts; a stricter uppercase-only pattern had been rejecting valid codes. No configuration changes; upgrade to pick them up. **Fixed:** *Reversing a goods-receipt rolls back the exact quantity removed* — Receipt reversal now records how many units each line's decrement actually removed (floored at the quantity on hand) and, if a later line in the same reversal fails, compensates the already-decremented lines by that exact amount. Previously the forward decrement clamped at zero while the compensation added back the full received quantity, so reversing a receipt for a SKU that had since been drawn down below the received amount could leave more stock on hand than before the reversal. · *Restock recommendations accept lowercase and dotted location codes* — smart-restocking now validates location codes against the same pattern the inventory-locations primitive uses (mixed case, with dot/underscore/hyphen), so a recommendation request for a location like "aisle-3.bin-2" is accepted. A divergent uppercase-only pattern had been rejecting valid location codes that every other inventory operation accepts.
+
+- v0.4.78 (2026-06-21) — **Voiding a gift card no longer clobbers a concurrent redemption, and a credit order can't be charged twice.** Two money-safety fixes that make terminal transitions exactly-once. Voiding a gift card is now a single atomic transition guarded on the card still being active, so a void that races a redemption can no longer overwrite the redemption's terminal state and silently discard the spent balance — whichever transition lands first wins and the other is refused. Separately, charging a credit-line order is now idempotent per order: the charge guard refuses a second charge for an order that already has one (and a retry returns the original charge rather than erroring), so the same order can't be charged twice against the customer's credit line. No configuration changes; upgrade to pick them up. **Fixed:** *Voiding a gift card is an atomic, fenced transition* — Gift-card void is now a single guarded UPDATE that only matches a card still in the active state, mirroring redeem. A void that races a redemption (or an expiry) can no longer overwrite the card's terminal state — the prior read-decide-write could void a card a concurrent redemption had just spent, discarding the remaining-balance debit. A void that loses the race is refused (or returns idempotently if the card was already voided). · *A credit-line order is charged at most once* — creditLimits.chargeOrder now refuses a second charge for an order that already carries one, enforced in the same atomic statement as the credit-cap check. A retried charge for an already-charged order returns the original charge instead of erroring or charging the line a second time, so a duplicate capture or retry can't double-draw the customer's credit.
+
 - v0.4.77 (2026-06-21) — **Exactly-once hardening for payment capture, auto-replenishment, gift redemption, and carrier-credential rotation.** Four correctness fixes that make money- and inventory-moving state transitions happen exactly once under concurrency or delayed settlement. A PayPal order is no longer marked paid when the capture itself is still pending — settlement is now read from the capture status, not the order envelope, so a delayed or under-review payment leaves the order pending until funds actually settle. Overlapping auto-replenishment ticks can no longer both fire the same policy: the cadence advance is now an atomic claim, so a vendor purchase order is composed and submitted once per window instead of being double-cut. Redeeming one gift-subscription link twice — two clicks racing within milliseconds — now mints exactly one subscription: the redemption claims the gift before creating the subscription, and rolls the claim back if the mint fails. And two carrier-credential rotations firing at once can no longer both commit; the rotation now compare-and-swaps on the observed key, so the loser is refused instead of clobbering the winner's fresh key and stranding the previous-key grace window. No configuration changes; upgrade to pick them up. **Fixed:** *A PayPal order is marked paid only when the capture itself completes* — Capturing a PayPal order now gates the paid transition on the per-capture status rather than the order envelope. The order-level status can read COMPLETED while the capture is still PENDING (a delayed-settlement or under-review payment), which previously marked the order paid before the money settled. Any non-completed capture now leaves the order pending and reports the capture as unhandled so the checkout surfaces the unsettled state. · *Overlapping auto-replenishment ticks no longer double-submit a purchase order* — The replenishment scheduler advances a policy's run cadence with a single conditional claim that is the serialization point: two ticks firing at once contend on the policy row, only one matches the due-window predicate, and the vendor purchase order is composed and submitted exactly once per window. Previously the cadence was an in-memory check followed by an unconditional stamp, so two overlapping ticks both passed the check and cut duplicate POs. · *Redeeming a gift-subscription link twice creates exactly one subscription* — Gift redemption now claims the gift's pending→redeemed transition before creating the recipient's subscription, and only the winner of that atomic claim mints. A leaked or double-clicked redemption link presented twice within milliseconds therefore creates one subscription, not two; if the subscription mint then fails, the claim is rolled back so the gift can be redeemed again rather than being stranded as redeemed-with-no-subscription. · *Concurrent carrier-credential rotations no longer over-issue or strand credentials* — Rotating a shipping-carrier account's API credentials now compare-and-swaps on the observed key and account state, so two rotations firing at once can't both commit. The loser is refused with a rotation-conflict error instead of overwriting the winner's freshly minted key and leaving the previous-key grace window pointing at a key no deployed worker holds.
 
 - v0.4.76 (2026-06-21) — **Account security hardening — revoking a passkey ends the account's other sessions, and registration no longer creates an account before the security key is enrolled.** Four hardenings on the customer account surface. Revoking a passkey now ends every other live session for the account — including pending magic-link sign-in tokens — while keeping the device that performed the revoke signed in; previously the credential was deleted but a sealed session cookie a lost or compromised authenticator had already established stayed valid for its full 14-day life. Signing out everywhere now also revokes any unredeemed magic-link token, so a link mailed before sign-out can no longer sign the account back in. Passkey registration no longer creates the customer record until the security-key ceremony actually completes: the pending sign-up is carried in the sealed challenge cookie and the account is created only on a verified finish, so an abandoned or scripted registration can no longer reserve an email address or leave empty accounts behind. And passkey sign-in performs the same credential lookup whether or not the address has an account, removing a response-time difference that could be used to test which emails are registered. No configuration changes; upgrade to pick them up. **Security:** *Revoking a passkey ends the account's other sessions and pending sign-in links* — Revoking a passkey is a response to a lost or compromised authenticator, so it now moves the account's server-side session-revocation boundary forward — invalidating every sealed auth cookie issued before the revoke, including one the compromised authenticator established — and revokes any pending customer-portal (magic-link) token. The browser that performed the revoke is re-issued a fresh cookie so it stays signed in; every other device is signed out on its next request. Previously only the credential row was deleted, leaving already-issued session cookies valid for their full 14-day life. · *Signing out everywhere also revokes pending magic-link tokens* — POST /account/logout already moved the session-revocation boundary forward to kill live sealed cookies; it now also revokes any unredeemed magic-link / customer-portal token for the account. An emailed sign-in link issued before the sign-out can no longer be redeemed to sign the account back in. · *Passkey registration creates the account only after the security key is enrolled* — The public passkey register-begin endpoint no longer writes a customer record before the WebAuthn ceremony completes. The pending sign-up (email + display name + challenge) is sealed into the tamper-proof challenge cookie, and the account is created only on a verified register-finish, where the duplicate-email check runs atomically to settle a begin/finish race. An abandoned or scripted register-begin can no longer reserve (squat) an email address or leave behind empty accounts. · *Passkey sign-in does not reveal whether an email is registered via timing* — Passkey login-begin now runs the same credential lookup on both paths — against the real account for a registered address, against a fixed non-matching id otherwise — so a registered address no longer takes measurably longer to respond. The challenge response shape was already identical on both paths; this closes the remaining response-time signal that could enumerate registered emails.

package/lib/asset-manifest.json

@@ -1,5 +1,5 @@
 {
-  "version": "0.4.77",
+  "version": "0.4.79",
   "assets": {
     "css/admin.css": {
       "integrity": "sha384-imfe0otYErcB8rr2h6KLSGTtStirysptpXETSPY4zLv3bZoIT75Lo1dOvkOav+xL",

package/lib/credit-limits.js

@@ -506,22 +506,61 @@ function create(opts) {
       var requested  = _epochMs(input.occurred_at, "occurred_at");
       if (requested == null) requested = _now();
 
+      // Per-order idempotency is independent of current account status: a
+      // retry of an order that ALREADY has a charge returns the original
+      // charge even if the account was later suspended or closed — a retried
+      // capture must be a stable no-op, never a double-charge, a spurious
+      // NOT_ACTIVE, or a misleading limit error. Checked up front (BEFORE the
+      // active-account gate) and again on the atomic guard's refusal (to catch
+      // a charge that landed concurrently between the two reads).
+      function _idempotentReturn(prior) {
+        return {
+          id:                  prior.id,
+          customer_id:         customerId,
+          kind:                "charge",
+          order_id:            orderId,
+          amount_minor:        Number(prior.amount_minor),
+          balance_after_minor: Number(prior.balance_after_minor),
+          occurred_at:         Number(prior.occurred_at),
+          idempotent:          true,
+        };
+      }
+      async function _priorCharge() {
+        return (await query(
+          "SELECT id, amount_minor, balance_after_minor, occurred_at FROM credit_transactions " +
+          "WHERE customer_id = ?1 AND order_id = ?2 AND kind = 'charge' ORDER BY occurred_at ASC, id ASC LIMIT 1",
+          [customerId, orderId],
+        )).rows[0];
+      }
+      var existingCharge = await _priorCharge();
+      if (existingCharge) return _idempotentReturn(existingCharge);
+
       // Fast pre-check for a clean NOT_FOUND / NOT_ACTIVE error; the
-      // credit-limit invariant itself is enforced atomically in the
-      // INSERT guard below (re-checking status = 'active' there too),
-      // so a charge can't slip past the limit by racing another charge.
+      // credit-limit invariant + per-order dedup are enforced atomically in
+      // the INSERT guard below (re-checking status = 'active' there too), so a
+      // charge can't slip past the limit or double-charge by racing another.
       await _requireActive(customerId, "chargeOrder");
       var written = await _appendTxnAtomic(
         customerId, "charge", orderId, null, requested,
         "?7",                                    // amount_minor: the charge
         _BAL_SUB + " + ?7",                      // balance_after = outstanding + amount
+        // Cap check AND per-order dedup in one atomic guard: refuse a second
+        // charge for the same order so the same order_id can't be charged
+        // twice against the line (the bridge serializes statements, so the
+        // NOT EXISTS sees a prior committed charge).
         "(" + _BAL_SUB + " + ?7) <= COALESCE((SELECT credit_limit_minor " +
-          "FROM credit_accounts WHERE customer_id = ?2 AND status = 'active'), -1)",
+          "FROM credit_accounts WHERE customer_id = ?2 AND status = 'active'), -1) " +
+          "AND NOT EXISTS (SELECT 1 FROM credit_transactions " +
+          "WHERE customer_id = ?2 AND order_id = ?4 AND kind = 'charge')",
         [amount],
       );
       if (!written) {
-        // Guard refused. Re-read to report precisely: a status change
-        // since the pre-check (rare race with suspend/close) vs the
+        // A charge for this order landed concurrently between the up-front
+        // check and the insert — return it idempotently.
+        var raced = await _priorCharge();
+        if (raced) return _idempotentReturn(raced);
+        // Guard refused for the cap. Re-read to report precisely: a status
+        // change since the pre-check (rare race with suspend/close) vs the
         // limit being exceeded.
         var acctNow = await _readAccount(customerId);
         if (!acctNow || acctNow.status !== "active") {

package/lib/giftcards.js

@@ -577,34 +577,39 @@ function create(opts) {
     "void": async function (id, opts2) {
       opts2 = opts2 || {};
       _uuid(id, "giftcard id");
-      var r = await query(
-        "SELECT id, status FROM giftcards WHERE id = ?1",
-        [id],
+      var ts = _now();
+      // Atomic guarded transition active -> voided. The status='active' fence
+      // lives in SQL (mirroring redeem()), so a concurrent redeem or expire
+      // that already moved the card to a terminal state is NOT silently
+      // overwritten — the prior read-decide-write clobbered a racing
+      // redemption (discarding its remaining-balance debit) because the
+      // UPDATE omitted the status fence.
+      var upd = await query(
+        "UPDATE giftcards SET status = 'voided', updated_at = ?1 WHERE id = ?2 AND status = 'active'",
+        [ts, id],
       );
+      // `opts2.reason` is operator-supplied free-form; it's not persisted on
+      // the row (no schema column) but accepted so a future audit-log
+      // primitive can ride alongside without a surface change.
+      void opts2.reason;
+      if (Number(upd.rowCount || 0) === 1) {
+        var after = await query("SELECT * FROM giftcards WHERE id = ?1", [id]);
+        return after.rows[0] || null;
+      }
+      // Zero rows: the card is missing or already in a terminal state.
+      // Re-read to disambiguate and preserve the prior call's contract.
+      var r = await query("SELECT * FROM giftcards WHERE id = ?1", [id]);
       if (!r.rows.length) return null;
       var row = r.rows[0];
+      if (row.status === "voided") return row;   // idempotent — already voided
       if (row.status === "redeemed") {
         var already = new Error("giftcards.void: card is fully redeemed");
         already.code = "GIFTCARD_ALREADY_REDEEMED";
         throw already;
       }
-      if (row.status === "voided") {
-        // Idempotent — already voided; return the row as-is.
-        var existing = await query("SELECT * FROM giftcards WHERE id = ?1", [id]);
-        return existing.rows[0] || null;
-      }
-      var ts = _now();
-      await query(
-        "UPDATE giftcards SET status = 'voided', updated_at = ?1 WHERE id = ?2",
-        [ts, id],
-      );
-      // `opts2.reason` is operator-supplied free-form; it's not
-      // persisted on the row (no schema column) but accepted so a
-      // future audit-log primitive can ride alongside without a
-      // surface change.
-      void opts2.reason;
-      var after = await query("SELECT * FROM giftcards WHERE id = ?1", [id]);
-      return after.rows[0] || null;
+      // Any other terminal state (e.g. expired) — return the row as-is rather
+      // than forcing it to voided over a terminal transition.
+      return row;
     },
 
     // Operator-facing list of issued cards — drives the admin

package/lib/inventory-receive.js

@@ -432,12 +432,25 @@ function create(opts) {
         for (var i = 0; i < receipt.lines.length; i += 1) {
           var l = receipt.lines[i];
           var ts = _now();
+          // Capture how many units the decrement ACTUALLY removes: a prior
+          // out-of-band decrement can leave stock below qty_received, so the
+          // removable amount is floored at what's on hand. Recording the real
+          // delta (not qty_received) is what makes a compensating add-back on
+          // a mid-loop failure an exact inverse — the old `MAX(0,...)` clamp
+          // removed fewer units than the compensation later added back, minting
+          // phantom stock. `removed <= prior`, so the subtraction never goes
+          // negative and the clamp is no longer needed.
+          var priorRow = (await query(
+            "SELECT stock_on_hand FROM inventory WHERE sku = ?1", [l.sku],
+          )).rows[0];
+          var prior   = priorRow ? Number(priorRow.stock_on_hand) : 0;
+          var removed = Math.min(l.qty_received, prior);
           await query(
-            "UPDATE inventory SET stock_on_hand = MAX(0, stock_on_hand - ?1), updated_at = ?2 WHERE sku = ?3",
-            [l.qty_received, ts, l.sku],
+            "UPDATE inventory SET stock_on_hand = stock_on_hand - ?1, updated_at = ?2 WHERE sku = ?3",
+            [removed, ts, l.sku],
           );
-          decremented.push(l);
-          stockChanges.push({ sku: l.sku, qty: -l.qty_received });
+          decremented.push({ sku: l.sku, removed: removed });
+          stockChanges.push({ sku: l.sku, qty: -removed });
         }
       } catch (e) {
         // Compensate the decrements that already landed and release the claim so
@@ -449,7 +462,7 @@ function create(opts) {
           try {
             await query(
               "UPDATE inventory SET stock_on_hand = stock_on_hand + ?1, updated_at = ?2 WHERE sku = ?3",
-              [dl.qty_received, _now(), dl.sku],
+              [dl.removed, _now(), dl.sku],
             );
           } catch (_compErr) { /* best-effort compensation; the claim release below restores retryability */ }
         }

package/lib/smart-restocking.js

@@ -149,7 +149,10 @@ var b = require("./vendor/blamejs");
 
 var SLUG_RE          = /^[a-z0-9][a-z0-9-]{0,63}$/;
 var SKU_RE           = /^[A-Za-z0-9][A-Za-z0-9._-]{0,127}$/;
-var LOCATION_RE      = /^[A-Z0-9][A-Z0-9_-]{0,63}$/;
+// Mirrors inventory-locations.js CODE_RE exactly — a divergent stricter
+// (uppercase-only, no dot) pattern here rejected valid lowercase/dotted
+// location codes that the rest of the inventory surface accepts.
+var LOCATION_RE      = /^[A-Za-z0-9][A-Za-z0-9._-]{0,63}$/;
 
 var MAX_HOLDING_BPS  = 100000;          // 1000% / yr — operator's upper bound; the migration CHECK enforces too
 var MAX_ORDERING_COST_MINOR = 1000000000; // 1e9 minor units — sanity ceiling
@@ -233,7 +236,7 @@ function _sku(s, label) {
 function _locationOrNull(s) {
   if (s == null) return null;
   if (typeof s !== "string" || !LOCATION_RE.test(s)) {
-    throw new TypeError("smart-restocking: location_code must match /^[A-Z0-9][A-Z0-9_-]*$/ (1..64 chars)");
+    throw new TypeError("smart-restocking: location_code must match /^[A-Za-z0-9][A-Za-z0-9._-]*$/ (1..64 chars)");
   }
   return s;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/blamejs-shop",
-  "version": "0.4.77",
+  "version": "0.4.79",
   "description": "Open-source framework built on blamejs. Vendored stack, zero npm runtime deps, PQC-first crypto, security-on by default.",
   "main": "lib/index.js",
   "scripts": {