@blamejs/blamejs-shop 0.4.64 → 0.4.65

package/CHANGELOG.md

@@ -8,6 +8,8 @@ upgrading across more than a few patches at a time.
 
 ## v0.4.x
 
+- v0.4.65 (2026-06-19) — **Dropship-forwarding and scheduled-export status transitions are now claimed atomically.** Closes two status-transition races in modules that validated the transition with the state-machine primitive but then persisted it with an unconditional update keyed only on the row id. Because the state-machine validation runs in process (each request rebuilds the machine from a fresh row), two concurrent transitions on the same row both passed validation and the second write silently clobbered the first — for example a dropship forwarding being marked shipped while a retry marks it failed, or a scheduled export being cancelled while a worker marks it running. Both now gate the write on the row still being in the state that was validated against (the same single-statement compare-and-swap the order and inventory-receipt lifecycles already use), so exactly one transition lands and a concurrent loser is refused rather than overwriting it. No API change. **Fixed:** *Dropship-forwarding transitions claim the from-state* — Every dropship-forwarding lifecycle edge routes through one helper that validated the transition against the state machine and then wrote UPDATE … WHERE id = ?. The write now also requires the row to still be in the state the transition was validated against (… AND status = <from>) and treats a zero-row result as a lost race (a typed refusal), so two concurrent vendor callbacks (e.g. accept racing ship, or a retry) can't both advance the row and silently overwrite each other. · *Scheduled-export status writers claim the from-state* — The four scheduled-export transitions (cancel, mark-running, mark-complete, mark-failed) validated against the export state machine and then wrote keyed only on the export id. Each now gates the write on the observed from-state and refuses on a zero-row result, so a cancel racing a mark-running (or a duplicate worker callback) no longer last-writer-wins into an illegal state. The state machine still enforces the legal-edge validation; the conditional update is the atomic claim.
+
 - v0.4.64 (2026-06-19) — **A failed side-effect can no longer strand a claimed record.** Hardens the atomic-claim concurrency fixes (shipped over the previous releases) against the case where the side-effect fails or the worker crashes AFTER a record was claimed. Each claim now restores or recovers the record so a transient failure can't leave it permanently stuck. A scheduled payment retry that is claimed out of the due set but then fails to advance (a malformed policy or a database write error) restores its next-retry time, so the retry isn't silently dropped. Approving a seller application that crashes between claiming the approval and persisting the vendor is now recoverable — an application left approved with no vendor can be approved again rather than being stranded in a terminal state. A survey response whose insert fails after the invitation was claimed reverts the invitation to issued so it can be answered. A reorder reminder or wishlist digest whose send fails defers the retry to a later tick on a distinct cursor, so a concurrent overlapping tick can't pick up the rolled-back row and send a duplicate in the same window. No API change. **Fixed:** *Payment retry restores its schedule on a failed advance* — The retry scheduler claims an enrollment out of the due set by clearing its next-retry time before doing processor work. If advancing the enrollment then throws (a malformed retry policy, or a database write failure while recording the attempt), the next-retry time is restored to the value the tick observed, so a later tick re-attempts the retry. Previously the enrollment was left active with no next-retry time, and the due query (which requires a next-retry time) would never pick it up again, silently stopping the customer's recovery retries. · *Seller approval is recoverable after a mid-approval crash* — Approving a seller application claims the in-review-to-approved transition before registering the vendor. If the worker crashes or times out between the claim and persisting the vendor, the application is left approved with no vendor — a terminal state the rest of the primitive could never move out of. Approval now treats an approved application that has no vendor attached as re-approvable, so the registration can be retried and the application recovered instead of stranded. · *Survey response keeps the invitation retryable on insert failure* — Submitting a survey response claims the invitation (issued to responded) before inserting the response row. If that insert fails (a transient write error), the invitation is reverted to issued so the response can be submitted again, rather than being stuck responded with no response recorded and every retry rejected as already-responded. · *Reorder reminder and wishlist digest defer a failed send instead of re-firing it* — When a reorder reminder or a wishlist digest send fails after the row was claimed, the schedule cursor is rolled to a value distinct from the one the tick observed (still due, so a later tick retries) rather than back to the exact observed value. A concurrent overlapping tick that read the same cursor was waiting to claim it; restoring the exact value let it match and send a duplicate in the same window. The retry is now deferred to a later tick with no duplicate.
 
 - v0.4.63 (2026-06-19) — **Fulfillment and customer-data actions can't double-fire under concurrent calls.** Closes a further set of concurrency races where a fulfillment or customer-data action read a row, checked its status in application code, and then performed an irreversible side-effect (open an inventory hold, create shipments, restock received stock, create an order, reparent customer records, requeue a print job, mint child carts) before an unconditional update committed — so two concurrent calls could both pass the check and both perform the side-effect. Each now claims the transition with a single conditional update and performs the side-effect only when that claim wins, reverting the claim if the side-effect then fails so a row is never stranded. Approving an exchange opens its replacement hold once; executing a split-shipment plan creates the parcels once; recording a partial purchase-order receipt restocks each line once (claimed per line); completing a pick list creates its shipment once; converting or launching a pre-order creates the order once and a reservation can't oversell its cap; merging or rolling back a customer reparents the records once; an impersonation notice, a duplicate-suggestion link, a print-job retry, and a cart split each happen once. Behavior for a single sequential caller is unchanged. **Fixed:** *Fulfillment transitions claim before their side-effect* — Approving an exchange now claims pending-to-approved (WHERE id = ? AND status = 'pending') before opening the replacement inventory hold, reverting to pending if the hold fails. Executing a split-shipment plan claims proposed-to-executed before creating any shipment. Recording a partial purchase-order receipt claims each receipt line by advancing its received quantity conditionally before restocking, rolling the claimed lines back if a later line fails. Completing a pick list claims its completion before creating the shipment. In each case two concurrent calls can no longer both create the holds / shipments / restock for one row. · *Pre-order conversion, launch, cancel, and reserve are atomic* — Converting a reservation to an order claims active-to-converted before creating the order (reverting on failure), so a reservation can't spawn two orders; launching a campaign claims active-to-launched before walking reservations; cancelling claims active-to-cancelled before decrementing the reserved counter. Reserving now enforces the campaign cap inside the increment itself (units_reserved + qty <= max_units_available in the update's WHERE), so concurrent reservations can't oversell the pool; a reservation that loses the cap is compensated. · *Customer merge/rollback, impersonation notice, suggestion dedup, print retry, and cart split run once* — Executing or rolling back a customer merge claims the transition before reparenting records, reverting if the reparent fails. Sending the 'an operator viewed your account' notice claims the notified stamp (WHERE customer_notified_at IS NULL) before enqueuing, so it's sent once. Linking a duplicate suggestion claims the source before migrating its votes to the canonical row. Marking a print job failed claims the transition before inserting the retry job, so a job isn't reprinted twice. Splitting a cart claims the source's abandon before minting the child carts, so a concurrent split can't create two sets of children.

package/lib/asset-manifest.json

@@ -1,5 +1,5 @@
 {
-  "version": "0.4.64",
+  "version": "0.4.65",
   "assets": {
     "css/admin.css": {
       "integrity": "sha384-imfe0otYErcB8rr2h6KLSGTtStirysptpXETSPY4zLv3bZoIT75Lo1dOvkOav+xL",

package/lib/dropship-forwarding.js

@@ -95,6 +95,33 @@ var MAX_LINES              = 1000;
 
 // ---- FSM definition -----------------------------------------------------
 
+// The legal edges, hoisted so the same table drives both b.fsm's
+// in-memory validation AND the side-effect-free (from,event)->to
+// resolver below. Keeping one source means the resolver can never
+// drift from the machine the guard validates against.
+var DROPSHIP_TRANSITIONS = [
+  { from: "queued",    to: "accepted",  on: "accept"   },
+  { from: "queued",    to: "failed",    on: "fail"     },
+  { from: "accepted",  to: "shipped",   on: "ship"     },
+  { from: "accepted",  to: "failed",    on: "fail"     },
+  { from: "shipped",   to: "delivered", on: "deliver"  },
+  { from: "shipped",   to: "failed",    on: "fail"     },
+  { from: "shipped",   to: "returned",  on: "return"   },
+  { from: "delivered", to: "returned",  on: "return"   },
+];
+
+// (from,event) -> to-state. State + event names are identifier-shaped
+// (no whitespace, enforced by b.fsm at define time), so a single space
+// is an unambiguous key separator. Lets us compute the destination
+// status for the atomic-claim UPDATE without calling b.fsm.transition()
+// (which would emit a "success" audit event before we know the claim
+// actually won the race).
+var _DROPSHIP_TO = Object.create(null);
+for (var _dti = 0; _dti < DROPSHIP_TRANSITIONS.length; _dti += 1) {
+  _DROPSHIP_TO[DROPSHIP_TRANSITIONS[_dti].from + " " + DROPSHIP_TRANSITIONS[_dti].on] =
+    DROPSHIP_TRANSITIONS[_dti].to;
+}
+
 var _dsFsm = null;
 function _getDropshipFsm() {
   if (_dsFsm) return _dsFsm;
@@ -113,16 +140,7 @@ function _getDropshipFsm() {
       failed:    {},
       returned:  {},
     },
-    transitions: [
-      { from: "queued",    to: "accepted",  on: "accept"   },
-      { from: "queued",    to: "failed",    on: "fail"     },
-      { from: "accepted",  to: "shipped",   on: "ship"     },
-      { from: "accepted",  to: "failed",    on: "fail"     },
-      { from: "shipped",   to: "delivered", on: "deliver"  },
-      { from: "shipped",   to: "failed",    on: "fail"     },
-      { from: "shipped",   to: "returned",  on: "return"   },
-      { from: "delivered", to: "returned",  on: "return"   },
-    ],
+    transitions: DROPSHIP_TRANSITIONS,
   });
   return _dsFsm;
 }
@@ -288,16 +306,25 @@ function create(opts) {
       history: [],
       context: {},
     });
-    try {
-      await instance.transition(event, null);
-    } catch (e) {
-      var err = new Error("dropship-forwarding: forwarding transition refused — " + (e && e.message || e));
-      err.code  = (e && e.code) || "DROPSHIP_FORWARDING_TRANSITION_REFUSED";
-      err.cause = e;
+    // Validate the legal edge IN MEMORY with `can` — it runs the same
+    // edge + guard check `transition` does but is side-effect-free (no
+    // state mutation, no audit emit). We DON'T call `transition` here:
+    // it emits a "success" `fsm.dropship_forwarding.transition` audit
+    // event, and emitting before the atomic claim below would record a
+    // phantom success for a caller that goes on to LOSE the race (the
+    // conditional UPDATE matches zero rows). The real transition() emit
+    // is deferred to the winning branch.
+    if (!instance.can(event)) {
+      var err = new Error("dropship-forwarding: forwarding transition refused — illegal edge '" +
+        event + "' from state '" + current.status + "'");
+      err.code = "DROPSHIP_FORWARDING_TRANSITION_REFUSED";
       throw err;
     }
+    // `can` returned true, so (current.status, event) is a declared edge
+    // and the resolver always has its to-state.
+    var toState = _DROPSHIP_TO[current.status + " " + event];
     var sets = ["status = ?1"];
-    var params = [instance.state];
+    var params = [toState];
     var p = 2;
     var keys = Object.keys(patch || {});
     for (var i = 0; i < keys.length; i += 1) {
@@ -316,11 +343,36 @@ function create(opts) {
       params.push(patch[k]);
       p += 1;
     }
-    params.push(forwardingId);
-    await query(
-      "UPDATE dropship_forwardings SET " + sets.join(", ") + " WHERE id = ?" + p,
+    params.push(forwardingId);       // ?p
+    params.push(current.status);     // ?(p+1)
+    // Cross-instance atomic claim — the transaction substitute on the D1
+    // bridge. b.fsm `can` above only validates the legal edge IN MEMORY
+    // (its lock is per-instance, and each request restores a fresh
+    // instance), so two concurrent transitions on the same row both pass
+    // it. Gating the write on the row STILL being in the from-state we
+    // validated against (`AND status = <from>`) is the single-statement
+    // serialization point: exactly one writer changes the row, the loser
+    // changes zero rows and is refused (no stale-edge clobber).
+    var upd = await query(
+      "UPDATE dropship_forwardings SET " + sets.join(", ") +
+      " WHERE id = ?" + p + " AND status = ?" + (p + 1),
       params,
     );
+    if (Number(upd.rowCount || 0) !== 1) {
+      var raced = new Error("dropship-forwarding: forwarding " + forwardingId +
+        " changed state concurrently (no longer " + current.status + ") — transition refused");
+      raced.code = "DROPSHIP_FORWARDING_TRANSITION_REFUSED";
+      throw raced;
+    }
+    // We won the atomic claim — the row really did advance
+    // current.status -> toState. NOW drive the transition through b.fsm
+    // so its `fsm.dropship_forwarding.transition=success` audit event
+    // fires exactly once and only for the writer that actually changed
+    // the row. `can` above already validated this edge, so transition()
+    // cannot refuse; its own audit emit is drop-silent, and the row is
+    // already persisted, so a throw here must never fail the caller.
+    try { await instance.transition(event, null); }
+    catch (_emitErr) { /* edge pre-validated by can(); audit emit is best-effort */ }
     return await _getForwardingRow(forwardingId);
   }
 

package/lib/order-export.js

@@ -576,18 +576,42 @@ function create(opts) {
       if (!row) throw new TypeError("order-export.cancelExport: " + exportId + " not found");
       var fsm = _getExportFsm();
       var inst = fsm.restore({ state: row.status, history: [], context: {} });
-      try { await inst.transition("cancel", null); }
-      catch (e) {
-        var err = new Error("order-export.cancelExport: refused — " + (e && e.message || e));
-        err.code = (e && e.code) || "ORDER_EXPORT_CANCEL_REFUSED";
-        err.cause = e;
+      // Validate the legal edge with `can` — same edge + guard check as
+      // transition() but side-effect-free (no state mutation, no audit
+      // emit). We deliberately do NOT call transition() here: it emits a
+      // "success" fsm.scheduled_export.transition audit event, and
+      // emitting before the atomic claim below would record a phantom
+      // success for a caller that then LOSES the race (the conditional
+      // UPDATE matches zero rows). transition()'s real emit is deferred
+      // to the winning branch.
+      if (!inst.can("cancel")) {
+        var err = new Error("order-export.cancelExport: refused — illegal edge 'cancel' from state '" + row.status + "'");
+        err.code = "ORDER_EXPORT_CANCEL_REFUSED";
         throw err;
       }
       var ts = _now();
-      await query(
-        "UPDATE scheduled_exports SET status = 'cancelled', completed_at = ?1 WHERE id = ?2",
-        [ts, exportId],
+      // Atomic claim — the cross-instance serialization point. b.fsm
+      // validated the edge IN MEMORY only (per-request instance, per-
+      // instance lock), so two concurrent transitions (e.g. cancel racing
+      // markExportRunning) both pass it; gating the write on the row STILL
+      // being in the from-state we read makes the loser change 0 rows.
+      var upd = await query(
+        "UPDATE scheduled_exports SET status = 'cancelled', completed_at = ?1 " +
+        "WHERE id = ?2 AND status = ?3",
+        [ts, exportId, row.status],
       );
+      if (Number(upd.rowCount || 0) !== 1) {
+        var raced = new Error("order-export.cancelExport: " + exportId +
+          " changed state concurrently (no longer " + row.status + ") — refused");
+        raced.code = "ORDER_EXPORT_CANCEL_REFUSED";
+        throw raced;
+      }
+      // Won the claim — drive the real transition so its audit event
+      // fires exactly once, only for the writer that changed the row.
+      // can() pre-validated the edge; transition()'s emit is drop-silent
+      // and the row is already persisted, so its throw never reaches the
+      // caller.
+      try { await inst.transition("cancel", null); } catch (_emitErr) { /* audit emit best-effort */ }
       return await _getExport(exportId);
     },
 
@@ -626,18 +650,28 @@ function create(opts) {
       if (!row) throw new TypeError("order-export.markExportRunning: " + exportId + " not found");
       var fsm = _getExportFsm();
       var inst = fsm.restore({ state: row.status, history: [], context: {} });
-      try { await inst.transition("start", null); }
-      catch (e) {
-        var err = new Error("order-export.markExportRunning: refused — " + (e && e.message || e));
-        err.code = (e && e.code) || "ORDER_EXPORT_START_REFUSED";
-        err.cause = e;
+      // Validate with side-effect-free `can` (no audit emit); defer the
+      // real transition() emit to the winning branch (see cancelExport).
+      if (!inst.can("start")) {
+        var err = new Error("order-export.markExportRunning: refused — illegal edge 'start' from state '" + row.status + "'");
+        err.code = "ORDER_EXPORT_START_REFUSED";
         throw err;
       }
       var ts = _now();
-      await query(
-        "UPDATE scheduled_exports SET status = 'running', started_at = ?1 WHERE id = ?2",
-        [ts, exportId],
+      // Atomic claim (see cancelExport): gate on the observed from-state.
+      var upd = await query(
+        "UPDATE scheduled_exports SET status = 'running', started_at = ?1 " +
+        "WHERE id = ?2 AND status = ?3",
+        [ts, exportId, row.status],
       );
+      if (Number(upd.rowCount || 0) !== 1) {
+        var raced = new Error("order-export.markExportRunning: " + exportId +
+          " changed state concurrently (no longer " + row.status + ") — refused");
+        raced.code = "ORDER_EXPORT_START_REFUSED";
+        throw raced;
+      }
+      // Won the claim — emit the real transition (see cancelExport).
+      try { await inst.transition("start", null); } catch (_emitErr) { /* audit emit best-effort */ }
       return await _getExport(exportId);
     },
 
@@ -655,19 +689,28 @@ function create(opts) {
       if (!row) throw new TypeError("order-export.markExportComplete: " + input.export_id + " not found");
       var fsm = _getExportFsm();
       var inst = fsm.restore({ state: row.status, history: [], context: {} });
-      try { await inst.transition("complete", null); }
-      catch (e) {
-        var err = new Error("order-export.markExportComplete: refused — " + (e && e.message || e));
-        err.code = (e && e.code) || "ORDER_EXPORT_COMPLETE_REFUSED";
-        err.cause = e;
+      // Validate with side-effect-free `can` (no audit emit); defer the
+      // real transition() emit to the winning branch (see cancelExport).
+      if (!inst.can("complete")) {
+        var err = new Error("order-export.markExportComplete: refused — illegal edge 'complete' from state '" + row.status + "'");
+        err.code = "ORDER_EXPORT_COMPLETE_REFUSED";
         throw err;
       }
       var ts = _now();
-      await query(
+      // Atomic claim (see cancelExport): gate on the observed from-state.
+      var upd = await query(
         "UPDATE scheduled_exports SET status = 'complete', row_count = ?1, " +
-        "byte_size = ?2, file_sha3_512 = ?3, completed_at = ?4 WHERE id = ?5",
-        [input.row_count, input.byte_size, input.file_sha3_512, ts, input.export_id],
+        "byte_size = ?2, file_sha3_512 = ?3, completed_at = ?4 WHERE id = ?5 AND status = ?6",
+        [input.row_count, input.byte_size, input.file_sha3_512, ts, input.export_id, row.status],
       );
+      if (Number(upd.rowCount || 0) !== 1) {
+        var raced = new Error("order-export.markExportComplete: " + input.export_id +
+          " changed state concurrently (no longer " + row.status + ") — refused");
+        raced.code = "ORDER_EXPORT_COMPLETE_REFUSED";
+        throw raced;
+      }
+      // Won the claim — emit the real transition (see cancelExport).
+      try { await inst.transition("complete", null); } catch (_emitErr) { /* audit emit best-effort */ }
       return await _getExport(input.export_id);
     },
 
@@ -687,18 +730,28 @@ function create(opts) {
       if (!row) throw new TypeError("order-export.markExportFailed: " + input.export_id + " not found");
       var fsm = _getExportFsm();
       var inst = fsm.restore({ state: row.status, history: [], context: {} });
-      try { await inst.transition("fail", null); }
-      catch (e) {
-        var err = new Error("order-export.markExportFailed: refused — " + (e && e.message || e));
-        err.code = (e && e.code) || "ORDER_EXPORT_FAIL_REFUSED";
-        err.cause = e;
+      // Validate with side-effect-free `can` (no audit emit); defer the
+      // real transition() emit to the winning branch (see cancelExport).
+      if (!inst.can("fail")) {
+        var err = new Error("order-export.markExportFailed: refused — illegal edge 'fail' from state '" + row.status + "'");
+        err.code = "ORDER_EXPORT_FAIL_REFUSED";
         throw err;
       }
       var ts = _now();
-      await query(
-        "UPDATE scheduled_exports SET status = 'failed', error = ?1, completed_at = ?2 WHERE id = ?3",
-        [errorText, ts, input.export_id],
+      // Atomic claim (see cancelExport): gate on the observed from-state.
+      var upd = await query(
+        "UPDATE scheduled_exports SET status = 'failed', error = ?1, completed_at = ?2 " +
+        "WHERE id = ?3 AND status = ?4",
+        [errorText, ts, input.export_id, row.status],
       );
+      if (Number(upd.rowCount || 0) !== 1) {
+        var raced = new Error("order-export.markExportFailed: " + input.export_id +
+          " changed state concurrently (no longer " + row.status + ") — refused");
+        raced.code = "ORDER_EXPORT_FAIL_REFUSED";
+        throw raced;
+      }
+      // Won the claim — emit the real transition (see cancelExport).
+      try { await inst.transition("fail", null); } catch (_emitErr) { /* audit emit best-effort */ }
       return await _getExport(input.export_id);
     },
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/blamejs-shop",
-  "version": "0.4.64",
+  "version": "0.4.65",
   "description": "Open-source framework built on blamejs. Vendored stack, zero npm runtime deps, PQC-first crypto, security-on by default.",
   "main": "lib/index.js",
   "scripts": {