@blamejs/blamejs-shop 0.4.61 → 0.4.63

package/lib/suggestion-box.js

@@ -754,11 +754,44 @@ function create(opts) {
     var ts        = _now();
     var srcVotes  = Number(src.vote_count) || 0;
 
-    await query(
+    // Atomic claim: flip the source to 'duplicate' under a WHERE that
+    // re-asserts the JS preconditions (not already a duplicate, not
+    // archived). SQLite/D1 serializes writers, so this conditional
+    // UPDATE is the exactly-once gate — two concurrent linkers both
+    // pass the read-time checks above, but only one wins this claim.
+    // The loser (rowCount === 0) did NOT transition the row, so it
+    // must NOT migrate votes a second time (which would double-count
+    // srcVotes onto the canonical); it returns the already-linked row.
+    var claim = await query(
       "UPDATE suggestions SET status = 'duplicate', canonical_id = ?1, " +
-      "vote_count = 0, updated_at = ?2 WHERE id = ?3",
+      "vote_count = 0, updated_at = ?2 " +
+      "WHERE id = ?3 AND status <> 'duplicate' AND archived_at IS NULL",
       [cid, ts, sid],
     );
+    if (Number(claim.rowCount || 0) !== 1) {
+      // Lost the race (a concurrent linkDuplicates already flipped the
+      // source) — or it was archived between the read and the claim.
+      // Re-read to distinguish: a row now in 'duplicate' is the
+      // expected concurrent-link outcome, so return it idempotently;
+      // anything else means the precondition genuinely no longer holds.
+      var current = await _getRaw(sid);
+      if (current && current.status === "duplicate") {
+        return {
+          suggestion_id:    sid,
+          canonical_id:     current.canonical_id,
+          migrated_votes:   0,
+          source:           _decode(current),
+          canonical:        _decode(await _getRaw(current.canonical_id)),
+        };
+      }
+      var lost = new Error("suggestionBox.linkDuplicates: source could not be claimed for linking");
+      lost.code = "SUGGESTION_ALREADY_DUPLICATE";
+      throw lost;
+    }
+
+    // Only the claim winner reaches here — migrate the source's net
+    // vote_count (captured from the row this claim transitioned) onto
+    // the canonical exactly once.
     if (srcVotes !== 0) {
       await query(
         "UPDATE suggestions SET vote_count = vote_count + ?1, updated_at = ?2 WHERE id = ?3",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/blamejs-shop",
-  "version": "0.4.61",
+  "version": "0.4.63",
   "description": "Open-source framework built on blamejs. Vendored stack, zero npm runtime deps, PQC-first crypto, security-on by default.",
   "main": "lib/index.js",
   "scripts": {