@blamejs/blamejs-shop 0.4.121 → 0.4.122

package/CHANGELOG.md

@@ -8,6 +8,8 @@ upgrading across more than a few patches at a time.
 
 ## v0.4.x
 
+- v0.4.122 (2026-06-26) — **Loyalty points are clawed back against the goods subtotal they were earned on, not the order's grand total.** Loyalty points are earned on an order's goods value. When an order was refunded, the points clawback was computed as a proportion of the GRAND total instead — so refunding the full goods value while keeping non-refundable shipping or tax clawed back less than all of the earned points, letting a customer keep loyalty points on goods they had fully returned (a buy-then-return rewards-farming gap). The clawback now ratios against the DISCOUNTED goods value (the subtotal minus any order discount — the cash the customer actually paid for the goods), so returning the full goods value reverses all earned points even when shipping or tax is retained; the refund is applied goods-first (capped at the goods value). Separately, the clawback's points-times-amount product is now computed in BigInt, so a very large order can no longer drift the floored result by a point. Loyalty-tender restoration (returning points that were spent at checkout) still ratios against the cash refund and is unchanged. **Fixed:** *Earned-points clawback ratios against the discounted goods value, not the grand total* — Points are awarded on an order's goods value, but the refund clawback divided the refunded amount by the order's grand total. On an order carrying tax or shipping the grand total is larger than the goods value, so refunding the full goods value never reached a 100% clawback — the customer kept a slice of points on goods they fully returned. The refund path now passes the DISCOUNTED goods value — the subtotal minus any order discount, i.e. the cash actually paid for the goods — as the clawback base (the refund is treated goods-first and capped at that value), so a full goods return reverses all earned points even when non-refundable shipping or tax is kept, and a discounted order is no longer under-clawed. The terminal full-refund edge still claws 100%, and loyalty points spent as a checkout tender are still restored against the cash refunded. · *The proportional clawback computes points-times-amount in BigInt* — The clawback's points-awarded times refunded-amount product was computed with floating-point arithmetic. On a sufficiently large order the product can exceed the exact-integer range and drift the floored clawback by a point. It is now computed in BigInt — matching the framework's convention for money-by-quantity products — so the clawed amount is exact at any order size.
+
 - v0.4.121 (2026-06-26) — **Vendor-invoice reconciliation values each PO line at its own cost, and a vendor's invoices must share one currency.** Two fixes to vendor-invoice reconciliation and reporting. When the same SKU appeared on more than one purchase order at different unit costs, reconcileAgainstPOs summed the received quantity across the POs but valued all of it at the LAST PO's unit cost, inflating the PO received value and corrupting the over-billing variance the operator relies on to catch a vendor over-bill before paying. Each PO line is now valued at its own unit cost and accumulated, so the received value and the variance are exact, and the per-unit figure shown in the line variance is a true weighted mean. Separately, a vendor's invoices may now only be recorded in one currency: the accounts-payable aging report and the vendor scorecard sum amounts per vendor into a single figure, which is meaningless across currencies, so an invoice whose currency differs from the vendor's existing invoices is refused at write time rather than silently producing an incommensurable total. **Fixed:** *PO reconciliation values each purchase-order line at its own unit cost* — reconcileAgainstPOs aggregated purchase-order lines per SKU, accumulating the received quantity across POs but overwriting the unit cost with each successive PO's — so when the same SKU was received on two POs at different prices, the received value was computed as the combined quantity times the last PO's cost. That inflated po_received_value_minor and the variance the operator uses to spot a vendor over-bill before payment. Each PO line is now valued at its own unit cost and the values accumulated, so the received value and variance are exact; the line-variance's per-unit cost is reported as the true weighted mean of the received value. · *A vendor's invoices must all be recorded in the same currency* — The accounts-payable aging report and the vendor scorecard sum each vendor's invoice amounts into a single figure, which is only meaningful within one currency — mixing currencies produced an incommensurable total with no currency tag to unwind it. Recording an invoice whose currency differs from the vendor's existing invoices is now refused with a clear error, so those per-vendor totals stay within a single currency by construction.
 
 - v0.4.120 (2026-06-26) — **Splitting a discount across order lines no longer rounds a line's share negative.** When an order-level discount is allocated across the order's lines (proportionally, equally, or by quantity), each line's share was rounded independently with half-even rounding. Independently rounded shares can sum to MORE than the discount, which drove the leftover remainder negative and produced a negative discount on one line — and the checkout recorder, which rejects a negative share, then dropped the whole allocation breakdown, leaving nothing for a later per-line partial refund to draw on. Reversing an allocation for a refund had the same flaw and could persist a negative per-line refund (a charge-back on that line). The split now composes the framework's largest-remainder allocator: it floors each share and hands out the non-negative leftover one minor unit at a time, so every line's share is non-negative, the shares sum to the discount (or the refund) exactly, and no breakdown is dropped. The only visible change is which line absorbs a leftover cent — now the line with the largest fractional remainder rather than the highest subtotal. **Fixed:** *Per-line discount and refund shares are floored and distributed, never rounded negative* — The per-line discount split rounded each share half-even and independently, so the rounded shares could sum above the discount, send the remainder negative, and assign a negative discount to one line; the checkout path then dropped the breakdown (its recorder refuses a negative share), so a subsequent per-line refund had no recorded allocation to subtract. The reverse path likewise could persist a negative per-line refund. Both now compose the framework's largest-remainder allocator, which floors each share and distributes the non-negative leftover one minor unit at a time to the largest remainders — every share is non-negative, the shares sum exactly to the total, and the allocation is recorded. The leftover cent now lands on the largest-remainder line instead of the highest-subtotal line.

package/lib/asset-manifest.json

@@ -1,5 +1,5 @@
 {
-  "version": "0.4.121",
+  "version": "0.4.122",
   "assets": {
     "css/admin.css": {
       "integrity": "sha384-imfe0otYErcB8rr2h6KLSGTtStirysptpXETSPY4zLv3bZoIT75Lo1dOvkOav+xL",

package/lib/loyalty-earn-rules.js

@@ -808,7 +808,13 @@ function create(opts) {
       var awarded = Number(row.points_awarded || 0);
       if (awarded <= 0) continue;
       var already = Number(row.clawed_points || 0);
-      var target  = Math.floor((awarded * effRefunded) / orderTotalMinor);
+      // BigInt math — awarded (up to the 1e9 per-event cap) times effRefunded
+      // (minor units, unbounded) can exceed 2^53 on a large order, where a
+      // float multiply drifts and the floored claw is off by a point. BigInt
+      // division floors toward zero, matching Math.floor for these
+      // non-negative operands; the quotient is < awarded so it returns to a
+      // safe Number.
+      var target  = Number((BigInt(awarded) * BigInt(effRefunded)) / BigInt(orderTotalMinor));
       if (target > awarded) target = awarded;
       var delta = target - already;
       if (delta <= 0) continue;

package/lib/order.js

@@ -839,16 +839,24 @@ function create(opts) {
               });
             }).catch(function () { /* drop-silent — loyalty ledger holds its own audit trail */ });
           }
-          // Loyalty points EARNED on the purchase — clawed back proportionally
-          // (full, on a death edge). Detached + drop-silent; clawed_points
-          // makes the claw idempotent and convergent across partial slices.
-          if (loyaltyEarnRules && typeof loyaltyEarnRules.reverseForEventProRata === "function") {
+          // Loyalty points EARNED on the purchase — clawed back proportionally.
+          // The claw ratios against the DISCOUNTED goods value (subtotal minus
+          // any order discount) — the cash the customer actually paid for the
+          // goods the points were earned on, and the most a goods refund can
+          // return. A full-refund death edge refunds the whole order, so
+          // effRefunded (capped at the goods value) reaches it and the claw is
+          // 100% even when non-refundable shipping/tax is kept. Ratioing
+          // against the raw (pre-discount) subtotal would under-claw a
+          // discounted order. Detached + drop-silent; clawed_points makes the
+          // claw idempotent and convergent across partial slices.
+          var _revGoods = (Number(refreshed.subtotal_minor) || 0) - (Number(refreshed.discount_minor) || 0);
+          if (_revGoods > 0 && loyaltyEarnRules && typeof loyaltyEarnRules.reverseForEventProRata === "function") {
             Promise.resolve().then(function () {
               return loyaltyEarnRules.reverseForEventProRata({
                 customer_id:       _revCustomer,
                 trigger_event_ref: "order:" + _revOrderId,
                 refunded_minor:    _refTotal,
-                order_total_minor: _refTotal,
+                order_total_minor: _revGoods,
               });
             }).catch(function () { /* drop-silent — loyalty ledger holds its own audit trail */ });
           }
@@ -1079,9 +1087,13 @@ function create(opts) {
       // the customer back more than the operator refunded. The provider can
       // never refund more than the cash it captured, so a cash-only partial
       // refund leaves the non-cash tenders untouched here; they are returned
-      // by the terminal full-refund edge. Earned-loyalty clawback stays
-      // proportional to the FULL order total — points were earned on the whole
-      // order, and clawing them back is not part of the value-return path.
+      // by the terminal full-refund edge. Earned-loyalty clawback ratios
+      // against the DISCOUNTED goods value (subtotal minus any order discount)
+      // — the cash paid for the goods the points were earned on — NOT the
+      // grand total: refunding the full goods value claws all earned points
+      // even when non-refundable shipping/tax is kept (the refund is
+      // goods-first, capped at the goods value). Clawing is not part of the
+      // value-return path above.
       var _ptTotal = Number(current.grand_total_minor) || 0;
       if (_ptTotal > 0) {
         var _ptRefunded = await this.refundedTotalMinor(orderId);
@@ -1108,13 +1120,14 @@ function create(opts) {
               });
             }).catch(function () { /* drop-silent — loyalty ledger holds its own audit trail */ });
           }
-          if (loyaltyEarnRules && typeof loyaltyEarnRules.reverseForEventProRata === "function") {
+          var _ptGoods = (Number(current.subtotal_minor) || 0) - (Number(current.discount_minor) || 0);
+          if (_ptGoods > 0 && loyaltyEarnRules && typeof loyaltyEarnRules.reverseForEventProRata === "function") {
             Promise.resolve().then(function () {
               return loyaltyEarnRules.reverseForEventProRata({
                 customer_id:       _ptCust,
                 trigger_event_ref: "order:" + orderId,
                 refunded_minor:    _ptRefunded,
-                order_total_minor: _ptTotal,
+                order_total_minor: _ptGoods,
               });
             }).catch(function () { /* drop-silent — loyalty ledger holds its own audit trail */ });
           }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/blamejs-shop",
-  "version": "0.4.121",
+  "version": "0.4.122",
   "description": "Open-source framework built on blamejs. Vendored stack, zero npm runtime deps, PQC-first crypto, security-on by default.",
   "main": "lib/index.js",
   "scripts": {