@blamejs/blamejs-shop 0.3.44 → 0.3.46

package/lib/subscription-analytics.js

@@ -185,6 +185,18 @@ var CADENCE_TO_MONTHLY = {
   year:  1 / 12,
 };
 
+// Exact rational [numerator, denominator] forms of the cadence factors
+// above, used by _monthlyMinor so the monthly-normalized minor-unit
+// figure is computed in BigInt (half-even) with no float intermediate.
+// The float CADENCE_TO_MONTHLY view above is retained only for the
+// display-only dashboard export.
+var CADENCE_TO_MONTHLY_RATIO = {
+  day:   [30n, 1n],
+  week:  [30n, 7n],
+  month: [1n, 1n],
+  year:  [1n, 12n],
+};
+
 // Active = (status in active/trialing) AND not cancelled AND not paused.
 var ACTIVE_STATUSES = ["active", "trialing"];
 
@@ -325,27 +337,28 @@ function _canonicalJson(value) {
 
 // ---- cadence normalization ---------------------------------------------
 //
-// Plan amount × quantity normalized to a single monthly figure. Uses
-// banker's rounding (round-half-to-even) on the final minor-unit total
-// so two interval combinations that produce e.g. 4499.5 minor units
-// don't oscillate the dashboard total by one cent between refreshes.
-
-function _bankersRound(x) {
-  var floor = Math.floor(x);
-  var diff = x - floor;
-  if (diff < 0.5) return floor;
-  if (diff > 0.5) return floor + 1;
-  // diff === 0.5 — round to even
-  return floor % 2 === 0 ? floor : floor + 1;
-}
+// Plan amount × quantity normalized to a single monthly figure. The
+// cadence factor (e.g. week → 30/7, year → 1/12) is applied as an
+// exact rational in BigInt half-even via b.money, so the monthly
+// minor-unit total carries no float rounding and two interval
+// combinations producing e.g. 4499.5 minor units settle on a stable
+// even value rather than oscillating the dashboard by a cent.
 
 function _monthlyMinor(amountMinor, interval, intervalCount, quantity) {
-  var factor = CADENCE_TO_MONTHLY[interval];
-  if (factor == null) return 0;
+  var ratio = CADENCE_TO_MONTHLY_RATIO[interval];
+  if (ratio == null) return 0;
+  if (!Number.isInteger(amountMinor)) return 0;
   var qty = Number.isInteger(quantity) && quantity > 0 ? quantity : 1;
   var ic  = Number.isInteger(intervalCount) && intervalCount > 0 ? intervalCount : 1;
-  var raw = (amountMinor * qty * factor) / ic;
-  return _bankersRound(raw);
+  // monthly = amount × qty × (num/den) / ic
+  //         = amount × qty × num / (den × ic)
+  var num = BigInt(amountMinor) * BigInt(qty) * ratio[0];
+  var den = ratio[1] * BigInt(ic);
+  return Number(
+    b.money.fromMinorUnits(num >= 0n ? num : 0n, "USD")
+      .multiply([1n, den], { rounding: "half-even" })
+      .toMinorUnits()
+  );
 }
 
 // ---- active-at predicate (in SQL) --------------------------------------

package/lib/tax.js

@@ -37,6 +37,8 @@
  *   additive `lines[].tax_class` field.
  */
 
+var b = require("./vendor/blamejs");
+
 var COUNTRY_RE = /^[A-Z]{2}$/;
 var STATE_RE   = /^[A-Z0-9]{1,5}$/;
 var POSTAL_RE  = /^[A-Za-z0-9 -]{1,16}$/;
@@ -72,6 +74,19 @@ function _nonNegInt(n, label) {
   }
 }
 
+// Multiply a non-negative minor-unit integer by the rational num/den
+// using the framework's BigInt money primitive (half-even). The result
+// is an integer minor-unit count in the SAME unit as `minor` — the
+// divisor is currency-exponent-independent, so a fixed carrier currency
+// is correct (see lib/quantity-discounts.js for the same technique).
+function _mulRational(minor, num, den) {
+  return Number(
+    b.money.fromMinorUnits(BigInt(minor), "USD")
+      .multiply([BigInt(num), BigInt(den)], { rounding: "half-even" })
+      .toMinorUnits()
+  );
+}
+
 function _validateRule(rule, i) {
   if (!rule || typeof rule !== "object") throw new TypeError("tax: rule[" + i + "] must be an object");
   _country(rule.country, "rule[" + i + "].country");
@@ -121,17 +136,9 @@ function operatorTable(opts) {
         if (_matches(rules[i], ctx.shipTo)) { matched = rules[i]; break; }
       }
       var rateBps = matched ? matched.rate_bps : 0;
-      // tax = subtotal × bps / 10000, rounded to nearest minor unit.
-      // Round-half-to-even (banker's) avoids systematic upward bias
-      // across many small carts; Math.round in JS is round-half-up,
-      // so we implement banker's by hand.
-      var raw = ctx.subtotal_minor * rateBps / 10000;
-      var floor = Math.floor(raw);
-      var frac  = raw - floor;
-      var tax;
-      if (frac < 0.5)      tax = floor;
-      else if (frac > 0.5) tax = floor + 1;
-      else                 tax = (floor % 2 === 0) ? floor : floor + 1; // even
+      // tax = subtotal × bps / 10000, half-even via b.money (BigInt —
+      // no float intermediate, exact for large subtotals).
+      var tax = _mulRational(ctx.subtotal_minor, rateBps, 10000);
       return {
         tax_minor:    tax,
         rate_bps:     rateBps,
@@ -171,18 +178,6 @@ function create(opts) {
 // primitives compose against. The operator-table adapter still owns
 // jurisdiction-rule selection.
 
-// Banker's rounding (round-half-to-even) for non-negative `raw`.
-// JS Math.round is round-half-up, which biases tax totals upward
-// across many small carts; this matches the rounding mode the
-// existing operatorTable adapter uses.
-function _bankersRound(raw) {
-  var floor = Math.floor(raw);
-  var frac  = raw - floor;
-  if (frac < 0.5) return floor;
-  if (frac > 0.5) return floor + 1;
-  return (floor % 2 === 0) ? floor : floor + 1;
-}
-
 function _currency(c) {
   if (typeof c !== "string" || !/^[A-Z]{3}$/.test(c)) {
     throw new TypeError("tax: currency must be a 3-letter ISO 4217 code (uppercase), got " + JSON.stringify(c));
@@ -210,7 +205,7 @@ function calculateInclusive(args) {
   _currency(args.currency);
   var gross = args.amount_minor;
   var rate  = args.rate_bps;
-  var tax   = _bankersRound(gross * rate / (10000 + rate));
+  var tax   = _mulRational(gross, rate, 10000 + rate);
   return {
     net_minor:   gross - tax,
     tax_minor:   tax,
@@ -237,7 +232,7 @@ function calculateExclusive(args) {
   _currency(args.currency);
   var net  = args.amount_minor;
   var rate = args.rate_bps;
-  var tax  = _bankersRound(net * rate / 10000);
+  var tax  = _mulRational(net, rate, 10000);
   return {
     net_minor:   net,
     tax_minor:   tax,

package/lib/wishlist-alerts.js

@@ -89,6 +89,7 @@
  */
 
 var b = require("./vendor/blamejs");
+var pricing = require("./pricing");
 
 var C = b.constants;
 
@@ -770,10 +771,10 @@ function create(opts) {
         var dispatchOk = false;
         try {
           var oldPriceStr = v.payload.old_amount_minor != null
-            ? String(v.payload.old_amount_minor / 100) + " " + v.payload.currency
+            ? pricing.format(v.payload.old_amount_minor, v.payload.currency)
             : "—";
           var newPriceStr = v.payload.new_amount_minor != null
-            ? String(v.payload.new_amount_minor / 100) + " " + v.payload.currency
+            ? pricing.format(v.payload.new_amount_minor, v.payload.currency)
             : "—";
           var pctStr = v.payload.discount_bps != null
             ? String(Math.floor(v.payload.discount_bps / 100)) + "%"

package/lib/wishlist-digest.js

@@ -111,6 +111,7 @@
  */
 
 var b = require("./vendor/blamejs");
+var pricing = require("./pricing");
 
 var C = b.constants;
 
@@ -781,7 +782,9 @@ function create(opts) {
       }
       var priceStr = "—";
       if (price && typeof price.amount_minor === "number") {
-        priceStr = (price.amount_minor / 100).toFixed(2) + " " + (price.currency || currency);
+        try {
+          priceStr = pricing.format(price.amount_minor, price.currency || currency);
+        } catch (_efmt) { priceStr = "—"; }
       }
 
       // Stock change — best-effort. The catalog dep doesn't guarantee

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blamejs/blamejs-shop",
-  "version": "0.3.44",
+  "version": "0.3.46",
   "description": "Open-source framework built on blamejs. Vendored stack, zero npm runtime deps, PQC-first crypto, security-on by default.",
   "main": "lib/index.js",
   "scripts": {