@blackcode_sa/metaestetics-api 1.7.10 → 1.7.12

package/src/services/reviews/reviews.service.ts

@@ -5,13 +5,9 @@ import {
   getDocs,
   query,
   where,
-  updateDoc,
   setDoc,
   deleteDoc,
-  Timestamp,
   serverTimestamp,
-  DocumentData,
-  writeBatch,
 } from "firebase/firestore";
 import { BaseService } from "../base.service";
 import {
@@ -20,9 +16,6 @@ import {
   PractitionerReview,
   ProcedureReview,
   REVIEWS_COLLECTION,
-  ClinicReviewInfo,
-  PractitionerReviewInfo,
-  ProcedureReviewInfo,
 } from "../../types/reviews";
 import {
   createReviewSchema,
@@ -32,9 +25,6 @@ import { z } from "zod";
 import { Auth } from "firebase/auth";
 import { Firestore } from "firebase/firestore";
 import { FirebaseApp } from "firebase/app";
-import { CLINICS_COLLECTION } from "../../types/clinic";
-import { PRACTITIONERS_COLLECTION } from "../../types/practitioner";
-import { PROCEDURES_COLLECTION } from "../../types/procedure";
 
 export class ReviewService extends BaseService {
   constructor(db: Firestore, auth: Auth, app: FirebaseApp) {
@@ -42,7 +32,7 @@ export class ReviewService extends BaseService {
   }
 
   /**
-   * Creates a new review and updates related entities
+   * Creates a new review
    * @param data - The review data to create
    * @param appointmentId - ID of the completed appointment
    * @returns The created review
@@ -147,34 +137,8 @@ export class ReviewService extends BaseService {
         updatedAt: serverTimestamp(),
       });
 
-      // Update related entities
-      const updatePromises: Promise<any>[] = [];
-
-      // Update clinic if clinic review exists
-      if (data.clinicReview) {
-        updatePromises.push(
-          this.updateClinicReviewInfo(data.clinicReview.clinicId)
-        );
-      }
-
-      // Update practitioner if practitioner review exists
-      if (data.practitionerReview) {
-        updatePromises.push(
-          this.updatePractitionerReviewInfo(
-            data.practitionerReview.practitionerId
-          )
-        );
-      }
-
-      // Update procedure if procedure review exists
-      if (data.procedureReview) {
-        updatePromises.push(
-          this.updateProcedureReviewInfo(data.procedureReview.procedureId)
-        );
-      }
-
-      // Wait for all updates to complete
-      await Promise.all(updatePromises);
+      // Note: Related entity updates (clinic, practitioner, procedure) are now handled
+      // by cloud functions through the ReviewsAggregationService
 
       return review;
     } catch (error) {
@@ -277,7 +241,7 @@ export class ReviewService extends BaseService {
   }
 
   /**
-   * Deletes a review and updates related entities
+   * Deletes a review
    * @param reviewId The ID of the review to delete
    */
   async deleteReview(reviewId: string): Promise<void> {
@@ -289,538 +253,8 @@ export class ReviewService extends BaseService {
     // Delete the review
     await deleteDoc(doc(this.db, REVIEWS_COLLECTION, reviewId));
 
-    // Update related entities after deletion
-    const updatePromises: Promise<any>[] = [];
-
-    if (review.clinicReview) {
-      updatePromises.push(
-        this.updateClinicReviewInfo(
-          review.clinicReview.clinicId,
-          review.clinicReview,
-          true
-        )
-      );
-    }
-
-    if (review.practitionerReview) {
-      updatePromises.push(
-        this.updatePractitionerReviewInfo(
-          review.practitionerReview.practitionerId,
-          review.practitionerReview,
-          true
-        )
-      );
-    }
-
-    if (review.procedureReview) {
-      updatePromises.push(
-        this.updateProcedureReviewInfo(
-          review.procedureReview.procedureId,
-          review.procedureReview,
-          true
-        )
-      );
-    }
-
-    // Wait for all updates to complete
-    await Promise.all(updatePromises);
-  }
-
-  /**
-   * Updates the review info for a clinic
-   * @param clinicId The ID of the clinic to update
-   * @param newReview Optional new review being added or removed
-   * @param isRemoval Whether this update is for a review removal
-   * @returns The updated clinic review info
-   */
-  async updateClinicReviewInfo(
-    clinicId: string,
-    newReview?: ClinicReview,
-    isRemoval: boolean = false
-  ): Promise<ClinicReviewInfo> {
-    // Get the current clinic document
-    const clinicDoc = await getDoc(doc(this.db, CLINICS_COLLECTION, clinicId));
-
-    if (!clinicDoc.exists()) {
-      throw new Error(`Clinic with ID ${clinicId} not found`);
-    }
-
-    const clinicData = clinicDoc.data();
-    const currentReviewInfo = (clinicData.reviewInfo as ClinicReviewInfo) || {
-      totalReviews: 0,
-      averageRating: 0,
-      cleanliness: 0,
-      facilities: 0,
-      staffFriendliness: 0,
-      waitingTime: 0,
-      accessibility: 0,
-      recommendationPercentage: 0,
-    };
-
-    // If we have no reviews and aren't adding a new one, return default values
-    if (currentReviewInfo.totalReviews === 0 && !newReview) {
-      await updateDoc(doc(this.db, CLINICS_COLLECTION, clinicId), {
-        reviewInfo: currentReviewInfo,
-        updatedAt: serverTimestamp(),
-      });
-      return currentReviewInfo;
-    }
-
-    let updatedReviewInfo: ClinicReviewInfo;
-
-    if (newReview) {
-      // Calculate new values based on existing averages and the new review
-      const oldTotal = currentReviewInfo.totalReviews;
-      const newTotal = isRemoval ? oldTotal - 1 : oldTotal + 1;
-
-      // If removing the last review, set all values to 0
-      if (newTotal === 0) {
-        updatedReviewInfo = {
-          totalReviews: 0,
-          averageRating: 0,
-          cleanliness: 0,
-          facilities: 0,
-          staffFriendliness: 0,
-          waitingTime: 0,
-          accessibility: 0,
-          recommendationPercentage: 0,
-        };
-      } else {
-        // Calculate new averages
-        const updateAverage = (
-          currentAvg: number,
-          newValue: number
-        ): number => {
-          const currentSum = currentAvg * oldTotal;
-          const newSum = isRemoval
-            ? currentSum - newValue
-            : currentSum + newValue;
-          const newAvg = newSum / newTotal;
-          return Math.round(newAvg * 10) / 10; // Round to 1 decimal
-        };
-
-        // Update recommendation percentage
-        const currentRecommendations =
-          (currentReviewInfo.recommendationPercentage / 100) * oldTotal;
-        const newRecommendations = isRemoval
-          ? newReview.wouldRecommend
-            ? currentRecommendations - 1
-            : currentRecommendations
-          : newReview.wouldRecommend
-          ? currentRecommendations + 1
-          : currentRecommendations;
-        const newRecommendationPercentage =
-          (newRecommendations / newTotal) * 100;
-
-        updatedReviewInfo = {
-          totalReviews: newTotal,
-          averageRating: updateAverage(
-            currentReviewInfo.averageRating,
-            newReview.overallRating
-          ),
-          cleanliness: updateAverage(
-            currentReviewInfo.cleanliness,
-            newReview.cleanliness
-          ),
-          facilities: updateAverage(
-            currentReviewInfo.facilities,
-            newReview.facilities
-          ),
-          staffFriendliness: updateAverage(
-            currentReviewInfo.staffFriendliness,
-            newReview.staffFriendliness
-          ),
-          waitingTime: updateAverage(
-            currentReviewInfo.waitingTime,
-            newReview.waitingTime
-          ),
-          accessibility: updateAverage(
-            currentReviewInfo.accessibility,
-            newReview.accessibility
-          ),
-          recommendationPercentage:
-            Math.round(newRecommendationPercentage * 10) / 10,
-        };
-      }
-    } else {
-      // If no new review provided, keep the current info
-      updatedReviewInfo = { ...currentReviewInfo };
-    }
-
-    // Update the clinic with the new review info
-    await updateDoc(doc(this.db, CLINICS_COLLECTION, clinicId), {
-      reviewInfo: updatedReviewInfo,
-      updatedAt: serverTimestamp(),
-    });
-
-    return updatedReviewInfo;
-  }
-
-  /**
-   * Updates the review info for a practitioner
-   * @param practitionerId The ID of the practitioner to update
-   * @param newReview Optional new review being added or removed
-   * @param isRemoval Whether this update is for a review removal
-   * @returns The updated practitioner review info
-   */
-  async updatePractitionerReviewInfo(
-    practitionerId: string,
-    newReview?: PractitionerReview,
-    isRemoval: boolean = false
-  ): Promise<PractitionerReviewInfo> {
-    // Get the current practitioner document
-    const practitionerDoc = await getDoc(
-      doc(this.db, PRACTITIONERS_COLLECTION, practitionerId)
-    );
-
-    if (!practitionerDoc.exists()) {
-      throw new Error(`Practitioner with ID ${practitionerId} not found`);
-    }
-
-    const practitionerData = practitionerDoc.data();
-    const currentReviewInfo =
-      (practitionerData.reviewInfo as PractitionerReviewInfo) || {
-        totalReviews: 0,
-        averageRating: 0,
-        knowledgeAndExpertise: 0,
-        communicationSkills: 0,
-        bedSideManner: 0,
-        thoroughness: 0,
-        trustworthiness: 0,
-        recommendationPercentage: 0,
-      };
-
-    // If we have no reviews and aren't adding a new one, return default values
-    if (currentReviewInfo.totalReviews === 0 && !newReview) {
-      await updateDoc(doc(this.db, PRACTITIONERS_COLLECTION, practitionerId), {
-        reviewInfo: currentReviewInfo,
-        updatedAt: serverTimestamp(),
-      });
-      return currentReviewInfo;
-    }
-
-    let updatedReviewInfo: PractitionerReviewInfo;
-
-    if (newReview) {
-      // Calculate new values based on existing averages and the new review
-      const oldTotal = currentReviewInfo.totalReviews;
-      const newTotal = isRemoval ? oldTotal - 1 : oldTotal + 1;
-
-      // If removing the last review, set all values to 0
-      if (newTotal === 0) {
-        updatedReviewInfo = {
-          totalReviews: 0,
-          averageRating: 0,
-          knowledgeAndExpertise: 0,
-          communicationSkills: 0,
-          bedSideManner: 0,
-          thoroughness: 0,
-          trustworthiness: 0,
-          recommendationPercentage: 0,
-        };
-      } else {
-        // Calculate new averages
-        const updateAverage = (
-          currentAvg: number,
-          newValue: number
-        ): number => {
-          const currentSum = currentAvg * oldTotal;
-          const newSum = isRemoval
-            ? currentSum - newValue
-            : currentSum + newValue;
-          const newAvg = newSum / newTotal;
-          return Math.round(newAvg * 10) / 10; // Round to 1 decimal
-        };
-
-        // Update recommendation percentage
-        const currentRecommendations =
-          (currentReviewInfo.recommendationPercentage / 100) * oldTotal;
-        const newRecommendations = isRemoval
-          ? newReview.wouldRecommend
-            ? currentRecommendations - 1
-            : currentRecommendations
-          : newReview.wouldRecommend
-          ? currentRecommendations + 1
-          : currentRecommendations;
-        const newRecommendationPercentage =
-          (newRecommendations / newTotal) * 100;
-
-        updatedReviewInfo = {
-          totalReviews: newTotal,
-          averageRating: updateAverage(
-            currentReviewInfo.averageRating,
-            newReview.overallRating
-          ),
-          knowledgeAndExpertise: updateAverage(
-            currentReviewInfo.knowledgeAndExpertise,
-            newReview.knowledgeAndExpertise
-          ),
-          communicationSkills: updateAverage(
-            currentReviewInfo.communicationSkills,
-            newReview.communicationSkills
-          ),
-          bedSideManner: updateAverage(
-            currentReviewInfo.bedSideManner,
-            newReview.bedSideManner
-          ),
-          thoroughness: updateAverage(
-            currentReviewInfo.thoroughness,
-            newReview.thoroughness
-          ),
-          trustworthiness: updateAverage(
-            currentReviewInfo.trustworthiness,
-            newReview.trustworthiness
-          ),
-          recommendationPercentage:
-            Math.round(newRecommendationPercentage * 10) / 10,
-        };
-      }
-    } else {
-      // If no new review provided, keep the current info
-      updatedReviewInfo = { ...currentReviewInfo };
-    }
-
-    // Update the practitioner with the new review info
-    await updateDoc(doc(this.db, PRACTITIONERS_COLLECTION, practitionerId), {
-      reviewInfo: updatedReviewInfo,
-      updatedAt: serverTimestamp(),
-    });
-
-    // Also update doctor info in procedures with the new rating
-    await this.updateDoctorInfoInProcedures(
-      practitionerId,
-      updatedReviewInfo.averageRating
-    );
-
-    return updatedReviewInfo;
-  }
-
-  /**
-   * Updates the review info for a procedure
-   * @param procedureId The ID of the procedure to update
-   * @param newReview Optional new review being added or removed
-   * @param isRemoval Whether this update is for a review removal
-   * @returns The updated procedure review info
-   */
-  async updateProcedureReviewInfo(
-    procedureId: string,
-    newReview?: ProcedureReview,
-    isRemoval: boolean = false
-  ): Promise<ProcedureReviewInfo> {
-    // Get the current procedure document
-    const procedureDoc = await getDoc(
-      doc(this.db, PROCEDURES_COLLECTION, procedureId)
-    );
-
-    if (!procedureDoc.exists()) {
-      throw new Error(`Procedure with ID ${procedureId} not found`);
-    }
-
-    const procedureData = procedureDoc.data();
-    const currentReviewInfo =
-      (procedureData.reviewInfo as ProcedureReviewInfo) || {
-        totalReviews: 0,
-        averageRating: 0,
-        effectivenessOfTreatment: 0,
-        outcomeExplanation: 0,
-        painManagement: 0,
-        followUpCare: 0,
-        valueForMoney: 0,
-        recommendationPercentage: 0,
-      };
-
-    // If we have no reviews and aren't adding a new one, return default values
-    if (currentReviewInfo.totalReviews === 0 && !newReview) {
-      await updateDoc(doc(this.db, PROCEDURES_COLLECTION, procedureId), {
-        reviewInfo: currentReviewInfo,
-        updatedAt: serverTimestamp(),
-      });
-      return currentReviewInfo;
-    }
-
-    let updatedReviewInfo: ProcedureReviewInfo;
-
-    if (newReview) {
-      // Calculate new values based on existing averages and the new review
-      const oldTotal = currentReviewInfo.totalReviews;
-      const newTotal = isRemoval ? oldTotal - 1 : oldTotal + 1;
-
-      // If removing the last review, set all values to 0
-      if (newTotal === 0) {
-        updatedReviewInfo = {
-          totalReviews: 0,
-          averageRating: 0,
-          effectivenessOfTreatment: 0,
-          outcomeExplanation: 0,
-          painManagement: 0,
-          followUpCare: 0,
-          valueForMoney: 0,
-          recommendationPercentage: 0,
-        };
-      } else {
-        // Calculate new averages
-        const updateAverage = (
-          currentAvg: number,
-          newValue: number
-        ): number => {
-          const currentSum = currentAvg * oldTotal;
-          const newSum = isRemoval
-            ? currentSum - newValue
-            : currentSum + newValue;
-          const newAvg = newSum / newTotal;
-          return Math.round(newAvg * 10) / 10; // Round to 1 decimal
-        };
-
-        // Update recommendation percentage
-        const currentRecommendations =
-          (currentReviewInfo.recommendationPercentage / 100) * oldTotal;
-        const newRecommendations = isRemoval
-          ? newReview.wouldRecommend
-            ? currentRecommendations - 1
-            : currentRecommendations
-          : newReview.wouldRecommend
-          ? currentRecommendations + 1
-          : currentRecommendations;
-        const newRecommendationPercentage =
-          (newRecommendations / newTotal) * 100;
-
-        updatedReviewInfo = {
-          totalReviews: newTotal,
-          averageRating: updateAverage(
-            currentReviewInfo.averageRating,
-            newReview.overallRating
-          ),
-          effectivenessOfTreatment: updateAverage(
-            currentReviewInfo.effectivenessOfTreatment,
-            newReview.effectivenessOfTreatment
-          ),
-          outcomeExplanation: updateAverage(
-            currentReviewInfo.outcomeExplanation,
-            newReview.outcomeExplanation
-          ),
-          painManagement: updateAverage(
-            currentReviewInfo.painManagement,
-            newReview.painManagement
-          ),
-          followUpCare: updateAverage(
-            currentReviewInfo.followUpCare,
-            newReview.followUpCare
-          ),
-          valueForMoney: updateAverage(
-            currentReviewInfo.valueForMoney,
-            newReview.valueForMoney
-          ),
-          recommendationPercentage:
-            Math.round(newRecommendationPercentage * 10) / 10,
-        };
-      }
-    } else {
-      // If no new review provided, keep the current info
-      updatedReviewInfo = { ...currentReviewInfo };
-    }
-
-    // Update the procedure with the new review info
-    await updateDoc(doc(this.db, PROCEDURES_COLLECTION, procedureId), {
-      reviewInfo: updatedReviewInfo,
-      updatedAt: serverTimestamp(),
-    });
-
-    return updatedReviewInfo;
-  }
-
-  /**
-   * Updates doctorInfo rating in all procedures for a practitioner
-   * @param practitionerId The ID of the practitioner
-   * @param rating The new rating to set
-   */
-  private async updateDoctorInfoInProcedures(
-    practitionerId: string,
-    rating: number
-  ): Promise<void> {
-    // Find all procedures for this practitioner
-    const q = query(
-      collection(this.db, PROCEDURES_COLLECTION),
-      where("practitionerId", "==", practitionerId)
-    );
-
-    const snapshot = await getDocs(q);
-
-    if (snapshot.empty) {
-      return;
-    }
-
-    // Batch update all procedures
-    const batch = writeBatch(this.db);
-
-    snapshot.docs.forEach((docSnapshot) => {
-      const procedureRef = doc(this.db, PROCEDURES_COLLECTION, docSnapshot.id);
-      batch.update(procedureRef, {
-        "doctorInfo.rating": rating,
-        updatedAt: serverTimestamp(),
-      });
-    });
-
-    await batch.commit();
-  }
-
-  /**
-   * Verifies a review as checked by admin/staff
-   * @param reviewId The ID of the review to verify
-   */
-  async verifyReview(reviewId: string): Promise<void> {
-    const review = await this.getReview(reviewId);
-    if (!review) {
-      throw new Error(`Review with ID ${reviewId} not found`);
-    }
-
-    const batch = writeBatch(this.db);
-
-    // Update main review document
-    batch.update(doc(this.db, REVIEWS_COLLECTION, reviewId), {
-      updatedAt: serverTimestamp(),
-    });
-
-    // Update clinic review if it exists
-    if (review.clinicReview) {
-      review.clinicReview.isVerified = true;
-    }
-
-    // Update practitioner review if it exists
-    if (review.practitionerReview) {
-      review.practitionerReview.isVerified = true;
-    }
-
-    // Update procedure review if it exists
-    if (review.procedureReview) {
-      review.procedureReview.isVerified = true;
-    }
-
-    await batch.commit();
-
-    // Update all related entities
-    const updatePromises: Promise<any>[] = [];
-
-    if (review.clinicReview) {
-      updatePromises.push(
-        this.updateClinicReviewInfo(review.clinicReview.clinicId)
-      );
-    }
-
-    if (review.practitionerReview) {
-      updatePromises.push(
-        this.updatePractitionerReviewInfo(
-          review.practitionerReview.practitionerId
-        )
-      );
-    }
-
-    if (review.procedureReview) {
-      updatePromises.push(
-        this.updateProcedureReviewInfo(review.procedureReview.procedureId)
-      );
-    }
-
-    await Promise.all(updatePromises);
+    // Note: Updates to related entities after deletion are now handled
+    // by cloud functions through the ReviewsAggregationService
   }
 
   /**

package/src/types/clinic/index.ts

@@ -19,6 +19,7 @@ import {
   ClinicTag,
   ClinicPhotoTag,
 } from "./preferences.types";
+import type { MediaResource } from "../../services/media/media.service";
 
 export * from "./preferences.types";
 
@@ -203,6 +204,10 @@ export interface ClinicGroup {
   calendarSyncEnabled?: boolean;
   autoConfirmAppointments?: boolean;
   businessIdentificationNumber?: string | null;
+  onboarding?: {
+    completed?: boolean;
+    step?: number;
+  };
 }
 
 /**
@@ -223,6 +228,10 @@ export interface CreateClinicGroupData {
   calendarSyncEnabled?: boolean;
   autoConfirmAppointments?: boolean;
   businessIdentificationNumber?: string | null;
+  onboarding?: {
+    completed?: boolean;
+    step?: number;
+  };
 }
 
 /**
@@ -253,11 +262,6 @@ export interface DoctorInfo {
   // TODO: Add aggregated fields, like rating, reviews, services this doctor provides in this clinic and similar
 }
 
-/**
- * Type that allows a field to be either a URL string or a File object
- */
-export type MediaResource = string | File | Blob;
-
 /**
  * Interface for clinic
  */
@@ -330,6 +334,10 @@ export interface CreateDefaultClinicGroupData {
   practiceType?: PracticeType;
   languages?: Language[];
   subscriptionModel?: SubscriptionModel;
+  onboarding?: {
+    completed?: boolean;
+    step?: number;
+  };
 }
 
 /**
@@ -364,6 +372,10 @@ export interface ClinicGroupSetupData {
   calendarSyncEnabled: boolean;
   autoConfirmAppointments: boolean;
   businessIdentificationNumber: string | null;
+  onboarding?: {
+    completed?: boolean;
+    step?: number;
+  };
 }
 
 /**