@blackcode_sa/metaestetics-api 1.13.15 → 1.13.17

package/dist/index.d.mts

@@ -7609,6 +7609,15 @@ declare class AppointmentService extends BaseService {
      * @returns The updated appointment
      */
     addAfterPhotoToEntry(appointmentId: string, zoneId: string, photoIndex: number, afterPhotoUrl: MediaResource, afterNote?: string): Promise<Appointment>;
+    /**
+     * Removes an after photo from an existing entry (keeps the before photo)
+     *
+     * @param appointmentId ID of the appointment
+     * @param zoneId ID of the zone
+     * @param photoIndex Index of the entry to remove after photo from
+     * @returns The updated appointment
+     */
+    removeAfterPhotoFromEntry(appointmentId: string, zoneId: string, photoIndex: number): Promise<Appointment>;
     /**
      * Updates notes for a photo entry
      *

package/dist/index.d.ts

@@ -7609,6 +7609,15 @@ declare class AppointmentService extends BaseService {
      * @returns The updated appointment
      */
     addAfterPhotoToEntry(appointmentId: string, zoneId: string, photoIndex: number, afterPhotoUrl: MediaResource, afterNote?: string): Promise<Appointment>;
+    /**
+     * Removes an after photo from an existing entry (keeps the before photo)
+     *
+     * @param appointmentId ID of the appointment
+     * @param zoneId ID of the zone
+     * @param photoIndex Index of the entry to remove after photo from
+     * @returns The updated appointment
+     */
+    removeAfterPhotoFromEntry(appointmentId: string, zoneId: string, photoIndex: number): Promise<Appointment>;
     /**
      * Updates notes for a photo entry
      *

package/dist/index.js

@@ -5328,6 +5328,12 @@ async function updateZonePhotoNotesUtil(db, appointmentId, zoneId, photoIndex, b
   }
   return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, updates);
 }
+async function removeAfterPhotoFromEntryUtil(db, appointmentId, zoneId, photoIndex) {
+  return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, {
+    after: null,
+    afterNote: null
+  });
+}
 async function getZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex) {
   var _a;
   const appointment = await getAppointmentOrThrow(db, appointmentId);
@@ -6767,6 +6773,30 @@ var AppointmentService = class extends BaseService {
       throw error;
     }
   }
+  /**
+   * Removes an after photo from an existing entry (keeps the before photo)
+   *
+   * @param appointmentId ID of the appointment
+   * @param zoneId ID of the zone
+   * @param photoIndex Index of the entry to remove after photo from
+   * @returns The updated appointment
+   */
+  async removeAfterPhotoFromEntry(appointmentId, zoneId, photoIndex) {
+    try {
+      console.log(
+        `[APPOINTMENT_SERVICE] Removing after photo from entry at index ${photoIndex} for zone ${zoneId}`
+      );
+      return await removeAfterPhotoFromEntryUtil(
+        this.db,
+        appointmentId,
+        zoneId,
+        photoIndex
+      );
+    } catch (error) {
+      console.error(`[APPOINTMENT_SERVICE] Error removing after photo from entry:`, error);
+      throw error;
+    }
+  }
   /**
    * Updates notes for a photo entry
    *
@@ -21125,7 +21155,6 @@ var ProcedureService = class extends BaseService {
         proceduresQuery = (0, import_firestore58.query)(proceduresCollection, (0, import_firestore58.orderBy)("name"));
       }
       const proceduresSnapshot = await (0, import_firestore58.getDocs)(proceduresQuery);
-      const lastVisible = proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1];
       let procedures = proceduresSnapshot.docs.map((doc47) => {
         const data = doc47.data();
         return {
@@ -21137,9 +21166,10 @@ var ProcedureService = class extends BaseService {
       if (excludeDraftPractitioners) {
         procedures = await this.filterDraftPractitionerProcedures(procedures);
       }
+      const lastDocForPagination = pagination && pagination > 0 && proceduresSnapshot.docs.length < pagination ? null : proceduresSnapshot.docs.length > 0 ? proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1] : null;
       return {
         procedures,
-        lastDoc: lastVisible
+        lastDoc: lastDocForPagination
       };
     } catch (error) {
       console.error("[PROCEDURE_SERVICE] Error getting all procedures:", error);
@@ -21265,11 +21295,11 @@ var ProcedureService = class extends BaseService {
           if (filters.excludeDraftPractitioners) {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
-          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures`);
+          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
           if (querySnapshot.docs.length < (filters.pagination || 10)) {
             return { procedures, lastDoc: null };
           }
+          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
           return { procedures, lastDoc };
         } catch (error) {
           console.log("[PROCEDURE_SERVICE] Strategy 1 failed:", error);
@@ -21308,11 +21338,11 @@ var ProcedureService = class extends BaseService {
           if (filters.excludeDraftPractitioners) {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
-          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures`);
-          if (procedures.length < (filters.pagination || 10)) {
+          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+          if (querySnapshot.docs.length < (filters.pagination || 10)) {
             return { procedures, lastDoc: null };
           }
+          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
           return { procedures, lastDoc };
         } catch (error) {
           console.log("[PROCEDURE_SERVICE] Strategy 2 failed:", error);
@@ -21392,13 +21422,14 @@ var ProcedureService = class extends BaseService {
           procedures = await this.filterDraftPractitionerProcedures(procedures);
         }
         console.log("[PROCEDURE_SERVICE] After applyInMemoryFilters (Strategy 3):", {
-          procedureCount: procedures.length
+          procedureCount: procedures.length,
+          queryDocCount: querySnapshot.docs.length
         });
-        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures`);
-        if (procedures.length < (filters.pagination || 10)) {
+        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
         return { procedures, lastDoc };
       } catch (error) {
         console.log("[PROCEDURE_SERVICE] Strategy 3 failed:", error);
@@ -21425,11 +21456,11 @@ var ProcedureService = class extends BaseService {
         if (filters.excludeDraftPractitioners) {
           procedures = await this.filterDraftPractitionerProcedures(procedures);
         }
-        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures`);
-        if (procedures.length < (filters.pagination || 10)) {
+        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
         return { procedures, lastDoc };
       } catch (error) {
         console.log("[PROCEDURE_SERVICE] Strategy 4 failed:", error);

package/dist/index.mjs

@@ -5215,6 +5215,12 @@ async function updateZonePhotoNotesUtil(db, appointmentId, zoneId, photoIndex, b
   }
   return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, updates);
 }
+async function removeAfterPhotoFromEntryUtil(db, appointmentId, zoneId, photoIndex) {
+  return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, {
+    after: null,
+    afterNote: null
+  });
+}
 async function getZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex) {
   var _a;
   const appointment = await getAppointmentOrThrow(db, appointmentId);
@@ -6654,6 +6660,30 @@ var AppointmentService = class extends BaseService {
       throw error;
     }
   }
+  /**
+   * Removes an after photo from an existing entry (keeps the before photo)
+   *
+   * @param appointmentId ID of the appointment
+   * @param zoneId ID of the zone
+   * @param photoIndex Index of the entry to remove after photo from
+   * @returns The updated appointment
+   */
+  async removeAfterPhotoFromEntry(appointmentId, zoneId, photoIndex) {
+    try {
+      console.log(
+        `[APPOINTMENT_SERVICE] Removing after photo from entry at index ${photoIndex} for zone ${zoneId}`
+      );
+      return await removeAfterPhotoFromEntryUtil(
+        this.db,
+        appointmentId,
+        zoneId,
+        photoIndex
+      );
+    } catch (error) {
+      console.error(`[APPOINTMENT_SERVICE] Error removing after photo from entry:`, error);
+      throw error;
+    }
+  }
   /**
    * Updates notes for a photo entry
    *
@@ -21361,7 +21391,6 @@ var ProcedureService = class extends BaseService {
         proceduresQuery = query33(proceduresCollection, orderBy18("name"));
       }
       const proceduresSnapshot = await getDocs33(proceduresQuery);
-      const lastVisible = proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1];
       let procedures = proceduresSnapshot.docs.map((doc47) => {
         const data = doc47.data();
         return {
@@ -21373,9 +21402,10 @@ var ProcedureService = class extends BaseService {
       if (excludeDraftPractitioners) {
         procedures = await this.filterDraftPractitionerProcedures(procedures);
       }
+      const lastDocForPagination = pagination && pagination > 0 && proceduresSnapshot.docs.length < pagination ? null : proceduresSnapshot.docs.length > 0 ? proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1] : null;
       return {
         procedures,
-        lastDoc: lastVisible
+        lastDoc: lastDocForPagination
       };
     } catch (error) {
       console.error("[PROCEDURE_SERVICE] Error getting all procedures:", error);
@@ -21501,11 +21531,11 @@ var ProcedureService = class extends BaseService {
           if (filters.excludeDraftPractitioners) {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
-          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures`);
+          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
           if (querySnapshot.docs.length < (filters.pagination || 10)) {
             return { procedures, lastDoc: null };
           }
+          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
           return { procedures, lastDoc };
         } catch (error) {
           console.log("[PROCEDURE_SERVICE] Strategy 1 failed:", error);
@@ -21544,11 +21574,11 @@ var ProcedureService = class extends BaseService {
           if (filters.excludeDraftPractitioners) {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
-          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures`);
-          if (procedures.length < (filters.pagination || 10)) {
+          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+          if (querySnapshot.docs.length < (filters.pagination || 10)) {
             return { procedures, lastDoc: null };
           }
+          const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
           return { procedures, lastDoc };
         } catch (error) {
           console.log("[PROCEDURE_SERVICE] Strategy 2 failed:", error);
@@ -21628,13 +21658,14 @@ var ProcedureService = class extends BaseService {
           procedures = await this.filterDraftPractitionerProcedures(procedures);
         }
         console.log("[PROCEDURE_SERVICE] After applyInMemoryFilters (Strategy 3):", {
-          procedureCount: procedures.length
+          procedureCount: procedures.length,
+          queryDocCount: querySnapshot.docs.length
         });
-        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures`);
-        if (procedures.length < (filters.pagination || 10)) {
+        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
         return { procedures, lastDoc };
       } catch (error) {
         console.log("[PROCEDURE_SERVICE] Strategy 3 failed:", error);
@@ -21661,11 +21692,11 @@ var ProcedureService = class extends BaseService {
         if (filters.excludeDraftPractitioners) {
           procedures = await this.filterDraftPractitionerProcedures(procedures);
         }
-        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures`);
-        if (procedures.length < (filters.pagination || 10)) {
+        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        const lastDoc = querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
         return { procedures, lastDoc };
       } catch (error) {
         console.log("[PROCEDURE_SERVICE] Strategy 4 failed:", error);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@blackcode_sa/metaestetics-api",
   "private": false,
-  "version": "1.13.15",
+  "version": "1.13.17",
   "description": "Firebase authentication service with anonymous upgrade support",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/src/services/appointment/appointment.service.ts

@@ -89,6 +89,7 @@ import {
 import {
   updateZonePhotoEntryUtil,
   addAfterPhotoToEntryUtil,
+  removeAfterPhotoFromEntryUtil,
   updateZonePhotoNotesUtil,
   getZonePhotoEntryUtil,
 } from './utils/zone-photo.utils';
@@ -2034,6 +2035,35 @@ export class AppointmentService extends BaseService {
     }
   }
 
+  /**
+   * Removes an after photo from an existing entry (keeps the before photo)
+   *
+   * @param appointmentId ID of the appointment
+   * @param zoneId ID of the zone
+   * @param photoIndex Index of the entry to remove after photo from
+   * @returns The updated appointment
+   */
+  async removeAfterPhotoFromEntry(
+    appointmentId: string,
+    zoneId: string,
+    photoIndex: number,
+  ): Promise<Appointment> {
+    try {
+      console.log(
+        `[APPOINTMENT_SERVICE] Removing after photo from entry at index ${photoIndex} for zone ${zoneId}`,
+      );
+      return await removeAfterPhotoFromEntryUtil(
+        this.db,
+        appointmentId,
+        zoneId,
+        photoIndex,
+      );
+    } catch (error) {
+      console.error(`[APPOINTMENT_SERVICE] Error removing after photo from entry:`, error);
+      throw error;
+    }
+  }
+
   /**
    * Updates notes for a photo entry
    *

package/src/services/appointment/utils/zone-photo.utils.ts

@@ -116,6 +116,27 @@ export async function updateZonePhotoNotesUtil(
   return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, updates);
 }
 
+/**
+ * Removes an after photo from an existing entry (keeps the before photo)
+ * 
+ * @param db Firestore instance
+ * @param appointmentId Appointment ID
+ * @param zoneId Zone ID
+ * @param photoIndex Index of the entry to remove after photo from
+ * @returns Updated appointment
+ */
+export async function removeAfterPhotoFromEntryUtil(
+  db: Firestore,
+  appointmentId: string,
+  zoneId: string,
+  photoIndex: number
+): Promise<Appointment> {
+  return updateZonePhotoEntryUtil(db, appointmentId, zoneId, photoIndex, {
+    after: null,
+    afterNote: null,
+  });
+}
+
 /**
  * Gets a specific photo entry from a zone
  * 

package/src/services/procedure/procedure.service.ts

@@ -1465,7 +1465,6 @@ export class ProcedureService extends BaseService {
       }
 
       const proceduresSnapshot = await getDocs(proceduresQuery);
-      const lastVisible = proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1];
 
       let procedures = proceduresSnapshot.docs.map(doc => {
         const data = doc.data() as Procedure;
@@ -1480,9 +1479,17 @@ export class ProcedureService extends BaseService {
         procedures = await this.filterDraftPractitionerProcedures(procedures);
       }
 
+      // Fix lastDoc - if we got fewer documents from Firestore than requested, no more pages
+      const lastDocForPagination = 
+        pagination && pagination > 0 && proceduresSnapshot.docs.length < pagination
+          ? null
+          : proceduresSnapshot.docs.length > 0
+          ? proceduresSnapshot.docs[proceduresSnapshot.docs.length - 1]
+          : null;
+
       return {
         procedures,
-        lastDoc: lastVisible,
+        lastDoc: lastDocForPagination,
       };
     } catch (error) {
       console.error('[PROCEDURE_SERVICE] Error getting all procedures:', error);
@@ -1657,17 +1664,20 @@ export class ProcedureService extends BaseService {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
           
-          const lastDoc =
-            querySnapshot.docs.length > 0
-              ? querySnapshot.docs[querySnapshot.docs.length - 1]
-              : null;
+          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
 
-          console.log(`[PROCEDURE_SERVICE] Strategy 1 success: ${procedures.length} procedures`);
-
-          // Fix Load More - ako je broj rezultata manji od pagination, nema više
+          // Fix Load More - if we got fewer documents from Firestore than requested, no more pages
           if (querySnapshot.docs.length < (filters.pagination || 10)) {
             return { procedures, lastDoc: null };
           }
+          
+          // If we filtered out some procedures but got full query results, use last doc for pagination
+          // This allows fetching more pages to get enough filtered results
+          const lastDoc =
+            querySnapshot.docs.length > 0
+              ? querySnapshot.docs[querySnapshot.docs.length - 1]
+              : null;
+          
           return { procedures, lastDoc };
         } catch (error) {
           console.log('[PROCEDURE_SERVICE] Strategy 1 failed:', error);
@@ -1719,17 +1729,19 @@ export class ProcedureService extends BaseService {
             procedures = await this.filterDraftPractitionerProcedures(procedures);
           }
           
+          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
+
+          // Fix Load More - if we got fewer documents from Firestore than requested, no more pages
+          if (querySnapshot.docs.length < (filters.pagination || 10)) {
+            return { procedures, lastDoc: null };
+          }
+          
+          // If we filtered out some procedures but got full query results, use last doc for pagination
           const lastDoc =
             querySnapshot.docs.length > 0
               ? querySnapshot.docs[querySnapshot.docs.length - 1]
               : null;
-
-          console.log(`[PROCEDURE_SERVICE] Strategy 2 success: ${procedures.length} procedures`);
-
-          // Fix Load More - ako je broj rezultata manji od pagination, nema više
-          if (procedures.length < (filters.pagination || 10)) {
-            return { procedures, lastDoc: null };
-          }
+          
           return { procedures, lastDoc };
         } catch (error) {
           console.log('[PROCEDURE_SERVICE] Strategy 2 failed:', error);
@@ -1836,16 +1848,20 @@ export class ProcedureService extends BaseService {
         
         console.log('[PROCEDURE_SERVICE] After applyInMemoryFilters (Strategy 3):', {
           procedureCount: procedures.length,
+          queryDocCount: querySnapshot.docs.length,
         });
 
-        const lastDoc =
-          querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures`);
+        console.log(`[PROCEDURE_SERVICE] Strategy 3 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
 
-        // Fix Load More - ako je broj rezultata manji od pagination, nema više
-        if (procedures.length < (filters.pagination || 10)) {
+        // Fix Load More - if we got fewer documents from Firestore than requested, no more pages
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        
+        // If we filtered out some procedures but got full query results, use last doc for pagination
+        const lastDoc =
+          querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
+        
         return { procedures, lastDoc };
       } catch (error) {
         console.log('[PROCEDURE_SERVICE] Strategy 3 failed:', error);
@@ -1880,14 +1896,17 @@ export class ProcedureService extends BaseService {
           procedures = await this.filterDraftPractitionerProcedures(procedures);
         }
 
-        const lastDoc =
-          querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
-        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures`);
+        console.log(`[PROCEDURE_SERVICE] Strategy 4 success: ${procedures.length} procedures (${querySnapshot.docs.length} from query)`);
 
-        // Fix Load More - ako je broj rezultata manji od pagination, nema više
-        if (procedures.length < (filters.pagination || 10)) {
+        // Fix Load More - if we got fewer documents from Firestore than requested, no more pages
+        if (querySnapshot.docs.length < (filters.pagination || 10)) {
           return { procedures, lastDoc: null };
         }
+        
+        // If we filtered out some procedures but got full query results, use last doc for pagination
+        const lastDoc =
+          querySnapshot.docs.length > 0 ? querySnapshot.docs[querySnapshot.docs.length - 1] : null;
+        
         return { procedures, lastDoc };
       } catch (error) {
         console.log('[PROCEDURE_SERVICE] Strategy 4 failed:', error);