@blackcode_sa/metaestetics-api 1.12.39 → 1.12.41

package/src/services/appointment/appointment.service.ts

@@ -49,7 +49,12 @@ import { PatientService } from '../patient/patient.service';
 import { PractitionerService } from '../practitioner/practitioner.service';
 import { ClinicService } from '../clinic/clinic.service';
 import { FilledDocumentService } from '../documentation-templates/filled-document.service';
-import { MediaService, MediaAccessLevel, MediaMetadata, MediaResource } from '../media/media.service';
+import {
+  MediaService,
+  MediaAccessLevel,
+  MediaMetadata,
+  MediaResource,
+} from '../media/media.service';
 
 // Import utility functions
 import {
@@ -379,8 +384,72 @@ export class AppointmentService extends BaseService {
     try {
       console.log(`[APPOINTMENT_SERVICE] Updating appointment with ID: ${appointmentId}`);
 
+      // AUTO-MIGRATION: Convert old zonePhotos format to new array format BEFORE validation
+      if (data.metadata?.zonePhotos) {
+        const migratedZonePhotos: Record<string, BeforeAfterPerZone[]> = {};
+
+        for (const [key, value] of Object.entries(data.metadata.zonePhotos)) {
+          if (Array.isArray(value)) {
+            // Already in new format
+            migratedZonePhotos[key] = value as BeforeAfterPerZone[];
+          } else {
+            // Old format - convert to array
+            console.log(`[APPOINTMENT_SERVICE] Auto-migrating ${key} from object to array format`);
+            const oldData = value as any;
+            migratedZonePhotos[key] = [
+              {
+                before: oldData.before || null,
+                after: oldData.after || null,
+                beforeNote: null,
+                afterNote: null,
+              },
+            ];
+          }
+        }
+
+        // Replace with migrated data
+        data.metadata.zonePhotos = migratedZonePhotos;
+      }
+
+      // AUTO-CLEANUP: Remove invalid recommendedProcedures with empty notes BEFORE validation
+      console.log(
+        '[APPOINTMENT_SERVICE] 🔍 BEFORE CLEANUP - recommendedProcedures:',
+        JSON.stringify(data.metadata?.recommendedProcedures, null, 2),
+      );
+
+      if (
+        data.metadata?.recommendedProcedures &&
+        Array.isArray(data.metadata.recommendedProcedures)
+      ) {
+        const validRecommendations = data.metadata.recommendedProcedures.filter((rec: any) => {
+          const isValid = rec.note && typeof rec.note === 'string' && rec.note.trim().length > 0;
+          if (!isValid) {
+            console.log('[APPOINTMENT_SERVICE] ❌ INVALID recommendation found:', rec);
+          }
+          return isValid;
+        });
+
+        if (validRecommendations.length !== data.metadata.recommendedProcedures.length) {
+          console.log(
+            `[APPOINTMENT_SERVICE] 🧹 Removing ${
+              data.metadata.recommendedProcedures.length - validRecommendations.length
+            } invalid recommended procedures with empty notes`,
+          );
+          data.metadata.recommendedProcedures = validRecommendations;
+        } else {
+          console.log('[APPOINTMENT_SERVICE] ✅ All recommendedProcedures are valid');
+        }
+      }
+
+      console.log(
+        '[APPOINTMENT_SERVICE] 🔍 AFTER CLEANUP - recommendedProcedures:',
+        JSON.stringify(data.metadata?.recommendedProcedures, null, 2),
+      );
+
       // Validate input data
+      console.log('[APPOINTMENT_SERVICE] 🔍 Starting Zod validation...');
       const validatedData = await updateAppointmentSchema.parseAsync(data);
+      console.log('[APPOINTMENT_SERVICE] ✅ Zod validation passed!');
 
       // Update the appointment using the utility function
       const updatedAppointment = await updateAppointmentUtil(this.db, appointmentId, validatedData);
@@ -1294,8 +1363,29 @@ export class AppointmentService extends BaseService {
       };
 
       // Initialize zonePhotos if it doesn't exist (array model per zone)
-      const currentZonePhotos: Record<string, BeforeAfterPerZone[]> =
-        (currentMetadata.zonePhotos as Record<string, BeforeAfterPerZone[]>) || {};
+      let currentZonePhotos: Record<string, BeforeAfterPerZone[]> = {};
+
+      // AUTO-MIGRATION: Convert old object format to new array format
+      if (currentMetadata.zonePhotos) {
+        for (const [key, value] of Object.entries(currentMetadata.zonePhotos)) {
+          if (Array.isArray(value)) {
+            // Already in new format
+            currentZonePhotos[key] = value as BeforeAfterPerZone[];
+          } else {
+            // Old format - convert to array
+            console.log(`[APPOINTMENT_SERVICE] Auto-migrating ${key} from object to array format`);
+            const oldData = value as any;
+            currentZonePhotos[key] = [
+              {
+                before: oldData.before || null,
+                after: oldData.after || null,
+                beforeNote: null,
+                afterNote: null,
+              },
+            ];
+          }
+        }
+      }
 
       // Initialize the zone array if it doesn't exist
       if (!currentZonePhotos[zoneId]) {
@@ -1306,8 +1396,8 @@ export class AppointmentService extends BaseService {
       const newEntry: BeforeAfterPerZone = {
         before: photoType === 'before' ? mediaMetadata.url : null,
         after: photoType === 'after' ? mediaMetadata.url : null,
-        beforeNote: photoType === 'before' ? (notes || null) : null,
-        afterNote: photoType === 'after' ? (notes || null) : null,
+        beforeNote: photoType === 'before' ? notes || null : null,
+        afterNote: photoType === 'after' ? notes || null : null,
       };
 
       // Append to the zone's photo list
@@ -1778,13 +1868,19 @@ export class AppointmentService extends BaseService {
     appointmentId: string,
     procedureId: string,
     note: string,
-    timeframe: { value: number; unit: 'day' | 'week' | 'month' | 'year' }
+    timeframe: { value: number; unit: 'day' | 'week' | 'month' | 'year' },
   ): Promise<Appointment> {
     try {
       console.log(
         `[APPOINTMENT_SERVICE] Adding recommended procedure ${procedureId} to appointment ${appointmentId}`,
       );
-      return await addRecommendedProcedureUtil(this.db, appointmentId, procedureId, note, timeframe);
+      return await addRecommendedProcedureUtil(
+        this.db,
+        appointmentId,
+        procedureId,
+        note,
+        timeframe,
+      );
     } catch (error) {
       console.error(`[APPOINTMENT_SERVICE] Error adding recommended procedure:`, error);
       throw error;
@@ -1798,7 +1894,10 @@ export class AppointmentService extends BaseService {
    * @param recommendationIndex Index of the recommendation to remove
    * @returns The updated appointment
    */
-  async removeRecommendedProcedure(appointmentId: string, recommendationIndex: number): Promise<Appointment> {
+  async removeRecommendedProcedure(
+    appointmentId: string,
+    recommendationIndex: number,
+  ): Promise<Appointment> {
     try {
       console.log(
         `[APPOINTMENT_SERVICE] Removing recommended procedure at index ${recommendationIndex} from appointment ${appointmentId}`,
@@ -1824,13 +1923,18 @@ export class AppointmentService extends BaseService {
     updates: {
       note?: string;
       timeframe?: { value: number; unit: 'day' | 'week' | 'month' | 'year' };
-    }
+    },
   ): Promise<Appointment> {
     try {
       console.log(
         `[APPOINTMENT_SERVICE] Updating recommended procedure at index ${recommendationIndex} in appointment ${appointmentId}`,
       );
-      return await updateRecommendedProcedureUtil(this.db, appointmentId, recommendationIndex, updates);
+      return await updateRecommendedProcedureUtil(
+        this.db,
+        appointmentId,
+        recommendationIndex,
+        updates,
+      );
     } catch (error) {
       console.error(`[APPOINTMENT_SERVICE] Error updating recommended procedure:`, error);
       throw error;
@@ -1869,7 +1973,7 @@ export class AppointmentService extends BaseService {
     appointmentId: string,
     zoneId: string,
     photoIndex: number,
-    updates: Partial<BeforeAfterPerZone>
+    updates: Partial<BeforeAfterPerZone>,
   ): Promise<Appointment> {
     try {
       console.log(
@@ -1897,7 +2001,7 @@ export class AppointmentService extends BaseService {
     zoneId: string,
     photoIndex: number,
     afterPhotoUrl: MediaResource,
-    afterNote?: string
+    afterNote?: string,
   ): Promise<Appointment> {
     try {
       console.log(
@@ -1909,7 +2013,7 @@ export class AppointmentService extends BaseService {
         zoneId,
         photoIndex,
         afterPhotoUrl,
-        afterNote
+        afterNote,
       );
     } catch (error) {
       console.error(`[APPOINTMENT_SERVICE] Error adding after photo to entry:`, error);
@@ -1932,7 +2036,7 @@ export class AppointmentService extends BaseService {
     zoneId: string,
     photoIndex: number,
     beforeNote?: string,
-    afterNote?: string
+    afterNote?: string,
   ): Promise<Appointment> {
     try {
       console.log(
@@ -1944,7 +2048,7 @@ export class AppointmentService extends BaseService {
         zoneId,
         photoIndex,
         beforeNote,
-        afterNote
+        afterNote,
       );
     } catch (error) {
       console.error(`[APPOINTMENT_SERVICE] Error updating zone photo notes:`, error);
@@ -1963,7 +2067,7 @@ export class AppointmentService extends BaseService {
   async getZonePhotoEntry(
     appointmentId: string,
     zoneId: string,
-    photoIndex: number
+    photoIndex: number,
   ): Promise<BeforeAfterPerZone> {
     try {
       console.log(