@blackbelt-technology/pi-agent-dashboard 0.4.1 → 0.4.2

package/packages/server/src/__tests__/directory-service.test.ts

@@ -226,6 +226,75 @@ describe("DirectoryService", () => {
 
       fs.rmSync(tmp, { recursive: true, force: true });
     });
+
+    it("applies design override (R3): tasks.md with checkboxes promotes design→done", async () => {
+      // See change: fix-openspec-design-detection.
+      const fs = await import("node:fs");
+      const os = await import("node:os");
+      const path = await import("node:path");
+      const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "ds-design-override-"));
+      const changeDir = path.join(tmp, "openspec", "changes", "change-x");
+      fs.mkdirSync(changeDir, { recursive: true });
+      fs.writeFileSync(path.join(changeDir, "tasks.md"), "## 1. Setup\n\n- [ ] 1.1 Do thing\n");
+
+      const { runOpenSpecList, runOpenSpecStatus } = await import("@blackbelt-technology/pi-dashboard-shared/openspec-poller.js");
+      (runOpenSpecList as any).mockResolvedValue({ changes: [
+        { name: "change-x", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+      ] });
+      (runOpenSpecStatus as any).mockResolvedValue({
+        artifacts: [
+          { id: "proposal", status: "done" },
+          { id: "specs", status: "done" },
+          { id: "design", status: "ready" },
+          { id: "tasks", status: "ready" },
+        ],
+        isComplete: false,
+      });
+
+      const stateStore = createMockPreferencesStore();
+      const sessionManager = createMockSessionManager();
+      service = createDirectoryService(stateStore, sessionManager);
+
+      const data = await service.refreshOpenSpec(tmp);
+      const change = data.changes.find((c) => c.name === "change-x")!;
+      const design = change.artifacts.find((a) => a.id === "design")!;
+      expect(design.status).toBe("done");
+      // tasks artifact should pass through unchanged (still ready)
+      expect(change.artifacts.find((a) => a.id === "tasks")!.status).toBe("ready");
+
+      fs.rmSync(tmp, { recursive: true, force: true });
+    });
+
+    it("design override leaves design=ready when no evidence", async () => {
+      const fs = await import("node:fs");
+      const os = await import("node:os");
+      const path = await import("node:path");
+      const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "ds-design-no-override-"));
+      const changeDir = path.join(tmp, "openspec", "changes", "change-y");
+      fs.mkdirSync(changeDir, { recursive: true });
+      fs.writeFileSync(path.join(changeDir, "proposal.md"), "# proposal\n");
+
+      const { runOpenSpecList, runOpenSpecStatus } = await import("@blackbelt-technology/pi-dashboard-shared/openspec-poller.js");
+      (runOpenSpecList as any).mockResolvedValue({ changes: [
+        { name: "change-y", status: "in-progress", completedTasks: 0, totalTasks: 0 },
+      ] });
+      (runOpenSpecStatus as any).mockResolvedValue({
+        artifacts: [
+          { id: "proposal", status: "done" },
+          { id: "design", status: "ready" },
+        ],
+      });
+
+      const stateStore = createMockPreferencesStore();
+      const sessionManager = createMockSessionManager();
+      service = createDirectoryService(stateStore, sessionManager);
+
+      const data = await service.refreshOpenSpec(tmp);
+      const change = data.changes.find((c) => c.name === "change-y")!;
+      expect(change.artifacts.find((a) => a.id === "design")!.status).toBe("ready");
+
+      fs.rmSync(tmp, { recursive: true, force: true });
+    });
   });
 
   describe("onDirectoryAdded", () => {
@@ -375,6 +444,111 @@ describe("DirectoryService", () => {
       expect(runOpenSpecStatus).toHaveBeenCalledTimes(1);
     });
 
+    it("re-spawns list+status when tasks.md is edited in place (POSIX dir-mtime blind spot)", async () => {
+      // This test covers the bug fix in change `fix-openspec-mtime-gate-blind-spots`:
+      // POSIX directory mtime advances only on entry create/delete/rename, not on
+      // in-place file content edits. The previous gate used dir mtime alone and
+      // missed these edits, leaving `completedTasks` stuck at the cached value.
+      const { runOpenSpecList, runOpenSpecStatus } = await import("@blackbelt-technology/pi-dashboard-shared/openspec-poller.js");
+      (runOpenSpecList as any).mockResolvedValue({ changes: [
+        { name: "change-a", status: "in-progress", completedTasks: 0, totalTasks: 3 },
+        { name: "change-b", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+      ] });
+      (runOpenSpecStatus as any).mockResolvedValue({ artifacts: [], isComplete: false });
+
+      // Seed tasks.md inside change-a so the file is part of the gate signal.
+      const tasksMd = path.join(changesDir, "change-a", "tasks.md");
+      fs.writeFileSync(tasksMd, "- [ ] 1.1 a\n- [ ] 1.2 b\n- [ ] 1.3 c\n", "utf-8");
+
+      const stateStore = createMockPreferencesStore();
+      const sessionManager = createMockSessionManager();
+      service = createDirectoryService(stateStore, sessionManager);
+      await service.refreshOpenSpec(cwd);
+      (runOpenSpecList as any).mockClear();
+      (runOpenSpecStatus as any).mockClear();
+
+      // Simulate an in-place edit: rewrite tasks.md AND bump its file mtime.
+      // Crucially, do NOT touch the parent directory's mtime — that's the
+      // blind spot the fix is supposed to cover.
+      fs.writeFileSync(tasksMd, "- [x] 1.1 a\n- [x] 1.2 b\n- [ ] 1.3 c\n", "utf-8");
+      const future = new Date(Date.now() + 60_000);
+      fs.utimesSync(tasksMd, future, future);
+
+      (runOpenSpecList as any).mockResolvedValue({ changes: [
+        { name: "change-a", status: "in-progress", completedTasks: 2, totalTasks: 3 },
+        { name: "change-b", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+      ] });
+
+      await service.pollDirectoryGated(cwd);
+
+      // List re-runs because the tasks.md file mtime is part of the list-step signal.
+      expect(runOpenSpecList).toHaveBeenCalledTimes(1);
+      // Status re-runs only for change-a (its effective mtime advanced via tasks.md).
+      expect(runOpenSpecStatus).toHaveBeenCalledTimes(1);
+      expect((runOpenSpecStatus as any).mock.calls[0][1]).toBe("change-a");
+      // Cache reflects the new counter.
+      const data = service.getOpenSpecData(cwd);
+      const ca = data?.changes.find((c) => c.name === "change-a");
+      expect(ca?.completedTasks).toBe(2);
+    });
+
+    it("post-archive path uses pollDirectoryGated (zero status spawns for unchanged changes)", async () => {
+      // Covers the post-archive contract: `fix-openspec-mtime-gate-blind-spots`
+      // made the gate file-aware so the bulk-archive path could safely skip
+      // status spawns for unchanged changes. `fix-openspec-mtime-gate-toctou`
+      // re-introduced `force=true` on the user-facing `refreshOpenSpec` (so a
+      // user clicking the refresh icon always sees authoritative data), and
+      // routed the bulk-archive handler through `pollDirectoryGated` instead
+      // — preserving the O(1) status-spawn property after archives.
+      // Pre-fix (pre-blind-spots) this test would see 4 status spawns because
+      // `force=true` disabled the gate.
+      const { runOpenSpecList, runOpenSpecStatus } = await import("@blackbelt-technology/pi-dashboard-shared/openspec-poller.js");
+
+      // Set up 5 changes in the directory (replacing the beforeEach default).
+      fs.rmSync(path.join(changesDir, "change-a"), { recursive: true });
+      fs.rmSync(path.join(changesDir, "change-b"), { recursive: true });
+      for (const n of ["c1", "c2", "c3", "c4", "c5"]) {
+        fs.mkdirSync(path.join(changesDir, n));
+      }
+
+      (runOpenSpecList as any).mockResolvedValueOnce({ changes: [
+        { name: "c1", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c2", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c3", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c4", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c5", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+      ] });
+      (runOpenSpecStatus as any).mockResolvedValue({ artifacts: [], isComplete: false });
+
+      const stateStore = createMockPreferencesStore();
+      const sessionManager = createMockSessionManager();
+      service = createDirectoryService(stateStore, sessionManager);
+
+      // First poll seeds the cache (5 list+status spawns; not what's under test).
+      await service.pollDirectoryGated(cwd);
+      (runOpenSpecList as any).mockClear();
+      (runOpenSpecStatus as any).mockClear();
+
+      // Simulate archive: remove one change directory and bump <changes>/ mtime.
+      fs.rmSync(path.join(changesDir, "c5"), { recursive: true });
+      const future = new Date(Date.now() + 60_000);
+      fs.utimesSync(changesDir, future, future);
+      (runOpenSpecList as any).mockResolvedValueOnce({ changes: [
+        { name: "c1", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c2", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c3", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+        { name: "c4", status: "in-progress", completedTasks: 0, totalTasks: 1 },
+      ] });
+
+      await service.pollDirectoryGated(cwd);
+
+      expect(runOpenSpecList).toHaveBeenCalledTimes(1);
+      // The gate skips every status because none of the surviving changes'
+      // artifact files moved. This is the path `handleOpenSpecBulkArchive`
+      // now takes (was `refreshOpenSpec` before fix-openspec-mtime-gate-toctou).
+      expect(runOpenSpecStatus).toHaveBeenCalledTimes(0);
+    });
+
     it("removed change is pruned from cache", async () => {
       const { runOpenSpecList, runOpenSpecStatus } = await import("@blackbelt-technology/pi-dashboard-shared/openspec-poller.js");
       (runOpenSpecList as any).mockResolvedValueOnce({ changes: [

package/packages/server/src/__tests__/installed-package-enricher.test.ts

@@ -0,0 +1,225 @@
+/**
+ * Unit tests for the installed-package enricher (used by /api/packages/installed).
+ *
+ * The enricher is pure-with-injected-IO: every external dep
+ * (readMeta, existsFn, manifest, bundledIds) is replaceable. We
+ * exercise each branch without touching the real filesystem.
+ */
+import { describe, it, expect } from "vitest";
+import {
+	enrichInstalledRow,
+	extractBasenameFromSource,
+	matchRecommendedEntry,
+	computeIsBundled,
+	type RawInstalledRow,
+} from "../installed-package-enricher.js";
+import type { RecommendedExtension } from "@blackbelt-technology/pi-dashboard-shared/recommended-extensions.js";
+
+const FAKE_MANIFEST: readonly RecommendedExtension[] = [
+	{
+		id: "pi-flows",
+		source: "https://github.com/BlackBeltTechnology/pi-flows.git",
+		displayName: "pi-flows",
+		fallbackDescription: "Flow engine for pi.",
+		status: "strongly-suggested",
+		unlocks: [],
+		toolsRegistered: [],
+	},
+	{
+		id: "pi-anthropic-messages",
+		source: "https://github.com/BlackBeltTechnology/pi-anthropic-messages.git",
+		displayName: "pi-anthropic-messages",
+		fallbackDescription: "Anthropic Messages provider.",
+		status: "required",
+		unlocks: [],
+		toolsRegistered: [],
+	},
+	{
+		id: "@tintinweb/pi-subagents",
+		source: "npm:@tintinweb/pi-subagents",
+		displayName: "@tintinweb/pi-subagents",
+		fallbackDescription: "Sub-agents for pi.",
+		status: "strongly-suggested",
+		unlocks: [],
+		toolsRegistered: [],
+	},
+];
+
+describe("extractBasenameFromSource", () => {
+	it("strips npm: prefix and version pin", () => {
+		expect(extractBasenameFromSource("npm:pi-agent-browser")).toBe("pi-agent-browser");
+		expect(extractBasenameFromSource("npm:pi-agent-browser@1.2.3")).toBe("pi-agent-browser");
+		expect(extractBasenameFromSource("npm:@tintinweb/pi-subagents")).toBe("@tintinweb/pi-subagents");
+	});
+
+	it("strips .git suffix from git URLs", () => {
+		expect(extractBasenameFromSource("https://github.com/BlackBeltTechnology/pi-flows.git")).toBe("pi-flows");
+		expect(extractBasenameFromSource("git@github.com:BlackBeltTechnology/pi-flows.git")).toBe("pi-flows");
+	});
+
+	it("returns last path segment for local paths", () => {
+		expect(extractBasenameFromSource("/home/user/pi-packages/pi-flows")).toBe("pi-flows");
+		expect(extractBasenameFromSource("../../BB/pi-packages/pi-flows")).toBe("pi-flows");
+	});
+
+	it("falls back to the raw source when nothing else matches", () => {
+		expect(extractBasenameFromSource("weird-thing")).toBe("weird-thing");
+	});
+});
+
+describe("matchRecommendedEntry", () => {
+	it("matches by exact source", () => {
+		expect(
+			matchRecommendedEntry("npm:@tintinweb/pi-subagents", FAKE_MANIFEST)?.id,
+		).toBe("@tintinweb/pi-subagents");
+	});
+
+	it("matches git source regardless of trailing slash / case", () => {
+		expect(
+			matchRecommendedEntry(
+				"https://github.com/BlackBeltTechnology/pi-flows.git",
+				FAKE_MANIFEST,
+			)?.id,
+		).toBe("pi-flows");
+	});
+
+	it("returns undefined when no entry matches", () => {
+		expect(matchRecommendedEntry("npm:weird-other-pkg", FAKE_MANIFEST)).toBeUndefined();
+	});
+});
+
+describe("computeIsBundled", () => {
+	it("returns false when no resourcesPath", () => {
+		expect(computeIsBundled("pi-flows", undefined, () => true, ["pi-flows"])).toBe(false);
+	});
+
+	it("returns false when id not in bundledIds", () => {
+		expect(computeIsBundled("pi-flows", "/res", () => true, ["pi-anthropic-messages"])).toBe(false);
+	});
+
+	it("returns false when bundle dir missing on disk", () => {
+		expect(computeIsBundled("pi-flows", "/res", () => false, ["pi-flows"])).toBe(false);
+	});
+
+	it("returns true when all conditions met", () => {
+		const exists = (p: string) => p === "/res/bundled-extensions/pi-flows";
+		expect(computeIsBundled("pi-flows", "/res", exists, ["pi-flows"])).toBe(true);
+	});
+});
+
+describe("enrichInstalledRow", () => {
+	const baseDeps = {
+		manifest: FAKE_MANIFEST,
+		bundledIds: ["pi-flows", "pi-anthropic-messages"],
+	};
+
+	it("enriches a recommended npm row with displayName and description from manifest", () => {
+		const row: RawInstalledRow = {
+			source: "npm:@tintinweb/pi-subagents",
+			scope: "user",
+			filtered: false,
+			installedPath: "/fake/path",
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({ version: "0.6.1", description: "Live npm desc" }),
+			existsFn: () => false,
+			resourcesPath: "/res",
+		});
+		expect(out.displayName).toBe("@tintinweb/pi-subagents");
+		// Recommended manifest description wins over package.json description.
+		expect(out.description).toBe("Sub-agents for pi.");
+		expect(out.version).toBe("0.6.1");
+		expect(out.isRecommended).toBe(true);
+		expect(out.isBundled).toBe(false);
+	});
+
+	it("enriches a recommended git row that is bundled", () => {
+		const row: RawInstalledRow = {
+			source: "https://github.com/BlackBeltTechnology/pi-flows.git",
+			scope: "user",
+			filtered: false,
+			installedPath: "/cache/pi-flows",
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({ version: "0.1.0", description: "from package.json" }),
+			existsFn: (p) => p === "/res/bundled-extensions/pi-flows",
+			resourcesPath: "/res",
+		});
+		expect(out.isRecommended).toBe(true);
+		expect(out.isBundled).toBe(true);
+		expect(out.displayName).toBe("pi-flows");
+	});
+
+	it("enriches a non-recommended row using basename + package.json", () => {
+		const row: RawInstalledRow = {
+			source: "/home/dev/pi-mystery",
+			scope: "user",
+			filtered: false,
+			installedPath: "/home/dev/pi-mystery",
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({ version: "9.9.9", description: "Mystery extension" }),
+			existsFn: () => false,
+		});
+		expect(out.isRecommended).toBe(false);
+		expect(out.isBundled).toBe(false);
+		expect(out.displayName).toBe("pi-mystery");
+		expect(out.description).toBe("Mystery extension");
+		expect(out.version).toBe("9.9.9");
+	});
+
+	it("handles missing installedPath silently", () => {
+		const row: RawInstalledRow = {
+			source: "npm:@tintinweb/pi-subagents",
+			scope: "user",
+			filtered: false,
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({}),
+			existsFn: () => false,
+		});
+		expect(out.version).toBeUndefined();
+		// Manifest description still applies.
+		expect(out.description).toBe("Sub-agents for pi.");
+		expect(out.isRecommended).toBe(true);
+	});
+
+	it("handles unreadable package.json silently", () => {
+		const row: RawInstalledRow = {
+			source: "/local/broken",
+			scope: "user",
+			filtered: false,
+			installedPath: "/local/broken",
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({}),
+			existsFn: () => false,
+		});
+		expect(out.version).toBeUndefined();
+		expect(out.description).toBeUndefined();
+		expect(out.isRecommended).toBe(false);
+		expect(out.displayName).toBe("broken");
+	});
+
+	it("isBundled is always false outside Electron (no resourcesPath)", () => {
+		const row: RawInstalledRow = {
+			source: "https://github.com/BlackBeltTechnology/pi-flows.git",
+			scope: "user",
+			filtered: false,
+			installedPath: "/cache/pi-flows",
+		};
+		const out = enrichInstalledRow(row, {
+			...baseDeps,
+			readMeta: () => ({ version: "0.1.0" }),
+			existsFn: () => true,
+			resourcesPath: undefined,
+		});
+		expect(out.isRecommended).toBe(true);
+		expect(out.isBundled).toBe(false);
+	});
+});