@blackbelt-technology/pi-agent-dashboard 0.2.9 → 0.4.0

package/packages/server/src/routes/tool-routes.ts

@@ -0,0 +1,153 @@
+/**
+ * REST routes for the tool registry.
+ *
+ *   GET    /api/tools                → list all resolutions
+ *   GET    /api/tools/:name          → single resolution
+ *   POST   /api/tools/rescan         → invalidate + refresh (all or one)
+ *   PUT    /api/tools/:name          → set override path
+ *   DELETE /api/tools/:name          → clear override
+ *   POST   /api/tools/diagnostics    → text/plain export
+ *
+ * Every route is guarded by the same network guard used by /api/config.
+ *
+ * See change: consolidate-tool-resolution (specs/tool-settings-ui).
+ */
+import type { FastifyInstance } from "fastify";
+import type { ApiResponse } from "@blackbelt-technology/pi-dashboard-shared/types.js";
+import type {
+  Resolution,
+  ToolRegistry,
+} from "@blackbelt-technology/pi-dashboard-shared/tool-registry/index.js";
+import { UnknownToolError } from "@blackbelt-technology/pi-dashboard-shared/tool-registry/index.js";
+import type { NetworkGuard } from "./route-deps.js";
+
+export interface ToolRoutesDeps {
+  registry: ToolRegistry;
+  networkGuard: NetworkGuard;
+}
+
+/**
+ * Format a plain-text diagnostics export. One tool per block, one line
+ * per attempted strategy. Used by the Settings panel's "Export diagnostics"
+ * action and by bug-report attachments.
+ */
+export function formatDiagnostics(tools: Resolution[]): string {
+  const lines: string[] = [];
+  lines.push(`# pi-dashboard tool diagnostics — ${new Date().toISOString()}`);
+  lines.push("");
+  for (const t of tools) {
+    const header = t.ok
+      ? `[ok]    ${t.name} (${t.source}) → ${t.path}`
+      : `[miss]  ${t.name} → not found`;
+    lines.push(header);
+    for (const entry of t.tried) {
+      lines.push(`          - ${entry.strategy}: ${entry.result}`);
+    }
+    lines.push("");
+  }
+  return lines.join("\n");
+}
+
+export function registerToolRoutes(
+  fastify: FastifyInstance,
+  { registry, networkGuard }: ToolRoutesDeps,
+): void {
+  // ── GET /api/tools ─────────────────────────────────────────────────
+  fastify.get(
+    "/api/tools",
+    { preHandler: networkGuard },
+    async () => {
+      return { success: true, data: { tools: registry.list() } } satisfies ApiResponse<{
+        tools: Resolution[];
+      }>;
+    },
+  );
+
+  // ── GET /api/tools/:name ───────────────────────────────────────────
+  fastify.get<{ Params: { name: string } }>(
+    "/api/tools/:name",
+    { preHandler: networkGuard },
+    async (request, reply) => {
+      const { name } = request.params;
+      if (!registry.has(name)) {
+        reply.status(404);
+        return { success: false, error: `Unknown tool: ${name}` } satisfies ApiResponse;
+      }
+      return { success: true, data: registry.resolve(name) } satisfies ApiResponse<Resolution>;
+    },
+  );
+
+  // ── POST /api/tools/rescan ─────────────────────────────────────────
+  fastify.post<{ Body: { name?: string } }>(
+    "/api/tools/rescan",
+    { preHandler: networkGuard },
+    async (request, reply) => {
+      const name = request.body?.name;
+      if (name !== undefined) {
+        if (!registry.has(name)) {
+          reply.status(404);
+          return { success: false, error: `Unknown tool: ${name}` } satisfies ApiResponse;
+        }
+        registry.rescan(name);
+      } else {
+        registry.rescan();
+      }
+      return { success: true, data: { tools: registry.list() } } satisfies ApiResponse<{
+        tools: Resolution[];
+      }>;
+    },
+  );
+
+  // ── PUT /api/tools/:name ───────────────────────────────────────────
+  fastify.put<{ Params: { name: string }; Body: { path?: string } }>(
+    "/api/tools/:name",
+    { preHandler: networkGuard },
+    async (request, reply) => {
+      const { name } = request.params;
+      const overridePath = request.body?.path;
+      if (typeof overridePath !== "string" || !overridePath.trim()) {
+        reply.status(400);
+        return { success: false, error: "body.path is required (non-empty string)" } satisfies ApiResponse;
+      }
+      try {
+        registry.setOverride(name, overridePath.trim());
+      } catch (err) {
+        if (err instanceof UnknownToolError) {
+          reply.status(404);
+          return { success: false, error: err.message } satisfies ApiResponse;
+        }
+        throw err;
+      }
+      return { success: true, data: registry.resolve(name) } satisfies ApiResponse<Resolution>;
+    },
+  );
+
+  // ── DELETE /api/tools/:name ────────────────────────────────────────
+  fastify.delete<{ Params: { name: string } }>(
+    "/api/tools/:name",
+    { preHandler: networkGuard },
+    async (request, reply) => {
+      const { name } = request.params;
+      try {
+        registry.clearOverride(name);
+      } catch (err) {
+        if (err instanceof UnknownToolError) {
+          reply.status(404);
+          return { success: false, error: err.message } satisfies ApiResponse;
+        }
+        throw err;
+      }
+      return { success: true, data: registry.resolve(name) } satisfies ApiResponse<Resolution>;
+    },
+  );
+
+  // ── POST /api/tools/diagnostics ────────────────────────────────────
+  fastify.post(
+    "/api/tools/diagnostics",
+    { preHandler: networkGuard },
+    async (_request, reply) => {
+      reply.type("text/plain; charset=utf-8");
+      return formatDiagnostics(registry.list());
+    },
+  );
+}

package/packages/server/src/server-pid.ts

@@ -6,6 +6,7 @@ import fs from "node:fs";
 import path from "node:path";
 import os from "node:os";
 import { isDashboardRunning } from "@blackbelt-technology/pi-dashboard-shared/server-identity.js";
+import { isProcessAlive } from "@blackbelt-technology/pi-dashboard-shared/platform/process.js";
 
 const DEFAULT_PID_PATH = path.join(os.homedir(), ".pi", "dashboard", "server.pid");
 
@@ -14,16 +15,11 @@ export interface ServerPidOptions {
 }
 
 /**
- * Check if a process with the given PID is alive.
+ * Re-export the platform's liveness primitive so existing importers of
+ * `server-pid.ts::isProcessAlive` keep working. See change:
+ * route-kill-paths-through-platform.
  */
-export function isProcessAlive(pid: number): boolean {
-  try {
-    process.kill(pid, 0);
-    return true;
-  } catch {
-    return false;
-  }
-}
+export { isProcessAlive };
 
 /**
  * Write the current process PID to the PID file.