@biznetgio/neo-app 0.4.35 → 0.4.37

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@biznetgio/neo-app",
-  "version": "0.4.35",
+  "version": "0.4.37",
   "description": "NEO App CLI — one-command agent onboarding, MCP server, and project ops for coding agents (Codex, Claude Code).",
   "type": "module",
   "bin": {

package/src/mcp/tools.js

@@ -4,7 +4,6 @@
 
 import { resolve, basename } from 'node:path';
 import { statSync, readFileSync } from 'node:fs';
-import { createHash } from 'node:crypto';
 import { deploySource } from '../deploySource.js';
 import { pkgVersion } from '../util.js';
 import { estimateCost } from '../pricing.js';
@@ -44,8 +43,8 @@ function requireEnv(env) {
 // actually converges (GET → 404), so a delete isn't reported done while the record
 // still exists. Returns a durable operation reference (`del-<id>`) + convergence
 // state (handoff 3.6; 0.4.34 retest §9 "every delete returns a durable operation ID").
-async function deleteAndConverge(api, path, resourceId, kind) {
-  const { status, data } = await api.del(path);
+async function deleteAndConverge(api, path, resourceId, kind, delQuery = '') {
+  const { status, data } = await api.del(path + delQuery);
   let converged = false, checks = 0;
   for (let i = 0; i < 12; i++) {
     checks++;
@@ -67,15 +66,6 @@ function gbFromSize(v) {
   return m ? parseInt(m[1], 10) : undefined;
 }
 
-// deletionHashOf is an immutable approval token for a project deletion: a short hash
-// of the exact inventory being deleted. The preview returns it; a cascade delete must
-// echo it back, and the tool recomputes the live inventory and refuses a mismatch — so
-// a project can't be deleted against a stale/partial inventory (0.4.31 retest §7).
-function deletionHashOf(pid, inv, total) {
-  const names = Object.entries(inv).flatMap(([k, a]) => a.map((n) => k + ':' + n)).sort();
-  return createHash('sha256').update(JSON.stringify({ pid, total, names })).digest('hex').slice(0, 16);
-}
-
 // confirmCost is the Approve & Create gate for billable one-shot creates: unless
 // args.confirm===true it returns the live-priced cost and creates NOTHING — the
 // agent shows the user, then re-calls with confirm:true. plan/apply remains the
@@ -214,6 +204,33 @@ export const TOOLS = [
       return (await api.get(`/api/v1/projects/${args.projectId}`)).data;
     },
   },
+  {
+    name: 'neo_get_confirmation',
+    description: 'Read a confirmation record (the server-side approval for a high-risk action) by id — its action, status, redacted summary, whether an exact-name phrase is required, and expiry. Read-only; never contains secrets.',
+    mutating: false,
+    schema: { type: 'object', properties: { confirmationId: str('Confirmation id (from a destructive preview or a plan)') }, required: ['confirmationId'] },
+    async call(api, args) {
+      return (await api.get(`/api/v1/confirmations/${args.confirmationId}`)).data;
+    },
+  },
+  {
+    name: 'neo_confirm_action',
+    description: 'Record a human DECISION on a confirmation (NEVER creates or deletes anything itself) — the server-enforced approval step for a high-risk action (project/service deletion, billable create). decision is approve | decline | cancel. Approving a DELETION requires confirmationPhrase to exactly equal the target name (the human must type it). After approve, call the action tool again with this confirmationId to actually perform it (single-use). Show the human the summary from the preview and ask once; never infer consent.',
+    mutating: true,
+    schema: {
+      type: 'object',
+      properties: {
+        confirmationId: str('Confirmation id (from a destructive preview or a plan)'),
+        decision: { type: 'string', enum: ['approve', 'decline', 'cancel'], description: 'approve | decline | cancel' },
+        confirmationPhrase: str('For a deletion: the EXACT target name, typed by the human, required to approve'),
+      },
+      required: ['confirmationId', 'decision'],
+    },
+    async call(api, args) {
+      const { status, data } = await api.post(`/api/v1/confirmations/${args.confirmationId}/decide`, { decision: args.decision, confirmationPhrase: args.confirmationPhrase });
+      return result(status, data);
+    },
+  },
   {
     name: 'neo_list_services',
     description: 'List services/apps in a project.',
@@ -333,7 +350,7 @@ export const TOOLS = [
   },
   {
     name: 'neo_scale_service',
-    description: 'Scale a service to N replicas. May return pending_approval under org policy.',
+    description: 'Scale a service to N replicas. Scaling changes cost, so without confirm:true it returns the new estimated cost and scales nothing (re-call with confirm:true). May return pending_approval under org policy.',
     mutating: true,
     schema: {
       type: 'object',
@@ -341,10 +358,22 @@ export const TOOLS = [
         projectId: str('Project id'),
         service: str('Service/app name'),
         replicas: int('Desired replica count (>=0)'),
+        confirm: { type: 'boolean', description: 'Approve the cost change: without confirm:true the tool returns the new cost and scales nothing.' },
       },
       required: ['projectId', 'service', 'replicas'],
     },
     async call(api, args) {
+      if (args.confirm !== true) {
+        let computeTier;
+        try {
+          const apps = (await api.get(`/api/v1/projects/${args.projectId}/apps`)).data;
+          const list = Array.isArray(apps) ? apps : (apps.applications || []);
+          const svc = list.find((a) => a.name === args.service || a.id === args.service);
+          computeTier = svc && (svc.cpuLimit || svc.computeTier);
+        } catch { /* best effort — gate regardless */ }
+        const gate = await confirmCost(api, args, { computeTier, replicas: args.replicas });
+        if (gate) return { ...gate, change: `scale "${args.service}" to ${args.replicas} replica(s)`, message: 'Scaling changes cost — show the user and re-call with confirm:true to apply.' };
+      }
       const { status, data } = await api.post(
         `/api/v1/projects/${args.projectId}/services/${args.service}/scale`,
         { replicas: args.replicas }
@@ -641,10 +670,16 @@ export const TOOLS = [
         databaseId: str('Database id'),
         volumeSize: str('New storage size, e.g. "20Gi" — must be >= current (grow-only)'),
         replicas: int('Read/failover replicas (CNPG/postgres); total instances = 1 + replicas'),
+        confirm: { type: 'boolean', description: 'Approve the cost change: without confirm:true a storage/replica resize returns the new cost and applies nothing.' },
       },
       required: ['databaseId'],
     },
     async call(api, args) {
+      const costChanging = args.volumeSize || args.replicas !== undefined;
+      if (costChanging && args.confirm !== true) {
+        const gate = await confirmCost(api, args, { storageGB: gbFromSize(args.volumeSize), replicas: args.replicas });
+        if (gate) return { ...gate, change: 'resize database (storage/replicas)', message: 'Resizing changes cost — re-call with confirm:true to apply.' };
+      }
       const body = {};
       if (args.volumeSize) body.volumeSize = args.volumeSize;
       if (args.replicas !== undefined) body.replicas = args.replicas;
@@ -807,11 +842,17 @@ export const TOOLS = [
         dlqEnabled: { type: 'boolean', description: 'Enable/disable the dead-letter queue' },
         volumeSize: str('New storage size, e.g. "20Gi" — must be >= current (grow-only)'),
         retention: { type: 'object', description: 'Retention policy {maxAgeSeconds, maxBytes, maxMsgs}' },
+        confirm: { type: 'boolean', description: 'Approve the cost change: without confirm:true a storage/plan change returns the new cost and applies nothing. DLQ/retention-only edits apply directly.' },
       },
       required: ['queueId'],
     },
     async call(api, args) {
-      const { queueId, ...body } = args;
+      const costChanging = args.volumeSize || args.planClass;
+      if (costChanging && args.confirm !== true) {
+        const gate = await confirmCost(api, args, { storageGB: gbFromSize(args.volumeSize) });
+        if (gate) return { ...gate, change: 'update queue (storage/plan)', message: 'This changes cost — re-call with confirm:true to apply.' };
+      }
+      const { queueId, confirm, orgId, ...body } = args;
       const { status, data } = await api.put(`/api/v1/queues/${queueId}`, body);
       return redactSecrets(result(status, data));
     },
@@ -1262,12 +1303,34 @@ export const TOOLS = [
   // the server hard-deletes the record and tears down the running workload. ---
   {
     name: 'neo_delete_service',
-    description: 'Permanently delete a service (web / worker / static_site) and tear down its running workload. Destructive and irreversible.',
+    description: 'Delete a service (web / worker / static_site) and tear down its workload. SAFE BY DEFAULT: with no confirmationId it returns the service details + a server-side CONFIRMATION, deleting NOTHING. Then: show the user, call neo_confirm_action(confirmationId, "approve", confirmationPhrase=<EXACT service name>), then re-call with that confirmationId. Server-enforced, single-use, exact-name. Destructive and irreversible.',
     mutating: true,
     destructive: true,
-    schema: { type: 'object', properties: { appId: str('Service/app id (from neo_list_services)') }, required: ['appId'] },
+    schema: {
+      type: 'object',
+      properties: {
+        appId: str('Service/app id (from neo_list_services)'),
+        confirmationId: str('An APPROVED confirmation id (from neo_confirm_action). Omit to get the confirmation.'),
+      },
+      required: ['appId'],
+    },
     async call(api, args) {
-      return deleteAndConverge(api, `/api/v1/apps/${args.appId}`, args.appId, 'service');
+      if (args.confirmationId) {
+        return deleteAndConverge(api, `/api/v1/apps/${args.appId}`, args.appId, 'service', `?confirmationId=${encodeURIComponent(args.confirmationId)}`);
+      }
+      let svc = null;
+      try { svc = (await api.get(`/api/v1/apps/${args.appId}`)).data; } catch { /* preview best-effort */ }
+      let c;
+      try { c = (await api.post('/api/v1/confirmations', { action: 'service_delete', targetId: args.appId })).data; }
+      catch (e) { return { deleted: false, error: 'confirmation_failed', message: 'Could not create a deletion confirmation: ' + (e.message || e) }; }
+      const phrase = (c.summary && c.summary.phraseRequired) || (svc && svc.name);
+      return {
+        deleted: false, requiresConfirmation: true,
+        service: svc ? { id: svc.id, name: svc.name, type: svc.serviceType, environment: svc.environment } : { id: args.appId },
+        warning: 'IRREVERSIBLE: deletes the service and tears down its running workload.',
+        confirmationId: c.confirmationId, phraseRequired: phrase,
+        message: `To delete: call neo_confirm_action("${c.confirmationId}", "approve", confirmationPhrase="${phrase}") — the human must type the exact service name — then re-call neo_delete_service with confirmationId="${c.confirmationId}".`,
+      };
     },
   },
   {
@@ -1366,21 +1429,24 @@ export const TOOLS = [
   },
   {
     name: 'neo_delete_project',
-    description: 'Delete a project and ALL its resources (apps, databases, queues, crons, buckets, namespace + PVCs/CNPG). SAFE BY DEFAULT: without confirm:true it returns a PREVIEW (project name, org, full resource inventory, accrued-usage snapshot, no-refund warning) and deletes NOTHING. A NON-EMPTY project additionally requires cascade:true. Destructive and irreversible. Only the creator or an org owner/admin may delete.',
+    description: 'Delete a project and ALL its resources (apps, databases, queues, crons, buckets, namespace + PVCs/CNPG). SAFE BY DEFAULT: with no confirmationId it returns a PREVIEW (name, org, full inventory, metering, no-refund) AND a server-side CONFIRMATION, deleting NOTHING. Then: show the user, call neo_confirm_action(confirmationId, "approve", confirmationPhrase=<EXACT project name>), then re-call this tool with that confirmationId. Server-enforced, single-use, exact-name. Destructive and irreversible. Only the creator or an org owner/admin may delete.',
     mutating: true,
     destructive: true,
     schema: {
       type: 'object',
       properties: {
         projectId: str('Project id'),
-        confirm: { type: 'boolean', description: 'Must be true to delete. Without it you get a preview only (nothing is deleted).' },
-        cascade: { type: 'boolean', description: 'Required true to delete a NON-EMPTY project — acknowledges every resource in the inventory is destroyed.' },
-        deletionHash: str('For a non-empty project: the deletionHash from the preview. The tool refuses if the live inventory no longer matches it (immutable approval).'),
+        confirmationId: str('An APPROVED confirmation id (from neo_confirm_action). Omit to get the preview + a fresh confirmation.'),
       },
       required: ['projectId'],
     },
     async call(api, args) {
       const pid = args.projectId;
+      // With an approved confirmation: the server consumes it atomically and deletes.
+      if (args.confirmationId) {
+        const { status, data } = await api.del(`/api/v1/projects/${pid}?confirmationId=${encodeURIComponent(args.confirmationId)}`);
+        return { deleted: true, project: { id: pid }, result: result(status, data) };
+      }
       // Gather inventory + usage BEFORE any delete (this is also the metering snapshot).
       const safeGet = async (p) => { try { return (await api.get(p)).data; } catch { return null; } };
       const [proj, apps, dbs, queues, crons, buckets, usage] = await Promise.all([
@@ -1405,36 +1471,28 @@ export const TOOLS = [
       // project is empty — treat it as non-empty so the empty-path can't silently
       // delete hidden resources (the preview must be trustworthy).
       const inventoryIncomplete = [apps, dbs, queues, crons, buckets].some((x) => x === null);
-      const preview = {
+      // Create a server-side, single-use, exact-name confirmation for this deletion.
+      let confirmationId, phraseRequired = proj && proj.name;
+      try {
+        const c = (await api.post('/api/v1/confirmations', { action: 'project_delete', projectId: pid })).data;
+        confirmationId = c.confirmationId;
+        phraseRequired = (c.summary && c.summary.phraseRequired) || phraseRequired;
+      } catch (e) {
+        return { deleted: false, error: 'confirmation_failed', message: 'Could not create a deletion confirmation: ' + (e.message || e) };
+      }
+      return {
+        deleted: false,
+        requiresConfirmation: true,
         project: proj ? { id: proj.id, name: proj.name, organizationId: proj.organizationId } : { id: pid },
         resourceInventory: inv,
         resourceCount: total,
         meteringSnapshot: usage ? { period: usage.period, total: usage.total ?? usage.totalCost, currency: usage.currency } : null,
         inventoryIncomplete: inventoryIncomplete || undefined,
-        deletionHash: deletionHashOf(pid, inv, total),
-        warning: 'IRREVERSIBLE: deletes the project, every resource above, and their data (database/queue volumes included). No refund for prepaid or accrued usage.',
+        warning: 'IRREVERSIBLE: deletes the project, every resource above, and their data (database/queue volumes included). No refund for prepaid or accrued usage. The organization itself remains.',
+        confirmationId,
+        phraseRequired,
+        message: `Show the user this inventory. To delete: call neo_confirm_action("${confirmationId}", "approve", confirmationPhrase="${phraseRequired}") — the human must type the exact project name — then re-call neo_delete_project with confirmationId="${confirmationId}".`,
       };
-      // Treat an unverifiable inventory as non-empty — never allow the no-cascade path
-      // when we could not confirm the project is actually empty.
-      const requireCascade = total > 0 || inventoryIncomplete;
-      if (args.confirm !== true) {
-        return { ...preview, deleted: false, requiresConfirmation: true, message: requireCascade ? 'Show this inventory to the user. To delete, re-call with confirm:true, cascade:true, and deletionHash.' : 'Empty project. To delete, re-call with confirm:true.' };
-      }
-      if (requireCascade && args.cascade !== true) {
-        return { ...preview, deleted: false, error: 'cascade_required', message: inventoryIncomplete ? 'Could not fully verify the project inventory — re-call with confirm:true AND cascade:true to delete anyway.' : `This project has ${total} resource(s). Re-call with confirm:true AND cascade:true to delete them all.` };
-      }
-      // Immutable approval: a non-empty cascade delete must echo the preview's
-      // deletionHash, and it must still match the live inventory.
-      if (total > 0) {
-        if (!args.deletionHash) {
-          return { ...preview, deleted: false, error: 'deletion_hash_required', message: 'Pass deletionHash (from the preview) to confirm you are deleting exactly this inventory.' };
-        }
-        if (args.deletionHash !== preview.deletionHash) {
-          return { ...preview, deleted: false, error: 'inventory_changed', message: 'The project inventory changed since your preview — re-preview and pass the new deletionHash.' };
-        }
-      }
-      const { status, data } = await api.del(`/api/v1/projects/${pid}`);
-      return { deleted: true, project: preview.project, removed: inv, resourceCount: total, meteringSnapshot: preview.meteringSnapshot, result: result(status, data) };
     },
   },
 ];