@bizjournals/js-storage 0.1.0 → 0.1.2

package/lib/abstract/__tests__/storage.issupported.spec.js

@@ -1,5 +1,6 @@
 import StorageAbstract from '../';
 import mockStorage from '../__mocks__/mock-storage';
+import store from '../store';
 
 describe('core:class >> storageabstract:issupported', () => {
     let storageAbstract;
@@ -10,7 +11,7 @@ describe('core:class >> storageabstract:issupported', () => {
         mockStorage.removeItem.mockClear();
 
         storageAbstract.storage = mockStorage;
-        StorageAbstract.supported = undefined;
+        store.supported = undefined;
     });
 
     it('returns false when the storage system is defaulted', () => {

package/lib/abstract/__tests__/storage.removeitem.spec.js

@@ -1,5 +1,7 @@
 import StorageAbstract from '../';
 
+import store from '../store';
+
 describe('core:class >> storageabstract:removeitem', () => {
     let storageClassMock, mockStorage, key = 'test';
 
@@ -20,7 +22,7 @@ describe('core:class >> storageabstract:removeitem', () => {
         };
 
         storageClassMock.storage = mockStorage;
-        StorageAbstract.supported = undefined;
+        store.supported = undefined;
     });
 
     it('halts when it is not supported', () => {
@@ -33,7 +35,7 @@ describe('core:class >> storageabstract:removeitem', () => {
     });
 
     it('falls through when encountering an exception', () => {
-        StorageAbstract.supported = true;
+        store.supported = true;
 
         const badStorage = {
             removeItem: jest.fn().mockImplementation(() => {
@@ -51,7 +53,7 @@ describe('core:class >> storageabstract:removeitem', () => {
     });
 
     it('removes both the item at namespace and expiration keys', () => {
-        StorageAbstract.supported = true;
+        store.supported = true;
         storageClassMock.removeItem();
 
         expect(storageClassMock.namespaceKey).toHaveBeenCalledTimes(1);

package/lib/abstract/__tests__/storage.setitem.spec.js

@@ -1,4 +1,5 @@
 import StorageAbstract from '../';
+import store from '../store';
 
 describe('core:class >> storageabstract:setitem', () => {
     let storageClassMock, mockStorage, key = 'test';
@@ -26,7 +27,7 @@ describe('core:class >> storageabstract:setitem', () => {
 
         storageClassMock.attempts = 0;
         storageClassMock.storage = mockStorage;
-        StorageAbstract.supported = undefined;
+        store.supported = undefined;
     });
 
     it('resets the attempts and returns when it is not supported without continuing', () => {

package/lib/abstract/index.js

@@ -1,5 +1,6 @@
-import { DEFAULT_EXPIRATION, DEFAULT_NAMESPACE, EXPIRES_KEY_SUFFIX } from "./constants";
-import { KEY_IS_REQUIRED_TO_FETCH_DATA } from "./exceptions";
+import { DEFAULT_EXPIRATION, DEFAULT_NAMESPACE, EXPIRES_KEY_SUFFIX } from './constants';
+import { KEY_IS_REQUIRED_TO_FETCH_DATA } from './exceptions';
+import store from './store';
 
 /*
 |--------------------------------------------------------------------------
@@ -12,13 +13,6 @@ import { KEY_IS_REQUIRED_TO_FETCH_DATA } from "./exceptions";
 |
 */
 export default class StorageAbstract {
-    /**
-     * Extensions to this abstraction share an enabled state.
-     *
-     * @type {boolean}
-     */
-    static supported;
-
     /**
      * Constructor takes in options for namespace and expiration.
      * Session storage is the default storage type.
@@ -46,8 +40,8 @@ export default class StorageAbstract {
     getItem (key, parse = true) {
         let response;
 
-        if (!this.isSupported() || this.isItemExpired(key)) {
-            return response;
+        if (! this.isSupported() || this.isItemExpired(key)) {
+            return undefined;
         }
 
         try {
@@ -71,7 +65,7 @@ export default class StorageAbstract {
      */
     parser (data) {
         try {
-            if (typeof data === "string") {
+            if (typeof data === 'string') {
                 data = JSON.parse(data);
             }
         } catch (e) {
@@ -99,7 +93,7 @@ export default class StorageAbstract {
      * @param {boolean} expires
      */
     setItem (key, value, expires = true) {
-        if (!this.isSupported()) {
+        if (! this.isSupported()) {
             return;
         }
 
@@ -110,8 +104,8 @@ export default class StorageAbstract {
 
             if (expires) {
                 this.storage.setItem(
-                  this.expirationKey(key),
-                  String(this.timestamp(this.expires))
+                    this.expirationKey(key),
+                    String(this.timestamp(this.expires)),
                 );
             }
         } catch (e) {
@@ -125,7 +119,7 @@ export default class StorageAbstract {
      * @param {string} key
      */
     removeItem (key) {
-        if (!this.isSupported()) {
+        if (! this.isSupported()) {
             return;
         }
 
@@ -175,7 +169,7 @@ export default class StorageAbstract {
      * @returns {string}
      */
     namespaceKey (key) {
-        if (typeof key !== "string") {
+        if (typeof key !== 'string') {
             throw new Error(KEY_IS_REQUIRED_TO_FETCH_DATA);
         }
 
@@ -202,14 +196,14 @@ export default class StorageAbstract {
      * @returns {boolean}
      */
     isItemExpired (key) {
-        if (!this.isSupported()) {
+        if (! this.isSupported()) {
             return false;
         }
 
         try {
             let value = this.storage.getItem(this.expirationKey(key));
 
-            if (value && "length" in value && value.length) {
+            if (typeof value === 'string' && value.length > 0) {
                 let expires = parseInt(value, 10);
 
                 if (expires - this.timestamp() <= 0) {
@@ -230,8 +224,8 @@ export default class StorageAbstract {
      * @returns {boolean}
      */
     isSupported () {
-        if (typeof StorageAbstract.supported === "boolean") {
-            return StorageAbstract.supported;
+        if (typeof store.supported === 'boolean') {
+            return store.supported;
         }
 
         const test = 'biz.storage.test';
@@ -240,10 +234,9 @@ export default class StorageAbstract {
             this.storage.setItem(test, '1');
             this.storage.removeItem(test);
 
-            StorageAbstract.supported = true;
+            store.supported = true;
         } catch (e) {
-            StorageAbstract.supported = e instanceof DOMException &&
-              (
+            store.supported = e instanceof DOMException && (
                 // everything except Firefox
                 e.code === 22 ||
                 // Firefox
@@ -253,9 +246,9 @@ export default class StorageAbstract {
                 e.name === 'QuotaExceededError' ||
                 // Firefox
                 e.name === 'NS_ERROR_DOM_QUOTA_REACHED'
-              ) && (this.storage && this.storage.length !== 0);
+            ) && (this.storage && this.storage.length !== 0);
         }
 
-        return StorageAbstract.supported;
+        return store.supported;
     }
 }

package/lib/abstract/store/index.js

@@ -0,0 +1,10 @@
+/**
+ * The data store for global variables
+ *
+ */
+const store = {
+  supported: null,
+}
+
+// --
+export default store;

package/lib/main.js

@@ -0,0 +1,5 @@
+import LocalStorage from "./local";
+import SessionStorage from "./session";
+import StorageReference from "./reference";
+
+export { LocalStorage, SessionStorage, StorageReference };

package/package.json

@@ -1,25 +1,25 @@
 {
-    "name": "@bizjournals/js-storage",
-    "version": "0.1.0",
-    "description": "ACBJ javascript storage classes",
-    "repository": {
-        "git": "https://gitlab.bizjournals.com/bizjournals/js-storage"
-    },
-    "main": "main.js",
-    "type": "module",
-    "sideEffects": false,
-    "scripts": {
-        "test": "jest",
-        "preversion": "npm test",
-        "postversion": "git push && git push --tags && npm publish"
-    },
-    "keywords": [],
-    "author": "DPD",
-    "license": "UNLICENSED",
-    "devDependencies": {
-        "@babel/preset-env": "^7.10.3",
-        "babel-jest": "^25.4.0",
-        "jest": "^25.4.0"
-    },
-    "dependencies": {}
+  "name": "@bizjournals/js-storage",
+  "version": "0.1.2",
+  "description": "ACBJ javascript storage classes",
+  "repository": {
+    "git": "https://gitlab.bizjournals.com/bizjournals/js-storage"
+  },
+  "main": "lib/main.js",
+  "type": "module",
+  "sideEffects": false,
+  "scripts": {
+    "test": "jest",
+    "preversion": "npm test",
+    "postversion": "git push && git push --tags && npm publish"
+  },
+  "keywords": [],
+  "author": "DPD",
+  "license": "UNLICENSED",
+  "devDependencies": {
+    "@babel/preset-env": "^7.10.3",
+    "babel-jest": "^25.4.0",
+    "jest": "^25.4.0"
+  },
+  "dependencies": {}
 }

package/main.js

@@ -1,5 +0,0 @@
-import LocalStorage from "./lib/local";
-import SessionStorage from "./lib/session";
-import StorageReference from "./lib/reference";
-
-export { LocalStorage, SessionStorage, StorageReference };