@bivy/bivy 0.7.0-staging.104 → 0.7.0-staging.106

package/dist/runtime/index.js

@@ -116,14 +116,27 @@ function claudeCodeInfo() {
         },
     };
 }
+// Memoized CLI probes. `commandAvailable`/`resolveCommandPath`/`probeHelpText`
+// each shell out with a BLOCKING spawnSync, and the runtime catalog that calls
+// them (cliAgentInfo → prefersAcp/acpSupportedByBinary) is rebuilt often — on
+// every advertise and every runtimes.list send. Re-probing per build stalled the
+// event loop for seconds at a time (a synchronous spawn storm). A CLI's presence
+// is effectively constant for the daemon's run, so cache per command for the
+// process lifetime and clear on install (invalidateCliProbeCache).
+const COMMAND_AVAILABLE_CACHE = new Map();
 function commandAvailable(command) {
     if (!command.trim())
         return false;
+    const cached = COMMAND_AVAILABLE_CACHE.get(command);
+    if (cached !== undefined)
+        return cached;
     const result = spawnSync(process.platform === "win32" ? "where" : "command", process.platform === "win32" ? [command] : ["-v", command], {
         shell: process.platform !== "win32",
         stdio: "ignore",
     });
-    return result.status === 0;
+    const available = result.status === 0;
+    COMMAND_AVAILABLE_CACHE.set(command, available);
+    return available;
 }
 function genericCliInfo() {
     const options = processRuntimeFromEnv();
@@ -869,17 +882,23 @@ function cliThinkingConfig(id) {
  * Used to key the help-probe cache: caching by the bare NAME would keep serving a
  * stale answer after the binary behind that name changed (a CLI upgraded or
  * installed while the daemon is running, or a different PATH entry winning).
+ * Memoized per command (see COMMAND_AVAILABLE_CACHE) — it spawnSyncs, and is hit
+ * on every catalog build.
  */
+const COMMAND_PATH_CACHE = new Map();
 function resolveCommandPath(command) {
     if (!command.trim())
         return null;
+    const cached = COMMAND_PATH_CACHE.get(command);
+    if (cached !== undefined)
+        return cached;
     const res = spawnSync(process.platform === "win32" ? "where" : "command", process.platform === "win32" ? [command] : ["-v", command], {
         shell: process.platform !== "win32",
         encoding: "utf8",
     });
-    if (res.status !== 0)
-        return null;
-    return (res.stdout ?? "").split(/\r?\n/)[0]?.trim() || null;
+    const resolved = res.status !== 0 ? null : ((res.stdout ?? "").split(/\r?\n/)[0]?.trim() || null);
+    COMMAND_PATH_CACHE.set(command, resolved);
+    return resolved;
 }
 const HELP_PROBE_CACHE = new Map();
 function probeHelpText(command) {
@@ -898,6 +917,19 @@ function probeHelpText(command) {
     HELP_PROBE_CACHE.set(key, text);
     return text;
 }
+/**
+ * Drop every memoized CLI probe (availability, resolved path, --help text). These
+ * probes shell out with a blocking spawnSync and are cached for the process
+ * lifetime to keep the frequently-rebuilt runtime catalog off the event loop, so a
+ * CLI installed/updated mid-run wouldn't otherwise be noticed until a restart.
+ * Call this right after Bivy installs a runtime so the next catalog build re-probes
+ * and reflects the new binary immediately.
+ */
+export function invalidateCliProbeCache() {
+    COMMAND_AVAILABLE_CACHE.clear();
+    COMMAND_PATH_CACHE.clear();
+    HELP_PROBE_CACHE.clear();
+}
 // A resume template mixes launch flags (`-p`, `--force`) with the resume-specific
 // token(s) (`--resume`, `threads continue`, `-s`, `--restore`, …). Only the latter
 // evidence resume support, so we match on those — otherwise a shared launch flag

package/dist/server.js

@@ -8,7 +8,7 @@ import { randomUUID, randomBytes, timingSafeEqual, createHash } from "node:crypt
 import { fileURLToPath } from "node:url";
 import express from "express";
 import { WebSocketServer, WebSocket } from "ws";
-import { listRuntimes, catalogRuntimes, cliInstallSpec, isCliAgentId } from "./runtime/index.js";
+import { listRuntimes, catalogRuntimes, cliInstallSpec, invalidateCliProbeCache, isCliAgentId } from "./runtime/index.js";
 import { createRunPolicy } from "./policy/run-policy.js";
 import { DEFAULT_BACKOFF } from "./policy/ruleset.js";
 import { SessionRerouteController } from "./policy/session-reroute.js";
@@ -3217,6 +3217,9 @@ const RELAY_COMMANDS = {
             const before = runtimeList().find((runtime) => runtime.id === spec.id);
             if (before?.status !== "available")
                 await runInstallCommand(spec);
+            // The just-installed binary changes what the CLI probes would report, so drop
+            // their (process-lifetime) cache and let the catalog below re-probe it.
+            invalidateCliProbeCache();
             const activeAgent = active?.runtimeId ?? defaultRuntimeId;
             const runtimes = runtimeList(activeAgent);
             relay?.sendEvent({ type: "runtime.install.done", id: spec.id, runtimes });
@@ -4345,6 +4348,12 @@ function startModelAuthWatcher() {
 let sessionAdvertiseTarget;
 let advertiseTimer;
 let advertiseResyncTimer;
+// Only one replace-all session advert may be in flight. If an older snapshot
+// (still containing a just-deleted/pruned session) completes after a newer one,
+// the control plane resurrects that row. Changes arriving during a request set
+// this flag and are sent immediately after it completes, in order.
+let advertiseRunning = false;
+let advertiseAgain = false;
 // How often the node re-affirms it's online to the control plane. Kept well
 // under the control plane's NODE_ONLINE_TTL_MS (90s) so a missed beat or two
 // doesn't flap a healthy node's status.
@@ -4575,11 +4584,17 @@ async function advertiseSessions() {
             : [];
         return {
             sessionId: s.id,
-            status: pendingApproval || failureAttention.length ? "needs_action" : (record ? (sessionBusy(record) ? "working" : "idle") : "saved"),
-            needsAction: pendingApproval || failureAttention.length > 0,
+            // Failures (including exhausted credits/rate limits) are outcomes to
+            // review, not blocking questions that keep saying "Needs your response".
+            // Only a still-pending approval/question owns that status.
+            status: pendingApproval ? "needs_action" : (record ? (sessionBusy(record) ? "working" : "idle") : "saved"),
+            needsAction: pendingApproval,
             source: record?.source || meta?.source,
             titleEnc: name ? relay.sealString(name) : undefined,
             branch: record?.worktree?.branch || meta?.branch,
+            // This is activity time, not advert receive time. A daemon restart/full
+            // resync must not make every historical row appear freshly updated.
+            updatedAt: isoFrom(record?.lastTouchedAt ?? meta?.lastActivityAt ?? meta?.updatedAt ?? s.modified),
             agentServiceAddress,
             githubIssueUrl: record?.githubIssueUrl,
             prUrl: record?.prUrl,
@@ -4597,16 +4612,39 @@ async function advertiseSessions() {
         // best effort; the periodic resync and the next change will retry
     }
 }
-/** Debounced advertise — many session events collapse into one POST. */
+/** Debounced, serialized advertise — many session events collapse into one
+ * POST, and replace-all snapshots can never complete out of order. */
 function scheduleAdvertise() {
-    if (!sessionAdvertiseTarget || advertiseTimer)
+    if (!sessionAdvertiseTarget)
+        return;
+    if (advertiseRunning) {
+        advertiseAgain = true;
+        return;
+    }
+    if (advertiseTimer)
         return;
     advertiseTimer = setTimeout(() => {
         advertiseTimer = undefined;
-        void advertiseSessions();
+        void drainSessionAdverts();
     }, 1000);
     advertiseTimer.unref?.();
 }
+async function drainSessionAdverts() {
+    if (advertiseRunning) {
+        advertiseAgain = true;
+        return;
+    }
+    advertiseRunning = true;
+    try {
+        do {
+            advertiseAgain = false;
+            await advertiseSessions();
+        } while (advertiseAgain);
+    }
+    finally {
+        advertiseRunning = false;
+    }
+}
 let githubPoller;
 /**
  * Serialize all work for one issue (keyed by its `issue:owner/repo#N` source).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bivy/bivy",
-  "version": "0.7.0-staging.104",
+  "version": "0.7.0-staging.106",
   "type": "module",
   "license": "FSL-1.1-ALv2",
   "description": "Run coding agents on machines you own. Source-available, self-hostable agent workspace.",