@bitsocial/bitsocial-cli 0.19.73 → 0.19.74

package/README.md

@@ -421,7 +421,7 @@ EXAMPLES
   $ bitsocial challenge install ./my-local-challenge
 ```
 
-_See code: [src/cli/commands/challenge/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/challenge/install.ts)_
+_See code: [src/cli/commands/challenge/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/challenge/install.ts)_
 
 ## `bitsocial challenge list`
 
@@ -447,7 +447,7 @@ EXAMPLES
   $ bitsocial challenge list -q
 ```
 
-_See code: [src/cli/commands/challenge/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/challenge/list.ts)_
+_See code: [src/cli/commands/challenge/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/challenge/list.ts)_
 
 ## `bitsocial challenge ls`
 
@@ -501,7 +501,7 @@ EXAMPLES
   $ bitsocial challenge remove @scope/my-challenge
 ```
 
-_See code: [src/cli/commands/challenge/remove.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/challenge/remove.ts)_
+_See code: [src/cli/commands/challenge/remove.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/challenge/remove.ts)_
 
 ## `bitsocial challenge rm NAME`
 
@@ -615,7 +615,7 @@ EXAMPLES
     $ bitsocial community create --jsonFile ./create-options.json
 ```
 
-_See code: [src/cli/commands/community/create.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/create.ts)_
+_See code: [src/cli/commands/community/create.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/create.ts)_
 
 ## `bitsocial community delete ADDRESSES`
 
@@ -640,7 +640,7 @@ EXAMPLES
   $ bitsocial community delete 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/delete.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/delete.ts)_
+_See code: [src/cli/commands/community/delete.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/delete.ts)_
 
 ## `bitsocial community edit ADDRESS`
 
@@ -710,7 +710,7 @@ EXAMPLES
     $ bitsocial community edit bitsocial.bso --jsonFile ./edit-options.json
 ```
 
-_See code: [src/cli/commands/community/edit.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/edit.ts)_
+_See code: [src/cli/commands/community/edit.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/edit.ts)_
 
 ## `bitsocial community export [ADDRESS]`
 
@@ -751,7 +751,7 @@ EXAMPLES
   $ bitsocial community export --publicKey 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/export.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/export.ts)_
+_See code: [src/cli/commands/community/export.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/export.ts)_
 
 ## `bitsocial community get [ADDRESS]`
 
@@ -782,7 +782,7 @@ EXAMPLES
   $ bitsocial community get --publicKey 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/get.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/get.ts)_
+_See code: [src/cli/commands/community/get.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/get.ts)_
 
 ## `bitsocial community list`
 
@@ -805,7 +805,7 @@ EXAMPLES
   $ bitsocial community list
 ```
 
-_See code: [src/cli/commands/community/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/list.ts)_
+_See code: [src/cli/commands/community/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/list.ts)_
 
 ## `bitsocial community start ADDRESSES`
 
@@ -839,7 +839,7 @@ EXAMPLES
     $ bitsocial community start $(bitsocial community list -q) --concurrency 1
 ```
 
-_See code: [src/cli/commands/community/start.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/start.ts)_
+_See code: [src/cli/commands/community/start.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/start.ts)_
 
 ## `bitsocial community stop ADDRESSES`
 
@@ -864,7 +864,7 @@ EXAMPLES
   $ bitsocial community stop Qmb99crTbSUfKXamXwZBe829Vf6w5w5TktPkb6WstC9RFW
 ```
 
-_See code: [src/cli/commands/community/stop.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/community/stop.ts)_
+_See code: [src/cli/commands/community/stop.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/community/stop.ts)_
 
 ## `bitsocial daemon`
 
@@ -911,7 +911,7 @@ EXAMPLES
   $ bitsocial daemon --no-allowPrivateKeyExport
 ```
 
-_See code: [src/cli/commands/daemon.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/daemon.ts)_
+_See code: [src/cli/commands/daemon.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/daemon.ts)_
 
 ## `bitsocial help [COMMAND]`
 
@@ -977,7 +977,7 @@ EXAMPLES
   $ bitsocial logs --stdout -f
 ```
 
-_See code: [src/cli/commands/logs.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/logs.ts)_
+_See code: [src/cli/commands/logs.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/logs.ts)_
 
 ## `bitsocial update check`
 
@@ -994,7 +994,7 @@ EXAMPLES
   $ bitsocial update check
 ```
 
-_See code: [src/cli/commands/update/check.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/update/check.ts)_
+_See code: [src/cli/commands/update/check.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/update/check.ts)_
 
 ## `bitsocial update install [VERSION]`
 
@@ -1026,7 +1026,7 @@ EXAMPLES
   $ bitsocial update install --no-restart-daemons
 ```
 
-_See code: [src/cli/commands/update/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/update/install.ts)_
+_See code: [src/cli/commands/update/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/update/install.ts)_
 
 ## `bitsocial update versions`
 
@@ -1048,7 +1048,7 @@ EXAMPLES
   $ bitsocial update versions --limit 5
 ```
 
-_See code: [src/cli/commands/update/versions.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.73/src/cli/commands/update/versions.ts)_
+_See code: [src/cli/commands/update/versions.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.74/src/cli/commands/update/versions.ts)_
 <!-- commandsstop -->
 
 ## Contribution

package/dist/cli/commands/daemon.js

@@ -210,6 +210,12 @@ export default class Daemon extends Command {
         this._setupLogger(PKCLogger);
         const { logFilePath, stdoutWrite } = await this._pipeDebugLogsToLogFile(flags.logPath, PKCLogger);
         const log = PKCLogger("bitsocial-cli:daemon");
+        // Captured once the async exit hook is registered (inside the try). The startup-failure
+        // catch and the force-quit signal guard use these to run kubo/daemon cleanup and drop the
+        // hook before the process exits via process.exit() — which would otherwise skip the async
+        // hook (exit-hook's "SYNCHRONOUS TERMINATION NOTICE") and orphan kubo. (issue #98)
+        let runDaemonShutdown;
+        let removeAsyncExitHook;
         try {
             // Log debug info after pipe is set up so it goes to the log file, not terminal
             const envDebug = process.env["_PKC_DEBUG"] || process.env["DEBUG"];
@@ -417,6 +423,13 @@ export default class Daemon extends Command {
                     return;
                 if (startedOwnRpc)
                     return;
+                // Test hook (issue #98): force a startup failure *after* keepKuboUp() has already
+                // spawned kubo, reproducing the real TOCTOU port race (createOrConnectRpc throwing
+                // once kubo is up). Verifies the daemon tears kubo down — and doesn't print
+                // exit-hook's "SYNCHRONOUS TERMINATION NOTICE" — when oclif process.exit()s on a
+                // thrown startup error, instead of orphaning kubo.
+                if (process.env["PKC_CLI_TEST_FAIL_AFTER_KUBO_START"])
+                    throw new Error("Simulated startup failure after kubo start (PKC_CLI_TEST_FAIL_AFTER_KUBO_START)");
                 // Re-check the port: the early fail-fast at startup is a few ms before this runs,
                 // so a TOCTOU race could let another process grab the port in between. If that
                 // happens we must fail rather than silently leaving the daemon without an RPC.
@@ -530,7 +543,7 @@ export default class Daemon extends Command {
                     killKuboProcessGroup(pid, "SIGKILL");
                 liveKuboPids.clear();
             };
-            asyncExitHook(async () => {
+            const shutdownDaemon = async () => {
                 if (keepKuboUpInterval)
                     clearInterval(keepKuboUpInterval);
                 if (mainProcessExited)
@@ -552,8 +565,16 @@ export default class Daemon extends Command {
                         log.error("Error shutting down daemon server", e);
                     }
                 await kuboKillPromise;
-            }, { wait: DAEMON_SHUTDOWN_TIMEOUT_MS } // could take two minutes to shut down
+            };
+            // Run kubo/daemon cleanup on SIGINT/SIGTERM/beforeExit. Capture the unsubscribe handle
+            // and the shutdown fn so the startup-failure catch (and the force-quit guard below) can
+            // run cleanup themselves and drop this hook: oclif calls process.exit() as it unwinds a
+            // thrown startup error, and process.exit() runs only synchronous exit hooks — exit-hook
+            // would skip this async one (printing its "SYNCHRONOUS TERMINATION NOTICE") and orphan a
+            // kubo we already spawned. (issue #98)
+            removeAsyncExitHook = asyncExitHook(shutdownDaemon, { wait: DAEMON_SHUTDOWN_TIMEOUT_MS } // could take two minutes to shut down
             );
+            runDaemonShutdown = shutdownDaemon;
             // Emergency cleanup: if the process force-exits (e.g. double Ctrl+C),
             // synchronously SIGKILL every live kubo's process group. This is a no-op if
             // killKuboProcess() already ran (it clears kuboProcess and liveKuboPids).
@@ -578,6 +599,11 @@ export default class Daemon extends Command {
                     terminationSignalCount++;
                     if (terminationSignalCount >= 2) {
                         log(`Received ${signal} again during shutdown, force-quitting`);
+                        // Deliberate immediate exit: the first signal's async shutdown is still
+                        // running but the user wants out now. Drop the async exit hook first so the
+                        // imminent process.exit() doesn't trip exit-hook's "SYNCHRONOUS TERMINATION
+                        // NOTICE"; kubo is still SIGKILLed by the emergency "exit" handler. (issue #98)
+                        removeAsyncExitHook?.();
                         process.exit(signal === "SIGINT" ? 130 : 143);
                     }
                 });
@@ -641,6 +667,20 @@ export default class Daemon extends Command {
             }
             stdoutWrite(`Full log: ${logFilePath}\n`);
             stdoutWrite(`Or run: bitsocial logs\n`);
+            // oclif's error handler calls process.exit() as it unwinds this throw, which runs only
+            // synchronous exit hooks — exit-hook would skip the async kubo/daemon cleanup (printing
+            // "SYNCHRONOUS TERMINATION NOTICE") and orphan a kubo we may have already spawned, and
+            // leave this daemon's state file behind. Run that cleanup now and drop the now-redundant
+            // hook so the process exits clean. No-ops if we failed before the hook was registered.
+            // Cap the wait with the same DAEMON_SHUTDOWN_TIMEOUT_MS the signal path gets (via the
+            // exit-hook `wait` option) so a hung daemonServer.destroy() can't swallow the original
+            // startup error forever; the unref'd timer never keeps the loop alive. (issue #98)
+            if (runDaemonShutdown)
+                await Promise.race([
+                    runDaemonShutdown().catch(() => { }),
+                    new Promise((resolve) => setTimeout(resolve, DAEMON_SHUTDOWN_TIMEOUT_MS).unref())
+                ]);
+            removeAsyncExitHook?.();
             throw err;
         }
     }

package/oclif.manifest.json

@@ -871,5 +871,5 @@
       ]
     }
   },
-  "version": "0.19.73"
+  "version": "0.19.74"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@bitsocial/bitsocial-cli",
-    "version": "0.19.73",
+    "version": "0.19.74",
     "description": "Command line interface to Bitsocial API",
     "types": "./dist/index.d.ts",
     "homepage": "https://github.com/bitsocialnet/bitsocial-cli",
@@ -119,7 +119,7 @@
         "@oclif/plugin-help": "6.2.36",
         "@oclif/plugin-not-found": "3.2.73",
         "@oclif/table": "0.5.1",
-        "@pkcprotocol/pkc-js": "0.0.48",
+        "@pkcprotocol/pkc-js": "0.0.49",
         "dataobject-parser": "1.2.22",
         "decompress": "4.2.1",
         "env-paths": "2.2.1",