@bitsocial/bitsocial-cli 0.19.66 → 0.19.67

package/README.md

@@ -421,7 +421,7 @@ EXAMPLES
   $ bitsocial challenge install ./my-local-challenge
 ```
 
-_See code: [src/cli/commands/challenge/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/challenge/install.ts)_
+_See code: [src/cli/commands/challenge/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/challenge/install.ts)_
 
 ## `bitsocial challenge list`
 
@@ -447,7 +447,7 @@ EXAMPLES
   $ bitsocial challenge list -q
 ```
 
-_See code: [src/cli/commands/challenge/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/challenge/list.ts)_
+_See code: [src/cli/commands/challenge/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/challenge/list.ts)_
 
 ## `bitsocial challenge ls`
 
@@ -501,7 +501,7 @@ EXAMPLES
   $ bitsocial challenge remove @scope/my-challenge
 ```
 
-_See code: [src/cli/commands/challenge/remove.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/challenge/remove.ts)_
+_See code: [src/cli/commands/challenge/remove.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/challenge/remove.ts)_
 
 ## `bitsocial challenge rm NAME`
 
@@ -615,7 +615,7 @@ EXAMPLES
     $ bitsocial community create --jsonFile ./create-options.json
 ```
 
-_See code: [src/cli/commands/community/create.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/create.ts)_
+_See code: [src/cli/commands/community/create.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/create.ts)_
 
 ## `bitsocial community delete ADDRESSES`
 
@@ -640,7 +640,7 @@ EXAMPLES
   $ bitsocial community delete 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/delete.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/delete.ts)_
+_See code: [src/cli/commands/community/delete.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/delete.ts)_
 
 ## `bitsocial community edit ADDRESS`
 
@@ -710,7 +710,7 @@ EXAMPLES
     $ bitsocial community edit bitsocial.bso --jsonFile ./edit-options.json
 ```
 
-_See code: [src/cli/commands/community/edit.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/edit.ts)_
+_See code: [src/cli/commands/community/edit.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/edit.ts)_
 
 ## `bitsocial community export [ADDRESS]`
 
@@ -751,7 +751,7 @@ EXAMPLES
   $ bitsocial community export --publicKey 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/export.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/export.ts)_
+_See code: [src/cli/commands/community/export.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/export.ts)_
 
 ## `bitsocial community get [ADDRESS]`
 
@@ -782,7 +782,7 @@ EXAMPLES
   $ bitsocial community get --publicKey 12D3KooWG3XbzoVyAE6Y9vHZKF64Yuuu4TjdgQKedk14iYmTEPWu
 ```
 
-_See code: [src/cli/commands/community/get.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/get.ts)_
+_See code: [src/cli/commands/community/get.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/get.ts)_
 
 ## `bitsocial community list`
 
@@ -805,7 +805,7 @@ EXAMPLES
   $ bitsocial community list
 ```
 
-_See code: [src/cli/commands/community/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/list.ts)_
+_See code: [src/cli/commands/community/list.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/list.ts)_
 
 ## `bitsocial community start ADDRESSES`
 
@@ -839,7 +839,7 @@ EXAMPLES
     $ bitsocial community start $(bitsocial community list -q) --concurrency 1
 ```
 
-_See code: [src/cli/commands/community/start.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/start.ts)_
+_See code: [src/cli/commands/community/start.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/start.ts)_
 
 ## `bitsocial community stop ADDRESSES`
 
@@ -864,7 +864,7 @@ EXAMPLES
   $ bitsocial community stop Qmb99crTbSUfKXamXwZBe829Vf6w5w5TktPkb6WstC9RFW
 ```
 
-_See code: [src/cli/commands/community/stop.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/community/stop.ts)_
+_See code: [src/cli/commands/community/stop.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/community/stop.ts)_
 
 ## `bitsocial daemon`
 
@@ -911,7 +911,7 @@ EXAMPLES
   $ bitsocial daemon --no-allowPrivateKeyExport
 ```
 
-_See code: [src/cli/commands/daemon.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/daemon.ts)_
+_See code: [src/cli/commands/daemon.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/daemon.ts)_
 
 ## `bitsocial help [COMMAND]`
 
@@ -977,7 +977,7 @@ EXAMPLES
   $ bitsocial logs --stdout -f
 ```
 
-_See code: [src/cli/commands/logs.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/logs.ts)_
+_See code: [src/cli/commands/logs.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/logs.ts)_
 
 ## `bitsocial update check`
 
@@ -994,7 +994,7 @@ EXAMPLES
   $ bitsocial update check
 ```
 
-_See code: [src/cli/commands/update/check.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/update/check.ts)_
+_See code: [src/cli/commands/update/check.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/update/check.ts)_
 
 ## `bitsocial update install [VERSION]`
 
@@ -1026,7 +1026,7 @@ EXAMPLES
   $ bitsocial update install --no-restart-daemons
 ```
 
-_See code: [src/cli/commands/update/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/update/install.ts)_
+_See code: [src/cli/commands/update/install.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/update/install.ts)_
 
 ## `bitsocial update versions`
 
@@ -1048,7 +1048,7 @@ EXAMPLES
   $ bitsocial update versions --limit 5
 ```
 
-_See code: [src/cli/commands/update/versions.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.66/src/cli/commands/update/versions.ts)_
+_See code: [src/cli/commands/update/versions.ts](https://github.com/bitsocialnet/bitsocial-cli/blob/v0.19.67/src/cli/commands/update/versions.ts)_
 <!-- commandsstop -->
 
 ## Contribution

package/dist/cli/commands/daemon.js

@@ -9,7 +9,7 @@ import { printBanner } from "../ascii-banner.js";
 import { loadChallengesIntoPKC, formatChallengeNameVersion } from "../../challenge-packages/challenge-utils.js";
 import { migrateDataDirectory } from "../../common-utils/data-migration.js";
 import { createBsoResolvers, DEFAULT_PROVIDERS } from "../../common-utils/resolvers.js";
-import { pruneStaleStates, writeDaemonState, deleteDaemonState } from "../../common-utils/daemon-state.js";
+import { pruneStaleStates, writeDaemonState, deleteDaemonState, DAEMON_SHUTDOWN_TIMEOUT_MS } from "../../common-utils/daemon-state.js";
 import { createDaemonFileLogger } from "../../common-utils/daemon-file-logger.js";
 import fs from "fs";
 import fsPromise from "fs/promises";
@@ -468,6 +468,16 @@ export default class Daemon extends Command {
                 }
             };
             const killKuboProcess = async () => {
+                // Test hook (issue #70): hold off the kubo teardown for a fixed delay so a test can
+                // deterministically reproduce the window where the daemon's RPC port is already free
+                // (daemonServer.destroy() runs in parallel) but kubo is still alive and bound. This is
+                // exactly the window `update install` must not restart into — see
+                // test/cli/update-install-restart-race.test.ts. The daemon process stays alive for the
+                // duration because the exit hook awaits killKuboProcess() before exiting.
+                const kuboShutdownDelayRaw = process.env["PKC_CLI_TEST_KUBO_SHUTDOWN_DELAY_MS"];
+                const kuboShutdownDelay = kuboShutdownDelayRaw ? Number(kuboShutdownDelayRaw) : 0;
+                if (Number.isFinite(kuboShutdownDelay) && kuboShutdownDelay > 0)
+                    await new Promise((resolve) => setTimeout(resolve, kuboShutdownDelay));
                 // Wait (bounded) for any in-flight start attempt so we kill the kubo it may still
                 // spawn. Both promises settle on all failure paths (issue #70), but a spawned kubo
                 // that wedges before "Daemon is ready" without exiting keeps them pending — the
@@ -538,7 +548,7 @@ export default class Daemon extends Command {
                         log.error("Error shutting down daemon server", e);
                     }
                 await kuboKillPromise;
-            }, { wait: 120000 } // could take two minutes to shut down
+            }, { wait: DAEMON_SHUTDOWN_TIMEOUT_MS } // could take two minutes to shut down
             );
             // Emergency cleanup: if the process force-exits (e.g. double Ctrl+C),
             // synchronously SIGKILL every live kubo's process group. This is a no-op if

package/dist/cli/commands/logs.js

@@ -163,6 +163,14 @@ export default class Logs extends Command {
         // Follow mode: dump existing content (filtered + tailed) then watch for new data
         let currentLogFile = latestLogFile;
         const existingContent = await fsPromise.readFile(currentLogFile, "utf-8");
+        // Anchor the follow offset to exactly the bytes we just read, NOT a separate
+        // fsPromise.stat() taken afterwards. A later stat is racy: any append landing between
+        // this read and the stat is skipped (position jumps past it) yet was never in the dump
+        // above, so follow mode silently drops those lines. Under load that window widens — this
+        // was the cause of the intermittent CI failure where an appended line was never surfaced
+        // (issue #77). Byte length (not string length) because position indexes bytes in the file.
+        let position = Buffer.byteLength(existingContent, "utf-8");
+        let pendingBuffer = "";
         const entries = this._parseLogEntries(existingContent);
         const filtered = this._filterEntries(entries, since, until);
         const streamFiltered = streamFilter ? this._filterByStream(filtered, streamFilter) : filtered;
@@ -170,9 +178,6 @@ export default class Logs extends Command {
         const initialOutput = tailed.map((e) => e.lines.join("\n")).join("\n");
         if (initialOutput)
             process.stdout.write(initialOutput + "\n");
-        const stat = await fsPromise.stat(currentLogFile);
-        let position = stat.size;
-        let pendingBuffer = "";
         // Watch for new data by reading directly from `position`. We intentionally do
         // NOT gate on fsPromise.stat().size — on Windows + NTFS, stat() returns a stale
         // size for a short window after another process appends, which causes the gate

package/dist/cli/commands/update/install.d.ts

@@ -10,5 +10,11 @@ export default class Install extends Command {
     };
     static examples: string[];
     run(): Promise<void>;
+    /**
+     * Poll until the given PID no longer exists (signal 0 throws ESRCH), or the timeout elapses.
+     * Returns true if the process exited, false on timeout. EPERM means the process is still alive
+     * but owned by another user, so we keep waiting.
+     */
+    private _waitForProcessExit;
     private _restartDaemons;
 }

package/dist/cli/commands/update/install.js

@@ -4,7 +4,7 @@ import tcpPortUsed from "tcp-port-used";
 import { fetchLatestVersion, installGlobal } from "../../../update/npm-registry.js";
 import { fastInstallGlobal } from "../../../update/fast-update.js";
 import { compareVersions } from "../../../update/semver.js";
-import { getAliveDaemonStates } from "../../../common-utils/daemon-state.js";
+import { getAliveDaemonStates, DAEMON_SHUTDOWN_TIMEOUT_MS } from "../../../common-utils/daemon-state.js";
 export default class Install extends Command {
     static description = "Install a specific version of bitsocial from npm";
     static args = {
@@ -54,15 +54,17 @@ export default class Install extends Command {
                     throw e;
                 }
             }
-            // Wait for all daemon ports to be free
+            // Wait for each daemon process to fully exit — NOT just for its RPC port to free.
+            // The daemon releases its RPC port (daemonServer.destroy()) before it finishes killing
+            // its kubo child, so a port-only wait lets us restart while the old kubo still holds the
+            // IPFS API port; the new daemon then dies on startup with "IPFS API port already in use"
+            // (issue #70). The daemon's exit hook kills kubo before the process exits, so waiting for
+            // the PID to disappear guarantees the kubo port is free before we restart.
             for (const d of aliveDaemons) {
-                const url = new URL(d.pkcRpcUrl);
-                const port = Number(url.port);
-                const host = url.hostname;
-                this.log(`Waiting for port ${port} to be free...`);
-                const freed = await tcpPortUsed.waitUntilFree(port, 500, 30000).then(() => true).catch(() => false);
-                if (!freed) {
-                    this.error(`Daemon (PID ${d.pid}) did not shut down within 30 seconds on port ${port}.`, { exit: 1 });
+                this.log(`Waiting for daemon (PID ${d.pid}) to exit...`);
+                const exited = await this._waitForProcessExit(d.pid, DAEMON_SHUTDOWN_TIMEOUT_MS);
+                if (!exited) {
+                    this.error(`Daemon (PID ${d.pid}) did not shut down within ${DAEMON_SHUTDOWN_TIMEOUT_MS / 1000} seconds.`, { exit: 1 });
                 }
             }
             this.log("All daemons stopped.");
@@ -118,6 +120,33 @@ export default class Install extends Command {
             this.log("To see the daemon logs run `bitsocial logs --stdout`");
         }
     }
+    /**
+     * Poll until the given PID no longer exists (signal 0 throws ESRCH), or the timeout elapses.
+     * Returns true if the process exited, false on timeout. EPERM means the process is still alive
+     * but owned by another user, so we keep waiting.
+     */
+    async _waitForProcessExit(pid, timeoutMs) {
+        const deadline = Date.now() + timeoutMs;
+        while (Date.now() < deadline) {
+            try {
+                process.kill(pid, 0);
+            }
+            catch (e) {
+                if (e.code === "ESRCH")
+                    return true; // no such process — it exited
+            }
+            await new Promise((resolve) => setTimeout(resolve, 250));
+        }
+        // Final check so a process that exits in the last interval isn't reported as a timeout
+        try {
+            process.kill(pid, 0);
+        }
+        catch (e) {
+            if (e.code === "ESRCH")
+                return true;
+        }
+        return false;
+    }
     async _restartDaemons(daemons) {
         this.log(`Restarting ${daemons.length} daemon(s)...`);
         for (const d of daemons) {

package/dist/common-utils/daemon-state.d.ts

@@ -1,3 +1,10 @@
+/**
+ * Maximum time a daemon is allowed to shut down its kubo + RPC server during its
+ * async exit hook. The `update install --restart-daemons` orchestrator must wait at
+ * least this long for a stopped daemon's PID to disappear before giving up — otherwise
+ * a slow-but-valid shutdown (within the daemon's own contract) aborts the update midway.
+ */
+export declare const DAEMON_SHUTDOWN_TIMEOUT_MS = 120000;
 export interface DaemonState {
     pid: number;
     startedAt: string;

package/dist/common-utils/daemon-state.js

@@ -5,6 +5,13 @@ import { execFile } from "child_process";
 import { promisify } from "util";
 const execFileAsync = promisify(execFile);
 const DAEMON_STATES_DIR = path.join(defaults.PKC_DATA_PATH, ".daemon_states");
+/**
+ * Maximum time a daemon is allowed to shut down its kubo + RPC server during its
+ * async exit hook. The `update install --restart-daemons` orchestrator must wait at
+ * least this long for a stopped daemon's PID to disappear before giving up — otherwise
+ * a slow-but-valid shutdown (within the daemon's own contract) aborts the update midway.
+ */
+export const DAEMON_SHUTDOWN_TIMEOUT_MS = 120000;
 function stateFilePath(pid) {
     return path.join(DAEMON_STATES_DIR, `${pid}-daemon.state`);
 }

package/oclif.manifest.json

@@ -871,5 +871,5 @@
       ]
     }
   },
-  "version": "0.19.66"
+  "version": "0.19.67"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@bitsocial/bitsocial-cli",
-    "version": "0.19.66",
+    "version": "0.19.67",
     "description": "Command line interface to Bitsocial API",
     "types": "./dist/index.d.ts",
     "homepage": "https://github.com/bitsocialnet/bitsocial-cli",