@bits-innovate/react-native-vstarcam 1.0.30 → 1.0.32

package/android/src/main/java/com/reactnativevstarcam/VStarCamModule.java

@@ -59,6 +59,12 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
     // Counter for unique internal client IDs
     private static final java.util.concurrent.atomic.AtomicInteger nextClientPtr = new java.util.concurrent.atomic.AtomicInteger(1000);
     
+    // Static proxy references to prevent GC. 
+    // If the native SDK holds these, Java must not collect them.
+    private static Object stateListenerProxy;
+    private static Object commandListenerProxy;
+    private static Object releaseListenerProxy;
+    
     // Helper for conditional debug logging
     private static void logDebug(String message) {
         if (DEBUG_LOGGING) {
@@ -270,14 +276,14 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
         
         try {
             // Create dynamic proxy for ClientStateListener
-            Object stateListener = Proxy.newProxyInstance(
+            stateListenerProxy = Proxy.newProxyInstance(
                 stateListenerClass.getClassLoader(),
                 new Class<?>[] { stateListenerClass },
                 new InvocationHandler() {
                     @Override
                     public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
                         try {
-                            Log.d(TAG, "ClientStateListener." + method.getName() + " called with " + (args != null ? args.length : 0) + " args");
+                            Log.d(TAG, "ClientStateListener." + method.getName() + " called");
                             if (method.getName().equals("stateListener")) {
                                 // args: long clientPtr, int state
                                 final long clientPtr = (Long) args[0];
@@ -297,28 +303,22 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
                         } catch (Exception e) {
                             Log.e(TAG, "Error in stateListener callback", e);
                         }
-                        
-                        // Handle return type
-                        Class<?> returnType = method.getReturnType();
-                        if (returnType.equals(int.class) || returnType.equals(Integer.class)) {
-                            return 0;
-                        }
-                        return null;
+                        return null; // void stateListener
                     }
                 }
             );
             
             // Create dynamic proxy for ClientCommandListener
-            Object commandListener = Proxy.newProxyInstance(
+            commandListenerProxy = Proxy.newProxyInstance(
                 commandListenerClass.getClassLoader(),
                 new Class<?>[] { commandListenerClass },
                 new InvocationHandler() {
                     @Override
                     public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
                         try {
-                            Log.d(TAG, "ClientCommandListener." + method.getName() + " called with " + (args != null ? args.length : 0) + " args");
+                            Log.d(TAG, "ClientCommandListener." + method.getName() + " called");
                             if (method.getName().equals("commandListener")) {
-                                // args: long clientPtr, byte[] data, int length (from interface)
+                                // args: long clientPtr, byte[] data, int length
                                 final long clientPtr = (Long) args[0];
                                 final byte[] data = (byte[]) args[1];
                                 final int length = (Integer) args[2];
@@ -336,19 +336,13 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
                         } catch (Exception e) {
                             Log.e(TAG, "Error in commandListener callback", e);
                         }
-                        
-                        // Handle return type
-                        Class<?> returnType = method.getReturnType();
-                        if (returnType.equals(int.class) || returnType.equals(Integer.class)) {
-                            return 0;
-                        }
-                        return null;
+                        return null; // void commandListener
                     }
                 }
             );
             
             // Create dynamic proxy for ClientReleaseListener
-            Object releaseListener = Proxy.newProxyInstance(
+            releaseListenerProxy = Proxy.newProxyInstance(
                 releaseListenerClass.getClassLoader(),
                 new Class<?>[] { releaseListenerClass },
                 new InvocationHandler() {
@@ -356,16 +350,14 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
                     public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
                         try {
                             Log.d(TAG, "ClientReleaseListener." + method.getName() + " called");
+                            if (method.getName().equals("releaseListener")) {
+                                final long clientPtr = (Long) args[0];
+                                Log.d(TAG, "Release callback: clientPtr=" + clientPtr);
+                            }
                         } catch (Exception e) {
                             Log.e(TAG, "Error in releaseListener callback", e);
                         }
-                        
-                        // Handle return type
-                        Class<?> returnType = method.getReturnType();
-                        if (returnType.equals(int.class) || returnType.equals(Integer.class)) {
-                            return 0;
-                        }
-                        return null;
+                        return null; // void releaseListener
                     }
                 }
             );
@@ -373,7 +365,8 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
             // Call JNIApi.init(stateListener, commandListener, releaseListener)
             Method initMethod = jniApiClass.getMethod("init", 
                 stateListenerClass, commandListenerClass, releaseListenerClass);
-            initMethod.invoke(null, stateListener, commandListener, releaseListener);
+            Log.d(TAG, "Calling JNIApi.init with proxies...");
+            initMethod.invoke(null, stateListenerProxy, commandListenerProxy, releaseListenerProxy);
             
             isP2PInitialized = true;
             Log.d(TAG, "P2P system initialized successfully!");
@@ -553,8 +546,8 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
                 Log.d(TAG, "Calling JNIApi.connect(" + clientInfo.sdkClientPtr + ", 15, " + param + ", " + actualConnectType + ")");
                 
                 try {
-                    connectMethod.invoke(null, clientInfo.sdkClientPtr, 15, param, actualConnectType);
-                    Log.d(TAG, "JNIApi.connect returned normally");
+                    Object result = connectMethod.invoke(null, clientInfo.sdkClientPtr, 15, param, actualConnectType);
+                    Log.d(TAG, "JNIApi.connect result: " + result);
                 } catch (java.lang.reflect.InvocationTargetException ite) {
                     Log.e(TAG, "JNIApi.connect threw exception: " + ite.getCause(), ite.getCause());
                     throw ite;
@@ -609,32 +602,35 @@ public class VStarCamModule extends ReactContextBaseJavaModule {
                 
                 Log.d(TAG, "Calling JNIApi.login(" + clientInfo.sdkClientPtr + ", " + username + ", ***)");
                 
-                boolean loginSuccess = false;
+                boolean loginResult = false;
                 try {
-                    loginMethod.invoke(null, clientInfo.sdkClientPtr, username, password);
-                    Log.d(TAG, "JNIApi.login returned normally");
-                    loginSuccess = true;
+                    Object result = loginMethod.invoke(null, clientInfo.sdkClientPtr, username, password);
+                    Log.d(TAG, "JNIApi.login result: " + result);
+                    // result is likely boolean based on signature log
+                    if (result instanceof Boolean) {
+                        loginResult = (Boolean) result;
+                    } else if (result != null) {
+                        loginResult = true; // Non-null result usually means success for some SDKs
+                    }
                 } catch (java.lang.reflect.InvocationTargetException ite) {
                     Throwable cause = ite.getCause();
                     Log.e(TAG, "JNIApi.login threw exception: " + cause, cause);
-                    // Don't rethrow - return false instead to prevent crash
                     promise.resolve(false);
                     return;
                 } catch (Throwable t) {
                     Log.e(TAG, "JNIApi.login crashed: " + t.getMessage(), t);
-                    // Don't rethrow - return false instead to prevent crash
                     promise.resolve(false);
                     return;
                 }
                 
-                if (loginSuccess) {
+                if (loginResult) {
                     clientInfo.isLoggedIn = true;
                     clientInfo.username = username;
                     clientInfo.password = password;
                 }
                 
-                Log.d(TAG, "JNIApi.login completed with result: " + loginSuccess);
-                promise.resolve(loginSuccess);
+                Log.d(TAG, "JNIApi.login completed with result: " + loginResult);
+                promise.resolve(loginResult);
             } catch (Exception e) {
                 Log.e(TAG, "clientLogin failed", e);
                 promise.reject("LOGIN_ERROR", e.getMessage());

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bits-innovate/react-native-vstarcam",
-  "version": "1.0.30",
+  "version": "1.0.32",
   "description": "React Native bridge for VStarCam P2P SDK",
   "main": "src/index.ts",
   "types": "src/index.ts",