@bitpoolos/edge-bacnet 1.6.6 → 1.6.8

package/bacnet_write.html

@@ -8,7 +8,7 @@
     color: "#00aeef",
     defaults: {
       name: { value: "" },
-      applicationTag: { value: "4" },
+      applicationTag: { value: "-1" },
       priority: { value: "16" },
       pointsToWrite: { value: [] },
       writeDevices: { value: [] },
@@ -943,6 +943,7 @@
           ><i class="icon-tag"></i><span data-i18n="bitpool-bacnet.label.applicationTag"></span> Application Tag</label
         >
         <select id="node-input-applicationTag">
+          <option value="-1">AUTO</option>
           <option value="0">NULL</option>
           <option value="1">BOOLEAN</option>
           <option value="2">UNSIGNED_INT</option>

package/common.js

@@ -67,7 +67,8 @@ class BacnetClientConfig {
     cacheFileEnabled,
     sanitise_device_schedule,
     portRangeMatrix,
-    enable_device_discovery
+    enable_device_discovery,
+    maxConcurrentRequests
   ) {
     this.apduTimeout = apduTimeout;
     this.localIpAdrress = localIpAdrress;
@@ -87,6 +88,12 @@ class BacnetClientConfig {
     this.sanitise_device_schedule = sanitise_device_schedule;
     this.portRangeMatrix = this.generatePortRangeArray(portRangeMatrix);
     this.enable_device_discovery = enable_device_discovery;
+    // Clamp maxConcurrentRequests between 1 and 250
+    // BACnet protocol limits invoke IDs to 256, so 250 is the safe maximum
+    let clampedMaxConcurrent = parseInt(maxConcurrentRequests) || 250;
+    if (clampedMaxConcurrent < 1) clampedMaxConcurrent = 1;
+    if (clampedMaxConcurrent > 250) clampedMaxConcurrent = 250;
+    this.maxConcurrentRequests = clampedMaxConcurrent;
   }
 
   generatePortRangeArray(rangeMatrix) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitpoolos/edge-bacnet",
-  "version": "1.6.6",
+  "version": "1.6.8",
   "description": "A bacnet gateway for node-red",
   "dependencies": {
     "@plus4nodered/ts-node-bacnet": "^1.0.0-beta.2",
@@ -26,13 +26,15 @@
     }
   },
   "keywords": [
+    "BACnet",
     "node-red",
     "bitpool",
     "bitpoolos",
     "edge",
     "big data",
     "iot",
-    "BACnet"
+    "building automation",
+    "bms"
   ],
   "engines": {
     "node": ">=12.0.0"

package/resources/node-bacstack-ts/dist/lib/asn1.js

@@ -73,7 +73,7 @@ const encodeBacnetDouble = (buffer, value) => {
 };
 const decodeUnsigned = (buffer, offset, length) => ({
     len: length,
-    value: buffer.readUIntBE(offset, length)
+    value: length === 0 ? 0 : buffer.readUIntBE(offset, length)
 });
 exports.decodeUnsigned = decodeUnsigned;
 const decodeEnumerated = (buffer, offset, lenValue) => {
@@ -815,7 +815,7 @@ const decodeReadAccessResult = (buffer, offset, apduLen) => {
 exports.decodeReadAccessResult = decodeReadAccessResult;
 const decodeSigned = (buffer, offset, length) => ({
     len: length,
-    value: buffer.readIntBE(offset, length)
+    value: length === 0 ? 0 : buffer.readIntBE(offset, length)
 });
 exports.decodeSigned = decodeSigned;
 const decodeReal = (buffer, offset) => ({