@bitpoolos/edge-bacnet 1.0.6 → 1.1.0

package/resources/{bacstack → node-bacnet}/lib/services/delete-object.js

@@ -1,14 +1,19 @@
 'use strict';
 
 const baAsn1 = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.decode = (buffer, offset, apduLen) => {
   const result = baAsn1.decodeTagNumberAndValue(buffer, offset);
-  if (result.tagNumber !== 12) return;
+  if (result.tagNumber !== 12) {
+    return undefined;
+  }
   let len = 1;
   const value = baAsn1.decodeObjectId(buffer, offset + len);
   len += value.len;
-  if (len !== apduLen) return;
+  if (len !== apduLen) {
+    return undefined;
+  }
   value.len = len;
   return value;
 };

package/resources/{bacstack → node-bacnet}/lib/services/device-communication-control.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const baAsn1 = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, timeDuration, enableDisable, password) => {
   if (timeDuration > 0) {
@@ -14,7 +15,7 @@ module.exports.encode = (buffer, timeDuration, enableDisable, password) => {
 
 module.exports.decode = (buffer, offset, apduLen) => {
   let len = 0;
-  const value = {};
+  let value = {};
   let decodedValue;
   let result;
   if (baAsn1.decodeIsContextTag(buffer, offset + len, 0)) {
@@ -24,14 +25,18 @@ module.exports.decode = (buffer, offset, apduLen) => {
     value.timeDuration = decodedValue.value;
     len += decodedValue.len;
   }
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 1)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 1)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
   value.enableDisable = decodedValue.value;
   len += decodedValue.len;
   if (len < apduLen) {
-    if (!baAsn1.decodeIsContextTag(buffer, offset + len, 2)) return;
+    if (!baAsn1.decodeIsContextTag(buffer, offset + len, 2)) {
+      return undefined;
+    }
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
     decodedValue = baAsn1.decodeCharacterString(buffer, offset + len, apduLen - (offset + len), result.value);

package/resources/{bacstack → node-bacnet}/lib/services/error.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const baAsn1 = require('../asn1');
+const baEnum = require('../enum');
 
 module.exports.encode = (buffer, errorClass, errorCode) => {
   baAsn1.encodeApplicationEnumerated(buffer, errorClass);
@@ -24,3 +25,9 @@ module.exports.decode = (buffer, offset) => {
     code: errorCode.value
   };
 };
+
+module.exports.buildMessage = function (result) {
+  return 'BacnetError Class: ' + baEnum.ErrorClassName[result.class] + ' ' +
+    '(' + result.class + ') ' +
+    'Code: ' + baEnum.ErrorCodeName[result.code] + ' (' + result.code + ')';
+};

package/resources/{bacstack → node-bacnet}/lib/services/event-information.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
-const baEnum = require('../enum');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, events, moreEvents) => {
   baAsn1.encodeOpeningTag(buffer, 0);
@@ -33,8 +33,9 @@ module.exports.decode = (buffer, offset, apduLen) => {
   let decodedValue;
   len++;
   const alarms = [];
+  let moreEvents;
   while ((apduLen - 3 - len) > 0) {
-    const value = {};
+    let value = {};
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
     decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
@@ -54,14 +55,14 @@ module.exports.decode = (buffer, offset, apduLen) => {
     len += result.len;
     value.eventTimeStamps = [];
     for (let i = 0; i < 3; i++) {
-      if (result.tagNumber !== baEnum.ApplicationTags.NULL) {
+      if (result.tagNumber !== baEnum.ApplicationTag.NULL) {
         decodedValue = baAsn1.decodeApplicationDate(buffer, offset + len);
         len += decodedValue.len;
         const date = decodedValue.value.value;
         decodedValue = baAsn1.decodeApplicationTime(buffer, offset + len);
         len += decodedValue.len;
         const time = decodedValue.value.value;
-        value.eventTimeStamps[i] = new Date(date.getFullYear(), date.getMonth(), date.getDate(), time.getHours(), time.getMinutes(), time.getSeconds(), time.getMilliseconds());
+        value.eventTimeStamps[i] =  new Date(date.getFullYear(), date.getMonth(), date.getDate(), time.getHours(), time.getMinutes(), time.getSeconds(), time.getMilliseconds());
       } else {
         len += result.value;
       }
@@ -89,10 +90,10 @@ module.exports.decode = (buffer, offset, apduLen) => {
     len++;
     alarms.push(value);
   }
-  const moreEvents = (buffer[apduLen - 1] === 1);
+  moreEvents = (buffer[apduLen - 1] === 1);
   return {
-    len: len,
-    alarms: alarms,
-    moreEvents: moreEvents
+    len,
+    alarms,
+    moreEvents
   };
 };

package/resources/{bacstack → node-bacnet}/lib/services/event-notify-data.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
-const baEnum = require('../enum');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, data) => {
   baAsn1.encodeContextUnsigned(buffer, 0, data.processId);
@@ -48,10 +48,10 @@ module.exports.encode = (buffer, data) => {
           baAsn1.encodeOpeningTag(buffer, 2);
           baAsn1.encodeOpeningTag(buffer, 0);
           switch (data.changeOfValueTag) {
-            case baEnum.CovTypes.REAL:
+            case baEnum.CovType.REAL:
               baAsn1.encodeContextReal(buffer, 1, data.changeOfValueChangeValue);
               break;
-            case baEnum.CovTypes.BIT_STRING:
+            case baEnum.CovType.BIT_STRING:
               baAsn1.encodeContextBitstring(buffer, 0, data.changeOfValueChangedBits);
               break;
             default:
@@ -118,26 +118,34 @@ module.exports.decode = (buffer, offset) => {
   let len = 0;
   let result;
   let decodedValue;
-  const eventData = {};
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) return;
+  let eventData = {};
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
   len += decodedValue.len;
   eventData.processId = decodedValue.value;
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 1)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 1)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
   len += decodedValue.len;
   eventData.initiatingObjectId = {type: decodedValue.objectType, instance: decodedValue.instance};
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 2)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 2)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
   len += decodedValue.len;
   eventData.eventObjectId = {type: decodedValue.objectType, instance: decodedValue.instance};
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 3)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 3)) {
+    return undefined;
+  }
   len += 2;
   decodedValue = baAsn1.decodeApplicationDate(buffer, offset + len);
   len += decodedValue.len;
@@ -148,20 +156,28 @@ module.exports.decode = (buffer, offset) => {
   eventData.timeStamp = {};
   eventData.timeStamp = new Date(date.getFullYear(), date.getMonth(), date.getDate(), time.getHours(), time.getMinutes(), time.getSeconds(), time.getMilliseconds());
   len += 2;
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 4)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 4)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
   len += decodedValue.len;
   eventData.notificationClass = decodedValue.value;
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 5)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 5)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
   len += decodedValue.len;
   eventData.priority = decodedValue.value;
-  if (eventData.priority > 0xFF) return;
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 6)) return;
+  if (eventData.priority > 0xFF) {
+    return undefined;
+  }
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 6)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
@@ -172,7 +188,9 @@ module.exports.decode = (buffer, offset) => {
     len += decodedValue.len;
     eventData.messageText = decodedValue.value;
   }
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 8)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 8)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
@@ -186,7 +204,9 @@ module.exports.decode = (buffer, offset) => {
       decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, 1);
       len += decodedValue.len;
       eventData.ackRequired = (decodedValue.value > 0);
-      if (!baAsn1.decodeIsContextTag(buffer, offset + len, 10)) return;
+      if (!baAsn1.decodeIsContextTag(buffer, offset + len, 10)) {
+        return undefined;
+      }
       result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
       len += result.len;
       decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
@@ -196,7 +216,9 @@ module.exports.decode = (buffer, offset) => {
     default:
       break;
   }
-  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 11)) return;
+  if (!baAsn1.decodeIsContextTag(buffer, offset + len, 11)) {
+    return undefined;
+  }
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);

package/resources/{bacstack → node-bacnet}/lib/services/get-enrollment-summary.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
-const baEnum = require('../enum');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, acknowledgmentFilter, enrollmentFilter, eventStateFilter, eventTypeFilter, priorityFilter, notificationClassFilter) => {
   baAsn1.encodeContextEnumerated(buffer, 0, acknowledgmentFilter);
@@ -40,7 +40,7 @@ module.exports.decode = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
   let decodedValue;
-  const value = {};
+  let value = {};
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
@@ -49,7 +49,9 @@ module.exports.decode = (buffer, offset, apduLen) => {
   if (baAsn1.decodeIsContextTag(buffer, offset + len, 1)) {
     len++;
     value.enrollmentFilter = {};
-    if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) return;
+    if (!baAsn1.decodeIsContextTag(buffer, offset + len, 0)) {
+      return undefined;
+    }
     len++;
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
@@ -123,43 +125,54 @@ module.exports.encodeAcknowledge = (buffer, enrollmentSummaries) => {
 module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
+  let decodedValue;
   const enrollmentSummaries = [];
   while ((apduLen - len) > 0) {
     const enrollmentSummary = {};
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
-    if (result.tagNumber !== baEnum.ApplicationTags.OBJECTIDENTIFIER) return;
+    if (result.tagNumber !== baEnum.ApplicationTag.OBJECTIDENTIFIER) {
+      return undefined;
+    }
     result = baAsn1.decodeObjectId(buffer, offset + len);
     len += result.len;
     enrollmentSummary.objectId = {type: result.objectType, instance: result.instance};
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
-    if (result.tagNumber !== baEnum.ApplicationTags.ENUMERATED) return;
+    if (result.tagNumber !== baEnum.ApplicationTag.ENUMERATED) {
+      return undefined;
+    }
     result = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
     len += result.len;
     enrollmentSummary.eventType = result.value;
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
-    if (result.tagNumber !== baEnum.ApplicationTags.ENUMERATED) return;
+    if (result.tagNumber !== baEnum.ApplicationTag.ENUMERATED) {
+      return undefined;
+    }
     result = baAsn1.decodeEnumerated(buffer, offset + len, result.value);
     len += result.len;
     enrollmentSummary.eventState = result.value;
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
-    if (result.tagNumber !== baEnum.ApplicationTags.UNSIGNED_INTEGER) return;
+    if (result.tagNumber !== baEnum.ApplicationTag.UNSIGNED_INTEGER) {
+      return undefined;
+    }
     result = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
     len += result.len;
     enrollmentSummary.priority = result.value;
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
-    if (result.tagNumber !== baEnum.ApplicationTags.UNSIGNED_INTEGER) return;
+    if (result.tagNumber !== baEnum.ApplicationTag.UNSIGNED_INTEGER) {
+      return undefined;
+    }
     result = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
     len += result.len;
     enrollmentSummary.notificationClass = result.value;
     enrollmentSummaries.push(enrollmentSummary);
   }
   return {
-    enrollmentSummaries: enrollmentSummaries,
-    len: len
+    enrollmentSummaries,
+    len
   };
 };

package/resources/{bacstack → node-bacnet}/lib/services/get-event-information.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
-const baEnum = require('../enum');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, lastReceivedObjectId) => {
   baAsn1.encodeContextObjectId(buffer, 0, lastReceivedObjectId.type, lastReceivedObjectId.instance);
@@ -9,10 +9,12 @@ module.exports.encode = (buffer, lastReceivedObjectId) => {
 
 module.exports.decode = (buffer, offset) => {
   let len = 0;
-  const value = {};
-  const result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
+  let result;
+  let decodedValue;
+  let value = {};
+  result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
-  const decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
+  decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
   len += decodedValue.len;
   value.lastReceivedObjectId = {type: decodedValue.objectType, instance: decodedValue.instance};
   value.len = len;
@@ -46,12 +48,14 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
   let decodedValue;
-  const value = {};
-  if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 0)) return;
+  let value = {};
+  if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 0)) {
+    return undefined;
+  }
   len++;
   value.events = [];
   while ((apduLen - len) > 3) {
-    const event = {};
+    let event = {};
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
     decodedValue = baAsn1.decodeObjectId(buffer, offset + len);
@@ -67,7 +71,9 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
     decodedValue = baAsn1.decodeBitstring(buffer, offset + len, result.value);
     len += decodedValue.len;
     event.acknowledgedTransitions = decodedValue.value;
-    if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 3)) return;
+    if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 3)) {
+      return undefined;
+    }
     len++;
     event.eventTimeStamps = [];
     for (let i = 0; i < 3; i++) {
@@ -77,6 +83,7 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
         decodedValue = baAsn1.decodeBacnetTime(buffer, offset + len, result.value);
         len += decodedValue.len;
         event.eventTimeStamps[i] = {value: decodedValue.value, type: baEnum.TimeStamp.TIME};
+
       } else if (result.tagNumber === baEnum.TimeStamp.SEQUENCE_NUMBER) {
         decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);
         len += decodedValue.len;
@@ -92,7 +99,9 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
         len++;
       }
     }
-    if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 3)) return;
+    if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 3)) {
+      return undefined;
+    }
     len++;
     result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
     len += result.len;
@@ -104,7 +113,9 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
     decodedValue = baAsn1.decodeBitstring(buffer, offset + len, result.value);
     len += decodedValue.len;
     event.eventEnable = decodedValue.value;
-    if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 6)) return;
+    if (!baAsn1.decodeIsOpeningTagNumber(buffer, offset + len, 6)) {
+      return undefined;
+    }
     len++;
     event.eventPriorities = [];
     for (let i = 0; i < 3; i++) {
@@ -114,11 +125,15 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
       len += decodedValue.len;
       event.eventPriorities[i] = decodedValue.value;
     }
-    if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 6)) return;
+    if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 6)) {
+      return undefined;
+    }
     len++;
     value.events.push(event);
   }
-  if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 0)) return;
+  if (!baAsn1.decodeIsClosingTagNumber(buffer, offset + len, 0)) {
+    return undefined;
+  }
   len++;
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;

package/resources/node-bacnet/lib/services/i-am.js

@@ -0,0 +1,90 @@
+/**
+ * The iAm event represents the response to a whoIs request to detect all
+ * devices in a BACNET network.
+ *
+ * @event bacnet.iAm
+ * @param {number} deviceId - The BACNET device-id of the detected device.
+ * @param {number} maxApdu - The max APDU size the detected device supports.
+ * @param {number} segmentation - The type of segmentation the detected device supports.
+ * @param {number} vendorId - The BACNET vendor-id of the detected device.
+ *
+ * @example
+ * const bacnet = require('node-bacnet');
+ * const client = new bacnet();
+ *
+ * client.on('iAm', (msg) => {
+ *   console.log(
+ *     'address: ', msg.header.address,
+ *     ' - deviceId: ', msg.payload.deviceId,
+ *     ' - maxApdu: ', msg.payload.maxApdu,
+ *     ' - segmentation: ', msg.payload.segmentation,
+ *     ' - vendorId: ', msg.payload.vendorId
+ *   );
+ * });
+ */
+
+'use strict';
+
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
+
+module.exports.encode = (buffer, deviceId, maxApdu, segmentation, vendorId) => {
+  baAsn1.encodeApplicationObjectId(buffer, baEnum.ObjectType.DEVICE, deviceId);
+  baAsn1.encodeApplicationUnsigned(buffer, maxApdu);
+  baAsn1.encodeApplicationEnumerated(buffer, segmentation);
+  baAsn1.encodeApplicationUnsigned(buffer, vendorId);
+};
+
+module.exports.decode = (buffer, offset) => {
+  let result;
+  let apduLen = 0;
+  const orgOffset = offset;
+  result = baAsn1.decodeTagNumberAndValue(buffer, offset + apduLen);
+  apduLen += result.len;
+  if (result.tagNumber !== baEnum.ApplicationTag.OBJECTIDENTIFIER) {
+    return undefined;
+  }
+  result = baAsn1.decodeObjectId(buffer, offset + apduLen);
+  apduLen += result.len;
+  if (result.objectType !== baEnum.ObjectType.DEVICE) {
+    return undefined;
+  }
+  const deviceId = result.instance;
+  result = baAsn1.decodeTagNumberAndValue(buffer, offset + apduLen);
+  apduLen += result.len;
+  if (result.tagNumber !== baEnum.ApplicationTag.UNSIGNED_INTEGER) {
+    return undefined;
+  }
+  result = baAsn1.decodeUnsigned(buffer, offset + apduLen, result.value);
+  apduLen += result.len;
+  const maxApdu = result.value;
+  result = baAsn1.decodeTagNumberAndValue(buffer, offset + apduLen);
+  apduLen += result.len;
+  if (result.tagNumber !== baEnum.ApplicationTag.ENUMERATED) {
+    return undefined;
+  }
+  result = baAsn1.decodeEnumerated(buffer, offset + apduLen, result.value);
+  apduLen += result.len;
+  if (result.value > baEnum.Segmentation.NO_SEGMENTATION) {
+    return undefined;
+  }
+  const segmentation = result.value;
+  result = baAsn1.decodeTagNumberAndValue(buffer, offset + apduLen);
+  apduLen += result.len;
+  if (result.tagNumber !== baEnum.ApplicationTag.UNSIGNED_INTEGER) {
+    return undefined;
+  }
+  result = baAsn1.decodeUnsigned(buffer, offset + apduLen, result.value);
+  apduLen += result.len;
+  if (result.value > 0xFFFF) {
+    return undefined;
+  }
+  const vendorId = result.value;
+  return {
+    len: offset - orgOffset,
+    deviceId,
+    maxApdu,
+    segmentation,
+    vendorId
+  };
+};

package/resources/{bacstack/lib/services/i-have-broadcast.js → node-bacnet/lib/services/i-have.js}

@@ -1,6 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, deviceId, objectId, objectName) => {
   baAsn1.encodeApplicationObjectId(buffer, deviceId.type, deviceId.instance);
@@ -12,7 +13,7 @@ module.exports.decode = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
   let decodedValue;
-  const value = {};
+  let value = {};
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeObjectId(buffer, offset + len);

package/resources/{bacstack → node-bacnet}/lib/services/index.js

@@ -6,6 +6,7 @@ module.exports.alarmSummary = require('./alarm-summary');
 module.exports.atomicReadFile = require('./atomic-read-file');
 module.exports.atomicWriteFile = require('./atomic-write-file');
 module.exports.covNotify = require('./cov-notify');
+module.exports.covNotifyUnconfirmed = module.exports.covNotify;
 module.exports.createObject = require('./create-object');
 module.exports.deleteObject = require('./delete-object');
 module.exports.deviceCommunicationControl = require('./device-communication-control');
@@ -14,18 +15,20 @@ module.exports.eventInformation = require('./event-information');
 module.exports.eventNotifyData = require('./event-notify-data');
 module.exports.getEnrollmentSummary = require('./get-enrollment-summary');
 module.exports.getEventInformation = require('./get-event-information');
-module.exports.iAmBroadcast = require('./i-am-broadcast');
-module.exports.iHaveBroadcast = require('./i-have-broadcast');
+module.exports.iAm = require('./i-am');
+module.exports.iHave = require('./i-have');
 module.exports.lifeSafetyOperation = require('./life-safety-operation');
 module.exports.privateTransfer = require('./private-transfer');
-module.exports.readPropertyMultiple = require('./read-property-multiple');
 module.exports.readProperty = require('./read-property');
+module.exports.readPropertyMultiple = require('./read-property-multiple');
 module.exports.readRange = require('./read-range');
+module.exports.registerForeignDevice = require('./register-foreign-device');
 module.exports.reinitializeDevice = require('./reinitialize-device');
 module.exports.subscribeCov = require('./subscribe-cov');
 module.exports.subscribeProperty = require('./subscribe-property');
 module.exports.timeSync = require('./time-sync');
+module.exports.timeSyncUTC = module.exports.timeSync;
 module.exports.whoHas = require('./who-has');
 module.exports.whoIs = require('./who-is');
-module.exports.writePropertyMultiple = require('./write-property-multiple');
 module.exports.writeProperty = require('./write-property');
+module.exports.writePropertyMultiple = require('./write-property-multiple');

package/resources/{bacstack → node-bacnet}/lib/services/life-safety-operation.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, processId, requestingSource, operation, targetObjectId) => {
   baAsn1.encodeContextUnsigned(buffer, 0, processId);
@@ -13,7 +14,7 @@ module.exports.decode = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
   let decodedValue;
-  const value = {};
+  let value = {};
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);

package/resources/{bacstack → node-bacnet}/lib/services/private-transfer.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, vendorId, serviceNumber, data) => {
   baAsn1.encodeContextUnsigned(buffer, 0, vendorId);
@@ -16,7 +17,7 @@ module.exports.decode = (buffer, offset, apduLen) => {
   let len = 0;
   let result;
   let decodedValue;
-  const value = {};
+  let value = {};
   result = baAsn1.decodeTagNumberAndValue(buffer, offset + len);
   len += result.len;
   decodedValue = baAsn1.decodeUnsigned(buffer, offset + len, result.value);

package/resources/{bacstack → node-bacnet}/lib/services/read-property-multiple.js

@@ -1,6 +1,7 @@
 'use strict';
 
-const baAsn1 = require('../asn1');
+const baAsn1      = require('../asn1');
+const baEnum      = require('../enum');
 
 module.exports.encode = (buffer, properties) => {
   properties.forEach((value) => {
@@ -13,12 +14,14 @@ module.exports.decode = (buffer, offset, apduLen) => {
   const values = [];
   while ((apduLen - len) > 0) {
     const decodedValue = baAsn1.decodeReadAccessSpecification(buffer, offset + len, apduLen - len);
-    if (!decodedValue) return;
+    if (!decodedValue) {
+      return undefined;
+    }
     len += decodedValue.len;
     values.push(decodedValue.value);
   }
   return {
-    len: len,
+    len,
     properties: values
   };
 };
@@ -34,12 +37,14 @@ module.exports.decodeAcknowledge = (buffer, offset, apduLen) => {
   const values = [];
   while ((apduLen - len) > 0) {
     const result = baAsn1.decodeReadAccessResult(buffer, offset + len, apduLen - len);
-    if (!result) return;
+    if (!result) {
+      return undefined;
+    }
     len += result.len;
     values.push(result.value);
   }
   return {
-    len: len,
-    values: values
+    len,
+    values
   };
 };