@bithomp/xrpl-api 3.7.18 → 3.7.20

package/lib/ledger/account_tx.js

@@ -49,6 +49,7 @@ const DEFAULT_LIMIT = 200;
 const MAX_LIMIT_WITH_FILTER = 20;
 const MAX_LIMIT_WITH_TAG = 3;
 const LIMIT_INCREASE_COUNT = 10;
+const DEFAULT_TIMEOUT = 15000;
 async function getTransactions(account, options = { limit: DEFAULT_LIMIT }) {
     const { hash, marker } = (0, utils_1.parseMarker)(options.marker);
     options.marker = marker;
@@ -137,11 +138,17 @@ async function getTransactions(account, options = { limit: DEFAULT_LIMIT }) {
     result.bithompHash = connection.hash;
     return result;
 }
-async function findTransactionsExt(account, options = { limit: DEFAULT_LIMIT, timeout: 15000 }) {
+async function findTransactionsExt(account, options = { limit: DEFAULT_LIMIT, timeout: DEFAULT_TIMEOUT }) {
     let transactions = [];
     let accountTransactionsError = null;
     const timeStart = new Date();
     const loadOptions = { ...options };
+    if (!loadOptions.limit || loadOptions.limit <= 0) {
+        loadOptions.limit = DEFAULT_LIMIT;
+    }
+    if (!loadOptions.timeout || loadOptions.timeout <= 0) {
+        loadOptions.timeout = DEFAULT_TIMEOUT;
+    }
     const formatted = loadOptions.legacy === true || loadOptions.formatted === true;
     loadOptions.binary = false;
     applyLimitOptions(loadOptions);
@@ -265,12 +272,12 @@ async function findTransactions(account, options = { limit: DEFAULT_LIMIT, timeo
 }
 function applyLimitOptions(options) {
     if (options.sourceTag > 0 || options.destinationTag > 0) {
-        if (options.limit > MAX_LIMIT_WITH_TAG) {
+        if (!options.limit || options.limit > MAX_LIMIT_WITH_TAG) {
             options.limit = MAX_LIMIT_WITH_TAG;
         }
     }
     else if (options.types || options.initiated || options.counterparty) {
-        if (options.limit > MAX_LIMIT_WITH_FILTER) {
+        if (!options.limit || options.limit > MAX_LIMIT_WITH_FILTER) {
             options.limit = MAX_LIMIT_WITH_FILTER;
         }
     }

package/lib/ledger/fee.d.ts

@@ -1,8 +1,13 @@
 import { XrplDefinitionsBase } from "ripple-binary-codec";
 import { Connection } from "../connection";
+import { ErrorResponse } from "../models/base_model";
 export interface GetFeeOptions {
     connection?: Connection;
     tx?: any;
     definitions?: XrplDefinitionsBase;
 }
+export interface GetFeeDataResult {
+    fee: string | null;
+}
+export declare function getFeeData(options?: GetFeeOptions): Promise<GetFeeDataResult | ErrorResponse>;
 export declare function getFee(options?: GetFeeOptions): Promise<string | null>;

package/lib/ledger/fee.js

@@ -36,12 +36,13 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.getFeeData = getFeeData;
 exports.getFee = getFee;
 const bignumber_js_1 = __importDefault(require("bignumber.js"));
 const ripple_binary_codec_1 = require("ripple-binary-codec");
 const Client = __importStar(require("../client"));
 const common_1 = require("../common");
-async function getFee(options = {}) {
+async function getFeeData(options = {}) {
     const connection = options.connection || Client.findConnection();
     if (!connection) {
         throw new Error("There is no connection");
@@ -57,13 +58,42 @@ async function getFee(options = {}) {
         command: "fee",
         tx_blob: txBlob,
     });
+    if (!response) {
+        return {
+            status: "error",
+            error: "invalidResponse",
+        };
+    }
+    if (response.error) {
+        const { error, error_code, error_message, error_exception, status, validated } = response;
+        return (0, common_1.removeUndefined)({
+            error,
+            error_code,
+            error_message,
+            error_exception,
+            status,
+            validated,
+        });
+    }
     const openLedgerFee = response?.result?.drops?.open_ledger_fee;
     if (!openLedgerFee) {
-        return null;
+        return {
+            status: "error",
+            error: "No open_ledger_fee data in response",
+        };
     }
     const fee = new bignumber_js_1.default(openLedgerFee)
         .multipliedBy(Client.feeCushion)
         .dividedBy(common_1.dropsInXRP)
         .decimalPlaces(6, bignumber_js_1.default.ROUND_UP);
-    return fee.toString();
+    return {
+        fee: fee.toString(),
+    };
+}
+async function getFee(options = {}) {
+    const response = await getFeeData(options);
+    if ("fee" in response) {
+        return response.fee;
+    }
+    return null;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bithomp/xrpl-api",
-  "version": "3.7.18",
+  "version": "3.7.20",
   "description": "A Bithomp JavaScript/TypeScript library for interacting with the XRP Ledger",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -62,15 +62,15 @@
     "xrpl": "4.4.3"
   },
   "devDependencies": {
-    "@eslint/eslintrc": "^3.3.1",
+    "@eslint/eslintrc": "^3.3.3",
     "@types/chai": "^5.2.3",
     "@types/chai-as-promised": "^8.0.2",
-    "@types/lodash": "^4.17.20",
+    "@types/lodash": "^4.17.21",
     "@types/mocha": "^10.0.10",
     "@types/nconf": "^0.10.7",
     "@types/node": "^22.15.21",
-    "@typescript-eslint/eslint-plugin": "^8.47.0",
-    "@typescript-eslint/parser": "^8.47.0",
+    "@typescript-eslint/eslint-plugin": "^8.48.0",
+    "@typescript-eslint/parser": "^8.48.0",
     "chai": "^6.2.1",
     "chai-as-promised": "^8.0.2",
     "eslint": "^9.39.1",