@bithomp/xrpl-api 3.2.13 → 3.2.15

package/README.md

@@ -168,7 +168,7 @@ const vl = await BithompXRPL.Client.createVLv2(vk, sk, [publishBlob, publishBlob
 
 // vl will contain the signed validator list with
 // {
-//   "blobs-v2": "...",
+//   "blobs_v2": "...",
 //   "manifest": "...", // signed with vk.privateKey and sk.privateKey
 //   "version": 2,
 //   "public_key": "..." // vk.publicKey

package/lib/ledger/vl-v2.js

@@ -107,7 +107,7 @@ async function createVLv2(masterKey, ephemeralKey, publishBlobs) {
         MasterPrivateKey: masterKey.privateKey,
     });
     return {
-        "blobs-v2": blobs,
+        "blobs_v2": blobs,
         manifest: globalManifest,
         public_key: masterKey.publicKey,
         version: 2,

package/lib/models/vl.d.ts

@@ -4,7 +4,7 @@ export interface VLInterface {
     public_key?: string;
     manifest?: string;
     blob?: string;
-    "blobs-v2"?: VLBlobInfoInterface[];
+    blobs_v2?: VLBlobInfoInterface[];
     signature?: string;
 }
 export interface ParsedVLInterface {

package/lib/models/vl.js

@@ -102,10 +102,13 @@ function parseVL(vl) {
         }
     }
     else if (decoded.version === 2) {
-        const blobs = vl["blobs-v2"];
+        const blobs = (vl["blobs-v2"] || vl["blobs_v2"]);
         if (!decoded.blobs) {
             decoded.blobs = [];
         }
+        if (!blobs) {
+            return decoded;
+        }
         for (const blobInfo of blobs) {
             const blob = decodeVLBlob(blobInfo.blob);
             error = isValidVLBlob(blob);
@@ -188,7 +191,10 @@ function isValidVL(vl) {
         }
     }
     else if (vl.version === 2) {
-        const blobs = vl["blobs-v2"];
+        const blobs = (vl["blobs-v2"] || vl["blobs_v2"]);
+        if (!blobs) {
+            return "blobs_v2 missing from vl";
+        }
         for (const blobInfo of blobs) {
             const blob = decodeVLBlob(blobInfo.blob);
             error = isValidVLBlob(blob);
@@ -226,17 +232,18 @@ function isValidVLFormat(vl) {
         }
     }
     else if (version === 2) {
+        const blobs = (vl["blobs-v2"] || vl["blobs_v2"]);
         if (blob !== undefined) {
             error = "Blob should not be present in vl version 2";
         }
-        else if (vl["blobs-v2"] === undefined) {
-            error = "blobs-v2 missing from vl";
+        else if (blobs === undefined) {
+            error = "blobs_v2 missing from vl";
         }
-        else if (!Array.isArray(vl["blobs-v2"])) {
-            error = "blobs-v2 should be an array";
+        else if (!Array.isArray(blobs)) {
+            error = "blobs_v2 should be an array";
         }
-        else if (vl["blobs-v2"].length === 0) {
-            error = "blobs-v2 should not be empty";
+        else if (blobs.length === 0) {
+            error = "blobs_v2 should not be empty";
         }
     }
     else {

package/lib/parse/outcome/balance_changes.js

@@ -75,7 +75,7 @@ function flipTrustlinePerspective(quantity) {
     return {
         address: quantity.balance.issuer,
         balance: {
-            issuer: quantity.address,
+            issuer: quantity.balance.issuer,
             currency: quantity.balance.currency,
             value: negatedBalance.toString(),
             counterparty: quantity.address,
@@ -88,13 +88,25 @@ function parseTrustlineQuantity(node, valueParser) {
         return null;
     }
     const fields = lodash_1.default.isEmpty(node.newFields) ? node.finalFields : node.newFields;
+    const previousFields = node.previousFields;
+    let viewLowest = true;
+    if (previousFields && previousFields.Balance && previousFields.Balance.value !== "0") {
+        viewLowest = previousFields.Balance.value[0] !== "-";
+    }
+    else {
+        viewLowest = fields.Balance.value[0] !== "-";
+    }
+    const sign = viewLowest ? 1 : -1;
+    const currency = fields.Balance.currency;
+    const issuer = viewLowest ? fields.HighLimit.issuer : fields.LowLimit.issuer;
+    const holder = viewLowest ? fields.LowLimit.issuer : fields.HighLimit.issuer;
     const result = {
-        address: fields.LowLimit.issuer,
+        address: holder,
         balance: {
-            issuer: fields.HighLimit.issuer,
-            currency: fields.Balance.currency,
-            value: value.toString(),
-            counterparty: fields.HighLimit.issuer,
+            issuer,
+            currency,
+            value: value.times(sign).toString(),
+            counterparty: issuer,
         },
     };
     return [result, flipTrustlinePerspective(result)];

package/lib/parse/outcome/locked_balance_changes.js

@@ -49,14 +49,25 @@ function parseTrustlineQuantity(node, valueParser) {
         return null;
     }
     const fields = lodash_1.default.isEmpty(node.newFields) ? node.finalFields : node.newFields;
-    const LockedBalanceFields = lodash_1.default.isEmpty(node.newFields?.LockedBalance) ? lodash_1.default.isEmpty(node.finalFields?.LockedBalance) ? node.previousFields : node.finalFields : node.newFields;
+    const previousFields = node.previousFields;
+    let viewLowest = true;
+    if (previousFields && previousFields.Balance && previousFields.Balance.value !== "0") {
+        viewLowest = previousFields.Balance.value[0] !== "-";
+    }
+    else {
+        viewLowest = fields.Balance.value[0] !== "-";
+    }
+    const sign = viewLowest ? 1 : -1;
+    const currency = fields.Balance.currency;
+    const issuer = viewLowest ? fields.HighLimit.issuer : fields.LowLimit.issuer;
+    const holder = viewLowest ? fields.LowLimit.issuer : fields.HighLimit.issuer;
     const result = {
-        address: fields.LowLimit.issuer,
+        address: holder,
         lockedBalance: {
-            issuer: LockedBalanceFields.LockedBalance.issuer,
-            currency: LockedBalanceFields.LockedBalance.currency,
-            value: value.toString(),
-            counterparty: LockedBalanceFields.LockedBalance.issuer,
+            issuer,
+            currency,
+            value: value.times(sign).toString(),
+            counterparty: issuer,
         },
     };
     return [result];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bithomp/xrpl-api",
-  "version": "3.2.13",
+  "version": "3.2.15",
   "description": "A Bithomp JavaScript/TypeScript library for interacting with the XRP Ledger",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -58,8 +58,8 @@
     "elliptic": "^6.6.1",
     "lodash": "^4.17.21",
     "ripple-address-codec": "^5.0.0",
-    "ripple-binary-codec": "^2.2.0",
-    "xrpl": "^4.1.0"
+    "ripple-binary-codec": "^2.3.0",
+    "xrpl": "^4.2.0"
   },
   "devDependencies": {
     "@eslint/eslintrc": "^3.2.0",
@@ -68,12 +68,12 @@
     "@types/lodash": "^4.17.15",
     "@types/mocha": "^10.0.10",
     "@types/nconf": "^0.10.7",
-    "@types/node": "^22.13.1",
-    "@typescript-eslint/eslint-plugin": "^8.23.0",
-    "@typescript-eslint/parser": "^8.23.0",
+    "@types/node": "^22.13.4",
+    "@typescript-eslint/eslint-plugin": "^8.24.1",
+    "@typescript-eslint/parser": "^8.24.1",
     "chai": "^4.5.0",
     "chai-as-promised": "^7.1.2",
-    "eslint": "^9.20.0",
+    "eslint": "^9.20.1",
     "eslint-config-prettier": "^10.0.1",
     "eslint-plugin-chai-friendly": "^1.0.1",
     "eslint-plugin-import": "^2.31.0",