@bithomp/xrpl-api 3.1.8 → 3.1.10

package/lib/connection.js

@@ -59,7 +59,6 @@ class Connection extends events_1.EventEmitter {
             });
             await this.removeClient();
             this.client = new xrpl_1.Client(this.url, (0, common_1.removeUndefined)({ timeout: this.timeout, connectionTimeout: this.connectionTimeout }));
-            this.client.apiVersion = this.apiVersion;
             this.setupEmitter();
             await this.client.connection.connect();
             await this.updateServerInfo();
@@ -89,7 +88,7 @@ class Connection extends events_1.EventEmitter {
                 return this.updateSubscriptions(request);
             }
             const waitTime = (0, utils_1.getTimestamp)() + RECONNECT_TIMEOUT;
-            while ((!this.client || !this.isConnected())) {
+            while (!this.client || !this.isConnected()) {
                 await (0, utils_1.sleep)(100);
                 if (this.shutdown) {
                     return { error: "shutdownConnection", error_message: "Connection is shutdown.", status: "error" };

package/lib/ledger/account_tx.js

@@ -107,28 +107,29 @@ async function getTransactions(account, options = { limit: DEFAULT_LIMIT }) {
 async function findTransactions(account, options = { limit: DEFAULT_LIMIT, timeout: 15000 }) {
     let transactions = [];
     let accountTransactionsError = null;
-    const formatted = options.legacy === true || options.formatted === true;
     const timeStart = new Date();
-    options.binary = false;
-    applyLimitOptions(options);
-    await applyStartTxOptions(options);
-    while (transactions.length !== options.limit) {
+    const loadOptions = { ...options };
+    const formatted = loadOptions.legacy === true || loadOptions.formatted === true;
+    loadOptions.binary = false;
+    applyLimitOptions(loadOptions);
+    await applyStartTxOptions(loadOptions);
+    while (transactions.length !== loadOptions.limit) {
         const currentTime = new Date();
-        if (options.timeout && currentTime.getTime() - timeStart.getTime() > options.timeout) {
+        if (loadOptions.timeout && currentTime.getTime() - timeStart.getTime() > loadOptions.timeout) {
             break;
         }
-        let limit = options.limit;
-        if (transactions.length === 0 && options.startTxHash) {
+        let limit = loadOptions.limit;
+        if (transactions.length === 0 && loadOptions.startTxHash) {
             limit += LIMIT_INCREASE_COUNT;
         }
-        if (options.sourceTag || options.destinationTag) {
+        if (loadOptions.sourceTag || loadOptions.destinationTag) {
             limit += LIMIT_INCREASE_COUNT;
         }
         if (limit > MAX_LIMIT) {
             limit = MAX_LIMIT;
         }
         const accountTransactions = await getTransactions(account, {
-            ...options,
+            ...loadOptions,
             ...{ balanceChanges: false, specification: false, limit },
         });
         if (!accountTransactions || accountTransactions.error) {
@@ -136,16 +137,16 @@ async function findTransactions(account, options = { limit: DEFAULT_LIMIT, timeo
             break;
         }
         let newTransactions = accountTransactions.transactions;
-        options.marker = accountTransactions.marker;
+        loadOptions.marker = accountTransactions.marker;
         newTransactions = newTransactions
-            .filter(lodash_1.default.partial(filterHelperTransactions, account, options))
-            .filter(lodash_1.default.partial(filterHelperStartTx, options));
-        if (formatted !== true && (options.balanceChanges === true || options.specification === true)) {
+            .filter(lodash_1.default.partial(filterHelperTransactions, account, loadOptions))
+            .filter(lodash_1.default.partial(filterHelperStartTx, loadOptions));
+        if (formatted !== true && (loadOptions.balanceChanges === true || loadOptions.specification === true)) {
             for (const newTransaction of newTransactions) {
-                if (options.balanceChanges === true) {
+                if (loadOptions.balanceChanges === true) {
                     newTransaction.balanceChanges = (0, xrpl_1.getBalanceChanges)(newTransaction.meta);
                 }
-                if (options.specification === true) {
+                if (loadOptions.specification === true) {
                     const details = (0, transaction_1.getAccountTxDetails)(newTransaction, true);
                     newTransaction.specification = details.specification;
                     newTransaction.outcome = details.outcome;
@@ -154,23 +155,23 @@ async function findTransactions(account, options = { limit: DEFAULT_LIMIT, timeo
             }
         }
         transactions = transactions.concat(newTransactions);
-        transactions = transactions.slice(0, options.limit);
-        if (options.marker === undefined) {
+        transactions = transactions.slice(0, loadOptions.limit);
+        if (loadOptions.marker === undefined) {
             break;
         }
     }
     if (accountTransactionsError && transactions.length === 0) {
         return accountTransactionsError;
     }
-    if (options.marker && transactions.length === 0) {
+    if (loadOptions.marker && transactions.length === 0) {
         return {
             status: "timeout",
             error: "searchTimeout",
-            marker: options.marker,
+            marker: loadOptions.marker,
         };
     }
     if (formatted === true) {
-        transactions = transactions.map((transaction) => (0, transaction_1.getAccountTxDetails)(transaction, options.includeRawTransactions === true));
+        transactions = transactions.map((transaction) => (0, transaction_1.getAccountTxDetails)(transaction, loadOptions.includeRawTransactions === true));
     }
     return transactions;
 }

package/lib/parse/specification/payment.js

@@ -43,7 +43,7 @@ function parsePayment(tx) {
     assert.ok(tx.TransactionType === "Payment");
     const source = {
         address: tx.Account,
-        maxAmount: (0, utils_1.removeGenericCounterparty)((0, amount_1.default)(tx.SendMax || tx.Amount), tx.Account),
+        maxAmount: (0, utils_1.removeGenericCounterparty)((0, amount_1.default)(tx.SendMax || tx.DeliverMax || tx.Amount), tx.Account),
         tag: tx.SourceTag,
     };
     const destination = {

package/lib/parse/transaction.js

@@ -158,6 +158,7 @@ function parseTransaction(tx, includeRawTransaction, nativeCurrency, definitions
         type: type,
         address: (0, account_1.parseAccount)(tx.Account),
         sequence: tx.Sequence,
+        ticketSequence: tx.TicketSequence,
         id: tx.hash,
         ctid: tx.ctid,
         specification: (0, common_1.removeUndefined)(specification),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bithomp/xrpl-api",
-  "version": "3.1.8",
+  "version": "3.1.10",
   "description": "A Bithomp JavaScript/TypeScript library for interacting with the XRP Ledger",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -64,19 +64,19 @@
   "devDependencies": {
     "@types/chai": "^4.3.19",
     "@types/chai-as-promised": "^7.1.8",
-    "@types/lodash": "^4.17.7",
-    "@types/mocha": "^10.0.8",
+    "@types/lodash": "^4.17.10",
+    "@types/mocha": "^10.0.9",
     "@types/nconf": "^0.10.7",
     "@types/node": "^20.14.15",
-    "@typescript-eslint/eslint-plugin": "^8.6.0",
-    "@typescript-eslint/parser": "^8.6.0",
+    "@typescript-eslint/eslint-plugin": "^8.9.0",
+    "@typescript-eslint/parser": "^8.9.0",
     "chai": "^4.5.0",
     "chai-as-promised": "^7.1.2",
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-chai-friendly": "^1.0.1",
-    "eslint-plugin-import": "^2.30.0",
-    "eslint-plugin-n": "^17.10.3",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-n": "^17.11.1",
     "eslint-plugin-promise": "^7.1.0",
     "mocha": "^10.7.3",
     "nconf": "^0.12.1",