@bitbonsai/mcpvault 0.17.0 → 0.17.2

package/dist/src/filesystem.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"filesystem.d.ts","sourceRoot":"","sources":["../../src/filesystem.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,kBAAkB,EAAE,MAAM,kBAAkB,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAE7C,OAAO,KAAK,EAAE,UAAU,EAAE,gBAAgB,EAAE,eAAe,EAAE,gBAAgB,EAAE,YAAY,EAAE,cAAc,EAAE,cAAc,EAAE,UAAU,EAAE,eAAe,EAAE,eAAe,EAAE,uBAAuB,EAAE,QAAQ,EAAE,mBAAmB,EAAE,mBAAmB,EAAE,eAAe,EAAE,eAAe,EAAE,UAAU,EAAE,WAAW,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAC;AAE3V;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,GAAG,KAAK,CAiBtE;AAoBD,qBAAa,iBAAiB;IAK1B,OAAO,CAAC,SAAS;IAJnB,OAAO,CAAC,kBAAkB,CAAqB;IAC/C,OAAO,CAAC,UAAU,CAAa;IAE/B,YACU,SAAS,EAAE,MAAM,EACzB,UAAU,CAAC,EAAE,UAAU,EACvB,kBAAkB,CAAC,EAAE,kBAAkB,EAWxC;IAED;;;;OAIG;IACH,OAAO,CAAC,aAAa;IAsBrB,OAAO,CAAC,WAAW;IAkDb,QAAQ,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,CA+BhD;IAEK,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CA0EtD;IAEK,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,eAAe,CAAC,CA4FjE;IAEK,aAAa,CAAC,IAAI,GAAE,MAAW,GAAG,OAAO,CAAC,gBAAgB,CAAC,CA4DhE;IAEK,MAAM,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAc3C;IAEK,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAchD;IAEK,UAAU,CAAC,MAAM,EAAE,gBAAgB,GAAG,OAAO,CAAC,YAAY,CAAC,CAyGhE;IAEK,QAAQ,CAAC,MAAM,EAAE,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,CAoF1D;IAEK,QAAQ,CAAC,MAAM,EAAE,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,CA+H1D;IAEK,iBAAiB,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,eAAe,CAAC,CA+CzE;IAEK,iBAAiB,CAAC,MAAM,EAAE,uBAAuB,GAAG,OAAO,CAAC,IAAI,CAAC,CAoCtE;IAEK,YAAY,CAAC,KAAK,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,QAAQ,EAAE,CAAC,CA0CvD;IAEK,UAAU,CAAC,MAAM,EAAE,mBAAmB,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAqG1E;IAED,YAAY,IAAI,MAAM,CAErB;IAED;;;;;;;;;;;;;;OAcG;IACG,mBAAmB,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,CA+CjE;IAEK,cAAc,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,CA+EzD;IAEK,aAAa,CAAC,MAAM,EAAE,mBAAmB,GAAG,OAAO,CAAC,MAAM,CAAC,CAehE;IAEK,aAAa,CAAC,WAAW,GAAE,MAAU,GAAG,OAAO,CAAC,UAAU,CAAC,CAuDhE;IAEK,WAAW,IAAI,OAAO,CAAC,KAAK,CAAC;QAAE,GAAG,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC,CAiDlE;CACF"}
+{"version":3,"file":"filesystem.d.ts","sourceRoot":"","sources":["../../src/filesystem.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,kBAAkB,EAAE,MAAM,kBAAkB,CAAC;AACtD,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAE7C,OAAO,KAAK,EAAE,UAAU,EAAE,gBAAgB,EAAE,eAAe,EAAE,gBAAgB,EAAE,YAAY,EAAE,cAAc,EAAE,cAAc,EAAE,UAAU,EAAE,eAAe,EAAE,eAAe,EAAE,uBAAuB,EAAE,QAAQ,EAAE,mBAAmB,EAAE,mBAAmB,EAAE,eAAe,EAAE,eAAe,EAAE,UAAU,EAAE,WAAW,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAC;AAE3V;;;;;;;;GAQG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,GAAG,KAAK,CAiBtE;AAoBD,qBAAa,iBAAiB;IAK1B,OAAO,CAAC,SAAS;IAJnB,OAAO,CAAC,kBAAkB,CAAqB;IAC/C,OAAO,CAAC,UAAU,CAAa;IAE/B,YACU,SAAS,EAAE,MAAM,EACzB,UAAU,CAAC,EAAE,UAAU,EACvB,kBAAkB,CAAC,EAAE,kBAAkB,EAWxC;IAED;;;;OAIG;IACH,OAAO,CAAC,aAAa;IAsBrB,OAAO,CAAC,WAAW;IAgDb,QAAQ,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,CA+BhD;IAEK,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,IAAI,CAAC,CA0EtD;IAEK,SAAS,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,eAAe,CAAC,CA4FjE;IAEK,aAAa,CAAC,IAAI,GAAE,MAAW,GAAG,OAAO,CAAC,gBAAgB,CAAC,CA4DhE;IAEK,MAAM,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAc3C;IAEK,WAAW,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC,CAchD;IAEK,UAAU,CAAC,MAAM,EAAE,gBAAgB,GAAG,OAAO,CAAC,YAAY,CAAC,CAyGhE;IAEK,QAAQ,CAAC,MAAM,EAAE,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,CA4H1D;IAEK,QAAQ,CAAC,MAAM,EAAE,cAAc,GAAG,OAAO,CAAC,UAAU,CAAC,CA+H1D;IAEK,iBAAiB,CAAC,MAAM,EAAE,eAAe,GAAG,OAAO,CAAC,eAAe,CAAC,CA+CzE;IAEK,iBAAiB,CAAC,MAAM,EAAE,uBAAuB,GAAG,OAAO,CAAC,IAAI,CAAC,CAoCtE;IAEK,YAAY,CAAC,KAAK,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,QAAQ,EAAE,CAAC,CA0CvD;IAEK,UAAU,CAAC,MAAM,EAAE,mBAAmB,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAqG1E;IAED,YAAY,IAAI,MAAM,CAErB;IAED;;;;;;;;;;;;;;OAcG;IACG,mBAAmB,CAAC,YAAY,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,EAAE,CAAC,CA+CjE;IAEK,cAAc,CAAC,IAAI,EAAE,MAAM,GAAG,OAAO,CAAC,WAAW,EAAE,CAAC,CA+EzD;IAEK,aAAa,CAAC,MAAM,EAAE,mBAAmB,GAAG,OAAO,CAAC,MAAM,CAAC,CAehE;IAEK,aAAa,CAAC,WAAW,GAAE,MAAU,GAAG,OAAO,CAAC,UAAU,CAAC,CAuDhE;IAEK,WAAW,IAAI,OAAO,CAAC,KAAK,CAAC;QAAE,GAAG,EAAE,MAAM,CAAC;QAAC,KAAK,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC,CAiDlE;CACF"}

package/dist/src/filesystem.js

@@ -1,7 +1,7 @@
 import { join, resolve, relative, dirname } from 'path';
 import { homedir } from 'os';
 import { readdir, stat, readFile, writeFile, unlink, mkdir, access, rename, copyFile } from 'node:fs/promises';
-import { constants, realpathSync } from 'node:fs';
+import { constants, lstatSync, realpathSync } from 'node:fs';
 import trash from 'trash';
 import { FrontmatterHandler } from './frontmatter.js';
 import { PathFilter } from './pathfilter.js';
@@ -104,46 +104,45 @@ export class FileSystemService {
         if (relativeToVault.startsWith('..')) {
             throw new Error(`Path traversal not allowed: ${relativePath}. Paths must be within the vault directory.`);
         }
-        // Security check: ensure symlinks don't escape vault boundary
-        try {
-            const realPath = realpathSync(fullPath);
-            const realRelative = relative(this.vaultPath, realPath);
-            if (realRelative.startsWith('..')) {
-                throw new Error(`Symlink target is outside vault: ${relativePath}. Symbolic links must resolve to a path within the vault directory.`);
+        // Walk missing parents to the nearest existing ancestor, without following dangling links.
+        let candidate = fullPath;
+        while (true) {
+            try {
+                const realPath = realpathSync(candidate);
+                if (relative(this.vaultPath, realPath).startsWith('..')) {
+                    throw new Error(`Symlink target is outside vault: ${relativePath}. Symbolic links must resolve to a path within the vault directory.`);
+                }
+                break;
             }
-        }
-        catch (err) {
-            if (err instanceof Error && 'code' in err) {
-                const code = err.code;
-                if (code === 'ENOENT') {
-                    // File doesn't exist yet (e.g. writing a new note). Verify the parent directory resolves inside vault.
+            catch (err) {
+                if (!(err instanceof Error) || !('code' in err))
+                    throw err;
+                if (err.code === 'ENOENT') {
                     try {
-                        const parentReal = realpathSync(dirname(fullPath));
-                        const parentRelative = relative(this.vaultPath, parentReal);
-                        if (parentRelative.startsWith('..')) {
-                            throw new Error(`Symlink target is outside vault: ${relativePath}. Symbolic links must resolve to a path within the vault directory.`);
+                        if (lstatSync(candidate).isSymbolicLink()) {
+                            throw new Error(`Cannot resolve symlink: ${relativePath}. Symbolic links must point to an existing path within the vault.`);
                         }
                     }
-                    catch (parentErr) {
-                        // Parent doesn't exist either (will be created by mkdir). Lexical check above is sufficient.
-                        if (parentErr instanceof Error && parentErr.message.includes('outside vault')) {
-                            throw parentErr;
+                    catch (linkError) {
+                        if (!(linkError instanceof Error) || !('code' in linkError) || linkError.code !== 'ENOENT') {
+                            throw linkError;
                         }
                     }
+                    const parent = dirname(candidate);
+                    if (candidate === this.vaultPath || parent === candidate)
+                        throw err;
+                    candidate = parent;
                 }
-                else if (code === 'ELOOP') {
+                else if (err.code === 'ELOOP') {
                     throw new Error(`Circular symlink detected: ${relativePath}. The symbolic link chain forms a loop.`);
                 }
-                else if (code === 'EACCES') {
+                else if (err.code === 'EACCES' || err.code === 'EPERM') {
                     throw new Error(`Permission denied resolving symlink: ${relativePath}. Cannot verify the symbolic link target is within the vault.`);
                 }
                 else {
                     throw err;
                 }
             }
-            else {
-                throw err;
-            }
         }
         return fullPath;
     }
@@ -466,7 +465,7 @@ export class FileSystemService {
                 };
             }
             if (trashMode === 'system') {
-                await trash(fullPath);
+                await trash(fullPath, { glob: false });
                 return {
                     success: true,
                     path: path,
@@ -527,20 +526,43 @@ export class FileSystemService {
         }
         const oldFullPath = this.resolvePath(oldPath);
         const newFullPath = this.resolvePath(newPath);
+        if (oldFullPath === newFullPath) {
+            return {
+                success: false,
+                oldPath,
+                newPath,
+                message: `Source and target paths are the same: ${oldPath}. Please provide a different target path.`
+            };
+        }
+        const sourceDirectoryResult = {
+            success: false,
+            oldPath,
+            newPath,
+            message: `Source path is a directory: ${oldPath}. Please provide a file path.`
+        };
+        const targetDirectoryResult = {
+            success: false,
+            oldPath,
+            newPath,
+            message: `Target path is a directory: ${newPath}. Please provide a file path.`
+        };
+        const sourceMissingResult = {
+            success: false,
+            oldPath,
+            newPath,
+            message: `Source file not found: ${oldPath}. Use list_directory to see available files.`
+        };
         try {
-            // Read source content (will throw ENOENT if not found)
             let content;
             try {
                 content = await readFile(oldFullPath, 'utf-8');
             }
             catch (error) {
                 if (error instanceof Error && 'code' in error && error.code === 'ENOENT') {
-                    return {
-                        success: false,
-                        oldPath,
-                        newPath,
-                        message: `Source file not found: ${oldPath}. Use list_directory to see available files.`
-                    };
+                    return sourceMissingResult;
+                }
+                if (error instanceof Error && 'code' in error && error.code === 'EISDIR') {
+                    return sourceDirectoryResult;
                 }
                 throw error;
             }
@@ -557,13 +579,29 @@ export class FileSystemService {
                 }
             }
             catch (error) {
-                if (error instanceof Error && 'code' in error && error.code === 'EEXIST') {
-                    return {
-                        success: false,
-                        oldPath,
-                        newPath,
-                        message: `Target file already exists: ${newPath}. Use overwrite=true to replace it.`
-                    };
+                if (error instanceof Error && 'code' in error) {
+                    if (error.code === 'EISDIR') {
+                        return targetDirectoryResult;
+                    }
+                    // Inspect only after a failed write; these codes also cover Windows directories.
+                    if (error.code === 'EEXIST' || error.code === 'EPERM' || error.code === 'EACCES') {
+                        try {
+                            if ((await stat(newFullPath)).isDirectory()) {
+                                return targetDirectoryResult;
+                            }
+                        }
+                        catch {
+                            // Preserve the write error if the target changed or cannot be inspected.
+                        }
+                    }
+                    if (error.code === 'EEXIST') {
+                        return {
+                            success: false,
+                            oldPath,
+                            newPath,
+                            message: `Target file already exists: ${newPath}. Use overwrite=true to replace it.`
+                        };
+                    }
                 }
                 throw error;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitbonsai/mcpvault",
-  "version": "0.17.0",
+  "version": "0.17.2",
   "description": "Universal AI bridge for Obsidian vaults - connect any MCP-compatible assistant",
   "homepage": "https://mcpvault.org",
   "author": "bitbonsai",