@bisondesk/core-sdk 1.0.653 → 1.0.654

package/src/types/quotes.ts

@@ -1,6 +1,5 @@
-import { AttachmentValue } from '@bisondesk/commons-sdk/types';
+import { AttachmentValue, LocationValue } from '@bisondesk/commons-sdk/types';
 import { OpportunityType } from '../constants.js';
-import { SalesDeliveryType } from './deliveries.js';
 import {
   CustomLeasingQuoteExtraInput,
   CustomSalesQuoteExtraInput,
@@ -34,6 +33,24 @@ export enum QuoteMetricsScore {
   NEUTRAL = 'neutral',
   GOOD = 'good',
 }
+export enum DeliveryTypes {
+  PICK_UP = 'pickUp',
+  ADDRESS = 'address',
+  PORT = 'port',
+  PORT_AND_SHIP = 'portAndShip',
+}
+
+export enum SpoilerInfo {
+  MOUNT = 'mount',
+  UNMOUNT = 'unmount',
+  NO_ACTION = 'noAction',
+}
+
+export enum TransportationMode {
+  BY_ROAD = 'byRoad',
+  ON_LOW_BED = 'onLowBed',
+}
+
 export enum SelfFinancingType {
   OWN_FINANCING = 'own_financing',
   ALREADY_FINANCED = 'already_financed',
@@ -131,6 +148,49 @@ export type LeasingCalculatorInput = BaseQuoteCalculatorInput & {
   customRequests: CustomLeasingQuoteExtraInput[];
 };
 
+type BaseDeliveryType = {
+  agreedPrice: string;
+  spoiler?: SpoilerInfo;
+  stackingVehicleNeeded?: boolean;
+  detailsStacking?: string;
+};
+
+export type PickUpDeliveryType = BaseDeliveryType & {
+  type: DeliveryTypes.PICK_UP;
+  urgent: boolean;
+  transportationMode?: TransportationMode;
+  detailsBorderCrossing?: string;
+  technicalControlNeeded: boolean;
+  insuranceNeeded: boolean;
+  transitPlateBelgiumNeeded: boolean;
+  transitPlateAustriaNeeded: boolean;
+  licensePlateNeeded: boolean;
+  dateOfPickUpByCustomer?: string;
+};
+
+export type AddressDeliveryType = BaseDeliveryType & {
+  type: DeliveryTypes.ADDRESS;
+  address: LocationValue;
+  distanceKm: string;
+  technicalControlNeeded: boolean;
+};
+
+export type PortDeliverytype = BaseDeliveryType & {
+  type: DeliveryTypes.PORT | DeliveryTypes.PORT_AND_SHIP;
+  portOriginId: string;
+  portDestination?: string;
+  shippingCompany?: string;
+  portToPortCostPrice: string;
+  parkToPortCostPrice?: string;
+  portToPortMargin: string;
+  ets?: string;
+  eta?: string;
+  etd?: string;
+  shipClosingDate?: string;
+  bookingRef?: string;
+  deliveryLocation?: string;
+};
+
 // Sent by the Frontend to bootstrap the calculator
 export type SalesCalculatorDefaultInput = Omit<BaseQuoteCalculatorInput, 'vehicle'> & {
   vehicle: Omit<BaseQuoteCalculatorInput['vehicle'], 'vatRate'>;
@@ -146,7 +206,7 @@ export type SalesCalculatorInput = BaseQuoteCalculatorInput & {
     internetPrice?: string;
     comissionCost: string;
   };
-  delivery?: SalesDeliveryType;
+  delivery?: PickUpDeliveryType | AddressDeliveryType | PortDeliverytype;
   extras: SalesQuoteExtraInput[];
   customRequests: CustomSalesQuoteExtraInput[];
   financing?: {
@@ -358,6 +418,16 @@ export type CalculatorSalesIO = {
 };
 export type CalculatorQuoteIO = CalculatorLeasingIO | CalculatorSalesIO;
 
+export type DeliveryLocationValue = Omit<LocationValue, 'addressLine1' | 'city'> & {
+  addressLine1: string;
+  city: string;
+};
+
+export type DeliveryRoutesRequest = {
+  origin: DeliveryLocationValue;
+  destination: DeliveryLocationValue;
+};
+
 export type NewQuoteValidator = {
   userId: string;
   countryCode: string;
@@ -372,17 +442,3 @@ export type QuoteValidator = NewQuoteValidator & {
 export type QuoteValidatorUpdate = {
   canValidateOwn: boolean;
 };
-
-export type {
-  AddressDeliveryType,
-  DeliveryLocationValue,
-  DeliveryRoutesRequest,
-  PickUpDeliveryType,
-  PortDeliverytype,
-} from './deliveries.js';
-/** @deprecated Import delivery types from ./deliveries.js. */
-export {
-  SalesDeliveryTypes as DeliveryTypes,
-  SpoilerInfo,
-  TransportationMode,
-} from './deliveries.js';

package/src/types/templates.ts

@@ -1,5 +1,3 @@
-import type { EmailContent, EmailRequest } from '@bisondesk/commons-sdk/messages';
-
 export type TemplateContent = {
   subject: string;
   content: {
@@ -37,28 +35,3 @@ export type UpdateTemplateInfoRequest = {
   name: string;
   tags?: any;
 };
-
-export type CodeEmailTemplateInfo = Pick<TemplateInfo, 'id' | 'name' | 'countries'> & {
-  format: 'react-email';
-};
-
-export type TemplateCatalogueEntry = (TemplateInfo & { format: 'html' }) | CodeEmailTemplateInfo;
-
-export type TemplateEmailRequest<T extends Record<string, unknown> = Record<string, unknown>> =
-  Omit<EmailRequest, 'subject' | 'body'> & {
-    templateId: string;
-    country: string;
-    fallbackCountry?: string;
-    data: T;
-    subject?: string;
-  };
-
-export type EmailTemplatePreviewRequest = {
-  data?: Record<string, unknown>;
-  subject?: string;
-};
-
-export type EmailTemplatePreview = {
-  content: EmailContent;
-  data: Record<string, unknown>;
-};

package/src/types/transports.ts

@@ -1,14 +1,13 @@
 import { GPSCoord, NextList, PaginatedList } from '@bisondesk/commons-sdk/types';
 import { Organization } from './crm.js';
+import { BaseEvent } from './internal-events.js';
+import { Opportunity, OpportunityPaymentStatus } from './opportunities.js';
 import {
   AddressDeliveryType,
+  DeliveryTypes,
   PickUpDeliveryType,
   PortDeliverytype,
-  PurchaseDeliveryType,
-  SalesDeliveryTypes,
-} from './deliveries.js';
-import { BaseEvent } from './internal-events.js';
-import { Opportunity, OpportunityPaymentStatus } from './opportunities.js';
+} from './quotes.js';
 import { BaseSearchRequest, SortOrder } from './search.js';
 import { DataRecord, ReferenceData } from './utils.js';
 import { Vehicle, VehiclePurchase } from './vehicles.js';
@@ -60,6 +59,13 @@ export enum TransportPriority {
   Urgent = 'URGENT',
 }
 
+export const TransportSalesDeliveryType = {
+  Address: DeliveryTypes.ADDRESS,
+  Port: DeliveryTypes.PORT,
+  PortAndShip: DeliveryTypes.PORT_AND_SHIP,
+  PickUp: DeliveryTypes.PICK_UP,
+} as const;
+
 /**
  * The customer collects the vehicle. Nothing is driven anywhere, but the papers still have to be
  * arranged and paid for — transit plates, technical control, insurance — which is why it is a
@@ -70,7 +76,11 @@ export enum TransportPriority {
  */
 export type TransportPickUpDeliveryType = Omit<PickUpDeliveryType, 'dateOfPickUpByCustomer'>;
 
-type TransportDeliveryExtras = {
+export type TransportSalesDeliveryType = (
+  | PortDeliverytype
+  | AddressDeliveryType
+  | TransportPickUpDeliveryType
+) & {
   cleaningNeeded?: boolean;
   driver?: string;
   transportCompany?: string;
@@ -79,22 +89,14 @@ type TransportDeliveryExtras = {
   stackingVehicleCostPrice?: string; // overrides the stacking rate from the delivery settings
 };
 
-export type TransportSalesDeliveryType = (
-  | PortDeliverytype
-  | AddressDeliveryType
-  | TransportPickUpDeliveryType
-) &
-  TransportDeliveryExtras;
-
-export type TransportPurchaseDeliveryType = PurchaseDeliveryType & TransportDeliveryExtras;
-
-/** @deprecated Use SalesDeliveryTypes from ./deliveries.js. */
-export const TransportSalesDeliveryType = {
-  Address: SalesDeliveryTypes.ADDRESS,
-  Port: SalesDeliveryTypes.PORT,
-  PortAndShip: SalesDeliveryTypes.PORT_AND_SHIP,
-  PickUp: SalesDeliveryTypes.PICK_UP,
-} as const;
+export type TransportPurchaseDeliveryType = AddressDeliveryType & {
+  cleaningNeeded?: boolean;
+  driver?: string;
+  transportCompany?: string;
+  date?: string; // Pick-up (purchase) | Delivery (OPP) (leaves parking)
+  adminCost?: string; // user-entered administrative cost summed into totalCostExclVat
+  stackingVehicleCostPrice?: string; // overrides the stacking rate from the delivery settings
+};
 
 export type Transport = {
   id: string;
@@ -179,8 +181,6 @@ export enum TransportActions {
  * server writes into the delivery it ends up with.
  */
 export type TransportUpdate = {
-  /** Changes the purchase method and the purchase agreement together. */
-  type?: TransportPurchaseType;
   delivery?: TransportSalesDeliveryType | TransportPurchaseDeliveryType;
   notes?: string | null;
   adminApproved?: boolean;

package/src/types/vehicle-sales.ts

@@ -1,9 +1,8 @@
 import { LocationValue } from '@bisondesk/commons-sdk/locations';
 import { Organization } from './crm.js';
-import { SalesDeliveryType } from './deliveries.js';
 import { BaseEvent } from './internal-events.js';
 import { Opportunity, VehicleSaleDealStatus, VehicleSaleLogisticsStatus } from './opportunities.js';
-import { Quote } from './quotes.js';
+import { DeliveryTypes, Quote } from './quotes.js';
 import { DataRecord } from './utils.js';
 
 export enum VehicleSaleInfoActions {
@@ -32,7 +31,7 @@ export type VehicleSaleInfoBff = {
   client?: Organization;
   delivery?: {
     address?: LocationValue;
-    type: SalesDeliveryType['type'];
+    type: DeliveryTypes;
   };
 };
 

package/src/utils/organizations.ts

@@ -0,0 +1,30 @@
+import { AppRoles } from '@bisondesk/commons-sdk/constants';
+import { addMonths, isBefore } from 'date-fns';
+
+const ORG_IDENTITY_LOCK_MONTHS = 1;
+
+const ORG_IDENTITY_EDIT_ROLES: AppRoles[] = [
+  AppRoles.Administrative,
+  AppRoles.GeneralManager,
+  AppRoles.Admin,
+];
+
+/**
+ * An organization's name and VAT number are its legal identity: the values invoices and contracts
+ * are issued against. They stay open for correction right after creation, then freeze for everyone
+ * except ORG_IDENTITY_EDIT_ROLES — by then they are already printed on legal documents.
+ *
+ * Shared so the server guard and the form's disabled state read one rule. Fails open on a missing
+ * createdAt: the org update path doubles as a create path for HyperDMS, and an org with no stored
+ * date must not be frozen out of its own first write.
+ */
+export const isOrgIdentityLocked = (
+  createdAt: string | undefined,
+  roles: AppRoles[] = [],
+): boolean => {
+  if (createdAt == null || roles.some((role) => ORG_IDENTITY_EDIT_ROLES.includes(role))) {
+    return false;
+  }
+
+  return isBefore(addMonths(new Date(createdAt), ORG_IDENTITY_LOCK_MONTHS), new Date());
+};

package/src/utils/transports.ts

@@ -4,10 +4,12 @@ import { VehiclePurchase } from '../types/vehicles.js';
 import { hasPurchaseArrived } from './vehicles.js';
 
 /**
- * Both purchase types bring a vehicle to our park: we collect a pickup, and the supplier brings
- * a drop-off. They share the purchase payment and arrival rules.
+ * Which side of the trade the transport serves. Both purchase types answer yes: a pick-up we drive
+ * and a drop-off the supplier drives differ only in who is behind the wheel, and every rule that
+ * asks this question — what it costs, whose money moved, which papers it needs — is the same for
+ * both.
  */
-export const isPurchaseTransport = (transport: Pick<Transport, 'type'>): boolean =>
+export const isPurchaseTransport = (transport: Transport): boolean =>
   transport.type !== TransportType.SaleDelivery;
 
 /**