@bisondesk/core-sdk 1.0.651 → 1.0.653

package/src/utils/transports.ts

@@ -1,10 +1,18 @@
 import { Opportunity } from '../types/opportunities.js';
 import { SearchTransport, Transport, TransportType } from '../types/transports.js';
-import { VehiclePurchase, VehiclePurchaseLogisticsStatus } from '../types/vehicles.js';
+import { VehiclePurchase } from '../types/vehicles.js';
+import { hasPurchaseArrived } from './vehicles.js';
+
+/**
+ * Both purchase types bring a vehicle to our park: we collect a pickup, and the supplier brings
+ * a drop-off. They share the purchase payment and arrival rules.
+ */
+export const isPurchaseTransport = (transport: Pick<Transport, 'type'>): boolean =>
+  transport.type !== TransportType.SaleDelivery;
 
 /**
  * A transport is finished when the journey it describes has demonstrably happened: the customer has
- * the vehicle for a sale delivery, the vehicle is on our park for a purchase pick-up. From then on
+ * the vehicle for a sale delivery, the vehicle is on our park for a purchase. From then on
  * the record is history and the server refuses edits to it.
  *
  * Not the same thing as the transport's own `doneAt`. Delivery can be declared on the opportunity
@@ -22,11 +30,7 @@ export const isTransportCompleted = (
     return context.opportunity?.deliveredAt != null;
   }
 
-  const status = context.purchase?.logistics.status;
-  return (
-    status === VehiclePurchaseLogisticsStatus.Arrived ||
-    status === VehiclePurchaseLogisticsStatus.CheckedIn
-  );
+  return context.purchase != null && hasPurchaseArrived(context.purchase);
 };
 
 /** The same question asked of a search document, which already carries both sides. */

package/src/utils/vehicles.ts

@@ -6,8 +6,18 @@ import {
   VehicleExternalInfo,
   VehiclePurchase,
   VehiclePurchaseDealStatus,
+  VehiclePurchaseLogisticsStatus,
 } from '../types/vehicles.js';
 
+/** The logistics statuses at which the purchased vehicle is on our park. */
+export const PURCHASE_ARRIVED_STATUSES: readonly VehiclePurchaseLogisticsStatus[] = [
+  VehiclePurchaseLogisticsStatus.Arrived,
+  VehiclePurchaseLogisticsStatus.CheckedIn,
+];
+
+export const hasPurchaseArrived = (purchase: Pick<VehiclePurchase, 'logistics'>): boolean =>
+  PURCHASE_ARRIVED_STATUSES.includes(purchase.logistics.status);
+
 /**
  * The deal has not been committed: there is no purchase yet, or its deal is still in
  * `Marketing`. Copies are created in this state; it ends when the owner agrees to buy