@bisondesk/core-sdk 1.0.432 → 1.0.433

package/src/types/opportunities.ts

@@ -2,6 +2,7 @@ import { Document, NextList } from '@bisondesk/commons-sdk/types';
 import { BusinessEntityIds, OpportunityType, WarningHints } from '../constants.js';
 import { Contact, Organization } from './crm.js';
 import type { InterestBffMeta, OpportunityInterest } from './interests.js';
+import { BaseEvent } from './internal-events.js';
 import { Payment } from './payments.js';
 import { Quote, QuoteStatus } from './quotes.js';
 import { OpportunityReservation } from './reservations.js';
@@ -251,7 +252,7 @@ export type OpportunityBFF = {
   };
 };
 
-type BaseOpportunityEvent = {
+type BaseOpportunityEvent = BaseEvent & {
   actionAt: string;
   userId: string;
   tenantId: string;
@@ -269,21 +270,12 @@ export type OpportunityUpdateEvent = BaseOpportunityEvent & {
   action: 'update';
 };
 
-export type OpportunityDeleteEvent = BaseOpportunityEvent & {
-  opportunity?: undefined;
-  previousOpportunity: Opportunity;
-  action: 'delete';
-};
-
-export type OpportunityEvent =
-  | OpportunityCreateEvent
-  | OpportunityUpdateEvent
-  | OpportunityDeleteEvent;
+export type OpportunityEvent = OpportunityCreateEvent | OpportunityUpdateEvent;
 
 export type QuoteEvent = {
   quote: Quote;
   opportunity: Opportunity;
-  action: 'create' | 'update' | 'delete';
+  action: 'create' | 'update';
   actionAt: string;
   userId: string;
   tenantId: string;
@@ -315,6 +307,7 @@ export type SearchOpportunity = {
 export const QUOTE_NEEDS_VALIDATION_NOTIFICATION_ORIGIN = 'quote-validation';
 export const QUOTE_NOT_CREATED_BY_ACCOUNT_MANAGER = 'quote-not-created-by-account-manager';
 export const QUOTE_VALIDATOR_FEEDBACK_NOTIFICATION_ORIGIN = 'quote-validation-feedback';
+
 export const OPPORTUNITY_VEHICLE_AVAILABLE_NOTIFICATION_ORIGIN = 'opportunity-vehicle-available';
 export const OPPORTUNITY_VEHICLE_DELIVERY_NOTIFICATION_ORIGIN = 'opportunity-vehicle-delivery';
 export const OPPORTUNITY_VEHICLE_RESERVATION_ABOUT_TO_EXPIRE_NOTIFICATION_ORIGIN =
@@ -322,6 +315,15 @@ export const OPPORTUNITY_VEHICLE_RESERVATION_ABOUT_TO_EXPIRE_NOTIFICATION_ORIGIN
 export const OPPORTUNITY_VEHICLE_RESERVATION_EXPIRED_NOTIFICATION_ORIGIN =
   'opportunity-vehicle-reservation-expired';
 
+export const OFFER_SET_FINAL_VALUATION_ORIGIN = 'offer-set-final-valuation';
+
+export const VEHICLE_PRICE_DECREASES_NOTIFICATION_ORIGIN = 'vehicle-price-decreased';
+export const VEHICLE_ARRIVED_NOTIFICATION_ORIGIN = 'vehicle-arrived';
+export const VEHICLE_CHECKEDIN_NOTIFICATION_ORIGIN = 'vehicle-checkedin';
+export const VEHICLE_PURCHASED_NOTIFICATION_ORIGIN = 'vehicle-purchased';
+export const VEHICLE_PRICE_CHANGED_NOTIFICATION_ORIGIN = 'vehicle-price-changed';
+export const VEHICLE_SOLD_NOTIFICATION_ORIGIN = 'vehicle-sold';
+
 export type OpportunityNotificationData = {
   quoteVersion?: number;
   snippet?: string;
@@ -662,6 +664,18 @@ export type HpLeasingContractResponse = {
   contractNumber: string;
 };
 
+export type HpLeasingDealReturnRequest = {
+  tenantId: string;
+  initiatedBy: 'bisondesk';
+  processMetaId: string;
+  processRunData: {
+    entityOwner: string;
+    leasingContractNumber2: string;
+    company: string;
+    vehicle: string;
+  };
+};
+
 export type HpLeasingDealEndRequest = {
   tenantId: string;
   initiatedBy: 'bisondesk';
@@ -763,7 +777,7 @@ export type HpIsaProcessResponse = {
 };
 
 export type SwitchOpportunityVehicleRequest = {
-  opportunityId: string;
+  opportunity: Opportunity;
   newVehicleId: string;
 };
 

package/src/types/payments.ts

@@ -1,3 +1,5 @@
+import { BaseEvent } from './internal-events.js';
+
 export enum PaymentActions {
   DELETE = 'delete',
   EDIT = 'edit',
@@ -71,4 +73,5 @@ export type PaymentDeleteEvent = {
   branchId: string;
 };
 
-export type PaymentEvent = PaymentCreateEvent | PaymentUpdateEvent | PaymentDeleteEvent;
+export type PaymentEvent = BaseEvent &
+  (PaymentCreateEvent | PaymentUpdateEvent | PaymentDeleteEvent);

package/src/types/vehicles.ts

@@ -50,7 +50,7 @@ export enum VehicleTachoTypes {
   SmartTacho2 = 'SMART_TACHO_2',
 }
 
-type BaseVehicleEvent = {
+type BaseVehicleEvent = BaseEvent & {
   id: string;
   actionAt: string;
   userId: string;
@@ -250,6 +250,7 @@ export type SearchVehicle = {
     dealStatus?: VehiclePurchaseDealStatus;
     logisticsStatus?: VehiclePurchaseLogisticsStatus;
     purchasedBy?: string;
+    parkingName?: string;
   };
   reservation?: Pick<OpportunityReservation, 'expiresAt' | 'opportunityId' | 'createdBy'>;
   vehicle: Vehicle;
@@ -462,7 +463,6 @@ export type VehicleExternalInfo = {
   };
   salesConditions: {
     leasing?: boolean;
-    expected?: boolean;
     price?: string | undefined;
     currency?: string | undefined;
     marginScheme?: boolean;

package/src/utils/vehicles.ts

@@ -100,16 +100,16 @@ export const convertLettersToNumber = (letters: string): number => {
 };
 
 export const getNextRelatedStockNumber = (stockNumber: string): string => {
-  const counterPattern = /^([A-Z]{2,4}\d{5})([A-Z]{0,2})$/;
+  const counterPattern = /^([A-Z]+\d{5})([A-Z]{0,2})$/;
   const match = stockNumber.match(counterPattern);
   if (match == null) {
     throw new XError('core-sdk.vehicles.bad-stock-number', { stockNumber });
   }
 
-  const baseNumber = match[1];
-  const counter = match[2];
-  const counterNumber = convertLettersToNumber(counter);
+  const baseStockNumber = match[1];
+  const counterLetters = match[2];
+  const counterNumber = convertLettersToNumber(counterLetters);
   const nextCounterNumber = counterNumber + 1;
-  const nextCounter = convertNumberToLetters(nextCounterNumber);
-  return `${baseNumber}${nextCounter}`;
+  const nextCounterLetters = convertNumberToLetters(nextCounterNumber);
+  return `${baseStockNumber}${nextCounterLetters}`;
 };