@birdcc/linter 0.0.1-alpha.0

package/dist/rules/type.js

@@ -0,0 +1,130 @@
+import { createRuleDiagnostic, filterAndFunctionDeclarations, pushUniqueDiagnostic, scalarTypeOfExpression, } from "./shared.js";
+const normalizeLeftExpression = (value) => value.replace(/^\s*if\s+/i, "").trim();
+const normalizeRightExpression = (value) => value
+    .replace(/\bthen\b.*$/i, "")
+    .replace(/[;]+$/, "")
+    .trim();
+const extractMatches = (text) => {
+    const matches = [];
+    const pattern = /([^;\n]+?)\s*~\s*([^;\n]+)/g;
+    let current = pattern.exec(text);
+    while (current) {
+        const left = normalizeLeftExpression(current[1] ?? "");
+        const right = normalizeRightExpression(current[2] ?? "");
+        if (left && right) {
+            matches.push({ left, right });
+        }
+        current = pattern.exec(text);
+    }
+    return matches;
+};
+const splitSetItems = (setText) => {
+    const inner = setText.trim().slice(1, -1).trim();
+    if (!inner) {
+        return [];
+    }
+    return inner
+        .split(",")
+        .map((item) => item.trim())
+        .filter((item) => item.length > 0);
+};
+const statementText = (statement) => {
+    if (statement.kind === "expression") {
+        return statement.expressionText;
+    }
+    if (statement.kind === "other") {
+        return statement.text;
+    }
+    if (statement.kind === "if") {
+        return statement.conditionText ?? "";
+    }
+    if (statement.kind === "return") {
+        return statement.valueText ?? "";
+    }
+    return "";
+};
+const declarationText = (source, range) => {
+    const lines = source.split(/\r?\n/);
+    const startLine = Math.max(1, range.line);
+    const endLine = Math.max(startLine, range.endLine);
+    return lines.slice(startLine - 1, endLine).join("\n");
+};
+const typeNotIterableRule = ({ parsed }) => {
+    const diagnostics = [];
+    const seen = new Set();
+    for (const declaration of filterAndFunctionDeclarations(parsed)) {
+        for (const statement of declaration.statements) {
+            const text = statementText(statement);
+            if (!text) {
+                continue;
+            }
+            for (const match of extractMatches(text)) {
+                if (match.right.startsWith("[") && match.right.endsWith("]")) {
+                    continue;
+                }
+                pushUniqueDiagnostic(diagnostics, seen, createRuleDiagnostic("type/not-iterable", `Type '${match.right}' is not iterable in match expression '${match.left} ~ ${match.right}'`, statement));
+            }
+        }
+        for (const match of declaration.matches) {
+            const right = normalizeRightExpression(match.right);
+            if (right.startsWith("[") && right.endsWith("]")) {
+                continue;
+            }
+            pushUniqueDiagnostic(diagnostics, seen, createRuleDiagnostic("type/not-iterable", `Type '${right}' is not iterable in match expression '${match.left} ${match.operator} ${match.right}'`, match));
+        }
+    }
+    return diagnostics;
+};
+const typeSetIncompatibleRule = ({ parsed, text }) => {
+    const diagnostics = [];
+    const seen = new Set();
+    const evaluateSetCompatibility = (left, right, range) => {
+        const normalizedRight = normalizeRightExpression(right);
+        if (!normalizedRight.startsWith("[") || !normalizedRight.endsWith("]")) {
+            return;
+        }
+        const leftType = scalarTypeOfExpression(left);
+        if (leftType === "unknown") {
+            return;
+        }
+        const items = splitSetItems(normalizedRight);
+        if (items.length === 0) {
+            return;
+        }
+        const firstType = scalarTypeOfExpression(items[0] ?? "");
+        if (firstType === "unknown" || firstType === leftType) {
+            return;
+        }
+        pushUniqueDiagnostic(diagnostics, seen, createRuleDiagnostic("type/set-incompatible", `Set-incompatible type (${leftType}) for match set '${normalizedRight}'`, range));
+    };
+    for (const declaration of filterAndFunctionDeclarations(parsed)) {
+        for (const statement of declaration.statements) {
+            const text = statementText(statement);
+            if (!text) {
+                continue;
+            }
+            for (const match of extractMatches(text)) {
+                evaluateSetCompatibility(match.left, match.right, statement);
+            }
+        }
+        for (const match of declaration.matches) {
+            evaluateSetCompatibility(match.left, match.right, match);
+        }
+        const hasTruncatedSetMatch = declaration.matches.some((match) => match.right.includes("[") && !match.right.includes("]"));
+        if (hasTruncatedSetMatch) {
+            const sourceText = declarationText(text, declaration);
+            for (const match of extractMatches(sourceText)) {
+                evaluateSetCompatibility(match.left, match.right, declaration);
+            }
+        }
+    }
+    return diagnostics;
+};
+export const typeRules = [
+    typeNotIterableRule,
+    typeSetIncompatibleRule,
+];
+export const collectTypeRuleDiagnostics = (context) => {
+    return typeRules.flatMap((rule) => rule(context));
+};
+//# sourceMappingURL=type.js.map

package/dist/rules/type.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"type.js","sourceRoot":"","sources":["../../src/rules/type.ts"],"names":[],"mappings":"AAEA,OAAO,EACL,oBAAoB,EACpB,6BAA6B,EAC7B,oBAAoB,EACpB,sBAAsB,GAEvB,MAAM,aAAa,CAAC;AAOrB,MAAM,uBAAuB,GAAG,CAAC,KAAa,EAAU,EAAE,CACxD,KAAK,CAAC,OAAO,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;AAEzC,MAAM,wBAAwB,GAAG,CAAC,KAAa,EAAU,EAAE,CACzD,KAAK;KACF,OAAO,CAAC,cAAc,EAAE,EAAE,CAAC;KAC3B,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC;KACpB,IAAI,EAAE,CAAC;AAEZ,MAAM,cAAc,GAAG,CAAC,IAAY,EAAe,EAAE;IACnD,MAAM,OAAO,GAAgB,EAAE,CAAC;IAChC,MAAM,OAAO,GAAG,6BAA6B,CAAC;IAC9C,IAAI,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAEjC,OAAO,OAAO,EAAE,CAAC;QACf,MAAM,IAAI,GAAG,uBAAuB,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACvD,MAAM,KAAK,GAAG,wBAAwB,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACzD,IAAI,IAAI,IAAI,KAAK,EAAE,CAAC;YAClB,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;QAChC,CAAC;QACD,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/B,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC,CAAC;AAEF,MAAM,aAAa,GAAG,CAAC,OAAe,EAAY,EAAE;IAClD,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IACjD,IAAI,CAAC,KAAK,EAAE,CAAC;QACX,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,OAAO,KAAK;SACT,KAAK,CAAC,GAAG,CAAC;SACV,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;SAC1B,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;AACvC,CAAC,CAAC;AAEF,MAAM,aAAa,GAAG,CAAC,SAA8B,EAAU,EAAE;IAC/D,IAAI,SAAS,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;QACpC,OAAO,SAAS,CAAC,cAAc,CAAC;IAClC,CAAC;IAED,IAAI,SAAS,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;QAC/B,OAAO,SAAS,CAAC,IAAI,CAAC;IACxB,CAAC;IAED,IAAI,SAAS,CAAC,IAAI,KAAK,IAAI,EAAE,CAAC;QAC5B,OAAO,SAAS,CAAC,aAAa,IAAI,EAAE,CAAC;IACvC,CAAC;IAED,IAAI,SAAS,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;QAChC,OAAO,SAAS,CAAC,SAAS,IAAI,EAAE,CAAC;IACnC,CAAC;IAED,OAAO,EAAE,CAAC;AACZ,CAAC,CAAC;AAEF,MAAM,eAAe,GAAG,CAAC,MAAc,EAAE,KAAkB,EAAU,EAAE;IACrE,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IACpC,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC;IAC1C,MAAM,OAAO,GAAG,IAAI,CAAC,GAAG,CAAC,SAAS,EAAE,KAAK,CAAC,OAAO,CAAC,CAAC;IACnD,OAAO,KAAK,CAAC,KAAK,CAAC,SAAS,GAAG,CAAC,EAAE,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACxD,CAAC,CAAC;AAEF,MAAM,mBAAmB,GAAa,CAAC,EAAE,MAAM,EAAE,EAAE,EAAE;IACnD,MAAM,WAAW,GAAqB,EAAE,CAAC;IACzC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAE/B,KAAK,MAAM,WAAW,IAAI,6BAA6B,CAAC,MAAM,CAAC,EAAE,CAAC;QAChE,KAAK,MAAM,SAAS,IAAI,WAAW,CAAC,UAAU,EAAE,CAAC;YAC/C,MAAM,IAAI,GAAG,aAAa,CAAC,SAAS,CAAC,CAAC;YACtC,IAAI,CAAC,IAAI,EAAE,CAAC;gBACV,SAAS;YACX,CAAC;YAED,KAAK,MAAM,KAAK,IAAI,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;gBACzC,IAAI,KAAK,CAAC,KAAK,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC7D,SAAS;gBACX,CAAC;gBAED,oBAAoB,CAClB,WAAW,EACX,IAAI,EACJ,oBAAoB,CAClB,mBAAmB,EACnB,SAAS,KAAK,CAAC,KAAK,0CAA0C,KAAK,CAAC,IAAI,MAAM,KAAK,CAAC,KAAK,GAAG,EAC5F,SAAS,CACV,CACF,CAAC;YACJ,CAAC;QACH,CAAC;QAED,KAAK,MAAM,KAAK,IAAI,WAAW,CAAC,OAAO,EAAE,CAAC;YACxC,MAAM,KAAK,GAAG,wBAAwB,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;YACpD,IAAI,KAAK,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;gBACjD,SAAS;YACX,CAAC;YAED,oBAAoB,CAClB,WAAW,EACX,IAAI,EACJ,oBAAoB,CAClB,mBAAmB,EACnB,SAAS,KAAK,0CAA0C,KAAK,CAAC,IAAI,IAAI,KAAK,CAAC,QAAQ,IAAI,KAAK,CAAC,KAAK,GAAG,EACtG,KAAK,CACN,CACF,CAAC;QACJ,CAAC;IACH,CAAC;IAED,OAAO,WAAW,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,uBAAuB,GAAa,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,EAAE;IAC7D,MAAM,WAAW,GAAqB,EAAE,CAAC;IACzC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAE/B,MAAM,wBAAwB,GAAG,CAC/B,IAAY,EACZ,KAAa,EACb,KAAkB,EACZ,EAAE;QACR,MAAM,eAAe,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QACxD,IAAI,CAAC,eAAe,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YACvE,OAAO;QACT,CAAC;QAED,MAAM,QAAQ,GAAG,sBAAsB,CAAC,IAAI,CAAC,CAAC;QAC9C,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;YAC3B,OAAO;QACT,CAAC;QAED,MAAM,KAAK,GAAG,aAAa,CAAC,eAAe,CAAC,CAAC;QAC7C,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACvB,OAAO;QACT,CAAC;QAED,MAAM,SAAS,GAAG,sBAAsB,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QACzD,IAAI,SAAS,KAAK,SAAS,IAAI,SAAS,KAAK,QAAQ,EAAE,CAAC;YACtD,OAAO;QACT,CAAC;QAED,oBAAoB,CAClB,WAAW,EACX,IAAI,EACJ,oBAAoB,CAClB,uBAAuB,EACvB,0BAA0B,QAAQ,oBAAoB,eAAe,GAAG,EACxE,KAAK,CACN,CACF,CAAC;IACJ,CAAC,CAAC;IAEF,KAAK,MAAM,WAAW,IAAI,6BAA6B,CAAC,MAAM,CAAC,EAAE,CAAC;QAChE,KAAK,MAAM,SAAS,IAAI,WAAW,CAAC,UAAU,EAAE,CAAC;YAC/C,MAAM,IAAI,GAAG,aAAa,CAAC,SAAS,CAAC,CAAC;YACtC,IAAI,CAAC,IAAI,EAAE,CAAC;gBACV,SAAS;YACX,CAAC;YAED,KAAK,MAAM,KAAK,IAAI,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;gBACzC,wBAAwB,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,EAAE,SAAS,CAAC,CAAC;YAC/D,CAAC;QACH,CAAC;QAED,KAAK,MAAM,KAAK,IAAI,WAAW,CAAC,OAAO,EAAE,CAAC;YACxC,wBAAwB,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAC3D,CAAC;QAED,MAAM,oBAAoB,GAAG,WAAW,CAAC,OAAO,CAAC,IAAI,CACnD,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,CACnE,CAAC;QAEF,IAAI,oBAAoB,EAAE,CAAC;YACzB,MAAM,UAAU,GAAG,eAAe,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;YACtD,KAAK,MAAM,KAAK,IAAI,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC;gBAC/C,wBAAwB,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;YACjE,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,WAAW,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,CAAC,MAAM,SAAS,GAAe;IACnC,mBAAmB;IACnB,uBAAuB;CACxB,CAAC;AAEF,MAAM,CAAC,MAAM,0BAA0B,GAAG,CACxC,OAAgC,EACd,EAAE;IACpB,OAAO,SAAS,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;AACpD,CAAC,CAAC"}

package/package.json

@@ -0,0 +1,41 @@
+{
+  "name": "@birdcc/linter",
+  "version": "0.0.1-alpha.0",
+  "private": false,
+  "type": "module",
+  "license": "GPL-3.0-only",
+  "author": {
+    "name": "BIRD Chinese Community",
+    "email": "npm-dev@birdcc.link",
+    "url": "https://github.com/bird-chinese-community/"
+  },
+  "main": "./dist/index.js",
+  "types": "./src/index.ts",
+  "exports": {
+    ".": {
+      "types": "./src/index.ts",
+      "default": "./dist/index.js"
+    }
+  },
+  "dependencies": {
+    "@birdcc/core": "0.0.1-alpha.0",
+    "@birdcc/parser": "0.0.1-alpha.0"
+  },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/bird-chinese-community/BIRD-LSP",
+    "directory": "packages/@birdcc/linter"
+  },
+  "homepage": "https://github.com/bird-chinese-community/BIRD-LSP/blob/main/packages/%40birdcc/linter/README.md",
+  "bugs": {
+    "url": "https://github.com/bird-chinese-community/BIRD-LSP/issues"
+  },
+  "scripts": {
+    "build": "tsc -p tsconfig.json",
+    "typecheck": "tsc -p tsconfig.json --noEmit",
+    "lint": "oxlint --deny-warnings src test",
+    "test": "vitest run",
+    "format": "oxfmt .",
+    "coverage": "vitest run --coverage --coverage.provider=v8 --coverage.reporter=text-summary --coverage.reporter=json-summary"
+  }
+}

package/src/index.ts

@@ -0,0 +1,155 @@
+import type { CrossFileResolutionResult, SymbolTable } from "@birdcc/core";
+import {
+  buildCoreSnapshotFromParsed,
+  type BirdDiagnostic,
+  type CoreSnapshot,
+} from "@birdcc/core";
+import { parseBirdConfig, type ParsedBirdDocument } from "@birdcc/parser";
+import { collectBgpRuleDiagnostics } from "./rules/bgp.js";
+import { collectCfgRuleDiagnostics } from "./rules/cfg.js";
+import { collectNetRuleDiagnostics } from "./rules/net.js";
+import { normalizeBaseDiagnostics } from "./rules/normalize.js";
+import { collectOspfRuleDiagnostics } from "./rules/ospf.js";
+import { collectSymRuleDiagnostics } from "./rules/sym.js";
+import { type RuleContext } from "./rules/shared.js";
+import { collectTypeRuleDiagnostics } from "./rules/type.js";
+
+export interface LintResult {
+  parsed: ParsedBirdDocument;
+  core: CoreSnapshot;
+  diagnostics: BirdDiagnostic[];
+}
+
+const dedupeDiagnostics = (diagnostics: BirdDiagnostic[]): BirdDiagnostic[] => {
+  const seen = new Set<string>();
+  const output: BirdDiagnostic[] = [];
+
+  for (const diagnostic of diagnostics) {
+    const key = [
+      diagnostic.code,
+      diagnostic.message,
+      diagnostic.uri ?? "",
+      diagnostic.range.line,
+      diagnostic.range.column,
+      diagnostic.range.endLine,
+      diagnostic.range.endColumn,
+    ].join(":");
+
+    if (seen.has(key)) {
+      continue;
+    }
+
+    seen.add(key);
+    output.push(diagnostic);
+  }
+
+  return output;
+};
+
+const diagnosticsForUri = (
+  diagnostics: BirdDiagnostic[],
+  uri: string,
+  entryUri: string,
+): BirdDiagnostic[] => {
+  return diagnostics.filter(
+    (diagnostic) => (diagnostic.uri ?? entryUri) === uri,
+  );
+};
+
+const createMergedCoreSnapshot = (
+  localCore: CoreSnapshot,
+  mergedSymbolTable: SymbolTable,
+  scopedDiagnostics: BirdDiagnostic[],
+): CoreSnapshot => ({
+  ...localCore,
+  symbols: mergedSymbolTable.definitions,
+  references: mergedSymbolTable.references,
+  symbolTable: mergedSymbolTable,
+  diagnostics: scopedDiagnostics,
+});
+
+export interface LintBirdConfigOptions {
+  parsed?: ParsedBirdDocument;
+  core?: CoreSnapshot;
+  uri?: string;
+}
+
+export interface CrossFileLintResult {
+  diagnostics: BirdDiagnostic[];
+  byUri: Record<string, LintResult>;
+}
+
+/** Runs parser + core + normalized 32-rule linter pipeline and returns merged diagnostics. */
+export const lintBirdConfig = async (
+  text: string,
+  options: LintBirdConfigOptions = {},
+): Promise<LintResult> => {
+  const parsed = options.parsed ?? (await parseBirdConfig(text));
+  const core =
+    options.core ?? buildCoreSnapshotFromParsed(parsed, { uri: options.uri });
+
+  const context: RuleContext = { text, parsed, core };
+
+  const normalizedBaseDiagnostics = normalizeBaseDiagnostics(
+    parsed,
+    core.diagnostics,
+    {
+      uri: options.uri,
+    },
+  );
+  const ruleDiagnostics: BirdDiagnostic[] = [
+    ...collectSymRuleDiagnostics(context),
+    ...collectCfgRuleDiagnostics(context),
+    ...collectNetRuleDiagnostics(context),
+    ...collectTypeRuleDiagnostics(context),
+    ...collectBgpRuleDiagnostics(context),
+    ...collectOspfRuleDiagnostics(context),
+  ].map((diagnostic) => ({
+    ...diagnostic,
+    uri: diagnostic.uri ?? options.uri,
+  }));
+
+  return {
+    parsed,
+    core,
+    diagnostics: dedupeDiagnostics([
+      ...normalizedBaseDiagnostics,
+      ...ruleDiagnostics,
+    ]),
+  };
+};
+
+export const lintResolvedCrossFileGraph = async (
+  resolution: CrossFileResolutionResult,
+): Promise<CrossFileLintResult> => {
+  const byUri: Record<string, LintResult> = {};
+  const diagnostics: BirdDiagnostic[] = [];
+  const uris =
+    resolution.visitedUris.length > 0
+      ? resolution.visitedUris
+      : [resolution.entryUri];
+
+  for (const uri of uris) {
+    const text = resolution.documents[uri];
+    const localCore = resolution.snapshots[uri];
+    if (!text || !localCore) {
+      continue;
+    }
+
+    const lintResult = await lintBirdConfig(text, {
+      uri,
+      core: createMergedCoreSnapshot(
+        localCore,
+        resolution.symbolTable,
+        diagnosticsForUri(resolution.diagnostics, uri, resolution.entryUri),
+      ),
+    });
+    byUri[uri] = lintResult;
+    diagnostics.push(...lintResult.diagnostics);
+  }
+
+  return {
+    byUri,
+    diagnostics: dedupeDiagnostics(diagnostics),
+  };
+};

package/src/rules/bgp.ts

@@ -0,0 +1,239 @@
+import type { BirdDiagnostic } from "@birdcc/core";
+import {
+  createProtocolDiagnostic,
+  createRuleDiagnostic,
+  extractFirstNumberAfterKeyword,
+  isProtocolType,
+  numericValue,
+  protocolDeclarations,
+  type BirdRule,
+} from "./shared.js";
+
+const isInternalSession = (value: string | undefined): boolean =>
+  /^(internal|ibgp)$/i.test(value?.trim() ?? "");
+
+const isExternalSession = (value: string | undefined): boolean =>
+  /^(external|ebgp)$/i.test(value?.trim() ?? "");
+
+const bgpMissingLocalAsRule: BirdRule = ({ parsed }) => {
+  const diagnostics: BirdDiagnostic[] = [];
+
+  for (const declaration of protocolDeclarations(parsed)) {
+    if (!isProtocolType(declaration, "bgp")) {
+      continue;
+    }
+
+    if (
+      declaration.statements.some((statement) => statement.kind === "local-as")
+    ) {
+      continue;
+    }
+
+    diagnostics.push(
+      createProtocolDiagnostic(
+        "bgp/missing-local-as",
+        `BGP protocol '${declaration.name}' missing local AS number`,
+        declaration,
+      ),
+    );
+  }
+
+  return diagnostics;
+};
+
+const bgpMissingNeighborRule: BirdRule = ({ parsed }) => {
+  const diagnostics: BirdDiagnostic[] = [];
+
+  for (const declaration of protocolDeclarations(parsed)) {
+    if (!isProtocolType(declaration, "bgp")) {
+      continue;
+    }
+
+    if (
+      declaration.statements.some((statement) => statement.kind === "neighbor")
+    ) {
+      continue;
+    }
+
+    diagnostics.push(
+      createProtocolDiagnostic(
+        "bgp/missing-neighbor",
+        `BGP protocol '${declaration.name}' missing neighbor configuration`,
+        declaration,
+      ),
+    );
+  }
+
+  return diagnostics;
+};
+
+const bgpMissingRemoteAsRule: BirdRule = ({ parsed }) => {
+  const diagnostics: BirdDiagnostic[] = [];
+
+  for (const declaration of protocolDeclarations(parsed)) {
+    if (!isProtocolType(declaration, "bgp")) {
+      continue;
+    }
+
+    for (const statement of declaration.statements) {
+      if (statement.kind !== "neighbor") {
+        continue;
+      }
+
+      if (
+        isInternalSession(statement.asn) ||
+        isExternalSession(statement.asn)
+      ) {
+        continue;
+      }
+
+      if (statement.asn && numericValue(statement.asn) !== null) {
+        continue;
+      }
+
+      diagnostics.push(
+        createRuleDiagnostic(
+          "bgp/missing-remote-as",
+          `BGP protocol '${declaration.name}' neighbor '${statement.address}' missing remote AS`,
+          statement.asnRange ?? statement.addressRange,
+        ),
+      );
+    }
+  }
+
+  return diagnostics;
+};
+
+const bgpAsMismatchRule: BirdRule = ({ parsed }) => {
+  const diagnostics: BirdDiagnostic[] = [];
+
+  for (const declaration of protocolDeclarations(parsed)) {
+    if (!isProtocolType(declaration, "bgp")) {
+      continue;
+    }
+
+    const localAsStatement = declaration.statements.find(
+      (statement) => statement.kind === "local-as",
+    );
+    if (!localAsStatement || localAsStatement.kind !== "local-as") {
+      continue;
+    }
+
+    const localAs = numericValue(localAsStatement.asn);
+    if (localAs === null) {
+      continue;
+    }
+
+    const hasInternalNeighbor = declaration.statements.some(
+      (statement) =>
+        statement.kind === "neighbor" && isInternalSession(statement.asn),
+    );
+
+    if (!hasInternalNeighbor) {
+      continue;
+    }
+
+    for (const statement of declaration.statements) {
+      if (statement.kind !== "neighbor" || !statement.asn) {
+        continue;
+      }
+
+      if (
+        isInternalSession(statement.asn) ||
+        isExternalSession(statement.asn)
+      ) {
+        continue;
+      }
+
+      const remoteAs = numericValue(statement.asn);
+      if (remoteAs === null || remoteAs === localAs) {
+        continue;
+      }
+
+      diagnostics.push(
+        createRuleDiagnostic(
+          "bgp/as-mismatch",
+          `BGP protocol '${declaration.name}' internal session requires same ASN (local ${localAs}, remote ${remoteAs})`,
+          statement.asnRange ?? statement.addressRange,
+        ),
+      );
+    }
+  }
+
+  return diagnostics;
+};
+
+const bgpTimerInvalidRule: BirdRule = ({ parsed }) => {
+  const diagnostics: BirdDiagnostic[] = [];
+
+  for (const declaration of protocolDeclarations(parsed)) {
+    if (!isProtocolType(declaration, "bgp")) {
+      continue;
+    }
+
+    let hold: number | null = null;
+    let keepalive: number | null = null;
+
+    for (const statement of declaration.statements) {
+      if (statement.kind !== "other") {
+        continue;
+      }
+
+      const text = statement.text.toLowerCase();
+      const holdValue = extractFirstNumberAfterKeyword(text, "hold");
+      const keepaliveValue = extractFirstNumberAfterKeyword(text, "keepalive");
+
+      if (holdValue !== null) {
+        hold = holdValue;
+        if (hold < 3 || hold > 65_535) {
+          diagnostics.push(
+            createRuleDiagnostic(
+              "bgp/timer-invalid",
+              `BGP protocol '${declaration.name}' hold time must be in range 3..65535`,
+              statement,
+            ),
+          );
+        }
+      }
+
+      if (keepaliveValue !== null) {
+        keepalive = keepaliveValue;
+        if (keepalive < 1 || keepalive > 65_535) {
+          diagnostics.push(
+            createRuleDiagnostic(
+              "bgp/timer-invalid",
+              `BGP protocol '${declaration.name}' keepalive must be in range 1..65535`,
+              statement,
+            ),
+          );
+        }
+      }
+    }
+
+    if (hold !== null && keepalive !== null && keepalive >= hold) {
+      diagnostics.push(
+        createProtocolDiagnostic(
+          "bgp/timer-invalid",
+          `BGP protocol '${declaration.name}' keepalive (${keepalive}) must be smaller than hold (${hold})`,
+          declaration,
+        ),
+      );
+    }
+  }
+
+  return diagnostics;
+};
+
+export const bgpRules: BirdRule[] = [
+  bgpMissingLocalAsRule,
+  bgpMissingNeighborRule,
+  bgpMissingRemoteAsRule,
+  bgpAsMismatchRule,
+  bgpTimerInvalidRule,
+];
+
+export const collectBgpRuleDiagnostics = (
+  context: Parameters<BirdRule>[0],
+): BirdDiagnostic[] => {
+  return bgpRules.flatMap((rule) => rule(context));
+};

package/src/rules/catalog.ts

@@ -0,0 +1,80 @@
+import type { BirdDiagnosticSeverity } from "@birdcc/core";
+
+export const RULE_CODES = {
+  sym: [
+    "sym/undefined",
+    "sym/duplicate",
+    "sym/proto-type-mismatch",
+    "sym/filter-required",
+    "sym/function-required",
+    "sym/table-required",
+    "sym/variable-scope",
+  ],
+  cfg: [
+    "cfg/no-protocol",
+    "cfg/missing-router-id",
+    "cfg/syntax-error",
+    "cfg/value-out-of-range",
+    "cfg/switch-value-expected",
+    "cfg/number-expected",
+    "cfg/incompatible-type",
+    "cfg/ip-network-mismatch",
+    "cfg/circular-template",
+  ],
+  net: [
+    "net/invalid-prefix-length",
+    "net/invalid-ipv4-prefix",
+    "net/invalid-ipv6-prefix",
+    "net/max-prefix-length",
+  ],
+  type: ["type/mismatch", "type/not-iterable", "type/set-incompatible"],
+  bgp: [
+    "bgp/missing-local-as",
+    "bgp/missing-neighbor",
+    "bgp/missing-remote-as",
+    "bgp/as-mismatch",
+    "bgp/timer-invalid",
+  ],
+  ospf: [
+    "ospf/missing-area",
+    "ospf/backbone-stub",
+    "ospf/vlink-in-backbone",
+    "ospf/asbr-stub-area",
+  ],
+} as const;
+
+export type RuleCode =
+  | (typeof RULE_CODES.sym)[number]
+  | (typeof RULE_CODES.cfg)[number]
+  | (typeof RULE_CODES.net)[number]
+  | (typeof RULE_CODES.type)[number]
+  | (typeof RULE_CODES.bgp)[number]
+  | (typeof RULE_CODES.ospf)[number];
+
+const ruleSeverityEntries: ReadonlyArray<
+  readonly [RuleCode, BirdDiagnosticSeverity]
+> = [
+  ...RULE_CODES.sym.map((code) => [code, "error"] as const),
+  ...RULE_CODES.cfg.map((code) => [code, "error"] as const),
+  ...RULE_CODES.net.map((code) => [code, "error"] as const),
+  ...RULE_CODES.type.map((code) => [code, "error"] as const),
+  ...RULE_CODES.bgp.map((code) => [code, "warning"] as const),
+  ...RULE_CODES.ospf.map((code) => [code, "warning"] as const),
+];
+
+export const RULE_SEVERITY: Record<RuleCode, BirdDiagnosticSeverity> =
+  Object.fromEntries(ruleSeverityEntries) as Record<
+    RuleCode,
+    BirdDiagnosticSeverity
+  >;
+
+export const LEGACY_CODE_PATTERNS = [
+  /^protocol\//,
+  /^security\//,
+  /^performance\//,
+  /^structure\//,
+] as const;
+
+export const isRuleCode = (code: string): code is RuleCode => {
+  return code in RULE_SEVERITY;
+};